Re: Segfault Question

2018-12-18 Thread nick
On 2018-12-17 11:12 a.m., nick wrote: > > > On 2018-12-17 10:23 a.m., Nathan Sidwell wrote: >> On 12/17/18 10:11 AM, Jonathan Wakely wrote: >> >>> The second snippet is his suggested fix for the caller of tsubst_expr >>> in expand_concept. That would have been a lot more helpful as a patch: >>

Re: Segfault Question

2018-12-17 Thread nick
On 2018-12-17 10:23 a.m., Nathan Sidwell wrote: > On 12/17/18 10:11 AM, Jonathan Wakely wrote: > >> The second snippet is his suggested fix for the caller of tsubst_expr >> in expand_concept. That would have been a lot more helpful as a patch: >> >> --- a/gcc/cp/constraint.cc >> +++ b/gcc/cp/co

Re: Segfault Question

2018-12-17 Thread Jonathan Wakely
On Mon, 17 Dec 2018 at 15:24, Jakub Jelinek wrote: > > On Mon, Dec 17, 2018 at 03:11:03PM +, Jonathan Wakely wrote: > > --- a/gcc/cp/constraint.cc > > +++ b/gcc/cp/constraint.cc > > @@ -563,7 +563,7 @@ expand_concept (tree decl, tree args) > >++processing_template_decl; > >tree result

Re: Segfault Question

2018-12-17 Thread Jakub Jelinek
On Mon, Dec 17, 2018 at 03:11:03PM +, Jonathan Wakely wrote: > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -563,7 +563,7 @@ expand_concept (tree decl, tree args) >++processing_template_decl; >tree result = tsubst_expr (def, args, tf_none, NULL_TREE, true); >--proces

Re: Segfault Question

2018-12-17 Thread Nathan Sidwell
On 12/17/18 10:11 AM, Jonathan Wakely wrote: The second snippet is his suggested fix for the caller of tsubst_expr in expand_concept. That would have been a lot more helpful as a patch: --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc @@ -563,7 +563,7 @@ expand_concept (tree decl, tree arg

Re: Segfault Question

2018-12-17 Thread Jonathan Wakely
On Mon, 17 Dec 2018 at 15:11, Jonathan Wakely wrote: > > On Mon, 17 Dec 2018 at 14:55, Nathan Sidwell wrote: > > > > On 12/14/18 10:55 AM, nick wrote: > > > Greetings All, > > > I was attempting to fix this bug: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88395#add_comment > > > > > > and m

Re: Segfault Question

2018-12-17 Thread Jonathan Wakely
On Mon, 17 Dec 2018 at 14:55, Nathan Sidwell wrote: > > On 12/14/18 10:55 AM, nick wrote: > > Greetings All, > > I was attempting to fix this bug: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88395#add_comment > > > > and managed to track it down to expand_concept in constraint.cc. > > > > See

Re: Segfault Question

2018-12-17 Thread Nathan Sidwell
On 12/14/18 10:55 AM, nick wrote: Greetings All, I was attempting to fix this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88395#add_comment and managed to track it down to expand_concept in constraint.cc. Seems that we are hitting this case in tsubst_expr for the NULL_TREE: if (t == NULL_

Segfault Question

2018-12-14 Thread nick
Greetings All, I was attempting to fix this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88395#add_comment and managed to track it down to expand_concept in constraint.cc. Seems that we are hitting this case in tsubst_expr for the NULL_TREE: if (t == NULL_TREE || t == error_mark_node)