Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-25 Thread Martin Jambor
On Sun, Sep 09, 2007 at 11:42:55AM -0700, Mark Mitchell wrote: > Other than that, the patch looks pretty good to me. However, I'd like a > middle-end maintainer to review the patch. Ian, Diego, Roger, would one > of you please take a look? Well... ping? > to use the --param mechanism. Our pol

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-17 Thread Mark Mitchell
Kai Tietz wrote: >> I'm sorry -- that doesn't really answer the question I was trying to >> ask. To be clear, if we're calling through a function pointer, we still >> need to be able to do the right thing, and in that case we don't have a >> FUNCTION_DECL. So, I don't understand how you can have

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-16 Thread Kai Tietz
Mark, > Kai Tietz wrote: > > >> Kai, why is your change making OUTGOING_REG_PARM_STACK_SPACE accept a > >> FUNCTION_DECL, rather than a FUNCTION_TYPE? I'd think that all > >> calling-convention predicates ought to be looking at the type to support > >> calling through function pointers? > > >

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-14 Thread Mark Mitchell
Kai Tietz wrote: >> Kai, why is your change making OUTGOING_REG_PARM_STACK_SPACE accept a >> FUNCTION_DECL, rather than a FUNCTION_TYPE? I'd think that all >> calling-convention predicates ought to be looking at the type to support >> calling through function pointers? > > This macro is used als

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-14 Thread Kai Tietz
Mark Mitchell wrote on 13.09.2007 20:42:25: > Jan Hubicka wrote: > >> Kai Tietz wrote: > >> > >>> See > >>> http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV- > MS-ABI-attributes-in-backend-tf4414541.html > >>> http://www.nabble.com/-PATCH-%3A-Implementation-for-SYSV-MS-ABI- > attribu

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-14 Thread Kai Tietz
"Joseph S. Myers" wrote on 14.09.2007 00:09:49: > On Thu, 13 Sep 2007, Michael Meissner wrote: > > > In the first patch, I am somewhat uncomfortable with changing > RETURN_IN_MEMORY > > and OUTGOING_REG_PARM_STACK_SPACE, by adding an additional > parameter, and then > > changing all of the targ

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Joseph S. Myers
On Thu, 13 Sep 2007, Michael Meissner wrote: > In the first patch, I am somewhat uncomfortable with changing RETURN_IN_MEMORY > and OUTGOING_REG_PARM_STACK_SPACE, by adding an additional parameter, and then > changing all of the targets. It might be better to have new macros > (RETURN_IN_MEMORY_A

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Mark Mitchell
Meissner, Michael wrote: > I didn't hear back from you, so I checked in the machine independent and > i386 parts in my SSE5 patch. Now, on to making the various ports still > work with the change. All right; sounds good. -- Mark Mitchell CodeSourcery [EMAIL PROTECTED] (650) 331-3385 x713

RE: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Meissner, Michael
> -Original Message- > From: Mark Mitchell [mailto:[EMAIL PROTECTED] > Sent: Thursday, September 13, 2007 2:37 PM > To: Meissner, Michael; Mark Mitchell; GCC > Subject: Re: GCC 4.3.0 Status Report (2007-09-04) > > Michael Meissner wrote: > > > One patch tha

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Michael Meissner
On Thu, Sep 13, 2007 at 10:45:56AM +0200, Jan Hubicka wrote: > > Kai Tietz wrote: > > > > > See > > > http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV-MS-ABI-attributes-in-backend-tf4414541.html > > > http://www.nabble.com/-PATCH-%3A-Implementation-for-SYSV-MS-ABI-attributes-in-i386

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Mark Mitchell
Jan Hubicka wrote: >> Kai Tietz wrote: >> >>> See >>> http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV-MS-ABI-attributes-in-backend-tf4414541.html >>> http://www.nabble.com/-PATCH-%3A-Implementation-for-SYSV-MS-ABI-attributes-in-i386-may-before-stage--3-tf4428449.html >> Thanks for l

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Mark Mitchell
Ramana Radhakrishnan wrote: > I have a couple of patches that I submitted / intend to submit . One > of them was submitted today regarding a small improvement to the > auto-increment pass. I am not sure if this is suitable for stage3 if > it is approved. > > http://gcc.gnu.org/ml/gcc-patches/2007

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Mark Mitchell
Michael Meissner wrote: > One patch that got dropped on the floor was my patch to remove the dependency > in the back ends of the way arguments are encoded, so that eventually for LTO > we can swtich to using a vector instead of linked list. I think that could still goto 4.3, since it's already

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-13 Thread Jan Hubicka
> Kai Tietz wrote: > > > See > > http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV-MS-ABI-attributes-in-backend-tf4414541.html > > http://www.nabble.com/-PATCH-%3A-Implementation-for-SYSV-MS-ABI-attributes-in-i386-may-before-stage--3-tf4428449.html > > Thanks for letting me know. I

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-12 Thread Mark Mitchell
Kai Tietz wrote: > See > http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV-MS-ABI-attributes-in-backend-tf4414541.html > http://www.nabble.com/-PATCH-%3A-Implementation-for-SYSV-MS-ABI-attributes-in-i386-may-before-stage--3-tf4428449.html Thanks for letting me know. I'm going to le

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-12 Thread Ramana Radhakrishnan
Hi, I apologize for the late response to your mail but I sort of did these patches up recently . I have a couple of patches that I submitted / intend to submit . One of them was submitted today regarding a small improvement to the auto-increment pass. I am not sure if this is suitable for stage3

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-12 Thread Kai Tietz
I have two patch may be worth to enter into 4.3 at stage 2. Jan and I tried to ping the first part now about some time and we didn't got a comment or approval for them. See http://www.nabble.com/-PING%5E2-PATCH-%3A-Preparations-for-SYSV-MS-ABI-attributes-in-backend-tf4414541.html http://www.nabbl

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Mark Mitchell
Peter Bergner wrote: > On Tue, 2007-09-04 at 19:40 -0700, Mark Mitchell wrote: >> Are there Stage 1 or Stage 2 patches in need of review? I'll do my best >> to either (a) convince someone to review them, or (b) review them myself. > > It has only been four days since I posted the patch, but I am

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Mark Mitchell
Jakub Jelinek wrote: > I have a bunch of tiny patches, nevertheless all Stage 2 material, as > they add new features: I'd like a middle-end maintainer to review this one: > redundant zero store elimination optimization (simplistic version, > but nevertheless is able to trigger many times during

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Martin Jambor
Hi, thanks for looking at the patch. On Sun, Sep 09, 2007 at 11:42:55AM -0700, Mark Mitchell wrote: > Martin Jambor wrote: > > > Well, there's mine :-) Specifically, its the "Switch initializations > > conversion:" http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00215.html > > Do you have an FSF c

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Michael Meissner
On Tue, Sep 04, 2007 at 07:40:19PM -0700, Mark Mitchell wrote: > Summary > === > > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Peter Bergner
On Tue, 2007-09-04 at 19:40 -0700, Mark Mitchell wrote: > Are there Stage 1 or Stage 2 patches in need of review? I'll do my best > to either (a) convince someone to review them, or (b) review them myself. It has only been four days since I posted the patch, but I am waiting for a review of the n

RE: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Jagasia, Harsha
>Jagasia, Harsha wrote: > >> I still plan to submit a patch for the x86 target cost model tuning. > >Assuming that this isn't too dramatic, I'll leave approval of that >during Stage 3 to the x86 back-end maintainers. Thanks. The patch involves some x86 back-end bits, which Honza has already appro

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-10 Thread Jakub Jelinek
On Tue, Sep 04, 2007 at 07:40:19PM -0700, Mark Mitchell wrote: > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted by > that point? > > A

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Jan Hubicka
> Jan Hubicka wrote: > > > I am still planning to do some retuning of inliner (our inline limits > > wasn't revisited for inclusion of SSA optimizers). > > Assuming that the tuning is essentially twiddling constants, I'm not > overly worried. If you're planning to adjust the algorithms > substan

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Richard Guenther wrote: > On 9/9/07, Roger Sayle <[EMAIL PROTECTED]> wrote: >>> This is an optimization pass which leads to dramatically better code on >>> at least one SPEC benchmark. Ian, Roger, Diego, would one of you care >>> to review this? > > Btw, diego already approved the patch. I apolo

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Richard Guenther
On 9/9/07, Roger Sayle <[EMAIL PROTECTED]> wrote: > > > This is an optimization pass which leads to dramatically better code on > > > at least one SPEC benchmark. Ian, Roger, Diego, would one of you care > > to review this? Btw, diego already approved the patch. > My concern is that as formulate

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Roger Sayle
This is an optimization pass which leads to dramatically better code on at least one SPEC benchmark. Ian, Roger, Diego, would one of you care to review this? My concern is that as formulated, conditional store elimination is not always a win. Transforming if (cond) *p = x; int

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Jagasia, Harsha wrote: > I still plan to submit a patch for the x86 target cost model tuning. Assuming that this isn't too dramatic, I'll leave approval of that during Stage 3 to the x86 back-end maintainers. Thanks, -- Mark Mitchell CodeSourcery [EMAIL PROTECTED] (650) 331-3385 x713

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Jan Hubicka wrote: > I am still planning to do some retuning of inliner (our inline limits > wasn't revisited for inclusion of SSA optimizers). Assuming that the tuning is essentially twiddling constants, I'm not overly worried. If you're planning to adjust the algorithms substantially, then I'd

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Richard Guenther wrote: > There is > > http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01978.html > > for example, which is not suitable for stage3. This is an optimization pass which leads to dramatically better code on at least one SPEC benchmark. Ian, Roger, Diego, would one of you care to rev

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Rask Ingemann Lambertsen wrote: > On Tue, Sep 04, 2007 at 07:40:19PM -0700, Mark Mitchell wrote: >> Are there Stage 1 or Stage 2 patches in need of review? I'll do my best >> to either (a) convince someone to review them, or (b) review them myself. > > http://gcc.gnu.org/ml/gcc-patches/2007-08/ms

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-09 Thread Mark Mitchell
Martin Jambor wrote: > Well, there's mine :-) Specifically, its the "Switch initializations > conversion:" http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00215.html Do you have an FSF copyright assignment on file? This patch is big enough that we would not be able to include it without that. > Ja

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-08 Thread Rask Ingemann Lambertsen
On Tue, Sep 04, 2007 at 07:40:19PM -0700, Mark Mitchell wrote: > Are there Stage 1 or Stage 2 patches in need of review? I'll do my best > to either (a) convince someone to review them, or (b) review them myself. http://gcc.gnu.org/ml/gcc-patches/2007-08/msg02217.html It's blocking work on the a

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-07 Thread Martin Jambor
Hi, On Tue, Sep 04, 2007 at 07:40:19PM -0700, Mark Mitchell wrote: > Summary > === > > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submi

RE: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Jagasia, Harsha
>On 9/4/07, Mark Mitchell <[EMAIL PROTECTED]> wrote: >> We are closing in on Stage 3, previously announced for September 10th. >> At this point, I'm not aware of any reason to delay that date. Are >> there any Stage 2 patches that people don't think will be submitted by >> that point? >> I still

RE: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Fu, Chao-Ying
Manuel López-Ibáñez wrote: > > On 05/09/07, Mark Mitchell <[EMAIL PROTECTED]> wrote: > > Summary > > === > > > > We are closing in on Stage 3, previously announced for > September 10th. > > At this point, I'm not aware of any reason to delay that date. Are > > there any Stage 2 patches that

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Sebastian Pop
On 9/4/07, Mark Mitchell <[EMAIL PROTECTED]> wrote: > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted by > that point? > I still plan t

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Jan Hubicka
> Summary > === > > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted by > that point? I am still planning to do some retuning of in

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Manuel López-Ibáñez
On 05/09/07, Mark Mitchell <[EMAIL PROTECTED]> wrote: > Summary > === > > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted by > that

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Richard Guenther
On 9/6/07, Paolo Bonzini <[EMAIL PROTECTED]> wrote: > > > There is > > > > http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01978.html > > > > for example, which is not suitable for stage3. > > As much as I like the idea, wasn't get_non_trapping considered unsafe? Only if you tried to preserve this in

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Paolo Bonzini
There is http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01978.html for example, which is not suitable for stage3. As much as I like the idea, wasn't get_non_trapping considered unsafe? Paolo

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-06 Thread Richard Guenther
On 9/5/07, Mark Mitchell <[EMAIL PROTECTED]> wrote: > Summary > === > > We are closing in on Stage 3, previously announced for September 10th. > At this point, I'm not aware of any reason to delay that date. Are > there any Stage 2 patches that people don't think will be submitted by > that po

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-05 Thread DJ Delorie
> It looks to me like this probably isn't quite ready for prime-time; > I do think we'd want to make the push/pop stuff fully reliable, > including warnings emitted from the middle-end. push-pop around functions won't be reliable until we have the file location thing, so we can map a file:line to

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-05 Thread Mark Mitchell
DJ Delorie wrote: > Also, we never decided if "undo" was worth the extra overhead. The > code is in the patch, but ifdef'd out. > >> URL, please? > > http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01317.html It looks to me like this probably isn't quite ready for prime-time; I do think we'd want

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-04 Thread DJ Delorie
> In, if it works. :-) Well, it does what it's supposed to do. Whether that's a "works" in the grand scheme of things is still debatable :-) I'd still need to write testcases and a changelog, as I was posing it as a what-if-example so far. Also, we still don't guarantee proper operation in all

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-04 Thread Mark Mitchell
DJ Delorie wrote: > Mark Mitchell <[EMAIL PROTECTED]> writes: >> Are there Stage 1 or Stage 2 patches in need of review? > > Do you want the diagnostic pragma push/pop patch in? In, if it works. :-) URL, please? Thanks, -- Mark Mitchell CodeSourcery [EMAIL PROTECTED] (650) 331-3385 x713

Re: GCC 4.3.0 Status Report (2007-09-04)

2007-09-04 Thread DJ Delorie
Mark Mitchell <[EMAIL PROTECTED]> writes: > Are there Stage 1 or Stage 2 patches in need of review? Do you want the diagnostic pragma push/pop patch in?