Re: Followup on PR/109279: large constants on RISCV

2023-06-17 Thread Jeff Law via Gcc
On 6/12/23 13:32, Vineet Gupta wrote: Gave this a try and it seems to fix Andrew's test, but then regresses the actual large const case: 0x1010101_01010101 : the mem to const_int transformation was being done in cse1 which no longer happens and the const pool from initial expand remains a

Re: Followup on PR/109279: large constants on RISCV

2023-06-12 Thread Vineet Gupta
Hi Jeff, Thx for the detailed explanation and insight. On 6/7/23 16:44, Jeff Law wrote: With 2e886eef7f2b, define_insn_and_split "*mvconst_internal" recog() kicks in during cse1, eliding insns for a const_int.     (insn 7 6 8 2 (set (reg:DI 137) (const_int [0x1010101])) {*mvconst_int

Re: Followup on PR/109279: large constants on RISCV

2023-06-07 Thread Jeff Law via Gcc
On 6/1/23 20:38, Vineet Gupta wrote: Hi Jeff, I finally got around to collecting various observations on PR/109279 - more importantly the state of large constants in RV backend, apologies in advance for the long email. It seems the various commits in area have improved the original test