Re: [BENCHMARK] runtime impact of fix for target/17390 on i386 targets

2005-10-20 Thread Uros Bizjak
Ian Lance Taylor wrote: Uros Bizjak <[EMAIL PROTECTED]> writes: There is no post-reload cse_condition_code_reg () pass, so perhaps we have to add one. A cse_condition_code_reg () walks all instructions by itself, so I'm not sure if some existing post-reload CSE pass could be enhanced.

Re: [BENCHMARK] runtime impact of fix for target/17390 on i386 targets

2005-10-20 Thread Ian Lance Taylor
Uros Bizjak <[EMAIL PROTECTED]> writes: > There is no post-reload cse_condition_code_reg () pass, so perhaps we > have to add one. A cse_condition_code_reg () walks all instructions by > itself, so I'm not sure if some existing post-reload CSE pass could be > enhanced. The cse_condition_code_reg

Re: [BENCHMARK] runtime impact of fix for target/17390 on i386 targets

2005-10-20 Thread Uros Bizjak
Hello Steven! > And FWIW, it is IMHO bad practice in general to just add new passes, > instead of investigating why existing passes don't do the job and how > they can be enhanced to do the job better. There is no post-reload cse_condition_code_reg () pass, so perhaps we have to add one. A cse_co

Re: [BENCHMARK] runtime impact of fix for target/17390 on i386 targets

2005-10-20 Thread Steven Bosscher
On Oct 20, 2005 10:45 AM, Uros Bizjak <[EMAIL PROTECTED]> wrote: > I got following times: > > 1m37.986 > 1m37.139 > 1m38.410 > > And _with_ patch: > > 1m37.264 > 1m37.352 > 1m37.383 > > I would say that the difference is burried in noise. It is still an extra pass over all instructions in the func