Re: Combined tree builds for mingw32

2007-05-07 Thread 'Daniel Jacobowitz'
On Tue, May 08, 2007 at 09:11:45AM +1200, Danny Smith wrote: > You've probably discovered this already, but... > > should not be included by default in libstdc++ on mingw > target. > That is taken care of by config/os/mingw32/os_defines.h. > min/max macros also are taken care of there, but I se

RE: Combined tree builds for mingw32

2007-05-07 Thread Danny Smith
> > > > > The failing command is trying to compile the PCH. This means that > > > we're including a large number of libstdc++ headers in a > row. One of > > > the first ones pulls in c++config.h, which has #undef > max; but so far, > > > nothing has included . Later, something includes > > >

Re: Combined tree builds for mingw32

2007-05-07 Thread Paolo Carlini
... should have explicitely added that changes to the mingw32 configure and mingw-specific config files are of course more than welcome: as soon as you are happy with a set of tweaks, just let the v3 people know! Paolo.

Re: Combined tree builds for mingw32

2007-05-07 Thread Daniel Jacobowitz
On Mon, May 07, 2007 at 10:55:38AM -0700, Brian Dessent wrote: > Well MinGW doesn't use any part of newlib so using --with-newlib sounds > like it's technically incorrect. The right way is probably to add > something that does the equivalent of > --with-headers=$top_srcdir/winsup/mingw/include (an

Re: Combined tree builds for mingw32

2007-05-07 Thread Daniel Jacobowitz
On Mon, May 07, 2007 at 07:47:01PM +0200, Paolo Carlini wrote: > Daniel Jacobowitz wrote: > > > The failing command is trying to compile the PCH. This means that > > we're including a large number of libstdc++ headers in a row. One of > > the first ones pulls in c++config.h, which has #undef max

Re: Combined tree builds for mingw32

2007-05-07 Thread Brian Dessent
Daniel Jacobowitz wrote: > The failing command is trying to compile the PCH. This means that > we're including a large number of libstdc++ headers in a row. One of > the first ones pulls in c++config.h, which has #undef max; but so far, > nothing has included . Later, something includes > gthr-

Re: Combined tree builds for mingw32

2007-05-07 Thread Paolo Carlini
Paolo Carlini wrote: Forgot: in fact, I don't see why the specific scenario above can happen: now includes c++config.h, which (now, not in old releases) undefs #min and #max again... Never mind, c++config.h has been included before. May previous doubts stand however. Paolo.

Re: Combined tree builds for mingw32

2007-05-07 Thread Daniel Jacobowitz
On Mon, May 07, 2007 at 01:37:51PM -0400, Daniel Jacobowitz wrote: > That third one does not define _U. It uses _UPPER instead. Does this > mean --with-newlib does not work for mingw32? (Note, you can't build > without it either.) That does appear to be the case. With --with-newlib, we get con

Re: Combined tree builds for mingw32

2007-05-07 Thread Paolo Carlini
Paolo Carlini wrote: The failing command is trying to compile the PCH. This means that we're including a large number of libstdc++ headers in a row. One of the first ones pulls in c++config.h, which has #undef max; but so far, nothing has included . Later, something includes gthr-default.h; o

Re: Combined tree builds for mingw32

2007-05-07 Thread Paolo Carlini
Daniel Jacobowitz wrote: The failing command is trying to compile the PCH. This means that we're including a large number of libstdc++ headers in a row. One of the first ones pulls in c++config.h, which has #undef max; but so far, nothing has included . Later, something includes gthr-default.

Re: Combined tree builds for mingw32

2007-05-07 Thread Daniel Jacobowitz
On Mon, May 07, 2007 at 07:25:25PM +0200, Paolo Carlini wrote: > Hi, > > > The #undef min / #undef max in c++config.h do not work if c++config.h > > is included before windows.h, which happens during a build of the PCH; > > > I'm not sure to understand. Can you explain in better detail? Provious

Re: Combined tree builds for mingw32

2007-05-07 Thread Paolo Carlini
Hi, The #undef min / #undef max in c++config.h do not work if c++config.h is included before windows.h, which happens during a build of the PCH; I'm not sure to understand. Can you explain in better detail? Proviously, we had those undefs in the middle of stl_algobase.h, I don't see why tha