RE: [EXTERNAL] Re: State of AutoFDO in GCC

2022-07-27 Thread Eugene Rozenfeld via Gcc
Hi Xionghu, Yes, I'm pretty sure both of the fixes you mentioned are applicable to GCC 10. I'm not sure what the bar is for backporting fixes. Jan, can you comment on that? The fixes that Xionghu mentioned are: Fix indirect call inlining with AutoFDO https://gcc.gnu.org/git/?p=g

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2022-07-27 Thread Eugene Rozenfeld via Gcc
Hi Jan, Thank you for your reply. I did have you on the TO line in my latest patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596065.html That's the patch I need a review on. I'm looking forward to co-maintaining AutoFDO with you. Thanks, Eugene -Original Message- From: Jan

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2022-07-27 Thread Eugene Rozenfeld via Gcc
Hi David, Thank you for your offer to take on the responsibility of maintaining the AutoFDO-specific portions of the code. I'll be happy to do that with Jan's and other GGC maintainers' help. I hope more people will start using and contributing to AutoFDO. Thanks, Eugene -Original Message

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-06-24 Thread Eugene Rozenfeld via Gcc
this. The version of perf I'm using is 5.8.18. Thanks, Eugene -Original Message- From: Andi Kleen Sent: Friday, April 30, 2021 2:46 PM To: Eugene Rozenfeld via Gcc Cc: Xinliang David Li ; Richard Biener ; Eugene Rozenfeld ; Jan Hubicka Subject: Re: [EXTERNAL] Re: State of AutoF

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-06-14 Thread Wei Mi via Gcc
dnesday, May 26, 2021 7:52 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > Thanks. Good to know the build works with newer protobuf. > > Wei. &g

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-06-11 Thread Eugene Rozenfeld via Gcc
; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC Thanks. Good to know the build works with newer protobuf. Wei. On Wed, May 26, 2021 at 4:40 PM Eugene Rozenfeld wrote: > > 3.0.0 is the latest supported version on Ubuntu 18.04. I verified that the > build works on Ubuntu

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-26 Thread Wei Mi via Gcc
sion 3.6.1.3. > > Eugene > > -Original Message- > From: Wei Mi > Sent: Tuesday, May 25, 2021 8:07 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; gcc@gcc.gnu.org; > Wenlei He > Subject: Re: [EXTERNAL] Re: State

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-26 Thread Eugene Rozenfeld via Gcc
; Hongtao Yu ; Xinliang David Li ; Jan Hubicka ; gcc@gcc.gnu.org; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC I checked the source of protobuf 3.0.0 and it didn't contain the operator[] in RepeatedField. Need to install a newer version of protobuf. Thanks, Wei. On Tue, May 25,

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Wei Mi via Gcc
alled] > > -Original Message- > From: Wei Mi > Sent: Tuesday, May 25, 2021 9:17 AM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; gcc@gcc.gnu.org; > Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > &g

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Eugene Rozenfeld via Gcc
3.0.0-9.1ubuntu1 amd64 [installed] -Original Message- From: Wei Mi Sent: Tuesday, May 25, 2021 9:17 AM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang David Li ; Jan Hubicka ; gcc@gcc.gnu.org; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC It looks like

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Wei Mi via Gcc
Mi > Sent: Monday, May 24, 2021 8:54 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; gcc@gcc.gnu.org; > Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > It isn't exposed on my platfor

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Eugene Rozenfeld via Gcc
gcc@gcc.gnu.org; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC It isn't exposed on my platform either. Looks like a bug in perf_data_converter (i.e., quipper). Could you try adding #include in third_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see if it f

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Wei Mi via Gcc
24, 2021 8:12 PM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; gcc@gcc.gnu.org; > Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > > > Sorry, I added dependency for create_gcov but missed it for dump_gcov. Fixed

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Eugene Rozenfeld via Gcc
~~~ From: Wei Mi Sent: Monday, May 24, 2021 8:12 PM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang David Li ; Jan Hubicka ; gcc@gcc.gnu.org; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC Sorry, I added dependency for create_gcov but missed it for dump_gcov.

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Wei Mi via Gcc
Eugene > > From: Wei Mi > Sent: Saturday, May 22, 2021 9:37 AM > To: Eugene Rozenfeld > Cc: Andi Kleen ; Hongtao Yu ; Xinliang > David Li ; Jan Hubicka ; > gcc@gcc.gnu.org; Wenlei He > Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC > > It is a proto library bui

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Eugene Rozenfeld via Gcc
a: build stopped: subcommand failed. Thanks, Eugene From: Wei Mi Sent: Saturday, May 22, 2021 9:37 AM To: Eugene Rozenfeld Cc: Andi Kleen ; Hongtao Yu ; Xinliang David Li ; Jan Hubicka ; gcc@gcc.gnu.org; Wenlei He Subject: Re: [EXTERNAL] Re: State of AutoFDO in GCC It is a proto library

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-22 Thread Wei Mi via Gcc
It is a proto library build dependency issue which didn't expose on my platform. I fix it at https://github.com/google/autofdo/commit/98269aee9674cc885cc5eb1bd917eb2d12731710. Please try again. Thanks, Wei. On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld < eugene.rozenf...@microsoft.com> wrote:

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-21 Thread Eugene Rozenfeld via Gcc
I tried following the instructions in "2.2 Build autofdo tool for gcc" in https://github.com/google/autofdo#readme and got build failures: eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228] Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o FAILED: CMakeFiles/create_gcov_l

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-04-30 Thread Andi Kleen via Gcc
Eugene Rozenfeld via Gcc writes: > Is the format produced by create_gcov and expected by GCC under > -fauto-rpofile documented somewhere? How is it different from .gcda > used in FDO, e.g., as described here: > http://src.gnu-darwin.org/src/contrib/gcc/gcov-io.h.html? I believe it's very similar

RE: [EXTERNAL] Re: State of AutoFDO in GCC

2021-04-30 Thread Eugene Rozenfeld via Gcc
Is the format produced by create_gcov and expected by GCC under -fauto-rpofile documented somewhere? How is it different from .gcda used in FDO, e.g., as described here: http://src.gnu-darwin.org/src/contrib/gcc/gcov-io.h.html? My input data is different from perf.data and I'd like to write a too