Re: Problems in IPA passes

2017-11-01 Thread Jeff Law
On 11/01/2017 08:24 AM, Richard Biener wrote: On November 1, 2017 3:12:05 PM GMT+01:00, Jeff Law wrote: On 11/01/2017 12:31 AM, Richard Biener wrote: In my local tree I'm just passing around the vrp_bitmap_obstack right now. Nobody's accessing it via a global anymore. So at least we know

Re: Problems in IPA passes

2017-11-01 Thread Richard Biener
On November 1, 2017 3:12:05 PM GMT+01:00, Jeff Law wrote: >On 11/01/2017 12:31 AM, Richard Biener wrote: > >>> In my local tree I'm just passing around the vrp_bitmap_obstack >right >>> now. Nobody's accessing it via a global anymore. So at least we >know >>> what routines directly or indirectly

Re: Problems in IPA passes

2017-11-01 Thread Jeff Law
On 11/01/2017 12:31 AM, Richard Biener wrote: In my local tree I'm just passing around the vrp_bitmap_obstack right now. Nobody's accessing it via a global anymore. So at least we know what routines directly or indirectly want to touch vrp_bitmap_obstack. Maybe that's not necessary in most p

Re: Problems in IPA passes

2017-10-31 Thread Richard Biener
On October 31, 2017 4:49:20 PM GMT+01:00, Jeff Law wrote: >On 10/31/2017 04:36 AM, Richard Biener wrote: >> On October 31, 2017 10:49:51 AM GMT+01:00, Kugan Vivekanandarajah >> wrote: >>> Hi Jeff, >>> >>> On 31 October 2017 at 14:47, Jeff Law wrote: On 10/29/2017 03:54 PM, Kugan Vivekanand

Re: Problems in IPA passes

2017-10-31 Thread Jeff Law
On 10/31/2017 04:31 AM, Richard Biener wrote: > > Equivalence shouldn't be used from the extract_range_from_* routines. > Vrp_meet probably uses them though. Factoring this function would be nice. You'd think it shouldn't be needed :-) If we look at extract_range_from_binary_expr_1, you'll see

Re: Problems in IPA passes

2017-10-31 Thread Jeff Law
On 10/31/2017 04:36 AM, Richard Biener wrote: > On October 31, 2017 10:49:51 AM GMT+01:00, Kugan Vivekanandarajah > wrote: >> Hi Jeff, >> >> On 31 October 2017 at 14:47, Jeff Law wrote: >>> On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: Hi Jeff, On 28 October 2017 at 18:28

Re: Problems in IPA passes

2017-10-31 Thread Jeff Law
On 10/31/2017 03:49 AM, Kugan Vivekanandarajah wrote: > Hi Jeff, > > On 31 October 2017 at 14:47, Jeff Law wrote: >> On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: >>> Hi Jeff, >>> >>> On 28 October 2017 at 18:28, Jeff Law wrote: Jan, What's the purpose behind calling

Re: Problems in IPA passes

2017-10-31 Thread Richard Biener
On October 31, 2017 10:49:51 AM GMT+01:00, Kugan Vivekanandarajah wrote: >Hi Jeff, > >On 31 October 2017 at 14:47, Jeff Law wrote: >> On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: >>> Hi Jeff, >>> >>> On 28 October 2017 at 18:28, Jeff Law wrote: Jan, What's the purpo

Re: Problems in IPA passes

2017-10-31 Thread Richard Biener
On October 31, 2017 4:47:06 AM GMT+01:00, Jeff Law wrote: >On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: >> Hi Jeff, >> >> On 28 October 2017 at 18:28, Jeff Law wrote: >>> >>> Jan, >>> >>> What's the purpose behind calling vrp_meet and >>> extract_range_from_unary_expr from within the IP

Re: Problems in IPA passes

2017-10-31 Thread Kugan Vivekanandarajah
Hi Jeff, On 31 October 2017 at 14:47, Jeff Law wrote: > On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: >> Hi Jeff, >> >> On 28 October 2017 at 18:28, Jeff Law wrote: >>> >>> Jan, >>> >>> What's the purpose behind calling vrp_meet and >>> extract_range_from_unary_expr from within the IPA p

Re: Problems in IPA passes

2017-10-30 Thread Jeff Law
On 10/29/2017 03:54 PM, Kugan Vivekanandarajah wrote: > Hi Jeff, > > On 28 October 2017 at 18:28, Jeff Law wrote: >> >> Jan, >> >> What's the purpose behind calling vrp_meet and >> extract_range_from_unary_expr from within the IPA passes? > > This is used such that when we have an argument to a

Re: Problems in IPA passes

2017-10-30 Thread Jeff Law
On 10/28/2017 11:18 AM, Richard Biener wrote: > On October 28, 2017 9:28:38 AM GMT+02:00, Jeff Law wrote: >> >> Jan, >> >> What's the purpose behind calling vrp_meet and >> extract_range_from_unary_expr from within the IPA passes? >> >> AFAICT that is not safe to do. Various paths through those r

Re: Problems in IPA passes

2017-10-29 Thread Kugan Vivekanandarajah
Hi Jeff, On 28 October 2017 at 18:28, Jeff Law wrote: > > Jan, > > What's the purpose behind calling vrp_meet and > extract_range_from_unary_expr from within the IPA passes? This is used such that when we have an argument to a function and this for which we know the VR and this intern is passed

Re: Problems in IPA passes

2017-10-28 Thread Richard Biener
On October 28, 2017 9:28:38 AM GMT+02:00, Jeff Law wrote: > >Jan, > >What's the purpose behind calling vrp_meet and >extract_range_from_unary_expr from within the IPA passes? > >AFAICT that is not safe to do. Various paths through those routines >will access static objects within tree-vrp.c which

Re: Problems in IPA passes

2017-10-28 Thread Jan Hubicka
Dne 2017-10-28 09:28, Jeff Law napsal: Jan, What's the purpose behind calling vrp_meet and extract_range_from_unary_expr from within the IPA passes? AFAICT that is not safe to do. Various paths through those routines will access static objects within tree-vrp.c which may not be initialized whe

Problems in IPA passes

2017-10-28 Thread Jeff Law
Jan, What's the purpose behind calling vrp_meet and extract_range_from_unary_expr from within the IPA passes? AFAICT that is not safe to do. Various paths through those routines will access static objects within tree-vrp.c which may not be initialized when IPA runs (vrp_equiv_obstack, vr_value)