Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-09 Thread Diego Novillo
On 09/08/05 16:25, Laurent GUERBY wrote: FYI, this fixes both PR ada/23141 and ada/23142. Well, but I cannot get a clean bootstrap with it. It fails building libstdc++ on x86_64 and libgfortran on x86. I'll have to poke more.

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-08 Thread Laurent GUERBY
FYI, this fixes both PR ada/23141 and ada/23142. Laurent On Thu, 2005-09-08 at 10:27 -0400, Diego Novillo wrote: > On 09/05/05 17:39, Richard Kenner wrote: > > >Shouldn't the test be that both lhs_vr *and* vr_result are VR_RANGE? > > > > > Yes, good catch. If that fixes your testcase, please

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-08 Thread Diego Novillo
On 09/07/05 16:18, Jeffrey A Law wrote: Are you getting something different? We'd probably trigger a problem if lhs_vr = [0, max] vr_result = ~[max, max] in that case, the code at the end of vrp_visit_phi_node would erroneously set VR_RESULT to ~[-INF, max], which I can see causing

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-08 Thread Diego Novillo
On 09/08/05 10:49, Richard Kenner wrote: I saw email from Jeff yesterday asking for more details, though. I was travelling yesterday, but will try to get back to that message tomorrow. Hmm, I missed that. Will check the archives.

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-08 Thread Richard Kenner
Yes, good catch. If that fixes your testcase, please apply the fix. You are referring to this, right? Will do. Yes, precisely that. I saw email from Jeff yesterday asking for more details, though. I was travelling yesterday, but will try to get back to that message tomorrow.

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-08 Thread Diego Novillo
On 09/05/05 17:39, Richard Kenner wrote: Shouldn't the test be that both lhs_vr *and* vr_result are VR_RANGE? Yes, good catch. If that fixes your testcase, please apply the fix. You are referring to this, right? --- tree-vrp.c 7 Sep 2005 20:35:19 - 2.54 +++ tree-vrp.c 8 Sep 2

Re: Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-07 Thread Jeffrey A Law
On Mon, 2005-09-05 at 17:39 -0400, Richard Kenner wrote: > Suppose lhs_vr is [64,64] and vr_result is ~[0,0]. It would seem > that the code near the end of this function will malfunction. > > Shouldn't the test be that both lhs_vr *and* vr_result are VR_RANGE? > > This is causing an ACATS failur

Possible bug in tree-vrp.c:vrp_visit_phi_node

2005-09-05 Thread Richard Kenner
Suppose lhs_vr is [64,64] and vr_result is ~[0,0]. It would seem that the code near the end of this function will malfunction. Shouldn't the test be that both lhs_vr *and* vr_result are VR_RANGE? This is causing an ACATS failure in c45651a and possibly others.