Re: PCH versus --enable-mapped-location

2005-03-31 Thread Geoffrey Keating
Per Bothner <[EMAIL PROTECTED]> writes: > Daniel Jacobowitz wrote: > > That's exactly what Geoff said. There are two relevant properties of > > GCed memory here: > > - Anything in GCed memory will be saved to the PCH > > - Anything in GCed memory will be overwritten by loading the PCH. > >

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Geoffrey Keating
Per Bothner <[EMAIL PROTECTED]> writes: > Geoff Keating wrote: > >> * Any source_location values handed out before the #include > >> that restores the gch will become invalid. They will be re-mapped > >> to that in the pre-compiled header. Presumably that's ok - there's > >> no declartions or

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Per Bothner
Daniel Jacobowitz wrote: > That's exactly what Geoff said. There are two relevant properties of GCed memory here: - Anything in GCed memory will be saved to the PCH - Anything in GCed memory will be overwritten by loading the PCH. So the corrollary: After a restore any pointers from non-gc'd

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Daniel Jacobowitz
On Thu, Mar 31, 2005 at 01:25:45PM -0800, Per Bothner wrote: > Geoff Keating wrote: > >> * Any source_location values handed out before the #include > >>that restores the gch will become invalid. They will be re-mapped > >>to that in the pre-compiled header. Presumably that's ok - there's > >>no

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Per Bothner
Geoff Keating wrote: >> * Any source_location values handed out before the #include that restores the gch will become invalid. They will be re-mapped to that in the pre-compiled header. Presumably that's ok - there's no declartions or expressions in the main file at that point, or the restore wo

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Geoff Keating
On 30/03/2005, at 10:36 PM, Per Bothner wrote: * Note that we compile the gch file as it were the main file - i.e. it has the MAIN_FILE_P property, and it is not included from any file. This means the restored line_table is slightly anomalous. One solution to this is when we generate the gch file

Re: PCH versus --enable-mapped-location

2005-03-31 Thread Devang Patel
On Mar 30, 2005, at 10:36 PM, Per Bothner wrote: * Note that we compile the gch file as it were the main file - i.e. it has the MAIN_FILE_P property, and it is not included from any file. Another side effect, it bypasses system header check. gcc -x c-header /usr/include/stdio.h Here, stdio.h is

PCH versus --enable-mapped-location

2005-03-30 Thread Per Bothner
I think I have a better handle of where the pch regressions with --enable-mapped-location are coming from. This is a follow-up to some debugging/experimentation that Zack did - in September! I agree with Zack that the problem is that the line_table data structure needs to saved into the gch file a