Re: New mklog script

2020-05-27 Thread Martin Liška
On 5/26/20 5:38 PM, Martin Sebor wrote: By the way, it's nice that the existing gcc- aliases are documented on https://gcc.gnu.org/gitwrite.html.  I would suggest to add this one there as well. Yes. I added the documentation bit and pushed ho master. Martin >From 035bdc56110914329c860870e33846

Re: New mklog script

2020-05-27 Thread Martin Liška
On 5/26/20 8:06 PM, Jason Merrill wrote: gcc-ci-log would be better if you want something short; I'd prefer gcc-commit-mklog, and let people define their own shorter aliases as desired. Hello. There's a rename I'm going to install. Martin >From b423f910dcc2a58a86b61cc5b966a81066abbf12 Mon Se

Re: New mklog script

2020-05-26 Thread Jason Merrill via Gcc
On Tue, May 26, 2020 at 11:38 AM Martin Sebor wrote: > On 5/26/20 7:14 AM, Martin Liška wrote: > > On 5/26/20 3:11 PM, Richard Earnshaw wrote: > >> On 26/05/2020 14:09, Martin Liška wrote: > >>> On 5/26/20 1:18 PM, Richard Earnshaw wrote: > On 26/05/2020 12:14, Martin Liška wrote: > > On

Re: New mklog script

2020-05-26 Thread Martin Sebor via Gcc
On 5/26/20 7:14 AM, Martin Liška wrote: On 5/26/20 3:11 PM, Richard Earnshaw wrote: On 26/05/2020 14:09, Martin Liška wrote: On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that ali

Re: New mklog script

2020-05-26 Thread Jakub Jelinek via Gcc
On Tue, May 26, 2020 at 03:14:54PM +0200, Martin Liška wrote: > > > > gcc-ci? > > > > > > What the abbreviation stands for? > > > > > > Martin > > > > > > > > > > > R. > > > > > > > > > > > CheckIn > > > > For those who come from the SVN days where ci was the standard > > abbreviation for c

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 3:11 PM, Richard Earnshaw wrote: On 26/05/2020 14:09, Martin Liška wrote: On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 26/05/2020 14:09, Martin Liška wrote: > On 5/26/20 1:18 PM, Richard Earnshaw wrote: >> On 26/05/2020 12:14, Martin Liška wrote: >>> On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?  This seems to go against that

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 1:18 PM, Richard Earnshaw wrote: On 26/05/2020 12:14, Martin Liška wrote: On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'?  This seems to go against that. You are right, but this one is so handy ;) What name

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 26/05/2020 12:14, Martin Liška wrote: > On 5/26/20 12:23 PM, Richard Earnshaw wrote: >> I thought we had a convention that aliases we added were prefixed with >> 'gcc-'?  This seems to go against that. > > You are right, but this one is so handy ;) > What name do you suggest? > > Martin gcc-c

Re: New mklog script

2020-05-26 Thread Martin Liška
On 5/26/20 12:23 PM, Richard Earnshaw wrote: I thought we had a convention that aliases we added were prefixed with 'gcc-'? This seems to go against that. You are right, but this one is so handy ;) What name do you suggest? Martin

Re: New mklog script

2020-05-26 Thread Richard Earnshaw
On 25/05/2020 20:41, Jason Merrill via Gcc-patches wrote: > On Mon, May 25, 2020 at 5:23 AM Martin Liška wrote: >> >> On 5/22/20 11:01 PM, Jason Merrill wrote: >>> On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > > On 5

Re: New mklog script

2020-05-25 Thread Jason Merrill via Gcc
On Mon, May 25, 2020 at 5:23 AM Martin Liška wrote: > > On 5/22/20 11:01 PM, Jason Merrill wrote: > > On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: > >> > >> On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > >>> > >>> On 5/15/20 3:22 PM, Marek Polacek wrote: > On Fri, May 15, 20

Re: New mklog script

2020-05-25 Thread Martin Liška
On 5/22/20 11:01 PM, Jason Merrill wrote: On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: On 5/15/20 3:22 PM, Marek Polacek wrote: On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: On 5/15/20 2:42 PM, Marek Polacek wrot

Re: New mklog script

2020-05-25 Thread Martin Liška
On 5/22/20 6:43 PM, Martin Sebor wrote: On 5/21/20 2:16 AM, Martin Liška wrote: Hello Martin. Can you please compare the current mklog.py. Is there anything you miss compared to your current script? Nope, it matches the format I get with my script and even works better and runs faster.  Very

Re: New mklog script

2020-05-22 Thread Jason Merrill via Gcc
On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: > > On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > > > > On 5/15/20 3:22 PM, Marek Polacek wrote: > > > On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: > > >> On 5/15/20 2:42 PM, Marek Polacek wrote: > > >>> I actually use

Re: New mklog script

2020-05-22 Thread Jonathan Wakely via Gcc
On Fri, 22 May 2020 at 19:15, Thomas Koenig via Gcc wrote: > > Hi, > > what's currently in trunk (as of a few hours ago) fails for me with > >File "contrib/mklog.py", line 36, in > from unidiff import PatchSet > ModuleNotFoundError: No module named 'unidiff' > > I think this is an error

Re: New mklog script

2020-05-22 Thread Thomas Koenig via Gcc
Hi, what's currently in trunk (as of a few hours ago) fails for me with File "contrib/mklog.py", line 36, in from unidiff import PatchSet ModuleNotFoundError: No module named 'unidiff' I think this is an error which would have to be taken into account one way or another - maybe include i

Re: New mklog script

2020-05-22 Thread Martin Sebor via Gcc
On 5/21/20 2:16 AM, Martin Liška wrote: Hello Martin. Can you please compare the current mklog.py. Is there anything you miss compared to your current script? Nope, it matches the format I get with my script and even works better and runs faster. Very nice! I'll be happy to switch to using i

Re: New mklog script

2020-05-21 Thread Jason Merrill via Gcc
On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > > On 5/15/20 3:22 PM, Marek Polacek wrote: > > On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: > >> On 5/15/20 2:42 PM, Marek Polacek wrote: > >>> I actually use mklog -i all the time. But I can work around it if it > >>> disapp

Re: New mklog script

2020-05-21 Thread Martin Liška
Hello Martin. Can you please compare the current mklog.py. Is there anything you miss compared to your current script? Thanks, Martin

Re: New mklog script

2020-05-19 Thread Michael Matz
Hello, On Tue, 19 May 2020, Jakub Jelinek wrote: > On Tue, May 19, 2020 at 05:21:16PM +0100, Richard Earnshaw wrote: > > This is really a wart in the GNU coding style. And one reason why I > > tend to indent such labels by a single space. It particularly affects > > things like class definition

Re: New mklog script

2020-05-19 Thread Jonathan Wakely via Gcc
On Tue, 19 May 2020 at 09:26, Jakub Jelinek via Gcc wrote: > > On Tue, May 19, 2020 at 10:11:28AM +0200, Martin Liška wrote: > > > I find this format more helpful for the reasons below so unless your > > > script can be tweaked to do something similar I'd like to be able to > > > continue to use m

Re: New mklog script

2020-05-19 Thread Jonathan Wakely via Gcc
On Tue, 19 May 2020 at 17:13, Joseph Myers wrote: > > On Tue, 19 May 2020, Martin Liška wrote: > > > On 5/19/20 10:11 AM, Martin Liška wrote: > > > Can you please share how do you do it? It would be easy to add it. > > > > I added the feature via --fill-up-bug-titles option. It uses common > > requ

Re: New mklog script

2020-05-19 Thread Martin Liška
On 5/19/20 5:53 PM, Joseph Myers wrote: On Tue, 19 May 2020, Martin Liška wrote: On 5/19/20 10:11 AM, Martin Liška wrote: Can you please share how do you do it? It would be easy to add it. I added the feature via --fill-up-bug-titles option. It uses common request and beatifulsoup packages.

Re: New mklog script

2020-05-19 Thread Jakub Jelinek via Gcc
On Tue, May 19, 2020 at 05:21:16PM +0100, Richard Earnshaw wrote: > This is really a wart in the GNU coding style. And one reason why I > tend to indent such labels by a single space. It particularly affects > things like class definitions where public, private, etc statements > often appear in c

Re: New mklog script

2020-05-19 Thread Richard Earnshaw
On 19/05/2020 15:51, Michael Matz wrote: > Hello, > > On Tue, 19 May 2020, Martin Liška wrote: > >>> The common problems I remember is that e.g. when changing a function comment >>> above some function, it is attributed to the previous function rather than >>> following, labels in function confus

Re: New mklog script

2020-05-19 Thread Joseph Myers
On Tue, 19 May 2020, Martin Liška wrote: > On 5/19/20 10:11 AM, Martin Liška wrote: > > Can you please share how do you do it? It would be easy to add it. > > I added the feature via --fill-up-bug-titles option. It uses common > request and beatifulsoup packages. The REST interface is much bette

Re: New mklog script

2020-05-19 Thread Michael Matz
Hello, On Tue, 19 May 2020, Martin Liška wrote: > > The common problems I remember is that e.g. when changing a function comment > > above some function, it is attributed to the previous function rather than > > following, labels in function confusing it: > > void > > foo () > > { > > .

Re: New mklog script

2020-05-19 Thread Martin Liška
f42f69676942 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Fri, 15 May 2020 00:44:07 +0200 Subject: [PATCH 2/2] New mklog script. contrib/ChangeLog: 2020-05-15 Martin Liska * gcc-git-customization.sh: Add alias.gcc-mklog new hook. * mklog.py: New file. * test_mklog.py: New fil

Re: New mklog script

2020-05-19 Thread Martin Liška
On 5/19/20 10:23 AM, Jakub Jelinek wrote: On Tue, May 19, 2020 at 10:11:28AM +0200, Martin Liška wrote: I find this format more helpful for the reasons below so unless your script can be tweaked to do something similar I'd like to be able to continue to use mine going forward with the new infras

Re: New mklog script

2020-05-19 Thread Martin Liška
001 From: Martin Liska Date: Fri, 15 May 2020 00:44:07 +0200 Subject: [PATCH] New mklog script. contrib/ChangeLog: 2020-05-15 Martin Liska * gcc-git-customization.sh: Add alias.gcc-mklog new hook. * mklog_ng.py: New file. * test_mklog_ng.py: New file. --- contrib/gcc-git-customization.sh |

Re: New mklog script

2020-05-19 Thread Jakub Jelinek via Gcc
On Tue, May 19, 2020 at 10:11:28AM +0200, Martin Liška wrote: > > I find this format more helpful for the reasons below so unless your > > script can be tweaked to do something similar I'd like to be able to > > continue to use mine going forward with the new infrastructure. > > Let's extend the c

Re: New mklog script

2020-05-19 Thread Martin Liška
cc/varasm.c +++ b/gcc/varasm.c @@ -1,3 +1,5 @@ + + /* Output variables, constants and external declarations, for GNU compiler. Copyright (C) 1987-2020 Free Software Foundation, Inc. >From 58719696e8b1acc06d788c0db069c4194b61e56f Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Fri, 15 May

Re: New mklog script

2020-05-15 Thread Martin Liška
On 5/15/20 3:22 PM, Marek Polacek wrote: On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: On 5/15/20 2:42 PM, Marek Polacek wrote: I actually use mklog -i all the time. But I can work around it if it disappears. Ah, I can see a consumer. There's an updated version that supports

Re: New mklog script

2020-05-15 Thread Martin Sebor via Gcc
On 5/15/20 2:59 AM, Martin Liška wrote: Hi. Since we moved to git world and we're in the preparation for ChangeLog messages being in git commit messages, I think it's the right time to also simplify mklog script. I'm sending a new version (which should eventually replace contrib/mklog and c

Re: New mklog script

2020-05-15 Thread Marek Polacek via Gcc
On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: > On 5/15/20 2:42 PM, Marek Polacek wrote: > > I actually use mklog -i all the time. But I can work around it if it > > disappears. > > Ah, I can see a consumer. > There's an updated version that supports that. > > For the future, wil

Re: New mklog script

2020-05-15 Thread Martin Liška
On 5/15/20 2:42 PM, Marek Polacek wrote: I actually use mklog -i all the time. But I can work around it if it disappears. Ah, I can see a consumer. There's an updated version that supports that. For the future, will you still use the option? Wouldn't be better to put the ChangeLog content dir

Re: New mklog script

2020-05-15 Thread David Malcolm via Gcc
On Fri, 2020-05-15 at 13:20 +0200, Martin Liška wrote: > On 5/15/20 12:58 PM, David Malcolm wrote: > > On Fri, 2020-05-15 at 10:59 +0200, Martin Liška wrote: > > > Hi. > > > > > > Since we moved to git world and we're in the preparation for > > > ChangeLog messages > > > being in git commit messag

Re: New mklog script

2020-05-15 Thread Marek Polacek via Gcc
On Fri, May 15, 2020 at 10:59:56AM +0200, Martin Liška wrote: > Hi. > > Since we moved to git world and we're in the preparation for ChangeLog > messages > being in git commit messages, I think it's the right time to also simplify > mklog > script. > > I'm sending a new version (which should ev

Re: New mklog script

2020-05-15 Thread Martin Liška
On 5/15/20 12:58 PM, David Malcolm wrote: On Fri, 2020-05-15 at 10:59 +0200, Martin Liška wrote: Hi. Since we moved to git world and we're in the preparation for ChangeLog messages being in git commit messages, I think it's the right time to also simplify mklog script. I'm sending a new versio

Re: New mklog script

2020-05-15 Thread David Malcolm via Gcc
On Fri, 2020-05-15 at 10:59 +0200, Martin Liška wrote: > Hi. > > Since we moved to git world and we're in the preparation for > ChangeLog messages > being in git commit messages, I think it's the right time to also > simplify mklog > script. > > I'm sending a new version (which should eventually

New mklog script

2020-05-15 Thread Martin Liška
Hi. Since we moved to git world and we're in the preparation for ChangeLog messages being in git commit messages, I think it's the right time to also simplify mklog script. I'm sending a new version (which should eventually replace contrib/mklog and contrib/mklog.pl). Changes made in the versio