Re: Flags and pph...

2011-07-19 Thread Diego Novillo
On Tue, Jul 19, 2011 at 00:09, Gabriel Charette wrote: > There is also the case where different C files are compiled with different > flags, but using the same headers (in the current build system say). When > moving to pph we would need to recognize that and generate different pph > files (as op

Re: Flags and pph...

2011-07-18 Thread Diego Novillo
On Mon, Jul 18, 2011 at 21:00, Gabriel Charette wrote: > We probably only want to enforce this for a subset of the flags (i.e. > we don't care about flags like -Wall and stuff like that, but only > about the flags actually affecting the binary output). In principle, this is no different than mix

Re: Flags and pph...

2011-07-18 Thread Gabriel Charette
On Mon, Jul 18, 2011 at 5:52 PM, Diego Novillo wrote: > On Mon, Jul 18, 2011 at 20:45, Gabriel Charette wrote: >> To demonstrate my point: >> add /* { dg-options "-ffinite-math-only -fno-math-errno" } */ >> to c1builin-integral.cc >> >> and watch the test pass (since now we are using the flags ac

Re: Flags and pph...

2011-07-18 Thread Diego Novillo
On Mon, Jul 18, 2011 at 20:45, Gabriel Charette wrote: > To demonstrate my point: > add /* { dg-options "-ffinite-math-only -fno-math-errno" } */ > to c1builin-integral.cc > > and watch the test pass (since now we are using the flags across all > compilations). Ah, OK. That's your fix then. Di

Re: Flags and pph...

2011-07-18 Thread Diego Novillo
On Mon, Jul 18, 2011 at 20:29, Gabriel Charette wrote: > so the asm diff we are seeing in c1builtin-integral is not something > we are not streaming out, or any other logic being wrong in the pph. > > The problem is: we define a dg-options entry in the header file which > tells deja-gnu to add fl

Re: Flags and pph...

2011-07-18 Thread Gabriel Charette
To demonstrate my point: add /* { dg-options "-ffinite-math-only -fno-math-errno" } */ to c1builin-integral.cc and watch the test pass (since now we are using the flags across all compilations). Or similarly, remove the same dg-options entry from c0builtin-integral.h and watch the test pass (sinc

Flags and pph...

2011-07-18 Thread Gabriel Charette
Hey guys, so the asm diff we are seeing in c1builtin-integral is not something we are not streaming out, or any other logic being wrong in the pph. The problem is: we define a dg-options entry in the header file which tells deja-gnu to add flags to the compilation (so far so good...) The problem