Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-22 Thread Jan Hubicka
> Hello. > I have already sent a patch for expanding roundeven for i386 with > relevant doubts. I also was regression testing with > make -k check > after successful bootstrap build with reverting my patches. Turns out > do-check fails without any patches applied, Is it ok to do anyways for > appli

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-22 Thread Tejas Joshi
Hello. I have already sent a patch for expanding roundeven for i386 with relevant doubts. I also was regression testing with make -k check after successful bootstrap build with reverting my patches. Turns out do-check fails without any patches applied, Is it ok to do anyways for applied patch? Also

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-19 Thread Tejas Joshi
Hello. I have made following changes to inspect inlining of roundeven with the following test code: double plusone (double d) { return __builtin_roundeven (d) + 1; } Running the program using -O2 foo.c gave internal compiler error which I believe is because gcc_unreachable() at: if (TARGET_SS

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-17 Thread Joseph Myers
On Mon, 17 Jun 2019, Tejas Joshi wrote: > > existing ROUND_NO_EXC definition in GCC. A new definition will need > > adding alongside ROUND_FLOOR, ROUND_CEIL and ROUND_TRUNC to correspond to > > rounding to nearest with ties to even, evaluating to 0.) > > So (ROUND_ROUNDEVEN 0x0) be declared fo

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-17 Thread Joseph Myers
On Fri, 14 Jun 2019, Martin Jambor wrote: > Make sure you compile to a target that has the rounding instruction, > i.e. by using an appropriate -march or -mavx) and also specify > -ffast-math on the command line. I have not double checked, but I > assume the latter is necessary (mainly) because i

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-17 Thread Tejas Joshi
Hello. Looking at machine description of functions like ceil/floor and I think specifically: (define_expand "2" Roundeven should be described as define_expand (or within this alongside ceil and floor?) with expand functions to emit instructions in i386-builtins.c? Referring to , operands of these

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-14 Thread Martin Jambor
Hi, On Fri, Jun 14 2019, Tejas Joshi wrote: >> Of course the instruction is not present there, that is the next step in >> your project :-) > > Yes, of course, but what I meant was that instructions for existing > round/ceil functions and not roundeven. If inlining for these > functions is availab

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-14 Thread Tejas Joshi
> Of course the instruction is not present there, that is the next step in > your project :-) Yes, of course, but what I meant was that instructions for existing round/ceil functions and not roundeven. If inlining for these functions is available, how can I inspect such instructions getting inline

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-13 Thread Joseph Myers
On Thu, 13 Jun 2019, Martin Jambor wrote: > architecture supports it. (and if IIUC, the intent is to use the 0 mode > from table 4-8 in > https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf > in instructions that take a rounding a mode to implement rounde

Re: Expanding roundeven (Was: Re: About GSOC.)

2019-06-13 Thread Martin Jambor
Hi Tejas, On Thu, Jun 13 2019, Tejas Joshi wrote: > Hello. > As further part of implementing roundeven is inlining, I was studying > machine descriptions and I have a few questions. > > As suggested, builtin functions provided a strong model for > implementing roundeven. Keeping that in mind, I tr