Re: C++ coding style inconsistencies

2015-07-14 Thread Trevor Saunders
On Tue, Jul 14, 2015 at 04:31:16PM +0200, Martin Liška wrote: > On 06/25/2015 08:28 PM, Richard Sandiford wrote: > > Sorry in advance for inviting a bikeshed discussion, but while making > > the hashing changes that I just committed, I noticed that the C++ification > > has been done in a variety of

Re: C++ coding style inconsistencies

2015-07-14 Thread Martin Liška
On 06/25/2015 08:28 PM, Richard Sandiford wrote: > Sorry in advance for inviting a bikeshed discussion, but while making > the hashing changes that I just committed, I noticed that the C++ification > has been done in a variety of different styles. I ended up having to follow > the "do what the sur

Re: C++ coding style inconsistencies

2015-06-29 Thread Jeff Law
On 06/27/2015 01:18 AM, Richard Sandiford wrote: Mikhail Maltsev writes: Perhaps one disappointing exception is mixed space/tabs indentation. It is often inconsistent (i.e. some parts use space-only indentation). Yeah. Been hitting that recently too. commit-hooks are the solution to this cla

Re: C++ coding style inconsistencies

2015-06-27 Thread Richard Sandiford
Mikhail Maltsev writes: > On 06/25/2015 09:28 PM, Richard Sandiford wrote: >> Sorry in advance for inviting a bikeshed discussion, but while making >> the hashing changes that I just committed, I noticed that the C++ification >> has been done in a variety of different styles. I ended up having to

Re: C++ coding style inconsistencies

2015-06-26 Thread Jeff Law
On 06/26/2015 03:50 AM, Martin Jambor wrote: Hi, On Thu, Jun 25, 2015 at 04:59:51PM -0400, David Malcolm wrote: On Thu, 2015-06-25 at 19:28 +0100, Richard Sandiford wrote: Sorry in advance for inviting a bikeshed discussion, but while making the hashing changes that I just committed, I noticed

Re: C++ coding style inconsistencies

2015-06-26 Thread Jonathan Wakely
On 26 June 2015 at 10:40, Martin Jambor wrote: >> (1) Should inline member functions be implemented inside the class or outside >> the class? If inside, should they be formatted like this: > > https://gcc.gnu.org/codingconventions.html has a big section on C++ > (note that there is also a simi

Re: C++ coding style inconsistencies

2015-06-26 Thread Martin Jambor
Hi, On Thu, Jun 25, 2015 at 04:59:51PM -0400, David Malcolm wrote: > On Thu, 2015-06-25 at 19:28 +0100, Richard Sandiford wrote: > > Sorry in advance for inviting a bikeshed discussion, but while making > > the hashing changes that I just committed, I noticed that the C++ification > > has been don

Re: C++ coding style inconsistencies

2015-06-26 Thread Richard Biener
On Thu, Jun 25, 2015 at 10:44 PM, Jeff Law wrote: > On 06/25/2015 12:28 PM, Richard Sandiford wrote: >> >> Sorry in advance for inviting a bikeshed discussion, but while making >> the hashing changes that I just committed, I noticed that the C++ification >> has been done in a variety of different

Re: C++ coding style inconsistencies

2015-06-26 Thread Martin Jambor
Hi, On Thu, Jun 25, 2015 at 07:28:45PM +0100, Richard Sandiford wrote: > Sorry in advance for inviting a bikeshed discussion >, but while making > the hashing changes that I just committed, I noticed that the C++ification > has been done in a variety of different styles. I ended up having to foll

Re: C++ coding style inconsistencies

2015-06-25 Thread Mikhail Maltsev
On 06/25/2015 09:28 PM, Richard Sandiford wrote: > Sorry in advance for inviting a bikeshed discussion, but while making > the hashing changes that I just committed, I noticed that the C++ification > has been done in a variety of different styles. I ended up having to follow > the "do what the sur

Re: C++ coding style inconsistencies

2015-06-25 Thread David Malcolm
On Thu, 2015-06-25 at 19:28 +0100, Richard Sandiford wrote: > Sorry in advance for inviting a bikeshed discussion, but while making > the hashing changes that I just committed, I noticed that the C++ification > has been done in a variety of different styles. I ended up having to follow > the "do w

Re: C++ coding style inconsistencies

2015-06-25 Thread Jeff Law
On 06/25/2015 12:28 PM, Richard Sandiford wrote: Sorry in advance for inviting a bikeshed discussion, but while making the hashing changes that I just committed, I noticed that the C++ification has been done in a variety of different styles. I ended up having to follow the "do what the surroundi

Re: C++ coding style inconsistencies

2015-06-25 Thread Jonathan Wakely
On 25 June 2015 at 19:28, Richard Sandiford wrote: > (2) Is there supposed to be a space before a template parameter list? > I.e. is it: > >foo > > or: > >foo > > ? Both are widely used. > > The current coding conventions don't say explicitly, but all the > exa

C++ coding style inconsistencies

2015-06-25 Thread Richard Sandiford
Sorry in advance for inviting a bikeshed discussion, but while making the hashing changes that I just committed, I noticed that the C++ification has been done in a variety of different styles. I ended up having to follow the "do what the surrounding code does" principle that some code bases have,