Re: [RFC] Disabling ICF for interrupt functions

2019-07-31 Thread Jozef Lawrynowicz
On Wed, 31 Jul 2019 11:49:58 +0200 Richard Biener wrote: > On Tue, Jul 30, 2019 at 3:41 PM Jozef Lawrynowicz > wrote: > > > > On Fri, 26 Jul 2019 18:39:50 +0100 > > Richard Sandiford wrote: > > > > > [Catching up after being away, sorry if this has already been resolved.] > > > > > > Jozef La

Re: [RFC] Disabling ICF for interrupt functions

2019-07-31 Thread Richard Biener
On Tue, Jul 30, 2019 at 3:41 PM Jozef Lawrynowicz wrote: > > On Fri, 26 Jul 2019 18:39:50 +0100 > Richard Sandiford wrote: > > > [Catching up after being away, sorry if this has already been resolved.] > > > > Jozef Lawrynowicz writes: > > > For MSP430, the folding of identical functions marked

Re: [RFC] Disabling ICF for interrupt functions

2019-07-30 Thread Jozef Lawrynowicz
On Fri, 26 Jul 2019 18:39:50 +0100 Richard Sandiford wrote: > [Catching up after being away, sorry if this has already been resolved.] > > Jozef Lawrynowicz writes: > > For MSP430, the folding of identical functions marked with the "interrupt" > > attribute by -fipa-icf-functions results in wro

Re: [RFC] Disabling ICF for interrupt functions

2019-07-26 Thread Richard Sandiford
[Catching up after being away, sorry if this has already been resolved.] Jozef Lawrynowicz writes: > For MSP430, the folding of identical functions marked with the "interrupt" > attribute by -fipa-icf-functions results in wrong code being generated. > Interrupts have different calling conventions

Re: [RFC] Disabling ICF for interrupt functions

2019-07-22 Thread Alexander Monakov
On Mon, 22 Jul 2019, Jozef Lawrynowicz wrote: > This would have to be caught at the point that an optimization pass > first considers inserting a CALL to the interrupt, i.e., if the machine > description tries to prevent the generation of a call to an interrupt function > once the RTL has been gen

Re: [RFC] Disabling ICF for interrupt functions

2019-07-22 Thread Jozef Lawrynowicz
Hi, On Fri, 19 Jul 2019 16:32:21 +0300 (MSK) Alexander Monakov wrote: > On Fri, 19 Jul 2019, Jozef Lawrynowicz wrote: > > > For MSP430, the folding of identical functions marked with the "interrupt" > > attribute by -fipa-icf-functions results in wrong code being generated. > > Interrupts have

Re: [RFC] Disabling ICF for interrupt functions

2019-07-19 Thread Alexander Monakov
On Fri, 19 Jul 2019, Jozef Lawrynowicz wrote: > For MSP430, the folding of identical functions marked with the "interrupt" > attribute by -fipa-icf-functions results in wrong code being generated. > Interrupts have different calling conventions than regular functions, so > inserting a CALL from on

[RFC] Disabling ICF for interrupt functions

2019-07-19 Thread Jozef Lawrynowicz
For MSP430, the folding of identical functions marked with the "interrupt" attribute by -fipa-icf-functions results in wrong code being generated. Interrupts have different calling conventions than regular functions, so inserting a CALL from one identical interrupt to another is not correct and wil