Re: [RFA] dwarf2out.c:eliminate_regs() bug

2009-10-08 Thread Maxim Kuvyrkov
Richard Guenther wrote: ... Yes, though we should probably try to catch the DECL_ABSTRACT case further up the call chain - there shouldn't be any location lists for abstract function. Thus, see why static dw_die_ref gen_formal_parameter_die (tree node, tree origin, dw_die_ref context_die) ...

Re: [RFA] dwarf2out.c:eliminate_regs() bug

2009-09-20 Thread Richard Guenther
On Sun, Sep 20, 2009 at 1:18 PM, Maxim Kuvyrkov wrote: > Richard Guenther wrote: >> >> On Sun, Sep 20, 2009 at 9:38 AM, Maxim Kuvyrkov >> wrote: > > ... >>> >>> This code uses eliminate_regs(), which implicitly assumes >>> reload_completed >>> as it uses reg_eliminate[], which assumes that frame_

Re: [RFA] dwarf2out.c:eliminate_regs() bug

2009-09-20 Thread Maxim Kuvyrkov
Richard Guenther wrote: On Sun, Sep 20, 2009 at 9:38 AM, Maxim Kuvyrkov wrote: ... This code uses eliminate_regs(), which implicitly assumes reload_completed as it uses reg_eliminate[], which assumes that frame_pointer_needed is properly set, which happens in ira.c. However, in some cases thi

Re: [RFA] dwarf2out.c:eliminate_regs() bug

2009-09-20 Thread Richard Guenther
On Sun, Sep 20, 2009 at 9:38 AM, Maxim Kuvyrkov wrote: > I'm investigating an ICE on m68k architecture.  I'm not quite sure what is > the right way to fix the bug so I welcome any feedback on the below > analysis. > > Compilation fails on the assert in dwarf2out.c:based_loc_descr(): > >  /* We on

[RFA] dwarf2out.c:eliminate_regs() bug

2009-09-20 Thread Maxim Kuvyrkov
I'm investigating an ICE on m68k architecture. I'm not quite sure what is the right way to fix the bug so I welcome any feedback on the below analysis. Compilation fails on the assert in dwarf2out.c:based_loc_descr(): /* We only use "frame base" when we're sure we're talking about the