Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-15 Thread Gabriel Dos Reis
On Thu, Aug 14, 2008 at 12:14 PM, Aldy Hernandez <[EMAIL PROTECTED]> wrote: >> * In the near future, make -fdiagnostics-show-caret the default at >> least while in experimental mode or at least during stages1 and 2. >> When making a release -fno-diagnostics-show-caret would be the >> default. Do th

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-15 Thread Gabriel Dos Reis
On Thu, Aug 14, 2008 at 7:39 AM, Joseph S. Myers <[EMAIL PROTECTED]> wrote: > On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > > I don't think the option should necessarily just be boolean; once choice > that may make sense would be caret diagnostics for the first diagnostic > from an input file o

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Aldy Hernandez
> * In the near future, make -fdiagnostics-show-caret the default at > least while in experimental mode or at least during stages1 and 2. > When making a release -fno-diagnostics-show-caret would be the > default. Do this through a configure option that sets the default. > > * In the far away futu

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Joseph S. Myers <[EMAIL PROTECTED]>: > > The solution is producing accurate location ranges, which can be used (a) > to print more accurate expressions within the text of diagnostics in the > existing style, (b) to print GCS-compliant ranges in text that IDEs can > parse to highlight the

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Aldy Hernandez <[EMAIL PROTECTED]>: > > I envision the caret diagnostics being disabled for only a short while-- > while we beat some sense into the column information. There's no point > in attacking everything at once. Then, I think we are talking past each other. To be crystal clear,

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Aldy Hernandez
> Then we are not going to get correct locations ever. New users do not > read the manual. Neither old users do. New functionality disabled by > default will be lost for both. I am fairly sure that a significant > percentage of GCC developers (not just users) do not know about > -fdiagnostics-show-

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Joseph S. Myers
On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > 2008/8/14 Joseph S. Myers <[EMAIL PROTECTED]>: > > > > But in any case the default should be the default with no configure > > option, users liking it should find their makefiles work the same > > everywhere and users not liking it can add the oppo

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Joseph S. Myers <[EMAIL PROTECTED]>: > > But in any case the default should be the default with no configure > option, users liking it should find their makefiles work the same > everywhere and users not liking it can add the opposite option. Then we are not going to get correct location

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Joseph S. Myers
On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > Even if the configure options do not control the compilation of the > code, they should at least control the default. I think that, at least No, whatever the default is there should definitely be no configure option to control it. Configure opti

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Joseph S. Myers <[EMAIL PROTECTED]>: > On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > >> It is controlled by -fdiagnostics-show-caret. See the diff for gcc/opts.c. >> >> The configure options are meant to enable/disable all code related to >> caret printing in a similar way as it was d

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Joseph S. Myers
On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > It is controlled by -fdiagnostics-show-caret. See the diff for gcc/opts.c. > > The configure options are meant to enable/disable all code related to > caret printing in a similar way as it was done with mapped locations. > This was requested the f

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Joseph S. Myers <[EMAIL PROTECTED]>: > On Thu, 14 Aug 2008, Manuel López-Ibáñez wrote: > >> You can see many examples of the caret output by configuring with >> --enable-caret-diagnostics, then reverting the changes to >> gcc/testsuite/lib/gcc.exp and running the testsuite. Check the outp

[PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Manuel López-Ibáñez
2008/8/14 Tom Tromey <[EMAIL PROTECTED]>: > > ISTR Manuel having a patch for caret diagnostic output... ? > I was planning to submit it this week to consider it for GCC 4.4 (disabled by default). I am still testing it. Bootstrap and regression testing with --enable-languages=all,ada,obj-c++ is ver