Re: [PATCH] MIPS: Make BUG() __noreturn.

2008-11-21 Thread David Daney
Andrew Morton wrote: Yup, this change will fix some compile warnings which will never be fixed in any other way for mips. +static inline void __noreturn BUG(void) +{ + __asm__ __volatile__("break %0" : : "i" (BRK_BUG)); + /* Fool GCC into thinking the function doesn't return. */ +

Re: [PATCH] MIPS: Make BUG() __noreturn.

2008-11-21 Thread Ralf Baechle
On Fri, Nov 21, 2008 at 07:46:43PM +0100, Geert Uytterhoeven wrote: > > up with a couple of options: > > > > 1) Enhance the _builtin_trap() function so that we can specify the > > break code that is emitted. This would allow us to do something > > like: > > > > static inline void __attribut

Re: [PATCH] MIPS: Make BUG() __noreturn.

2008-11-21 Thread Geert Uytterhoeven
On Fri, 21 Nov 2008, David Daney wrote: > Geert Uytterhoeven wrote: > > On Fri, 21 Nov 2008, Alan Cox wrote: > > > On Thu, 20 Nov 2008 17:26:36 -0800 > > > David Daney <[EMAIL PROTECTED]> wrote: > > > > > > > MIPS: Make BUG() __noreturn. > > > > > > > > Often we do things like put BUG() in the de

Re: [PATCH] MIPS: Make BUG() __noreturn.

2008-11-21 Thread David Daney
Geert Uytterhoeven wrote: On Fri, 21 Nov 2008, Alan Cox wrote: On Thu, 20 Nov 2008 17:26:36 -0800 David Daney <[EMAIL PROTECTED]> wrote: MIPS: Make BUG() __noreturn. Often we do things like put BUG() in the default clause of a case statement. Since it was not declared __noreturn, this could