Re: [OMPD] regarding const char **ompd_dll_locations

2020-06-18 Thread Jakub Jelinek via Gcc
On Thu, Jun 18, 2020 at 06:19:43PM -0400, y2s1982 . wrote: > Thank you for the quick response. I assume, then, there's no need for > making a function to set this global variable at this point. Should I > create a simple unit test that asserts the value to be "libgompd.so.1" for > now, or should I

Re: [OMPD] regarding const char **ompd_dll_locations

2020-06-18 Thread y2s1982 . via Gcc
Hello Jakub, Thank you for the quick response. I assume, then, there's no need for making a function to set this global variable at this point. Should I create a simple unit test that asserts the value to be "libgompd.so.1" for now, or should I skip the unit test on this for now? Cheers, Tony Si

Re: [OMPD] regarding const char **ompd_dll_locations

2020-06-18 Thread Jakub Jelinek via Gcc
On Thu, Jun 18, 2020 at 05:24:25PM -0400, y2s1982 . wrote: > (LLVM currently simply puts { "ompd.so", NULL }, but I am assuming this was > just a placeholder.) Let's put there { "libgompd" SONAME_SUFFIX (1), NULL } for now. You'll need to change the SONAME_SUFFIX macros though - remove the ()s aro

[OMPD] regarding const char **ompd_dll_locations

2020-06-18 Thread y2s1982 . via Gcc
Hello everyone, I would like to share some of my thoughts and seek some opinions on coding for const char **ompd_dll_locations. After reviewing the documentation , looking over LLVM approach