Re: "fall-through" errors

2018-07-28 Thread Eric Gallager
On 7/28/18, Bruce Korb wrote: > ../../autoopts/makeshell.c: In function ‘text_to_var’: > ../../autoopts/makeshell.c:324:14: error: this statement may fall > through [-Werror=implicit-fallthrough=] > (*(opts->pUsageProc))(opts, EXIT_SUCCESS); > ~^~~

Re: "fall-through" errors

2018-07-28 Thread Bruce Korb
On Sat, Jul 28, 2018 at 11:48 AM Jakub Jelinek wrote: > You don't need to use configure for this, something like: > #ifdef __has_attribute > #if __has_attribute(__noreturn__) > #define NORETURN __attribute__((__noreturn__)) > #endif OK. Thanks. It _will_ be a bit more complicated because my

Re: "fall-through" errors

2018-07-28 Thread Jakub Jelinek
On Sat, Jul 28, 2018 at 10:56:24AM -0700, Bruce Korb wrote: > > NOTREACHED means something different, and I don't think we want to add > > support for this when we already support a way (including a standard way) to > > mark function pointers noreturn (noreturn attribute, _Noreturn in C). > > Or yo

Re: "fall-through" errors

2018-07-28 Thread Bruce Korb
On Sat, Jul 28, 2018 at 10:44 AM Jakub Jelinek wrote: > > On Sat, Jul 28, 2018 at 10:22:35AM -0700, Bruce Korb wrote: > > ../../autoopts/makeshell.c: In function ‘text_to_var’: > > ../../autoopts/makeshell.c:324:14: error: this statement may fall > > through [-Werror=implicit-fallthrough=] > >

Re: "fall-through" errors

2018-07-28 Thread Jakub Jelinek
On Sat, Jul 28, 2018 at 10:22:35AM -0700, Bruce Korb wrote: > ../../autoopts/makeshell.c: In function ‘text_to_var’: > ../../autoopts/makeshell.c:324:14: error: this statement may fall > through [-Werror=implicit-fallthrough=] > (*(opts->pUsageProc))(opts, EXIT_SUCCESS); >

"fall-through" errors

2018-07-28 Thread Bruce Korb
../../autoopts/makeshell.c: In function ‘text_to_var’: ../../autoopts/makeshell.c:324:14: error: this statement may fall through [-Werror=implicit-fallthrough=] (*(opts->pUsageProc))(opts, EXIT_SUCCESS); ~^~~~ This warning goes away if