Re: git hooks update

2020-09-08 Thread Joseph Myers
The new version of the hooks is now in use for the production repository. -- Joseph S. Myers jos...@codesourcery.com

Re: Why was it important to change "FALLTHROUGH" to "fall through"?

2020-09-08 Thread Jonathan Wakely via Gcc
On Tue, 8 Sep 2020 at 17:33, Bruce Korb wrote: > > On Tue, Sep 8, 2020 at 7:36 AM Jakub Jelinek wrote: > > > The fall through comment was polluted with a colon that I hadn't noticed, > > > as in: > > > > > > /* FALLTHROUGH: */ > > > > > > and your fall through regex doesn't allow for that. >

Re: Why was it important to change "FALLTHROUGH" to "fall through"?

2020-09-08 Thread Bruce Korb via Gcc
On Tue, Sep 8, 2020 at 7:36 AM Jakub Jelinek wrote: > > The fall through comment was polluted with a colon that I hadn't noticed, > > as in: > > > > /* FALLTHROUGH: */ > > > > and your fall through regex doesn't allow for that. > > I'd add a colon to the space, tab and '!' that the regex acce

Re: Why was it important to change "FALLTHROUGH" to "fall through"?

2020-09-08 Thread Jakub Jelinek via Gcc
On Tue, Sep 08, 2020 at 07:28:45AM -0700, Bruce Korb via Gcc wrote: > On Tue, Sep 8, 2020 at 2:33 AM Jonathan Wakely wrote: > > > Nope. I had /* FALLTHROUGH */ on the line before a blank line before > > > the case label. After Googling, I found an explicit reference that you > > > had to spell it:

Re: Why was it important to change "FALLTHROUGH" to "fall through"?

2020-09-08 Thread Bruce Korb via Gcc
On Tue, Sep 8, 2020 at 2:33 AM Jonathan Wakely wrote: > > Nope. I had /* FALLTHROUGH */ on the line before a blank line before > > the case label. After Googling, I found an explicit reference that you > > had to spell it: // fall through > > I did that, and it worked. So I'm moving on, but still

Re: Why was it important to change "FALLTHROUGH" to "fall through"?

2020-09-08 Thread Jonathan Wakely via Gcc
On Mon, 7 Sep 2020 at 23:53, Bruce Korb via Gcc wrote: > > On Mon, Sep 7, 2020 at 3:45 PM Florian Weimer wrote: > > > > * Bruce Korb via Gcc: > > > > > I don't write a lot of code anymore, but this sure seems like a > > > gratuitous irritation to me. I've been using > > > > > > // FALLTHRU an