Re: Dropping ChangeLogs

2017-12-22 Thread Eric S. Raymond
Joseph Myers : > I proposed removing the GNU Coding Standards requirement for ChangeLog > format when using a public distributed VCS with per-logical-changeset > commits in > > (discussion continues in August, September, N

Re: Dropping ChangeLogs

2017-12-22 Thread Joseph Myers
On Fri, 22 Dec 2017, Eric S. Raymond wrote: > Janne Blomqvist : > > My secret desire is that once we get this done we would drop these > > silly ChangeLogs. Although I'm not a kernel developer, I kind of like > > the Linux kernel style, where the commit msg contains a reasonably > > in-depth motiv

Re: Dropping ChangeLogs

2017-12-22 Thread Siddhesh Poyarekar
On Friday 22 December 2017 06:06 PM, Florian Weimer wrote: > I cannot agree with that.  Full commit review is an absolute requirement > before we can eliminate ChangeLogs because the review needs to cover the > author attribution. We have agreed on doing full commit reviews multiple times (at leas

Re: Dropping ChangeLogs

2017-12-22 Thread Florian Weimer
On 12/22/2017 01:34 PM, Siddhesh Poyarekar wrote: On Friday 22 December 2017 05:57 PM, Florian Weimer wrote: The Linux community does not have a tool-based solution for that.  I think it mainly relies on lack of commit access for contributors. Sure, but that's a minor detail to implement once

Re: Dropping ChangeLogs

2017-12-22 Thread Siddhesh Poyarekar
On Friday 22 December 2017 05:57 PM, Florian Weimer wrote: > The Linux community does not have a tool-based solution for that.  I > think it mainly relies on lack of commit access for contributors. Sure, but that's a minor detail to implement once we decide we don't need ChangeLogs. As far as gli

Re: Dropping ChangeLogs

2017-12-22 Thread Florian Weimer
On 12/22/2017 01:20 PM, Siddhesh Poyarekar wrote: On Friday 22 December 2017 05:41 PM, Florian Weimer wrote: *However*, my main problem with getting rid of ChangeLogs is that without a pull-request-based contribution procedure or some tool support like Gerrit, it's impossible to tell which parts

Re: How far should we trust ChangeLog attribution dates?

2017-12-22 Thread Richard Kenner
> My secret desire is that once we get this done we would drop these > silly ChangeLogs. Although I'm not a kernel developer, I kind of like > the Linux kernel style, where the commit msg contains a reasonably > in-depth motivation for the change, sort of like the email message one > sends to gcc-p

Re: Dropping ChangeLogs

2017-12-22 Thread Siddhesh Poyarekar
On Friday 22 December 2017 05:41 PM, Florian Weimer wrote: > *However*, my main problem with getting rid of ChangeLogs is that > without a pull-request-based contribution procedure or some tool support > like Gerrit, it's impossible to tell which parts of a patch submission> make > it into a commi

Re: Dropping ChangeLogs

2017-12-22 Thread Florian Weimer
On 12/22/2017 12:42 PM, Eric Botcazou wrote: ChangeLogs are a relic from the days before version-control systems with real changesets. When you have real changesets, all ChangeLogs do is add unnecessary process friction. ChangeLogs make it possible to quickly pinpoint unintentional changes goin

Re: Dropping ChangeLogs

2017-12-22 Thread Eric Botcazou
> ChangeLogs are a relic from the days before version-control systems with > real changesets. When you have real changesets, all ChangeLogs do is > add unnecessary process friction. ChangeLogs make it possible to quickly pinpoint unintentional changes going in the commits. Maybe git has specific

Dropping ChangeLogs

2017-12-22 Thread Eric S. Raymond
Janne Blomqvist : > My secret desire is that once we get this done we would drop these > silly ChangeLogs. Although I'm not a kernel developer, I kind of like > the Linux kernel style, where the commit msg contains a reasonably > in-depth motivation for the change, sort of like the email message on

Re: How far should we trust ChangeLog attribution dates?

2017-12-22 Thread Janne Blomqvist
On Fri, Dec 22, 2017 at 12:22 PM, Thomas Schwinge wrote: > Hi! > > On Thu, 21 Dec 2017 17:55:28 -0500, "Eric S. Raymond" > wrote: >> Jason Merrill : >> > YMD in the ChangeLog is typically commit date rather than authorship >> > date anyway, so (i) and (iii) shouldn't differ much at all, and (i)

Re: How far should we trust ChangeLog attribution dates?

2017-12-22 Thread Thomas Schwinge
Hi! On Thu, 21 Dec 2017 17:55:28 -0500, "Eric S. Raymond" wrote: > Jason Merrill : > > YMD in the ChangeLog is typically commit date rather than authorship > > date anyway, so (i) and (iii) shouldn't differ much at all, and (i) > > seems simpler. > > I have not generally observed this to be true