[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (opened)

2016-08-25 Thread jcholast
jcholast's pull request #20: "cert: include CA name in cert command output" was opened PR body: """ Include name of the CA that issued a certificate in cert-request, cert-show and cert-find. This allows the caller to call further commands on the cert without having to call ca-find to find the na

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (opened)

2016-08-25 Thread jcholast
jcholast's pull request #21: "custodia: include known CA certs in the PKCS#12 file for Dogtag" was opened PR body: """ This fixes CA replica install in a topology upgraded from CA-less to CA-full. https://fedorahosted.org/freeipa/ticket/6207 """ See the full pull-request at https://github.com/f

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (synchronize)

2016-08-26 Thread jcholast
jcholast's pull request #20: "cert: include CA name in cert command output" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/20 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/20/head:pr20 g

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (synchronize)

2016-08-26 Thread jcholast
jcholast's pull request #20: "cert: include CA name in cert command output" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/20 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/20/head:pr20 g

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-28 Thread jcholast
jcholast commented on a pull request """ LDAPS is not enabled during replica promotion because of this condition in DS setup: https://github.com/freeipa/freeipa/blob/master/ipaserver/install/dsinstance.py#L391 Maybe we can remove the condition rather than add `ds.enable_ssl()

[Freeipa-devel] [freeipa PR#22] otptoken: Convert ipatokenotpkey on server (+ack)

2016-08-29 Thread jcholast
dkupka's pull request #22: "otptoken: Convert ipatokenotpkey on server" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/22 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contrib

[Freeipa-devel] [freeipa PR#22] otptoken: Convert ipatokenotpkey on server (+pushed)

2016-08-29 Thread jcholast
dkupka's pull request #22: "otptoken: Convert ipatokenotpkey on server" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/22 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Cont

[Freeipa-devel] [freeipa PR#22] otptoken: Convert ipatokenotpkey on server (comment)

2016-08-29 Thread jcholast
jcholast commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/386fdc1d77affc897b923a58602a9f14325216c6 """ See the full comment at https://github.com/freeipa/freeipa/pull/22#issuecomment-243066366 -- Manage your subs

[Freeipa-devel] [freeipa PR#22] otptoken: Convert ipatokenotpkey on server (closed)

2016-08-29 Thread jcholast
dkupka's pull request #22: "otptoken: Convert ipatokenotpkey on server" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/22 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/22/head:pr22 git checko

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (opened)

2016-08-29 Thread jcholast
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was opened PR body: """ Fix the code which determines if a record part is required and thus should be prompted not to wrongfully consider all record parts to be optional. Add a client-side fallback of the dnsrecord_split

[Freeipa-devel] [freeipa PR#35] rpcserver: assume version 1 for unversioned command calls (opened)

2016-08-29 Thread jcholast
jcholast's pull request #35: "rpcserver: assume version 1 for unversioned command calls" was opened PR body: """ When a command is called on the server over RPC without its version specified, assume version 1 instead of the highest known version. This ensures backward compatibility with old clie

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (comment)

2016-08-29 Thread jcholast
jcholast commented on a pull request """ I'm afraid this can't be easily fixed due to the manner in which the dns plugin is implemented. I'm open to suggestions if you have any. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (synchronize)

2016-08-29 Thread jcholast
jcholast's pull request #20: "cert: include CA name in cert command output" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/20 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/20/head:pr20 g

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (+pushed)

2016-08-29 Thread jcholast
tomaskrizek's pull request #29: "Enable LDAPS in replica promotion" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/29 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribu

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (+ack)

2016-08-29 Thread jcholast
tomaskrizek's pull request #29: "Enable LDAPS in replica promotion" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/29 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (closed)

2016-08-29 Thread jcholast
tomaskrizek's pull request #29: "Enable LDAPS in replica promotion" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/29 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/29/head:pr29 git checkout pr

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread jcholast
jcholast commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/89de60c5d8ba64d619101a7498b8c4469b6e50ae """ See the full comment at https://github.com/freeipa/freeipa/pull/29#issuecomment-243343065 -- Manage your subs

[Freeipa-devel] [freeipa PR#3] User add fix #6199 (+ack)

2016-08-29 Thread jcholast
mbasti-rh's pull request #3: "User add fix #6199" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/3 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://w

[Freeipa-devel] [freeipa PR#3] User add fix #6199 (closed)

2016-08-29 Thread jcholast
mbasti-rh's pull request #3: "User add fix #6199" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/3 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/3/head:pr3 git checkout pr3 -- Manage your sub

[Freeipa-devel] [freeipa PR#3] User add fix #6199 (comment)

2016-08-29 Thread jcholast
jcholast commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/5c50b265e6b5a0d06f213b5eb581c96e3392aeea """ See the full comment at https://github.com/freeipa/freeipa/pull/3#issuecomment-243344321 -- Manage your subs

[Freeipa-devel] [freeipa PR#3] User add fix #6199 (+pushed)

2016-08-29 Thread jcholast
mbasti-rh's pull request #3: "User add fix #6199" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/3 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http:

[Freeipa-devel] [freeipa PR#37] cert: add missing param values to cert-find output (opened)

2016-08-29 Thread jcholast
jcholast's pull request #37: "cert: add missing param values to cert-find output" was opened PR body: """ Add back `serial_number_hex` and `revoked` param values to cert-find output accidentally removed in commit c718ef058847bb39e78236e8af0ad69ac961bbcf. https://fedorahosted.org/freeipa/ticket/6

[Freeipa-devel] [freeipa PR#25] Added install check before executing ipa-* command (comment)

2016-08-30 Thread jcholast
jcholast commented on a pull request """ @tomaskrizek: none of them except `ipa trust-find` fail with "cannot connect to 'http://localhost:/ipa/json'", so I would say only `ipa trust-find` needs to be fixed. """ See the full comm

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (synchronize)

2016-08-30 Thread jcholast
jcholast's pull request #20: "cert: include CA name in cert command output" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/20 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/20/head:pr20 g

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (synchronize)

2016-08-31 Thread jcholast
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/34 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/34/head:pr34 g

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (comment)

2016-08-31 Thread jcholast
jcholast commented on a pull request """ I have decided to instead copy & paste the code, as it exists solely for the purpose of supporting old servers, so it should not get any additional improvements in the future. """ See the full comment at https://

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (synchronize)

2016-08-31 Thread jcholast
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/34 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/34/head:pr34 g

[Freeipa-devel] [freeipa PR#41] Postpone enabling LDAPS in replica promotion (comment)

2016-08-31 Thread jcholast
jcholast commented on a pull request """ However, I don't think this should block the release of 4.4.1, so I would just revert 89de60c5d8ba64d619101a7498b8c4469b6e50ae and keep the ticket open. """ See the full comment at https://github.com/freeipa/fre

[Freeipa-devel] [freeipa PR#41] Postpone enabling LDAPS in replica promotion (comment)

2016-08-31 Thread jcholast
jcholast commented on a pull request """ `ipa-replica-install` fails with: ``` Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/ipaserver/install/service.py", line 448, in start_creation run_step(full_msg, method) File "/usr/lib/pyt

[Freeipa-devel] [freeipa PR#44] rpcserver: fix crash in XML-RPC system commands (opened)

2016-09-01 Thread jcholast
jcholast's pull request #44: "rpcserver: fix crash in XML-RPC system commands" was opened PR body: """ Fix an AttributeError in XML-RPC methodSignature and methodHelp commands caused by incorrect mangled name usage. https://fedorahosted.org/freeipa/ticket/6217 """ See the full pull-request at h

[Freeipa-devel] [freeipa PR#45] custodia: force reconnect before retrieving CA certs from LDAP (opened)

2016-09-01 Thread jcholast
jcholast's pull request #45: "custodia: force reconnect before retrieving CA certs from LDAP" was opened PR body: """ Force reconnect to LDAP as DS might have been restarted after the connection was opened, rendering the connection invalid. This fixes a crash in ipa-replica-install with --setup-

[Freeipa-devel] [freeipa PR#47] schema cache: Store and check info for pre-schema servers (-ack)

2016-09-05 Thread jcholast
dkupka's pull request #47: "schema cache: Store and check info for pre-schema servers" label *ack* has been removed See the full pull-request at https://github.com/freeipa/freeipa/pull/47 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/free

[Freeipa-devel] [freeipa PR#47] schema cache: Store and check info for pre-schema servers (comment)

2016-09-05 Thread jcholast
jcholast commented on a pull request """ NACK on the while loop which could loop infinitely. """ See the full comment at https://github.com/freeipa/freeipa/pull/47#issuecomment-244690568 -- Manage your subscription for the Freeipa-devel mailing list: https://w

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (synchronize)

2016-09-05 Thread jcholast
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/34 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/34/head:pr34 g

[Freeipa-devel] [freeipa PR#54] cli: use full name when executing a command (opened)

2016-09-05 Thread jcholast
jcholast's pull request #54: "cli: use full name when executing a command" was opened PR body: """ Fixes the CLI not to always call the default version of a command even when the version was explicitly specified. https://fedorahosted.org/freeipa/ticket/6279 """ See the full pull-request at http

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (synchronize)

2016-09-05 Thread jcholast
jcholast's pull request #34: " dns: prompt for missing record parts in CLI" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/34 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/34/head:pr34 g

[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)

2016-09-05 Thread jcholast
jcholast commented on a pull request """ NACK, see my inline comments above. """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-244858726 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/

[Freeipa-devel] [freeipa PR#47] schema cache: Store and check info for pre-schema servers (+pushed)

2016-09-06 Thread jcholast
dkupka's pull request #47: "schema cache: Store and check info for pre-schema servers" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/47 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/fre

[Freeipa-devel] [freeipa PR#47] schema cache: Store and check info for pre-schema servers (closed)

2016-09-06 Thread jcholast
dkupka's pull request #47: "schema cache: Store and check info for pre-schema servers" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/47 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/47/head:

[Freeipa-devel] [freeipa PR#47] schema cache: Store and check info for pre-schema servers (comment)

2016-09-06 Thread jcholast
jcholast commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ec2401917456d6f643532c0d0218c9e75172c2d8 ipa-4-4: https://fedorahosted.org/freeipa/changeset/2be232f67074ef052debb91962dbc8acd09d45bd """ See the full comment

[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)

2016-09-06 Thread jcholast
jcholast commented on a pull request """ More comments inline. """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-244967015 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listin

[Freeipa-devel] [freeipa PR#64] cert: fix cert-find --certificate when the cert is not in LDAP (opened)

2016-09-06 Thread jcholast
jcholast's pull request #64: "cert: fix cert-find --certificate when the cert is not in LDAP" was opened PR body: """ Always return the cert specified in --certificate in cert-find result, even when the cert is not found in LDAP. https://fedorahosted.org/freeipa/ticket/6304 """ See the full pul

[Freeipa-devel] [freeipa PR#10] Client-side CSR autogeneration (comment)

2016-09-14 Thread jcholast
jcholast commented on a pull request """ In addition to my inline comments above: 1. "Certificate mapping" does not really evoke "certificate request templating" to me, and is also used in the context of mapping identities to certificates. Could we use a mo

[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)

2016-09-15 Thread jcholast
jcholast commented on a pull request """ Functional ACK, but please don't use newlines in exception messages. If you want the original error on a separate line, you can use the logger to log it, but I think it would be preferable to use this format: ``` Peer's certific

[Freeipa-devel] [freeipa PR#87] dns: re-introduce --raw in dnsrecord-del (opened)

2016-09-15 Thread jcholast
jcholast's pull request #87: "dns: re-introduce --raw in dnsrecord-del" was opened PR body: """ The flag was removed in commit ff52c25ae299abba8bed653fe324951979a41293 because it is unused. Add it back for compatibility with old clients. https://fedorahosted.org/freeipa/ticket/5644 """ See the

[Freeipa-devel] [freeipa PR#88] test_plugable: update the rest of test_init (opened)

2016-09-15 Thread jcholast
jcholast's pull request #88: "test_plugable: update the rest of test_init" was opened PR body: """ In commit ed4c2d9252a995d01dc098e5b761ded8cd9373d8, changes to the Plugin class were made, but the test was updated only partially. Update the rest to fix the failing test. https://fedorahosted.or

[Freeipa-devel] [freeipa PR#89] client: remove hard dependency on pam_krb5 (opened)

2016-09-15 Thread jcholast
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was opened PR body: """ If ipa-client-install is executed with --no-sssd, check if pam_krb5 is available before proceeding with the install. https://fedorahosted.org/freeipa/ticket/5557 """ See the full pull-request at ht

[Freeipa-devel] [freeipa PR#89] client: remove hard dependency on pam_krb5 (synchronize)

2016-09-15 Thread jcholast
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/89 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/89/head:pr89 git

[Freeipa-devel] [freeipa PR#50][+ack] Add cert checks in ipa-server-certinstall

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/50 Title: #50: Add cert checks in ipa-server-certinstall Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#50][+pushed] Add cert checks in ipa-server-certinstall

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/50 Title: #50: Add cert checks in ipa-server-certinstall Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#50][comment] Add cert checks in ipa-server-certinstall

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/50 Title: #50: Add cert checks in ipa-server-certinstall jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/0c4a91348a57ee941db94b31f59952eb1fcd4565 """ See the full comment

[Freeipa-devel] [freeipa PR#50][closed] Add cert checks in ipa-server-certinstall

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/50 Author: flo-renaud Title: #50: Add cert checks in ipa-server-certinstall Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/50/head:pr50 git checkout pr50 -- Manage y

[Freeipa-devel] [freeipa PR#89][+pushed] client: remove hard dependency on pam_krb5

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/89 Title: #89: client: remove hard dependency on pam_krb5 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribu

[Freeipa-devel] [freeipa PR#89][closed] client: remove hard dependency on pam_krb5

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/89 Author: jcholast Title: #89: client: remove hard dependency on pam_krb5 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/89/head:pr89 git checkout pr89 -- Manage

[Freeipa-devel] [freeipa PR#89][comment] client: remove hard dependency on pam_krb5

2016-09-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/89 Title: #89: client: remove hard dependency on pam_krb5 jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/984ae3858d8fb25d30b886bb953df1b06ab34ec7 ipa-4-4: https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#10][comment] Client-side CSR autogeneration

2016-09-19 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/10 Title: #10: Client-side CSR autogeneration jcholast commented: """ 1. I'm afraid `certrequest` (actually `certreq`) is already taken. What about `csrgen`? 2. I would be perfectly happy with `ipaclient.`. 3. OK. Logistical stu

[Freeipa-devel] [freeipa PR#88][synchronized] test_plugable: update the rest of test_init

2016-09-19 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/88 Author: jcholast Title: #88: test_plugable: update the rest of test_init Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/88/head:pr88 git checkout pr88 From

[Freeipa-devel] [freeipa PR#84][comment] Fix update_from_dict function testing

2016-09-21 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/84 Title: #84: Fix update_from_dict function testing jcholast commented: """ @abbra: > Update plugins are higher level of abstraction. They use > ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and

[Freeipa-devel] [freeipa PR#117][-ack] Make ipa-replica-install run in interactive mode

2016-10-03 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Con

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-03 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/117 Title: #117: Make ipa-replica-install run in interactive mode jcholast commented: """ NACK, see inline comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/117#issuecomment-251044036 -- Ma

[Freeipa-devel] [freeipa PR#10][comment] Client-side CSR autogeneration

2016-10-09 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/10 Title: #10: Client-side CSR autogeneration jcholast commented: """ @LiptonB, I have added some inline comments. Also, have you seen [my latest reply in the design thread](https://www.redhat.com/archives/freeipa-devel/2016-Septembe

[Freeipa-devel] [freeipa PR#142][comment] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling

2016-10-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/142 Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling jcholast commented: """ NACK, see inline comments. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#142][-ack] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling

2016-10-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/142 Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#156][opened] cert: add revocation reason back to cert-find output

2016-10-12 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/156 Author: jcholast Title: #156: cert: add revocation reason back to cert-find output Action: opened PR body: """ In commit c718ef058847bb39e78236e8af0ad69ac961bbcf some param values were accidentally removed from cert-find out

[Freeipa-devel] [freeipa PR#159][opened] spec file: clean up BuildRequires

2016-10-12 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: opened PR body: """ Add missing cyrus-sasl-devel, python-cffi, python-custodia, python-nose, python-paste, python-sssdconfig and systemd-python BuildRe

[Freeipa-devel] [freeipa PR#156][comment] cert: add revocation reason back to cert-find output

2016-10-12 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output jcholast commented: """ It's intentional. With `--raw`, only data retrieved directly from the backend should be returned. `cert-show` does the same. I should

[Freeipa-devel] [freeipa PR#156][synchronized] cert: add revocation reason back to cert-find output

2016-10-12 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/156 Author: jcholast Title: #156: cert: add revocation reason back to cert-find output Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/156/head:pr156 git

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires

2016-10-13 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires jcholast commented: """ @pspacek, @mbasti-rh, fixed. """ See the full comment at https://github.com/freeipa/freeipa/pull/159#issuecomment-253491282 -- Manage you

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-10-17 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir jcholast commented: """ NACK, see inline comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/143#issuecomment-254226440 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#163][comment] Do not create Object Signing certificate

2016-10-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/163 Title: #163: Do not create Object Signing certificate jcholast commented: """ LGTM. """ See the full comment at https://github.com/freeipa/freeipa/pull/163#issuecomment-254430550 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#157][comment] git: Add commit template

2016-10-18 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/157 Title: #157: git: Add commit template jcholast commented: """ Not everyone uses vim. I'd like the comments visually close to the relevant commit message part, otherwise the visual guides in them do not seem very useful to

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-20 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#132][comment] Port all setup.py files to setuptools

2016-10-20 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/132 Title: #132: Port all setup.py files to setuptools jcholast commented: """ LGTM, but shouldn't we also move `/setup.py` to `/ipaserver/setup.py`? """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#177][comment] Add options to write lightweight CA cert or chain to file

2016-10-23 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/177 Title: #177: Add options to write lightweight CA cert or chain to file jcholast commented: """ The original review thread is available at: https://www.redhat.com/archives/freeipa-devel/2016-October/msg00578.html ""&

[Freeipa-devel] [freeipa PR#159][synchronized] spec file: clean up BuildRequires

2016-10-24 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/159 Author: jcholast Title: #159: spec file: clean up BuildRequires Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/159/head:pr159 git checkout pr159 From

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-10-24 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ This seems rather unnecessary to me, as you can do: ``` $ ipa -e confdir=/path/to/confdir command ``` In case there is some sh

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-10-25 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context jcholast commented: """ In custom Python scripts, you have to call `api.bootstrap()`, so you may as well call `api.bootstrap(confdir='/path/to

[Freeipa-devel] [freeipa PR#50][comment] Add cert checks in ipa-server-certinstall

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/50 Title: #50: Add cert checks in ipa-server-certinstall jcholast commented: """ ipa-4-4: https://fedorahosted.org/freeipa/changeset/f32e68349b291288c154dcf4dd17002a966195c5 """ See the full comment at https://gith

[Freeipa-devel] [freeipa PR#198][+ack] Fix missing file that fails DL1 replica installation

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [freeipa PR#198][comment] Fix missing file that fails DL1 replica installation

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation jcholast commented: """ Please rebase to ipa-4-4. """ See the full comment at https://github.com/freeipa/freeipa/pull/198#issuecomment-257500714 --

[Freeipa-devel] [freeipa PR#198][comment] Fix missing file that fails DL1 replica installation

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/842bf3d09f4b2de7d4b52005ac970594345455e0 """ See the full

[Freeipa-devel] [freeipa PR#198][+pushed] Fix missing file that fails DL1 replica installation

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Title: #198: Fix missing file that fails DL1 replica installation Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/p

[Freeipa-devel] [freeipa PR#198][closed] Fix missing file that fails DL1 replica installation

2016-10-31 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/198 Author: stlaz Title: #198: Fix missing file that fails DL1 replica installation Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/198/head:pr198 git checkout pr198 -

[Freeipa-devel] [freeipa PR#199][+ack] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#199][+pushed] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.fre

[Freeipa-devel] [freeipa PR#199][closed] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Author: stlaz Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/199/head:pr199 git checko

[Freeipa-devel] [freeipa PR#199][comment] [ipa-4-4] Fix missing file that fails DL1 replica installation

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/199 Title: #199: [ipa-4-4] Fix missing file that fails DL1 replica installation jcholast commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/19a32da65f792bc8f054c14edfcf704876e0257e """

[Freeipa-devel] [freeipa PR#201][opened] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Author: jcholast Title: #201: spec file: bump minimal required version of 389-ds-base Action: opened PR body: """ Require 389-ds-base >= 1.3.5.14 for: https://fedorahosted.org/389/ticket/48992 https://fedorahosted.org/f

[Freeipa-devel] [freeipa PR#201][+pushed] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.or

[Freeipa-devel] [freeipa PR#201][comment] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Title: #201: spec file: bump minimal required version of 389-ds-base jcholast commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f12abfb852dfb1a7759928b05defde68d5d7a3df ipa-4-4: https://fedorahos

[Freeipa-devel] [freeipa PR#201][closed] spec file: bump minimal required version of 389-ds-base

2016-11-01 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/201 Author: jcholast Title: #201: spec file: bump minimal required version of 389-ds-base Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/201/head:pr201 git checkout

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-02 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ In addition to my inline comments: * use component name ("ipaldap", "ldap2", "install", ...) rather than "lda refactor

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-03 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ @mbasti: YDUC, that would break `ipa config`-defined limits. """ See the full comment at https://github.com/freeipa/freeipa/pull/145#iss

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ @mbasti: Because if the argument default values were constants as you suggested, they would take precedence over `ipa config` limits. ""&

[Freeipa-devel] [freeipa PR#187][comment] Register entry points of Custodia plugins

2016-11-09 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/187 Title: #187: Register entry points of Custodia plugins jcholast commented: """ Just curious, why is the store class called `iSecStore` and not `IPASecStore` or something similar to make it apparent that it comes from IPA? &q

[Freeipa-devel] [freeipa PR#182][-ack] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-10 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/

  1   2   >