Quoting Kuogee Hsieh (2020-10-20 09:59:59)
> No need to check LINK_STATuS_UPDATED bit before
LINK_STATUS_UPDATED?
> return 6 bytes of link status during link training.
Why?
> This patch also fix phy compliance test link rate
> conversion error.
How?
>
> Signed-off-by: Kuogee Hsieh
> ---
An
ning.
>
> Fixes: af776a3e1c30 ("drm/msm/dpu: add SM8250 to hw catalog")
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Subject has a typo in "training".
Quoting Kuogee Hsieh (2020-10-30 16:23:24)
> Some dongles, such as Apple, required link training done at irq_hpd
s/required/require/
> request instead of plugin request. This patch promote irq_hpd hanlder
s/hanlder/handler/
> to handle link training and setup
Quoting Kuogee Hsieh (2020-10-30 16:23:10)
> Some dongle will not clear LINK_STATUS_UPDATED bit after
> DPCD read which cause link training failed. This patch
$ git grep 'this patch' -- Documentation/process/submitting-patches.rst
> just read 6 bytes of DPCD link status from sink and return
> wit
Quoting Kuogee Hsieh (2020-10-30 16:22:53)
> DP compo phy have to be enable to start link training. When
> link training failed phy need to be disabled so that next
> link trainng can be proceed smoothly at next plug in. This
s/trainng/training/
> patch de initialize mainlink to disable phy if li
Quoting Abhinav Kumar (2020-10-29 13:55:09)
> For sinks that do not support audio, there is no need to notify
> audio subsystem of the connection event.
>
> This will make sure that audio routes only to the primary display
> when connected to such sinks.
>
Does this need a Fixes tag? Or it's jus
Quoting abhin...@codeaurora.org (2020-11-02 14:43:33)
> Hi Stephen
>
> Thanks for the review.
>
> On 2020-11-02 13:19, Stephen Boyd wrote:
> > Quoting Abhinav Kumar (2020-10-29 13:55:09)
> >> For sinks that do not support audio, there is no need to notify
> >
Quoting Kuogee Hsieh (2020-11-03 12:49:02)
> Some dongles require link training done at irq_hpd request instead
> of plugin request. This patch promote irq_hpd handler to handle link
> training and setup hpd_state correctly.
>
> Fixes: fdaf9a5e3c15 (drm/msm/dp: fixes wrong connection state caused
Quoting Tian Tao (2020-11-10 23:57:56)
> linux/rational.h is included more than once, Remove the one that isn't
> necessary.
>
> Signed-off-by: Tian Tao
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.f
Quoting Kuogee Hsieh (2020-11-13 14:26:39)
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 27e7e27b8b90..4e84f500b721 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -279,13 +279,25 @@ static voi
I don't know what this debug print is for but it is super chatty,
throwing 8 lines of debug prints in the logs every time we update a
plane. It looks like it has no value. Let's nuke it so we can get
better logs.
Cc: Sean Paul
Cc: Abhinav Kumar
Signed-off-by: Stephen Boyd
---
drive
Quoting abhin...@codeaurora.org (2020-11-17 12:34:56)
> On 2020-11-17 09:26, Stephen Boyd wrote:
> > I don't know what this debug print is for but it is super chatty,
> > throwing 8 lines of debug prints in the logs every time we update a
> > plane. It looks like it has
in V2:
> -- add dp_display_handle_port_ststus_changed()
> -- fix kernel test robot complaint
>
> Reported-by: kernel test robot
> Fixes: 26b8d66a399e ("drm/msm/dp: promote irq_hpd handle to handle link
> training correctly")
> Signed-off-by
Quoting Kuogee Hsieh (2021-01-07 12:30:25)
> There is HPD unplug interrupts missed at scenario of an irq_hpd
> followed by unplug interrupts with around 10 ms in between.
> Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts,
> irq_hpd handler should not issues either aux or sw res
Quoting Kuogee Hsieh (2021-01-07 12:30:24)
> irq_hpd event can only be executed at connected state. Therefore
> irq_hpd event should be postponed if it happened at connection
> pending state. This patch also make sure both link rate and lane
Why does it happen at connection pending state?
> are v
Quoting khs...@codeaurora.org (2021-01-13 09:44:24)
> On 2021-01-11 11:55, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
> >> irq_hpd event can only be executed at connected state. Therefore
> >> irq_hpd event should be postponed if it happened at co
Quoting khs...@codeaurora.org (2021-01-13 09:44:24)
> On 2021-01-11 11:55, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
> >> irq_hpd event can only be executed at connected state. Therefore
> >> irq_hpd event should be postponed if it happened at co
Quoting khs...@codeaurora.org (2021-01-13 09:48:25)
> On 2021-01-11 11:54, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-07 12:30:25)
> >> There is HPD unplug interrupts missed at scenario of an irq_hpd
> >> followed by unplug interrupts with around 10 ms
Quoting Kuogee Hsieh (2021-01-13 10:59:58)
> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
> Therefore irq_hpd handler should not issues either aux or sw reset
> to avoid following unplug interrupt be cleared accidentally.
>
> Kuogee Hsieh (2):
> drm/msm/dp: return fail when bo
Quoting khs...@codeaurora.org (2021-01-13 15:44:32)
> On 2021-01-13 12:22, Stephen Boyd wrote:
> > Quoting khs...@codeaurora.org (2021-01-13 09:44:24)
> >> On 2021-01-11 11:55, Stephen Boyd wrote:
> >> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
> >> &
Quoting khs...@codeaurora.org (2021-01-13 15:52:37)
> On 2021-01-13 12:25, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-13 10:59:58)
> >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
> >> Therefore irq_hpd handler should not issues either au
layer updates")
Cc: Krishna Manikandan
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_kms.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h
index d8151a89e163..4735251a394d 100644
--- a/drivers
layer updates")
Cc: Krishna Manikandan
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_kms.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h
index d8151a89e163..4735251a394d 100644
--- a/drivers
layer updates")
Cc: Krishna Manikandan
Signed-off-by: Stephen Boyd
---
Changes from v1:
* Fixed typo in commit text
drivers/gpu/drm/msm/msm_kms.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h
index d
Quoting Bernard Zhao (2021-02-02 04:32:03)
> remove unneeded variable: "rc".
>
> Signed-off-by: Bernard Zhao
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedeskto
Quoting Rob Clark (2021-02-03 09:29:09)
> On Wed, Feb 3, 2021 at 2:10 AM Daniel Vetter wrote:
> >
> > On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote:
> > > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote:
> > > >
> > > > On Mon, Jan
Quoting Xu Wang (2021-01-29 01:44:16)
> fix semicolon.cocci warnings:
> drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing
after irq_hpd
> handler")
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
dreno@lists.freedesktop.org
Cc: Lee Jones
Fixes: cc9014bf63a4 ("drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap")
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c
Quoting Joe Perches (2021-02-06 21:06:54)
> On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote:
> > A missing semicolon here causes my external display to stop working.
> > Indeed, missing the semicolon on the return statement leads to
> > dp_panel_update_tu_timings() not
ishna Manikandan
Suggested-by: Daniel Vetter
Fixes: b3d91800d9ac ("drm/msm: Fix race condition in msm driver with async
layer updates")
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_atomic.c | 7 +--
drivers/gpu/drm/msm/msm_kms.h| 8 ++--
2 files changed, 7 insertions(
Quoting Kuogee Hsieh (2021-02-17 08:58:42)
> Add hbr3_hbr2 voltage and pre-emphasis swing table to support
> HBR3 link rate
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 4
> drivers/phy/qualcomm/phy-qcom-qmp.c | 24 ++--
This spans to su
Quoting Kuogee Hsieh (2021-02-17 15:09:57)
> Drop limit link rate at HBR2 to support link rate
> upto HBR3.
>
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freede
Quoting Kuogee Hsieh (2021-02-17 15:09:57)
> Drop limit link rate at HBR2 to support link rate
> upto HBR3.
>
> Signed-off-by: Kuogee Hsieh
> ---
Should also say
Tested-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.
Quoting Kuogee Hsieh (2021-02-18 12:55:04)
> Allow supported link rate to be limited to the value specified at
> dtsi. If it is not specified, then link rate is derived from dpcd
> directly. Below are examples,
> link-rate = <162000> for max link rate limited at 1.62G
> link-rate = <27> for max
Quoting khs...@codeaurora.org (2021-02-19 08:39:38)
> On 2021-02-18 15:02, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-02-18 12:55:04)
> >> Allow supported link rate to be limited to the value specified at
> >> dtsi. If it is not specified, then link rate is deri
e reliable.
Cc: Kuogee Hsieh
Fixes: 9fc418430c65 ("drm/msm/dp: unplug interrupt missed after irq_hpd
handler")
Signed-off-by: Stephen Boyd
---
Noticed by code inspection and based on bug reports where the aux channel
stops working once the commit this is fixing is applied.
drivers/gp
Maybe subject could be "Ignore debugfs failures, fix indentation, fix
logical error"?
Quoting Abhinav Kumar (2021-03-04 17:31:52)
> Fix the warnings reported by kbot across MSM DP driver.
Which warnings? Can you include them? Or at least list the three things
that are being fixed in this patch?
Quoting Bhaskar Chowdhury (2021-03-17 23:26:50)
> s/modueles/modules/ two different places
>
> Signed-off-by: Bhaskar Chowdhury
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedeskt
Quoting Dmitry Baryshkov (2021-03-18 13:05:44)
> if GPU components have failed to bind, shutdown callback would fail with
> the following backtrace. Add safeguard check to stop that oops from
> happening and allow the board to reboot.
[...]
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu
Quoting Rob Clark (2021-03-24 20:09:37)
> On Wed, Mar 24, 2021 at 6:49 PM Stephen Boyd wrote:
> >
> > Quoting Dmitry Baryshkov (2021-03-18 13:05:44)
> > > if GPU components have failed to bind, shutdown callback would fail with
> > > the following backtrace. Add
ort for display
platform_driver")
Cc: Dmitry Baryshkov
Cc: Fabio Estevam
Cc: Krishna Manikandan
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index a5c6b8c23336..19690
rm/msm/dp/dp_power.c:203 dp_power_clk_enable()
> warn: inconsistent indenting
>
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Abhinav Kumar
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing
)
>
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Abhinav Kumar
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
TR_ERR'
>
> Debugfs functions are not supposed to be checked in the normal
> case so delete this code. Also it silences the above Smatch
> warnings that we're checking for NULL when these functions only
> return error pointers.
>
> Reported-by: kernel test robot
&g
new compatible in the condition.
>
> Signed-off-by: Jonathan Marek
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
This will conflict with the yaml changes to this file that are also in
flight.
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Dmitry Baryshkov (2021-03-29 05:00:51)
> From: Jonathan Marek
>
> - Use sm8250 compatibles instead of sdm845 compatibles
>
Does it need the " - " prefix?
> Signed-off-by: Jonathan Marek
> Signed-off-by: Dmitry Baryshkov
>
Quoting Dmitry Baryshkov (2021-03-27 04:02:42)
> Add devm_clk_hw_register_mux() - devres-managed version of
> clk_hw_register_mux().
>
> Signed-off-by: Dmitry Baryshkov
> Reviewed-by: Abhinav Kumar
> ---
Acked-by: Stephen Boyd
___
Quoting Dmitry Baryshkov (2021-03-27 04:02:43)
> Add devm_clk_hw_register_divider() - devres version of
> clk_hw_register_divider().
>
> Signed-off-by: Dmitry Baryshkov
> Reviewed-by: Abhinav Kumar
> ---
Acked-by: Stephen Boyd
___
Subject should say register instead of registe
Quoting Dmitry Baryshkov (2021-03-27 04:02:52)
> Use devres-enabled version of clock registration functions. This lets us
> remove dsi_pll destroy callbacks completely.
>
> Signed-off-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/dsi/dsi.h
Would make it devm_of_clk_add_hw_provider() in the subject
Quoting Dmitry Baryshkov (2021-03-27 04:02:53)
> Use devm_of_clk_add_hw_provider() to register provided clocks. This
> allows dropping the remove function alltogether.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-b
since commit 627dc55c273dab308303a5217bd3e767d7083ddb:
>
> drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume
> (2021-03-22 18:52:34 -0700)
>
> are available in the Git repository at:
>
> https://git.li
Trimming Cc list way down, sorry if that's too much.
Quoting Maxime Ripard (2021-02-19 04:00:30)
> Many drivers reference the plane->state pointer in order to get the
> current plane state in their atomic_update or atomic_disable hooks,
> which would be the new plane state in the global atomic sta
Quoting Maxime Ripard (2021-03-30 08:35:27)
> Hi Stephen,
>
> On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote:
> > Trimming Cc list way down, sorry if that's too much.
> >
> > Quoting Maxime Ripard (2021-02-19 04:00:30)
> > > Many drivers re
Quoting Bernard Zhao (2021-04-07 06:06:21)
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return
> "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard
Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> devm_clk_hw_register_fixed_factor_release(), the release function for
> the devm_clk_hw_register_fixed_factor(), calls
> clk_hw_unregister_fixed_factor(), which will kfree() the clock. However
> after that the devres functions will also kfree the all
Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> devm_clk_hw_register_fixed_factor_release(), the release function for
> the devm_clk_hw_register_fixed_factor(), calls
> clk_hw_unregister_fixed_factor(), which will kfree() the clock. However
> after that the devres functions will also kfree the all
Quoting Dmitry Baryshkov (2021-04-07 15:57:01)
> On Thu, 8 Apr 2021 at 01:41, Stephen Boyd wrote:
> >
> > Quoting Dmitry Baryshkov (2021-04-06 16:06:06)
> > > devm_clk_hw_register_fixed_factor_release(), the release function for
> > > the devm_clk_
Quoting Kuogee Hsieh (2021-04-12 10:02:51)
> At pm_resume check link sisnk_count before update is_connected status
s/sisnk_count/sink_count/
> base on HPD real time link status. Also print out error message only
> when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT
> happen.
ned-off-by: Kuogee Hsieh
> ---
Also please include
Reported-by: Stephen Boyd
in the next post.
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Kuogee Hsieh (2021-04-12 10:03:23)
> At dp_display_disable(), do not re initialize audio_comp if
> hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid
> race condition which cause 5 second timeout expired.
More details please.
> Also
> add abort mechanism to reduce time spinning at
only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoting Kuogee Hsieh (2021-04-13 16:11:30)
> At dongle unplug, dp initializes audio_comp followed by sending disconnect
> event notification to audio and to make sure audio had shutdown completely
> by wait for audio completion notification at display_disable(). This patch
Is this dp_display_disab
Quoting Kuogee Hsieh (2021-04-13 16:11:44)
> Make sure main link is in connection state before start aux
> read/write operation to avoid unnecessary long delay due to
> main link had been unplugged.
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_aux.c | 5 +
> drivers/gp
only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Reviewed-by: Stephen Boyd
> Tested-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
Can you please thread your emailed patches? I see them all as toplevel
messages in my inbox :(
> drivers/gpu/drm/msm
Quoting Kuogee Hsieh (2021-04-14 14:02:50)
> Initialize audio_comp when audio starts and wait for audio_comp at
> dp_display_disable(). This will take care of both dongle unplugged
> and display off (suspend) cases.
>
> Changes in v2:
> -- add dp_display_start_audio()
>
> Signed-off-by: Kuogee Hs
Quoting khs...@codeaurora.org (2021-04-15 10:37:29)
> On 2021-04-14 14:09, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-04-13 16:11:44)
> >> Make sure main link is in connection state before start aux
> >> read/write operation to avoid unnecessary long delay due
Quoting khs...@codeaurora.org (2021-04-15 15:02:40)
> On 2021-04-15 13:06, Stephen Boyd wrote:
> >
> > Is it really necessary to have this patch at all? I think there are
> > bigger problems with suspend/resume of the DP driver in relation to the
> > kthread stopping.
Quoting Kuogee Hsieh (2021-04-16 13:27:57)
> Some dongle may generate more than one irq_hpd events in a short period of
> time. This patch will treat those irq_hpd events as single one and service
> only one irq_hpd event.
Why is it bad to get multiple irq_hpd events in a short period of time?
Ple
Quoting Kuogee Hsieh (2021-04-16 10:38:51)
> Maybe when the cable is disconnected the DP phy should be shutdown and
> some bit in the phy could effectively "cut off" the aux channel and then
> NAKs would start coming through here in the DP controller I/O register
> space. This patch have DP aux cha
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
> On 2021-04-21 10:26, khs...@codeaurora.org wrote:
> >>
> >>> +
> >>> mutex_unlock(&dp->event_mutex);
> >>>
> >>> return 0;
> >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp,
> >>> struct drm_encoder *enco
Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
> On 2021-04-27 17:00, Stephen Boyd wrote:
> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
> >> On 2021-04-21 10:26, khs...@codeaurora.org wrote:
> >> >>
> >> >>&g
Quoting khs...@codeaurora.org (2021-04-29 10:23:31)
> On 2021-04-29 02:26, Stephen Boyd wrote:
> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
> >> On 2021-04-27 17:00, Stephen Boyd wrote:
> >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21)
&g
80/0xa0
>[ 20.950058] el0_svc+0x20/0x30
>[ 20.953145] el0_sync_handler+0x88/0xb0
>[ 20.957014] el0_sync+0x13c/0x140
>
> The reason for the codepath seems dubious, the atomic suspend/resume
> heplers should handle the power-collapse case. If not, the CRTC's
Put these debug prints in the vblank code into the appropriate vblank
category via drm_dbg_vbl().
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2
This print is missing a newline, and doesn't really provide any value.
Drop it.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_panel.c | 1 -
1 file changed, 1 deletion(-)
cally useless.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16
2 files changed, 9 insertions(
that felt appropriate. Please review.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Stephen Boyd (6):
drm/msm: Move vblank debug prints to drm_dbg_vbl()
drm/msm: Use VERB() for extra verbose logging
drm/msm/dp: Drop malformed debug
Use the DPU_DEBUG_PLANE() helper to print the plane number instead of
open coding it.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++--
1 file
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_format
g
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/msm_fb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index d42f0665359a..90514d3179bb 100644
--- a/drivers/gpu/drm/msm/msm_fb.c
+++ b/
Quoting khs...@codeaurora.org (2021-05-03 12:23:31)
> On 2021-04-29 20:11, Stephen Boyd wrote:
> > Quoting khs...@codeaurora.org (2021-04-29 10:23:31)
> >> On 2021-04-29 02:26, Stephen Boyd wrote:
> >> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11)
> >&g
m/dp: reset dp controller only at boot up and
> pm_resume")
> Reported-by: Stephen Boyd
> Reviewed-by: Stephen Boyd
> Tested-by: Stephen Boyd
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 15 ---
> 1 file changed, 8
>
> Changes in v3:
> -- restore dp_display_handle_plugged_change() at dp_hpd_unplug_handle().
>
> Changes in v4:
> -- none
>
> Signed-off-by: Kuogee Hsieh
> ---
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
Fixes: c703d5789590 ("drm/msm/
V4:
> -- split this patch as stand alone patch
>
> Signed-off-by: Kuogee Hsieh
Can this patch come before the one previously? And then some fixes tag
be added? Otherwise looks good to me.
Reviewed-by: Stephen Boyd
Tested-by: Stephen Boyd
__
Quoting Kuogee Hsieh (2021-04-21 16:37:37)
> Maybe when the cable is disconnected the DP phy should be shutdown and
> some bit in the phy could effectively "cut off" the aux channel and then
> NAKs would start coming through here in the DP controller I/O register
> space. This patch have DP aux cha
at the drm core can figure out that things are just not going
well. The important thing is that we're now returning -ETIMEDOUT when
the message times out and nacks for bad addresses.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Signed-
vi...@codeaurora.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_aux.c | 22 --
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +-
3 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/dr
e
into the logs.
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Kuogee Hsieh
Cc: aravi...@codeaurora.org
Cc: Sean Paul
Stephen Boyd (3):
drm/msm/dp: Simplify aux irq handling code
drm/msm/dp: Shrink locking area of dp_aux_transfer()
drm/msm/dp: Handle aux timeouts, nacks, defers
drivers
ra.org
Cc: Sean Paul
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_aux.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c
index 91188466cece..b49810396513 100644
--- a/drivers/gpu
Quoting Zhen Lei (2021-05-07 19:42:54)
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
> Reported-by: Hulk Robot
> Signed-off-by: Zhen Lei
> ---
> drivers
Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04)
>
>
> On 2021/5/8 14:09, Stephen Boyd wrote:
> > Quoting Zhen Lei (2021-05-07 19:42:54)
> >> Fix to return a negative error code from the error handling case instead
> >> of 0, as done elsewhere in this functi
quot; to make
> the code clearer.
>
> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
> Reported-by: Hulk Robot
> Signed-off-by: Zhen Lei
> ---
Reviewed-by: Stephen Boyd
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
Russell King
Cc: Saravana Kannan
[1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org
Stephen Boyd (7):
component: Drop 'dev' argument to component_match_realloc()
component: Rename 'dev' to 'parent'
component: Introduce struct aggregate_devic
This argument isn't used. Drop it.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/bas
places that 'dev'
is modified.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 89 +++-
1 file changed, 42 insertions(+), 47 deleti
This allows aggregate driver writers to use the device passed to their
probe/remove/shutdown functions properly instead of treating it as an
opaque pointer.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
--
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/component.c | 249 --
include/linux/component.h | 2 +-
2 files changed, 134 insertions(+), 117 deletio
We left this in place to ease the code diff, but now we can remove it
because the aggregate device parent pointer is the same.
Cc: Daniel Vetter
Cc: "Rafael J. Wysocki"
Cc: Rob Clark
Cc: Russell King
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
drivers/base/compon
1 - 100 of 1102 matches
Mail list logo
