[Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-01 Thread Rob Clark
: Douglas Anderson Signed-off-by: Rob Clark --- This is an alternative/replacement for [1]. What it lacks in elegance it makes up for in practicality ;-) [1] https://patchwork.freedesktop.org/patch/264930/ drivers/of/device.c | 22 ++ 1 file changed, 22 insertions(+) diff

Re: [Freedreno] [PATCH v2 3/9] drm/msm/mdp4: add lcdc-align-lsb flag to control lane alignment

2018-12-02 Thread Rob Clark
On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > Controls which of the 8 lanes are used for 6 bit color. > > Signed-off-by: Jonathan Marek > --- > .../gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 22 --- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/

Re: [Freedreno] [PATCH v2 5/9] drm/msm: add headless gpu device (for imx5)

2018-12-02 Thread Rob Clark
On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > This patch allows using drm/msm without qcom display hardware. This is > especially useful for iMX5 hardware, which has a a2xx GPU but uses the > imx-drm driver for display. > > Signed-off-by: Jonathan Marek > --- > v2: added commit messag

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-03 Thread Rob Clark
On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-03 Thread Rob Clark
On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [Freedreno] [PATCH] drm/msm: Only add available components

2018-12-04 Thread Rob Clark
glas Anderson yeah, that seems like a reasonable thing to do Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/msm/msm_drv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > inde

Re: [Freedreno] [RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

2018-12-04 Thread Rob Clark
On Tue, Dec 4, 2018 at 11:56 AM Robert Foss wrote: > > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > Reviewed-by: Chris Wilson > Cc

Re: [Freedreno] [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-12-07 Thread Rob Clark
On Thu, Dec 6, 2018 at 8:38 PM Christoph Hellwig wrote: > > On Fri, Nov 30, 2018 at 10:46:04AM +0100, Daniel Vetter wrote: > > > Being able to dip into CMA and maybe iommu coalescing if we want to > > > get fancy is indeed the only reason for this API. If we just wanted > > > to map pages we coul

Re: [Freedreno] [PATCH] drm/msm/a6xx: Add support for an interconnect path

2018-12-07 Thread Rob Clark
it would be appropriate and/or possible to merge this > with the generic interconnect patches and with his blessing I would like to > renew that request. This should merge cleanly against tip of tree and it would > be nice to get this support in at the same time that the base patches go

Re: [Freedreno] [PATCH] drm/msm: fix arm64 build error

2018-12-10 Thread Rob Clark
On Mon, Dec 10, 2018 at 3:56 PM Arnd Bergmann wrote: > > The new a200 GPU MMU support fails to build on arm64 because > of a conflicting macro name: > > drivers/gpu/drm/msm/msm_gpummu.c:17: error: "VA_START" redefined [-Werror] > #define VA_START SZ_16M > > In file included from arch/arm64/includ

[Freedreno] [pull] drm/msm: msm-next for 4.21

2018-12-12 Thread Rob Clark
drm/msm/dpu: Clean up dpu_media_info.h static inline functions Mamta Shukla (1): drm: msm: Use DRM_DEV_* instead of dev_* Matthias Kaehlcke (1): dt-bindings: msm/dsi: Add ref clock for PHYs Rob Clark (5): drm/msm: update generated headers drm/msm/gpu: add submit flag to hint wh

Re: [Freedreno] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-18 Thread Rob Clark
On Mon, Dec 17, 2018 at 3:41 PM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g, r32f, r32i, r32ui) this results in extra mov > instructions. > > This patch uses the actu

Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: fix building without debugfs

2019-01-08 Thread Rob Clark
On Tue, Jan 8, 2019 at 9:16 AM Ioana Ciornei wrote: > > > > Subject: [PATCH 2/2] drm/msm/gpu: fix building without debugfs > > > > When debugfs is disabled, but coredump is turned on, the adreno driver > > fails to > > build: > > > > drivers/gpu/drm/msm/adreno/a3xx_gpu.c:460:4: error: 'struct msm

Re: [Freedreno] [PATCH v7 0/6] arm64: dts: Add sdm845 GPU/GMU and SMMU

2019-01-09 Thread Rob Clark
On Wed, Jan 9, 2019 at 1:20 PM Doug Anderson wrote: > > Hi Rob, > > On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse wrote: > > > > Now that more of the sdm845 bindings are headed upstream this a refresh of > > of https://patchwork.freedesktop.org/series/39308/ to add bindings and nodes > > for the

Re: [Freedreno] [PATCH v2 1/2] drm/msm: Fix A6XX support for opp-level

2019-01-16 Thread Rob Clark
s On Wed, Jan 16, 2019 at 1:46 PM Douglas Anderson wrote: > > The bindings for Qualcomm opp levels changed after being Acked but > before landing. Thus the code in the GPU driver that was relying on > the old bindings is now broken. > > Let's change the code to match the new bindings by adjustin

Re: [Freedreno] [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Rob Clark
On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse wrote: > > > > Try to get the interconnect path for the GPU and vote for the maximum > > bandwidth to support all frequencies. This is needed for performance. > > Later we will want to s

[Freedreno] [pull] drm/msm: drm-msm-fixes-2018-01-22 for 5.0

2019-01-22 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [Freedreno] [PATCH 2/2] drm/msm: Use DRM_DEV_INFO_RATELIMITED for shrinker messages

2019-01-23 Thread Rob Clark
On Mon, Jan 21, 2019 at 4:36 AM Jani Nikula wrote: > > On Fri, 18 Jan 2019, "Kristian H. Kristensen" wrote: > > Otherwise we get hard to track down "Purging: 123123 bytes" messages in > > the log. > > > > Signed-off-by: Kristian H. Kristensen > > --- > > drivers/gpu/drm/msm/msm_gem_shrinker.c |

[Freedreno] [resend pull] drm/msm: drm-msm-fixes-2019-01-24 for 5.0

2019-01-24 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [Freedreno] [RFC 0/4] freedreno: Move some compiler offset computations to NIR

2019-01-25 Thread Rob Clark
On Fri, Jan 25, 2019 at 10:48 AM Eduardo Lima Mitev wrote: > > There are a bunch of instructions emitted on ir3_compiler_nir related to > offset computations for IO opcodes (ssbo, image, etc). This small series > explores the possibility of moving these instructions to NIR, where we > have higher

Re: [Freedreno] [RFC 0/4] freedreno: Move some compiler offset computations to NIR

2019-01-28 Thread Rob Clark
On Mon, Jan 28, 2019 at 3:32 AM Eduardo Lima Mitev wrote: > > On 1/26/19 12:42 AM, Rob Clark wrote: > > On Fri, Jan 25, 2019 at 10:48 AM Eduardo Lima Mitev > > wrote: > >> > >> There are a bunch of instructions emitted on ir3_compiler_nir related to > >

Re: [Freedreno] [PATCH v2 3/5] drm: msm: Switch to use drm_gem_object reservation_object

2019-02-13 Thread Rob Clark
will also do some cache > maintenance on the GEM object. > > Cc: Rob Clark > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-arm-...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Rob Herring Acked-by:

Re: [Freedreno] [PATCH] drm/msm: fix an error code in the ioctl

2019-02-15 Thread Rob Clark
On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter wrote: > > The copy_to/from_user() functions return the number of bytes remaining > to be copied but we should return -EFAULT to the user. > > Fixes: f05c83e77460 ("drm/msm: add uapi to get/set debug name") > Signed-off-by: Dan Carpenter > --- > If I

Re: [Freedreno] [PATCH] drm/msm: fix an error code in the ioctl

2019-02-15 Thread Rob Clark
On Fri, Feb 15, 2019 at 11:01 AM Jordan Crouse wrote: > > On Thu, Feb 14, 2019 at 06:16:01PM -0500, Rob Clark wrote: > > On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter > > wrote: > > > > > > The copy_to/from_user() functions return the number of bytes remain

Re: [Freedreno] [v1] drm/msm: Remove clock and bandwidth votes in mdss pm suspend

2019-02-17 Thread Rob Clark
On Wed, Jan 23, 2019 at 6:12 AM Jayant Shekhar wrote: > > MDSS PM suspend is dependent on runtime suspend for disabling > clocks and removing bandwidth votes. In case of pm_suspend > triggered, dpm_prepare hold a refcount on power usage of device > and hence runtime suspend is never triggered duri

Re: [Freedreno] [PATCH v1 2/6] dt-bindings: drm/msm/a6xx: Add GX power-domain for GMU bindings

2019-02-17 Thread Rob Clark
On Sun, Feb 17, 2019 at 4:08 PM Rob Herring wrote: > > On Mon, Feb 4, 2019 at 10:15 AM Jordan Crouse wrote: > > > > The GMU should have two power domains defined: "cx" and "gx". "cx" is the > > actual power domain for the device and "gx" will be attached at runtime > > to manage reference countin

[Freedreno] [pull] drm/msm: msm-next for 5.1

2019-02-19 Thread Rob Clark
s dt-bindings: drm/msm/a6xx: Document GMU bindings drm/msm: Truncate the buffer object name if the copy from user failed Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (2): drm/msm: honor GPU_READONLY flag MAINTAINERS: update ent

Re: [Freedreno] drm : adv7511 module unload crash

2019-02-28 Thread Rob Clark
Looks like a spot where we don't drain a workqueue on unload. In general, I'd say unload is not well tested and there is a lot that can go wrong. It's also not something that really happens in the real world. Patches welcome, but I don't think it is the highest priority. BR, -R On Wed, Feb 27,

Re: [Freedreno] [RFC PATCH v1 15/15] drm/msm/a5xx: Support per-instance pagetables

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:39 PM Jordan Crouse wrote: > > Add support for per-instance pagetables for 5XX targets. Create a support > buffer for preemption to hold the SMMU pagetable information for a > preempted ring, enable TTBR1 to support split pagetables and add the > necessary PM4 commands to

Re: [Freedreno] [RFC PATCH v1 02/15] iommu/arm-smmu: Add split pagetable support for arm-smmu-v2

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:38 PM Jordan Crouse wrote: > > Add support for a split pagetable (TTBR0/TTBR1) scheme for > arm-smmu-v2. If split pagetables are enabled, create a > pagetable for TTBR1 and set up the sign extension bit so > that all IOVAs with that bit set are mapped and translated > from

Re: [Freedreno] [PATCH v1 4/4] arm64: dts: sdm845: Add zap shader region for GPU

2019-03-13 Thread Rob Clark
On Tue, Mar 12, 2019 at 2:14 PM Jordan Crouse wrote: > > Some Adreno GPU targets require a special zap shader to bring the GPU > out of secure mode. Define a region to allocate and store the zap > shader. > > Signed-off-by: Jordan Crouse > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 ++

Re: [Freedreno] [PATCH v1 4/4] arm64: dts: sdm845: Add zap shader region for GPU

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 1:20 AM Bjorn Andersson wrote: > > On Wed 13 Mar 08:42 PDT 2019, Rob Clark wrote: > > > On Tue, Mar 12, 2019 at 2:14 PM Jordan Crouse > > wrote: > > > > > > Some Adreno GPU targets require a special zap shader to bring the GPU >

Re: [Freedreno] GSOC2019

2019-03-25 Thread Rob Clark
Hi Khaled, There is some basic (but not enabled by default on a5xx) tiled texture support for a5xx (but probably still some bugs w/ various 3d/array texture modes).. The support is better on a6xx where it is enabled by default. But still not enabled at all for a3xx. (And a device like dragonboar

Re: [Freedreno] [PATCH v3 3/5] drm/msm: fix fb references in async update

2019-03-27 Thread Rob Clark
On Wed, Mar 13, 2019 at 8:21 PM Helen Koike wrote: > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Cc: # v4.14+ > Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic") > Suggested-by: Boris Brez

Re: [Freedreno] GSOC2019

2019-03-27 Thread Rob Clark
On Wed, Mar 27, 2019 at 5:53 PM Trevor Woerner wrote: > > Hi Khaled: Does Rob's answer help? > If you're interested in participating in this year's X.Org GSoC you'll need > to get your submission done and in before 1400EDT on April 9th. > > Rob: if Khaled is interested, can you recommend a mentor

Re: [Freedreno] [PATCH] freedreno: PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT unreachable statement

2019-04-09 Thread Rob Clark
Good catch, I've pushed this one Thanks BR, -R On Tue, Apr 9, 2019 at 4:20 AM Khaled Emara wrote: > > There seems to be a duplicate return statement, > as A2XX doesn't support shader buffers. > --- > src/gallium/drivers/freedreno/freedreno_screen.c | 1 - > 1 file changed, 1 deletion(-) > > d

Re: [Freedreno] [PATCH] freedreno: moved get_param to generation specific files

2019-04-09 Thread Rob Clark
On Tue, Apr 9, 2019 at 5:37 AM Khaled Emara wrote: > > According to the TODO: moved get_param to generation specific code. > --- > .../drivers/freedreno/a2xx/fd2_screen.c | 207 ++- > .../drivers/freedreno/a2xx/fd2_screen.h | 4 +- > .../drivers/freedreno/a3xx/fd3_screen

Re: [Freedreno] [PATCH libdrm] headers: Sync with drm-next

2019-04-10 Thread Rob Clark
On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom wrote: > > On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > > Generated using make headers_install from the drm-next > > > tree - git://anongit.freedesktop.org/drm/drm > > >

[Freedreno] [PATCH 0/3] drm/msm: uabi updates for KHR_robustness

2019-04-16 Thread Rob Clark
er-context pagetables yet without some iommu work landing first. But it can otherwise be tested for the fault detection part of things with a small hack. Jordan Crouse (1): drm/msm/gpu: Add submit queue queries Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param t

[Freedreno] [PATCH 1/3] drm/msm/gpu: add per-process pagetables param

2019-04-16 Thread Rob Clark
From: Rob Clark For now it always returns '0' (false), but once the iommu work is in place to enable per-process pagetables we can update the value returned. Userspace needs to know this to make an informed decision about exposing KHR_robustness. Signed-off-by: Rob Clark --- drive

[Freedreno] [PATCH 2/3] drm/msm: add param to retrieve # of GPU faults (global)

2019-04-16 Thread Rob Clark
From: Rob Clark For KHR_robustness, userspace wants to know two things, the count of GPU faults globally, and the count of faults attributed to a given context. This patch providees the former, and the next patch provides the latter. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno

[Freedreno] [PATCH 3/3] drm/msm/gpu: Add submit queue queries

2019-04-16 Thread Rob Clark
of faults to see if it is responsible for any and if so it can invalidate itself. This is also helpful for testing by confirming to the user driver if a particular command stream caused a fault (or not as the case may be). Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu

[Freedreno] [pull] drm/msm: msm-next for 5.2

2019-04-21 Thread Rob Clark
() drm/msm: Split submit_lookup_objects() into two loops Luca Weiss (1): drm/msm: Fix NULL pointer dereference Lucas Stach (1): drm/msm: don't allocate pages from the MOVABLE zone Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param to retrieve #

Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Rob Clark
On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with an experimental coccinelle script > > While this chec

[Freedreno] [PATCH] drm/msm/a6xx: No zap shader is not an error

2019-05-08 Thread Rob Clark
From: Rob Clark Depending on platform firmware, a zap shader may not be required to take the GPU out of secure mode on boot, in which case we can just write RBBM_SECVID_TRUST_CNTL directly. Which we *mostly* handled, but missed clearing 'ret' resulting that hw_init() returned an erro

[Freedreno] [PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling

2019-05-08 Thread Rob Clark
(Sean Paul) Changes in v4-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 174 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 +- drivers/gpu/drm/msm/disp

[Freedreno] [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-05-08 Thread Rob Clark
Djakov) Changes in v6: - Change to new icc_set API's (Doug Anderson) Changes in v7: - Fixed a typo Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 49 ++-- 1 file ch

[Freedreno] [PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-05-08 Thread Rob Clark
balanced add a minimum vote in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar Reviewed-by: Sean Paul Signed-off-by: Rob Clark

[Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-05-08 Thread Rob Clark
From: Georgi Djakov Signed-off-by: Georgi Djakov Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 97179bec8902

[Freedreno] [PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-05-08 Thread Rob Clark
definitions (Rob Herring) Changes in v4: - Use port macros and change port string names (Georgi Djakov) Changes in v5-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Reviewed-by: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-08 Thread Rob Clark
On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > b/arch/arm/boot/dts/qcom-msm8974.dtsi > > [..] > > > +

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Rob Clark
On Thu, May 9, 2019 at 12:12 AM Brian Masney wrote: > > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > &

Re: [Freedreno] About EVOC 2019 project ideas

2019-05-10 Thread Rob Clark
Hi, actually the texture tiling project was selected for a GSoC project which is just starting up.. But there may be other projects for other drivers or in other areas of mesa/xserver/drm/etc. Adding evoc list. BR, -R On Fri, May 10, 2019 at 5:40 AM Shubham Verma wrote: > > Hello Dear Sir, > >

Re: [Freedreno] About EVOC 2019 project ideas

2019-05-10 Thread Rob Clark
Then we can work on compressed textures > project. > > On Fri, 10 May 2019 6:16 pm Rob Clark, wrote: >> >> Hi, actually the texture tiling project was selected for a GSoC >> project which is just starting up.. But there may be other projects >> for other drivers o

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-05-10 Thread Rob Clark
On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [Freedreno] [PATCH] iommu: arm-smmu: Set SCTLR.HUPCF bit

2019-05-24 Thread Rob Clark
On Mon, Nov 26, 2018 at 11:31 AM Will Deacon wrote: > > Hi Rob, > > On Tue, Nov 13, 2018 at 08:12:35AM -0500, Rob Clark wrote: > > On Tue, Nov 13, 2018 at 1:32 AM Will Deacon wrote: > > > On Fri, Nov 09, 2018 at 01:01:55PM -0500, Rob Clark wrote: > > > &g

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-24 Thread Rob Clark
On Fri, May 24, 2019 at 1:43 PM Stephen Boyd wrote: > > Quoting Sean Paul (2019-05-24 10:32:18) > > From: Sean Paul > > > > Instead of reaching into dev->primary for debugfs_root, use the minor > > passed into debugfs_init. > > > > This avoids creating the debug directory under /sys/kernel/debug/

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-28 Thread Rob Clark
Link to v1: > https://patchwork.freedesktop.org/patch/msgid/20190524173231.5040-1-s...@poorly.run > > Cc: Rob Clark > Reported-by: Stephen Boyd > Reviewed-by: Abhinav Kumar > Signed-off-by: Sean Paul nice! Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/dp

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Rob Clark
On Tue, May 28, 2019 at 6:17 PM Brian Masney wrote: > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote: > > > > > Here is a patch series that adds initial display support for the LG > > > Nexus 5 (hammerhead) phone. It's not fu

Re: [Freedreno] [PATCH v2 1/2] a5xx: Define HLSQ_DBG_ECO_CNTL

2019-05-29 Thread Rob Clark
thanks, I've pushed this one to envytools tree BR, -R On Wed, May 29, 2019 at 8:20 AM Jeffrey Hugo wrote: > > --- > rnndb/adreno/a5xx.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rnndb/adreno/a5xx.xml b/rnndb/adreno/a5xx.xml > index ae654eeb..16203512 100644 > --- a/rnndb/adreno

Re: [Freedreno] [PATCH v3 3/5] drm/msm: fix fb references in async update

2019-05-31 Thread Rob Clark
page in how things work on kernel/display side after spending most of my time in userspace/mesa), but I don't want to hold this up.. Acked-by: Rob Clark > > > > --- > > Hello, > > > > As mentioned in the cover letter, > > But I couldn't test on MSM because

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-02 Thread Rob Clark
On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > > > This solves a problem we see with drm/msm, caused by getting > > > iommu_dma_

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 12:57 AM Vivek Gautam wrote: > > > > On 6/3/2019 11:50 AM, Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >> On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > >>> On Tue, Dec 4, 2018 at 2:29 PM Rob Herrin

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > > > > On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > > > > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > > >

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > On 03/06/2019 11:47, Rob Clark wrote: > > On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > >> > >> On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >>> > >>> So, another case I'

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 6:54 AM Thierry Reding wrote: > > On Mon, Jun 03, 2019 at 06:20:57AM -0700, Rob Clark wrote: > > On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > > > > > On 03/06/2019 11:47, Rob Clark wrote: > > > > On Sun,

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > > But first of all, I remember Marek already submitted some patches long > ago that extended struct driver with some flag that means that the > driver doesn't want the IOMMU to be attached before probe. Why > wouldn't that work? Sounds like a pe

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Wed, Jun 5, 2019 at 6:18 AM Marek Szyprowski wrote: > > Hi Rob, > > On 2019-06-05 14:57, Rob Clark wrote: > > On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > >> But first of all, I remember Marek already submitted some patches long > >> ago that extend

Re: [Freedreno] Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-13 Thread Rob Clark
so, for dpu_format_map_tile, I'd like to define a fourcc modifier for tiled formats (we currently have a workaround in userspace w/ a private modifier in the gallium driver).. I think the problem is defining the layout of the tiled format(s) (there are at least two per generation and I can't guaran

Re: [Freedreno] [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Rob Clark
On Mon, Jun 17, 2019 at 7:02 PM Brian Masney wrote: > > Hi Rob Clark, > > On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > > > I would prefer that these lived at t

[Freedreno] [PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling

2019-06-18 Thread Rob Clark
(Sean Paul) Changes in v4-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 174 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 +- drivers/gpu/drm/msm/disp

[Freedreno] [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-06-18 Thread Rob Clark
bably best for clarity to keep num_paths=0 in this case. Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark Acked-by: Georgi Djakov --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 49 ++-- 1 file changed, 45 insertions(+), 4

[Freedreno] [PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-06-18 Thread Rob Clark
definitions (Rob Herring) Changes in v4: - Use port macros and change port string names (Georgi Djakov) Changes in v5-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Reviewed-by: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree

[Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-06-18 Thread Rob Clark
interconnects and request bandwidth between DDR and the display hardware (MDP port(s) and rotator downscaler). v2: update the path names to be consistent with dpu, handle the NULL path case, updated commit msg from Georgi. Signed-off-by: Georgi Djakov Signed-off-by: Rob Clark --- drivers/gpu/drm/msm

[Freedreno] [PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-06-18 Thread Rob Clark
balanced add a minimum vote in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar Reviewed-by: Sean Paul Signed-off-by: Rob Clark

Re: [Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-06-18 Thread Rob Clark
On Tue, Jun 18, 2019 at 1:44 PM Jeffrey Hugo wrote: > > On Tue, Jun 18, 2019 at 2:25 PM Rob Clark wrote: > > > > From: Georgi Djakov > > > > The interconnect API provides an interface for consumer drivers to > > express their bandwidth needs in the SoC. Th

[Freedreno] [PATCH 5/5 v3] drm/msm/mdp5: Use the interconnect API

2019-06-18 Thread Rob Clark
ly so no interconnect paths is not fatal. Signed-off-by: Georgi Djakov Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 38 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_

Re: [Freedreno] [PATCH v2] drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings

2019-06-19 Thread Rob Clark
On Wed, Jun 19, 2019 at 12:32 PM Sean Paul wrote: > > On Wed, Jun 19, 2019 at 12:17:23PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is > > only applied to the left hand side of this bitwise operator > > [-Wlogical-

Re: [Freedreno] [PATCH 2/6] dt-bindings: display: msm: gmu: add optional ocmem property

2019-06-19 Thread Rob Clark
On Wed, Jun 19, 2019 at 1:17 PM Rob Herring wrote: > > On Sun, Jun 16, 2019 at 7:29 AM Brian Masney wrote: > > > > Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and > > must use the On Chip MEMory (OCMEM) in order to be functional. Add the > > optional ocmem property to the

Re: [Freedreno] [PATCH 2/6] dt-bindings: display: msm: gmu: add optional ocmem property

2019-06-22 Thread Rob Clark
On Thu, Jun 20, 2019 at 7:14 PM Brian Masney wrote: > > On Wed, Jun 19, 2019 at 01:21:20PM -0700, Rob Clark wrote: > > On Wed, Jun 19, 2019 at 1:17 PM Rob Herring wrote: > > > > > > On Sun, Jun 16, 2019 at 7:29 AM Brian Masney > > > wrote: > > >

[Freedreno] [PATCH] drm/msm/a3xx: remove TPL1 regs from snapshot

2019-06-24 Thread Rob Clark
From: Rob Clark These regs are write-only, and the hw throws a hissy-fit (ie. reboots) when we try to read them for GPU state snapshot, in response to a GPU hang. It is rather impolite when GPU recovery triggers an insta- reboot, so lets remove the TPL1 registers from the snapshot. Fixes

Re: [Freedreno] [PATCH 2/7] drm/msm: Use drm_gem_fb_prepare_fb

2019-06-25 Thread Rob Clark
On Tue, Jun 25, 2019 at 1:42 PM Daniel Vetter wrote: > > msm has switched over to drm_fb->obj[] a while ago already, so we can > just use the helper. > > v2: Make it compile ... oops. > > Cc: Eric Anholt > Cc: Emil Velikov > Signed-off-by: Daniel Vetter > Cc:

[Freedreno] [pull] drm/msm: msm-next for 5.3

2019-06-25 Thread Rob Clark
quirks check in dsi_phy_hw_v3_0_lane_settings Nathan Huckleberry (1): drm/msm/dpu: Fix Wunused-const-variable Nicholas Mc Guire (1): drm/msm: check for equals 0 only Rob Clark (1): drm/msm/a3xx: remove TPL1 regs from snapshot Sean Paul (23): drm/msm/a6xx: Avoid freeing gmu resources

Re: [Freedreno] [PATCH] drm: msm: Fix add_gpu_components

2019-06-26 Thread Rob Clark
for gpu to ever be disabled (since it isn't depending on external non-SoC-specific wiring up of things.. but I guess that might still be useful for bring-up.. either way, Reviewed-by: Rob Clark Sean, want to pick this up in drm-misc-fixes? BR, -R > > Fixes: dc3ea265b856 ("drm/ms

Re: [Freedreno] [PATCH] drm/msm: correct NULL pointer dereference in context_init

2019-06-28 Thread Rob Clark
; Thoughts? yeah, we probably want to keep !iommu support, it is at least useful for bringup of new (or old) devices. But tends to bitrot a since it isn't a case that gets tested much once iommu is in place. Perhaps there is a way to have a null iommu/aspace, although I'm not quite sure h

Re: [Freedreno] [PATCH] drm/msm: Transition console to msm framebuffer

2019-06-29 Thread Rob Clark
framebuffers to accomplish the console transition. > > Suggested-by: Rob Clark > Signed-off-by: Jeffrey Hugo lgtm, Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_fb

Re: [Freedreno] [PATCH] drm/msm: Transition console to msm framebuffer

2019-06-29 Thread Rob Clark
On Sat, Jun 29, 2019 at 10:46 AM Rob Clark wrote: > > On Fri, Jun 28, 2019 at 9:28 AM Jeffrey Hugo wrote: > > > > If booting a device using EFI, efifb will likely come up and claim the > > console. When the msm display stack finally comes up, we want the > > cons

[Freedreno] [PATCH] drm/msm: stop abusing dma_map/unmap for cache

2019-06-30 Thread Rob Clark
From: Rob Clark Recently splats like this started showing up: WARNING: CPU: 4 PID: 251 at drivers/iommu/dma-iommu.c:451 __iommu_dma_unmap+0xb8/0xc0 Modules linked in: ath10k_snoc ath10k_core fuse msm ath mac80211 uvcvideo cfg80211 videobuf2_vmalloc videobuf2_memops vide CPU: 4 PID

[Freedreno] [PATCH 0/3] drm/msm: few small cleanups

2019-06-30 Thread Rob Clark
From: Rob Clark 2 and 3 are some early prep-work to deal with bootloader enabled displays, where we want to avoid runpm get/put cycles until we know that we won't -EPROBE_DEFER. (Otherwise, it will kill the display, and it's not terribly nice to kill efifb and leave the user with no g

[Freedreno] [PATCH 1/3] drm/msm: don't open-code governor name

2019-06-30 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 0a4c77fb3d94..e323259a16d3 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers

[Freedreno] [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion

2019-06-30 Thread Rob Clark
From: Rob Clark Unused and the extra rpm get/put interferes with handover from bootloader (ie. happens before we have a chance to check if things are already enabled). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier

2019-06-30 Thread Rob Clark
From: Rob Clark If we are going to -EPROBE_DEFER due to panel/bridge not probed yet, we want to do it before we start touching hardware. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/dsi/dsi.h | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c| 30 +-- drivers

Re: [Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-30 Thread Rob Clark
c-gpio" isn't found, we try to find just > "qcom,misc" as a last resort. Provide an explicit whitelist > for those GPIOs. > > Cc: Rob Clark > Cc: Sean Paul > Cc: linux-arm-...@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Linus Wa

[Freedreno] [PATCH 0/5] drm+clk+genpd: support for bootloader enabled display

2019-06-30 Thread Rob Clark
From: Rob Clark The aarch64 laptops which ship with windows, have the display by the bootloader, and efifb (yah!). But unlike x86 laptops, device power management isn't handled via ACPI[1]. Currently the CCF and genpd frameworks will turn off power domains and clocks that they think are u

[Freedreno] [PATCH 2/5] genpd/gdsc: inherit display powerdomain from bootloader

2019-06-30 Thread Rob Clark
From: Rob Clark Mark power domains that may be enabled by bootloader, and which should not be disabled until a driver takes them over. This keeps efifb alive until the real driver can be probed. In a distro kernel, the driver will most likely built as a module, and not probed until we get to

[Freedreno] [PATCH 1/5] clk: inherit clocks enabled by bootloader

2019-06-30 Thread Rob Clark
From: Rob Clark The goal here is to support inheriting a display setup by bootloader, although there may also be some non-display related use-cases. Rough idea is to add a flag for clks and power domains that might already be enabled when kernel starts, and which should not be disabled at

[Freedreno] [PATCH 3/5] drm/msm/dsi: split clk rate setting and enable

2019-06-30 Thread Rob Clark
From: Rob Clark Prep work for the following patch. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/dsi/dsi.h | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.c | 3 +++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 38 ++ 4 files

[Freedreno] [PATCH 4/5] drm/msm/dsi: get the clocks into OFF state at init

2019-06-30 Thread Rob Clark
From: Rob Clark Do an extra enable/disable cycle at init, to get the clks into disabled state in case bootloader left them enabled. In case they were already enabled, the clk_prepare_enable() has no real effect, other than getting the enable_count/prepare_count into the right state so that we

[Freedreno] [PATCH 5/5] drm/bridge: ti-sn65dsi86: support booloader enabled display

2019-06-30 Thread Rob Clark
From: Rob Clark Request the enable gpio ASIS to avoid disabling bridge during probe, if already enabled. And if already enabled, defer enabling runpm until attach to avoid cutting off the power to the bridge. Once we get to attach, we know panel and drm driver are probed successfully, so at

Re: [Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-30 Thread Rob Clark
On Sun, Jun 30, 2019 at 8:18 AM Linus Walleij wrote: > > On Sun, Jun 30, 2019 at 3:26 PM Rob Clark wrote: > > > I'm ok with this.. although I wonder if we need to try this hard for > > backwards compat? At least I don't see any upstream dts > > using the ol

<    3   4   5   6   7   8   9   10   11   12   >