From: Rob Clark
The mutex wasn't really protecting anything before. Before the previous
patch we could still be racing with the scheduler's kthread, as that is
not necessarily frozen yet. Now that we've parked the sched threads,
the only race is with jobs retiring, and that
From: Rob Clark
Add a way to override comm/cmdline per-drm_file. This is useful for
VM scenarios where the host process is just a proxy for the actual
guest process.
Rob Clark (3):
drm/msm: Add support for pointer params
drm/msm: Split out helper to get comm/cmdline
drm/msm: Add a way to
From: Rob Clark
The 64b value field is already suffient to hold a pointer instead of
immediate, but we also need a length field.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++--
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 ++--
drivers/gpu/drm/msm
From: Rob Clark
Deduplicate this from fault_worker and recover_worker.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gpu.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm
From: Rob Clark
In the cause of using the GPU via virtgpu, the host side process is
really a sort of proxy, and not terribly interesting from the PoV of
crash/fault logging. Add a way to override these per process so that
we can see the guest process's name.
Signed-off-by: Rob
On Thu, Mar 17, 2022 at 1:21 AM Dan Carpenter wrote:
>
> On Wed, Mar 16, 2022 at 05:29:45PM -0700, Rob Clark wrote:
> > switch (param) {
> > + case MSM_PARAM_COMM:
> > + case MSM_PARAM_CMDLINE: {
> > + char *str, **paramp;
> > +
>
On Thu, Mar 17, 2022 at 3:06 AM Christian König
wrote:
>
> Am 17.03.22 um 10:59 schrieb Daniel Vetter:
> > On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote:
> >> From: Rob Clark
> >>
> >> In the system suspend path, we don't want to be rac
On Thu, Mar 17, 2022 at 9:04 AM Christian König
wrote:
>
> Am 17.03.22 um 16:10 schrieb Rob Clark:
> > [SNIP]
> > userspace frozen != kthread frozen .. that is what this patch is
> > trying to address, so we aren't racing between shutting down the hw
> > and t
From: Rob Clark
Add a way to override comm/cmdline per-drm_file. This is useful for
VM scenarios where the host process is just a proxy for the actual
guest process.
Rob Clark (3):
drm/msm: Add support for pointer params
drm/msm: Split out helper to get comm/cmdline
drm/msm: Add a way to
From: Rob Clark
The 64b value field is already suffient to hold a pointer instead of
immediate, but we also need a length field.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++--
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 ++--
drivers/gpu/drm/msm
From: Rob Clark
Deduplicate this from fault_worker and recover_worker.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gpu.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm
From: Rob Clark
In the cause of using the GPU via virtgpu, the host side process is
really a sort of proxy, and not terribly interesting from the PoV of
crash/fault logging. Add a way to override these per process so that
we can see the guest process's name.
v2: Handle kmalloc failure
On Thu, Mar 17, 2022 at 9:45 AM Christian König
wrote:
>
> Am 17.03.22 um 17:18 schrieb Rob Clark:
> > On Thu, Mar 17, 2022 at 9:04 AM Christian König
> > wrote:
> >> Am 17.03.22 um 16:10 schrieb Rob Clark:
> >>> [SNIP]
> >>> userspace fro
On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky
wrote:
>
>
> On 2022-03-17 13:35, Rob Clark wrote:
> > On Thu, Mar 17, 2022 at 9:45 AM Christian König
> > wrote:
> >> Am 17.03.22 um 17:18 schrieb Rob Clark:
> >>> On Thu, Mar 17, 2022 at 9:04 AM Christ
From: Rob Clark
Fixes: 25faf2f2e065 ("drm/msm: Show process names in gem_describe")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 02b9ae65a96a..a4
On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky
wrote:
>
>
> On 2022-03-17 14:25, Rob Clark wrote:
> > On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky
> > wrote:
> >>
> >> On 2022-03-17 13:35, Rob Clark wrote:
> >>> On Thu, Mar 17, 2022
On Thu, Mar 17, 2022 at 1:45 PM Akhil P Oommen wrote:
>
> On 3/11/2022 5:16 AM, Rob Clark wrote:
> > From: Rob Clark
> >
> > The mutex wasn't really protecting anything before. Before the previous
> > patch we could still be racing with the scheduler's
From: Rob Clark
The motivation at this point is mainly native userspace mesa driver in a
VM guest. The one remaining synchronous "hotpath" is buffer allocation,
because guest needs to wait to know the bo's iova before it can start
emitting cmdstream/state that references
On Fri, Mar 18, 2022 at 12:19 AM Dan Carpenter wrote:
>
> On Thu, Mar 17, 2022 at 08:03:59AM -0700, Rob Clark wrote:
> > > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c
> > > > b/drivers/gpu/drm/msm/msm_gpu.c
> > > > index 4ec62b601adc..68f3f8ade76
On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky
wrote:
>
>
> On 2022-03-17 16:35, Rob Clark wrote:
> > On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky
> > wrote:
> >>
> >> On 2022-03-17 14:25, Rob Clark wrote:
> >>> On Thu, Mar 17, 2022 at
On Fri, Mar 18, 2022 at 9:27 AM Andrey Grodzovsky
wrote:
>
>
> On 2022-03-18 12:20, Rob Clark wrote:
> > On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky
> > wrote:
> >>
> >> On 2022-03-17 16:35, Rob Clark wrote:
> >>> On Thu, Mar 17, 2022 at
From: Rob Clark
The ring seqno counter duplicates the fence-context last_fence counter.
They end up getting incremented in lock-step, on the same scheduler
thread, but the split just makes things less obvious.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2
From: Rob Clark
Prep for a following patch. While we are at it, convert a few remaining
WARN_ON()s to GEM_WARN_ON().
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c | 2 +-
drivers/gpu/drm/msm/msm_gem.h | 1 +
drivers/gpu/drm/msm/msm_gem_vma.c | 15 ++-
3
From: Rob Clark
These belong more cleanly in the gem header.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.h | 23 ---
drivers/gpu/drm/msm/msm_gem.h | 22 ++
2 files changed, 22 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/msm
From: Rob Clark
Get rid of all the unnecessary conversion between address/size and page
offsets. It just confuses things.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
drivers/gpu/drm/msm/msm_gem.c | 5 ++---
drivers/gpu/drm/msm/msm_gem.h | 4
From: Rob Clark
The first five paches are various cleanups and simplifications. The
next two get rid of redundant vma lookups in the submit and retire
paths. Following that, fenced vma lets us indicate a fence value
following which the vma is no longer used, which is needed because
otherwise
From: Rob Clark
There was only a single user, which could just as easily stash the iova
when pinning.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_fb.c | 16 ++--
drivers/gpu/drm/msm/msm_gem.c | 16
drivers/gpu/drm/msm/msm_gem.h | 2 --
3 files changed
From: Rob Clark
Combines duplicate vma lookup in the get_and_pin path.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c | 50 ++-
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm
From: Rob Clark
This way we only lookup vma once per object per submit, for both the
submit and retire path.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c| 60 +---
drivers/gpu/drm/msm/msm_gem.h| 9 +++--
drivers/gpu/drm/msm
From: Rob Clark
With userspace allocated iova (next patch), we can have a race condition
where userspace observes the fence completion and deletes the vma before
retire_submit() gets around to unpinning the vma. To handle this, add a
fenced unpin which drops the refcount but tracks the fence
From: Rob Clark
The motivation at this point is mainly native userspace mesa driver in a
VM guest. The one remaining synchronous "hotpath" is buffer allocation,
because guest needs to wait to know the bo's iova before it can start
emitting cmdstream/state that references
On Tue, Mar 29, 2022 at 4:42 PM Dmitry Baryshkov
wrote:
>
> On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote:
> >
> > From: Rob Clark
> >
> > The motivation at this point is mainly native userspace mesa driver in a
> > VM guest. The one remaining synchr
On Wed, Mar 30, 2022 at 4:32 AM Dmitry Baryshkov
wrote:
>
> On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote:
> >
> > From: Rob Clark
> >
> > Prep for a following patch. While we are at it, convert a few remaining
> > WARN_ON()s to GEM_WARN_ON().
>
> Well
From: Rob Clark
The first six paches are various cleanups and simplifications. The
next two get rid of redundant vma lookups in the submit and retire
paths. Following that, fenced vma lets us indicate a fence value
following which the vma is no longer used, which is needed because
otherwise
From: Rob Clark
These belong more cleanly in the gem header.
Signed-off-by: Rob Clark
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/msm_drv.h | 23 ---
drivers/gpu/drm/msm/msm_gem.h | 22 ++
2 files changed, 22 insertions(+), 23 deletions
From: Rob Clark
The ring seqno counter duplicates the fence-context last_fence counter.
They end up getting incremented in lock-step, on the same scheduler
thread, but the split just makes things less obvious.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2
From: Rob Clark
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem_vma.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c
b/drivers/gpu/drm/msm/msm_gem_vma.c
index f914ddbaea89..64906594fc65 100644
--- a/drivers/gpu/drm/msm
From: Rob Clark
Prep for a following patch, where it gets a bit more complicated.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c | 2 +-
drivers/gpu/drm/msm/msm_gem.h | 1 +
drivers/gpu/drm/msm/msm_gem_vma.c | 9 +++--
3 files changed, 9 insertions(+), 3 deletions
From: Rob Clark
Get rid of all the unnecessary conversion between address/size and page
offsets. It just confuses things.
Signed-off-by: Rob Clark
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
drivers/gpu/drm/msm/msm_gem.c | 5 ++---
drivers/gpu
From: Rob Clark
Combines duplicate vma lookup in the get_and_pin path.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c | 50 ++-
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm
From: Rob Clark
There was only a single user, which could just as easily stash the iova
when pinning.
Signed-off-by: Rob Clark
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/msm_fb.c | 16 ++--
drivers/gpu/drm/msm/msm_gem.c | 16
drivers/gpu/drm/msm
From: Rob Clark
This way we only lookup vma once per object per submit, for both the
submit and retire path.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem.c| 60 +---
drivers/gpu/drm/msm/msm_gem.h| 9 +++--
drivers/gpu/drm/msm
From: Rob Clark
With userspace allocated iova (next patch), we can have a race condition
where userspace observes the fence completion and deletes the vma before
retire_submit() gets around to unpinning the vma. To handle this, add a
fenced unpin which drops the refcount but tracks the fence
From: Rob Clark
The motivation at this point is mainly native userspace mesa driver in a
VM guest. The one remaining synchronous "hotpath" is buffer allocation,
because guest needs to wait to know the bo's iova before it can start
emitting cmdstream/state that references
On Thu, Mar 31, 2022 at 11:27 AM Dmitry Osipenko
wrote:
>
> On 3/30/22 23:47, Rob Clark wrote:
> > From: Rob Clark
> >
> > Combines duplicate vma lookup in the get_and_pin path.
> >
> > Signed-off-by: Rob Clark
> > -
On Thu, Mar 31, 2022 at 11:52 AM Dmitry Osipenko
wrote:
>
> ...
> > +/*
> > + * Get the requested iova but don't pin it. Fails if the requested iova is
> > + * not available. Doesn't need a put because iovas are currently valid for
> > + * the life of the object.
> > + *
> > + * Setting an iova
Hi Dave,
sorry, somewhat late (was sick last week plus $day_job stuff).. I've
removed the few patches that haven't been in msm-next / linux-next for
at least a few weeks, so everything that is left has been in
linux-next for a while. The other stuff I'll add back in for 4.19.
The following cha
On Sun, Jun 17, 2018 at 11:40 PM, Souptick Joarder wrote:
> On Thu, May 31, 2018 at 11:29 PM, Jordan Crouse
> wrote:
>> On Mon, May 28, 2018 at 12:38:41PM +0530, Souptick Joarder wrote:
>>> On Mon, May 21, 2018 at 10:59 PM, Souptick Joarder
>>> wrote:
>>> > Use new return type vm_fault_t for f
On Wed, Jun 20, 2018 at 8:50 AM, Sravanthi Kollukuduru
wrote:
> Reserve one DMA pipe as cursor plane and also, update crtc
> support of cursor in crtc_init.
hmm, mdp5 in 820 had real cursor planes in hw, did these go away? If
so I guess DMA plane is best candidate for cursor..
BR,
-R
>
> Signe
On Wed, Jun 20, 2018 at 12:29 PM, wrote:
> On 2018-06-20 19:18, Rob Clark wrote:
>>
>> On Wed, Jun 20, 2018 at 8:50 AM, Sravanthi Kollukuduru
>> wrote:
>>>
>>> Reserve one DMA pipe as cursor plane and also, update crtc
>>> support of cursor
On Tue, Jun 26, 2018 at 11:55 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Jun 25, 2018 at 9:45 PM, Sandeep Panda wrote:
>> From: Abhinav Kumar
>>
>> Setting the DSI PLL src in probe doesn't provide the clock
>> driver sufficient time to reclaim unused clock resources
>> from coreboot resulting in
On Wed, Jun 27, 2018 at 2:48 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Jun 26, 2018 at 10:27 AM, Rob Clark wrote:
>> On Tue, Jun 26, 2018 at 11:55 AM, Doug Anderson
>> wrote:
>>> Hi,
>>>
>>> On Mon, Jun 25, 2018 at 9:45 PM, San
appen it would paper over the bug, since the first plag flip would
flush out the state to the hardware.
The issue could be reproduced with, for example, modetest (without the
'-v' argument).
Fixes: f9cb8d8d836e drm/msm/mdp5: rework CTL START signal handling
Signed-off-by: Rob Clark
---
d
On Mon, Jul 9, 2018 at 2:35 PM, Sean Paul wrote:
> On Mon, Jul 09, 2018 at 12:07:11PM -0600, Rob Herring wrote:
>> On Mon, Jul 9, 2018 at 11:40 AM Sean Paul wrote:
>> >
>> > Signed-off-by: Sean Paul
>> > ---
>> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 194 +++
>> > 1 fil
On Thu, Jul 12, 2018 at 2:59 PM, Jordan Crouse wrote:
> Add a put function for the coredump printer to bypass printf()
> for constant strings for a speed boost.
s/put/puts/ (and in the $subject)
BR,
-R
>
> v2: Add EXPORT_SYMBOL for _drm_puts_coredump
> Signed-off-by: Jordan Crouse
> ---
> dri
On Mon, Jul 9, 2018 at 1:31 PM, Sean Paul wrote:
> From: Jeykumar Sankaran
>
> Qualcomm Snapdragon chipsets uses compressed format
> to optimize BW across multiple IP's. This change adds
> needed modifier support in drm for a simple 4x4 tile
> based compressed variants of base formats.
>
> Signed
uses compressed format
>>> to optimize BW across multiple IP's. This change adds
>>> needed modifier support in drm for a simple 4x4 tile
>>> based compressed variants of base formats.
>>>
>>> Changes in v3:
>>> - Removed duplicate e
On Thu, Jul 26, 2018 at 4:30 PM, Jordan Crouse wrote:
> I made a silly little script that looked at the defined symbols
> in nm and then looked to see if other files in the module used
> those symbols and if they didn't they were either candidates
> for removal or to be made static. This is the re
nm pll
drm/msm/mdp5: subclass msm_mdss for mdp5
drm/msm: rework vblank event handling in dpu_crtc
Rob Clark (1):
drm/msm/mdp5: fix missing CTL flush
Sean Paul (5):
drm/msm: Move wait_for_vblanks into mdp complete_commit() hooks
drm/msm: Clean up dangling atomic_wq
rmats.c
drm/msm/disp/dpu: Mark a handful of functions as static
Rajesh Yadav (3):
drm/msm/dsi: initialize postdiv_lock before use for 10nm pll
drm/msm/mdp5: subclass msm_mdss for mdp5
drm/msm: rework vblank event handling in dpu_crtc
Rob Clark (1):
drm/msm/mdp5: fix m
On Thu, Aug 2, 2018 at 7:24 PM, Kees Cook wrote:
> On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote:
>> On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote:
>>> In the quest to remove all stack VLA usage from the kernel[1], this
>>> switches to using a kasprintf()ed buffer. Return paths
On Fri, Aug 3, 2018 at 5:06 PM Jordan Crouse wrote:
>
> Set the correct initial GPU frequency on the GMU just after turning on
> or resetting the GMU so it doesn't keep running at a horribly slow
> speed.
>
> Signed-off-by: Jordan Crouse
*much* better :-
On Thu, Jul 12, 2018 at 3:48 PM Chris Wilson wrote:
>
> Quoting Jordan Crouse (2018-07-12 19:59:25)
> > Do a bit of cleanup to prepare for upcoming changes to pass the
> > hanging task comm and cmdline to the crash dump function.
> >
> > Signed-off-by: Jordan Crouse
> > ---
> > drivers/gpu/drm/m
On Mon, Aug 6, 2018 at 1:35 PM Jordan Crouse wrote:
>
> This is an initial version of support for the Adreno a6xx GPU family starting
> with the a630 from the sdm845 SoC. This code is ahead of much of the sdm845
> code that would be needed to actually bring up a device and it is also in
> advance
Hi Dave,
A couple small fixes for v4.19.
I have a 2nd optional follow-up PR that I'll send on top of this which
adds a6xx support. See the following PR for details.
The following changes since commit a7663a79343658f9362dc0655f1a06723c7014e3:
dt-bindings: msm/disp: Add bindings for Snapdragon
e firmware before bringing up the hardware
drm/msm: Add A6XX device support
Rob Clark (1):
drm/msm: update generated headers
drivers/gpu/drm/msm/Makefile |3 +
drivers/gpu/drm/msm/adreno/a2xx.xml.h | 57 +-
drivers/gpu/drm/msm/adreno/a3xx.xm
On Tue, Aug 14, 2018 at 9:00 AM Pradeep Reddy
wrote:
>
> Hi Archit,
>
> I have enabled splash screen (penguin) in bootloader with fastboot oem
> select-display-panel hdmi. Kernel crashes during boot. I identified that
> there is issue with below two smmu clocks.
> static struct clk_branch smmu_m
On Mon, Aug 27, 2018 at 9:53 PM Rob Herring wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Gustavo Padovan
> Cc: Maarten Lankhorst
> Cc: Sean Paul
> Cc: David Airli
ly not what we want
(and definately not what we want for GPU).
Signed-off-by: Rob Clark
---
So I hit this issue a long time back on 820 (msm8996) and at the
time I solved it with a patch that enabled CFCFG. And it resurfaced
more recently on sdm845. But at the time CFCFG was rejected, iirc
bec
On Mon, Oct 1, 2018 at 3:04 PM Jordan Crouse wrote:
>
> On Mon, Oct 01, 2018 at 06:01:33PM +0530, Sharat Masetty wrote:
> > Track the GPU fences created at submit time with idr instead of the ring
> > the sequence number. This helps with easily changing the underlying
> > fence to something we don
responses
drm/msm/a6xx: Add inactive_period for a6xx
drm/msm/a6xx: Remove CP perfcounter selects from the protected list
Rob Clark (2):
drm/msm/rd: fix crash with long process cmdlines
drm/msm: update generated headers
Sean Paul (17):
drm/msm: dsi: Initialize msm_dsi
On Sun, Oct 7, 2018 at 3:23 PM Rob Clark wrote:
>
> Hi Dave,
>
> This time mostly further refinement of dpu1+a6xx for sdm845 and
> beyond.. and hurray for more negative diffstat :-)
>
> - Misc cleanups and fixes
> - GPU preemption optimization
> - a6xx perf improvement
Hi Dave,
Fix for armv7 u64 division
The following changes since commit 3ce36b4542b585ed0231b175aee31020b2f289c2:
drm/msm/a6xx: Remove CP perfcounter selects from the protected list
(2018-10-07 14:40:28 -0400)
are available in the Git repository at:
git://people.freedesktop.org/~robclark/l
Thanks, I've pushed 2 and 3 to msm-next, since these should probably
go in a -fixes pr for 4.20
This one, you might want to resend w/
--cc-cmd=./scripts/get_maintainer.pl so that it gets seen by someone
who could apply it
fwiw, I use
git config sendemail.cccmd './scripts/get_maintainer.pl -i'
er for all buffers in the
command
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_rd.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
index cca933458439..0c2c8d2c631f 100644
--- a/drivers/gpu/drm/msm/msm_rd.c
+++
MSM_SUBMIT_BO_DUMP flag so userspace can indicate
buffers that contain cmdstream (or are otherwise important to dump).
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem_submit.c | 5 -
drivers/gpu/drm/msm/msm_rd.c | 13 ++---
include/uapi/drm/msm_drm.h | 5 -
3 files
;
> v2: Pre-compute and submit the log2 of the image format's bpp as shader
> constant instead of emitting the LOG2 instruction in code. (Rob Clark)
>
> v3: Use ffs (find-first-bit) helper for computing log2 (Ilia Mirkin)
Reviewed-by: Rob Clark
On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov wrote:
>
> On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote:
> >
> > On Tuesday, 2018-10-23 10:49:26 -0400,
> > mesa-dev-boun...@lists.freedesktop.org wrote:
> > > In the pursuit of lowering driver overhead, it became clear that some
> > > amount o
On Tue, Oct 30, 2018 at 1:34 PM Emil Velikov wrote:
>
> On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote:
> > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov
> > wrote:
>
> > > > > NOTE: if bisecting a build error takes you hear, try a clean build.
> > >
On Mon, Oct 29, 2018 at 3:09 PM Will Deacon wrote:
>
> On Thu, Sep 27, 2018 at 06:46:07PM -0400, Rob Clark wrote:
> > We seem to need to set either this or CFCFG (stall), otherwise gpu
> > faults trigger problems with other in-flight transactions from the
> > GP
On Tue, Nov 13, 2018 at 1:32 AM Will Deacon wrote:
>
> On Fri, Nov 09, 2018 at 01:01:55PM -0500, Rob Clark wrote:
> > On Mon, Oct 29, 2018 at 3:09 PM Will Deacon wrote:
> > > On Thu, Sep 27, 2018 at 06:46:07PM -0400, Rob Clark wrote:
> > > > We seem to need t
thanks, it's nice to see a2xx getting some attention upstream.. few
comments inline..
On Wed, Nov 14, 2018 at 5:28 PM Jonathan Marek wrote:
>
> A2XX has its own very simple MMU.
>
> Added a msm_use_mmu() function because we can't rely on iommu_present to
> decide to use MMU or not.
>
> Signed-off
On Mon, Nov 26, 2018 at 2:31 PM Will Deacon wrote:
>
> Hi Rob,
>
> On Tue, Nov 13, 2018 at 08:12:35AM -0500, Rob Clark wrote:
> > On Tue, Nov 13, 2018 at 1:32 AM Will Deacon wrote:
> > > On Fri, Nov 09, 2018 at 01:01:55PM -0500, Rob Clark wrote:
> > > &g
On Wed, Nov 28, 2018 at 2:39 AM Christoph Hellwig wrote:
>
> > + /*
> > + * dma_sync_sg_*() flush the physical pages, so point
> > + * sg->dma_address to the physical ones for the right
> > behavior.
> > + */
> > + for_each_sg(msm_obj
On Wed, Nov 28, 2018 at 1:29 PM Jordan Crouse wrote:
>
> Try to get the interconnect path for the GPU and vote for the maximum
> bandwidth to support all frequencies. This is needed for performance.
> Later we will want to scale the bandwidth based on the frequency to
> also optimize for power but
On Fri, Oct 26, 2018 at 9:46 AM Sharat Masetty wrote:
>
> Added Rob to this thread.
>
> On 10/17/2018 8:05 PM, Jordan Crouse wrote:
> > On Wed, Oct 17, 2018 at 06:34:01PM +0530, Sharat Masetty wrote:
> >> This patch attempts to make use of the hardware counters for GPU busy %
> >> estimation when
On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote:
>
> On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote:
> > dma_map_sg() expects a DMA domain. However, the drm devices
> > have been traditionally using unmanaged iommu domain which
> > is non-dma type. Using dma mapping APIs with
On Thu, Nov 29, 2018 at 9:25 AM Rob Clark wrote:
>
> On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote:
> >
> > On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote:
> > > dma_map_sg() expects a DMA domain. However, the drm devices
> > > hav
On Thu, Nov 29, 2018 at 10:53 AM Christoph Hellwig wrote:
>
> On Thu, Nov 29, 2018 at 09:25:43AM -0500, Rob Clark wrote:
> > > As I told you before: hell no. If you spent the slightest amount of
> > > actually trying to understand what you are doing here you'd know
On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig wrote:
>
> On Thu, Nov 29, 2018 at 09:42:50AM -0500, Rob Clark wrote:
> > Maybe the thing we need to do is just implement a blacklist of
> > compatible strings for devices which should skip the automatic
> > iommu/dma h
On Thu, Nov 29, 2018 at 12:24 PM Tomasz Figa wrote:
>
> [CC Marek]
>
> On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter wrote:
> >
> > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig wrote:
> > >
> > > Note that one thing I'd like to avoid is exposing these funtions directly
> > > to drivers, as
On Thu, Nov 29, 2018 at 10:57 AM Christoph Hellwig wrote:
>
> On Thu, Nov 29, 2018 at 03:43:50PM +0100, Daniel Vetter wrote:
> > Yeah we had patches to add manual cache management code to drm, so we
> > don't have to abuse the dma streaming api anymore. Got shouted down.
> > Abusing the dma stream
MSM_SUBMIT_BO_DUMP flag so userspace can indicate
buffers that contain cmdstream (or are otherwise important to dump).
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem_submit.c | 5 -
drivers/gpu/drm/msm/msm_rd.c | 13 ++---
include/uapi/drm/msm_drm.h | 5 -
3 files
Prep work to add a way to get/set the GEM objects debug name.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.c | 25 -
include/uapi/drm/msm_drm.h| 17 -
2 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/msm
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 6ebbd5010722..782cc33916d6 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm
Add UAPI to get/set GEM objects' debug name.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.c | 36 ++-
include/uapi/drm/msm_drm.h| 2 ++
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gp
On Fri, Nov 30, 2018 at 10:14 AM Arnd Bergmann wrote:
>
> On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote:
> >
>
> > -
> > -#define MSM_INFO_FLAGS (MSM_INFO_IOVA)
> > +/* Get or set GEM buffer info. The requested value can be passed
> > + * directly
On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote:
>
> On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote:
> >
> > Signed-off-by: Rob Clark
> > ---
> > drivers/gpu/drm/msm/msm_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
On Fri, Nov 30, 2018 at 10:36 AM Arnd Bergmann wrote:
>
> On Fri, Nov 30, 2018 at 4:31 PM Rob Clark wrote:
> >
> > On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote:
> > >
> > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote:
>
, 2018 at 11:40 AM Jordan Crouse
> > > > wrote:
> > > >>
> > > >> On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote:
> > > >>> On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig
> > > >>> wrote:
> > > &
601 - 700 of 2689 matches
Mail list logo
