[PATCH v3] drm/sched: Use struct for drm_sched_init() params

2025-02-07 Thread Philipp Stanner
_init()"). Introduce a new struct for the scheduler init parameters and port all users. Signed-off-by: Philipp Stanner Reviewed-by: Liviu Dudau Acked-by: Matthew Brost # for Xe Reviewed-by: Boris Brezillon # for Panfrost and Panthor Reviewed-by: Christian Gmeiner # for Etnaviv Reviewed

[PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-11 Thread Philipp Stanner
me in nouveau_sched_init()"). Introduce a new struct for the scheduler init parameters and port all users. Signed-off-by: Philipp Stanner Reviewed-by: Liviu Dudau Acked-by: Matthew Brost # for Xe Reviewed-by: Boris Brezillon # for Panfrost and Panthor Reviewed-by: Christian Gmeiner # for Etnavi

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-12 Thread Philipp Stanner
On Tue, 2025-02-11 at 12:14 +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming,

[PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-22 Thread Philipp Stanner
me in nouveau_sched_init()"). Introduce a new struct for the scheduler init parameters and port all users. Signed-off-by: Philipp Stanner --- Howdy, I have a patch-series in the pipe that will add a `flags` argument to drm_sched_init(). I thought it would be wise to first rework the API as detailed in this p

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 09:10 +0100, Philipp Stanner wrote: > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > Hi Philipp, > > > > On 22/01/25 11:08, Philipp Stanner wrote: > > > drm_sched_init() has a great many parameters and upcoming new > > > fu

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > On Wed, 22 Jan 2025 15:08:20 +0100 > Philipp Stanner wrote: > > >  int drm_sched_init(struct drm_gpu_scheduler *sched, > > -    const struct drm_sched_backend_ops *ops, > > -    struct workqueue_struct *subm

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 16:06 +0100, Christian König wrote: > Am 22.01.25 um 15:48 schrieb Philipp Stanner: > > On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > > > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > > > drm_sched_init() has a great ma

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 15:34 +0100, Christian König wrote: > Am 22.01.25 um 15:08 schrieb Philipp Stanner: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of parameters re

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 08:10 -0300, Maíra Canal wrote: > Hi Philipp, > > On 23/01/25 05:10, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > > > Hi Philipp, > > > > > > On 22/01/25 11:08, Philipp Stanner wrote: > >

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Wed, 2025-01-22 at 19:07 -0300, Maíra Canal wrote: > Hi Philipp, > > On 22/01/25 11:08, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great n

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
t; > On Wed, 22 Jan 2025 15:08:20 +0100 > > > > Philipp Stanner wrote: > > > >   > > > > > --- a/drivers/gpu/drm/panthor/panthor_sched.c > > > > > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > > > > > @@ -3272,6 +3272,7 @@ group_creat

Re: [PATCH] drm/sched: Use struct for drm_sched_init() params

2025-01-23 Thread Philipp Stanner
On Thu, 2025-01-23 at 10:29 +0100, Danilo Krummrich wrote: > On Thu, Jan 23, 2025 at 08:33:01AM +0100, Philipp Stanner wrote: > > On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > > > On Wed, 22 Jan 2025 15:08:20 +0100 > > > Philipp Stanner wrote: > &g

[PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-28 Thread Philipp Stanner
me in nouveau_sched_init()"). Introduce a new struct for the scheduler init parameters and port all users. Signed-off-by: Philipp Stanner --- Changes in v2: - Point out that the hang-limit is deprecated. (Christian) - Initialize the structs to 0 at declaration. (Planet Earth) - Don't set stuff

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Philipp Stanner
On Tue, 2025-01-28 at 15:56 +0100, Danilo Krummrich wrote: > On Tue, Jan 28, 2025 at 03:29:27PM +0100, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great

Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params

2025-01-29 Thread Philipp Stanner
On Wed, 2025-01-29 at 07:53 -0300, Maíra Canal wrote: > Hi Philipp, > > On 28/01/25 11:29, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great n

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: > Am 09.04.25 um 14:56 schrieb Philipp Stanner: > > On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: > > > On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > > > > Hi Philipp, > > >

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: > On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > > Hi Philipp, > > > > On Wed,  9 Apr 2025 14:06:37 +0200 > > Philipp Stanner wrote: > > > > > dma_fence_is_signaled()'s nam

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > Hi Philipp, > > On Wed,  9 Apr 2025 14:06:37 +0200 > Philipp Stanner wrote: > > > dma_fence_is_signaled()'s name strongly reads as if this function > > were > > intended for checking whether

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-10 Thread Philipp Stanner
On Wed, 2025-04-09 at 16:10 +0200, Christian König wrote: > Am 09.04.25 um 16:01 schrieb Philipp Stanner: > > On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: > > > Am 09.04.25 um 14:56 schrieb Philipp Stanner: > > > > On Wed, 2025-04-09 at 14:51 +0200, Phili

Re: [PATCH v8 00/10] Improve gpu_scheduler trace events + UAPI

2025-04-09 Thread Philipp Stanner
On Wed, 2025-04-09 at 09:52 +0200, Pierre-Eric Pelloux-Prayer wrote: > Hi, > > I've rebased the series on top of drm-next, applied the minor tweaks > suggested by Tvrtko on v8 and > the R-b tags. The result can be found on gitlab.fdo: > > https://gitlab.freedesktop.org/pepp/linux/-/commits/impro

[PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
nouveau_fence_done() uses the function to check a fence, which causes a race. Give the function a more obvious name. Signed-off-by: Philipp Stanner --- drivers/dma-buf/dma-fence-array.c | 2 +- drivers/dma-buf/dma-fence-chain.c | 6 +++--- drivers/dma-buf/dma-

[PATCH 0/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
at it becomes very, very explicit when reading code that this is a place where fences can get signaled. This series obsoletes this patch: [2] P. [1] https://lore.kernel.org/all/20250403101353.42880-2-pha...@kernel.org/ [2] https://lore.kernel.org/all/20250408122217.61530-2-pha...@kernel.org/ Ph

[PATCH 2/2] dma-fence: Improve docu for dma_fence_check_and_signal()

2025-04-09 Thread Philipp Stanner
style. Signed-off-by: Philipp Stanner --- include/linux/dma-fence.h | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index dc2ad171458b..3df370b2cc7c 100644 --- a/include/linux/dma-fence.h +++ b/in

Re: [PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-05-14 Thread Philipp Stanner
On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote: > This will be used in a later commit to trace the drm client_id in > some of the gpu_scheduler trace events. > > This requires changing all the users of drm_sched_job_init to > add an extra parameter. > > The newly added drm_cl

Re: [PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-05-19 Thread Philipp Stanner
On Mon, 2025-05-19 at 13:02 +0200, Pierre-Eric Pelloux-Prayer wrote: > > > Le 15/05/2025 à 08:53, Pierre-Eric Pelloux-Prayer a écrit : > > Hi, > > > > Le 14/05/2025 à 14:44, Philipp Stanner a écrit : > > > On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pell

Re: [PATCH v4 04/40] drm/sched: Add enqueue credit limit

2025-05-15 Thread Philipp Stanner
Hello, On Wed, 2025-05-14 at 09:59 -0700, Rob Clark wrote: > From: Rob Clark > > Similar to the existing credit limit mechanism, but applying to jobs > enqueued to the scheduler but not yet run. > > The use case is to put an upper bound on preallocated, and > potentially > unneeded, pgtable pag

Re: [PATCH v11 00/10] Improve gpu_scheduler trace events + UAPI

2025-05-28 Thread Philipp Stanner
On Mon, 2025-05-26 at 14:54 +0200, Pierre-Eric Pelloux-Prayer wrote: > Hi, > > The initial goal of this series was to improve the drm and amdgpu > trace events to be able to expose more of the inner workings of > the scheduler and drivers to developers via tools. > > Then, the series evolved to b

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-07-09 Thread Philipp Stanner
On Tue, 2025-07-08 at 14:02 +0100, Tvrtko Ursulin wrote: > > > On 11/02/2025 11:14, Philipp Stanner wrote: > > drm_sched_init() has a great many parameters and upcoming new > > functionality for the scheduler might add even more. Generally, the > > great number of par