[Freedreno] [PATCH 02/10] drm: Rename plane atomic_check state names

2021-01-15 Thread Maxime Ripard
} Signed-off-by: Maxime Ripard --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++--- .../gpu/drm/arm/display/komeda/komeda_plane.c | 11 ++--- drivers/gpu/drm/arm/hdlcd_crtc.c | 18 drivers/gpu/drm/arm/malidp_planes.c | 36 drive

[Freedreno] [PATCH 04/10] drm/atomic: Pass the full state to planes atomic_check

2021-01-15 Thread Maxime Ripard
s on !include && adds_new_state @ @@ + #include #include Signed-off-by: Maxime Ripard --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +++- drivers/gpu/drm/arm/hdlcd_crtc.c | 4 +++- drivers/gpu/dr

Re: [Freedreno] [PATCH 02/10] drm: Rename plane atomic_check state names

2021-01-15 Thread Maxime Ripard
Hi, On Fri, Jan 15, 2021 at 02:46:36PM +0100, Thomas Zimmermann wrote: > Hi > > Am 15.01.21 um 13:56 schrieb Maxime Ripard: > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c > > b/drivers/gpu/drm/imx/ipuv3-plane.c > > index 8a4235d9d9f1..2cb09e9d9306 100644 > >

[Freedreno] [PATCH 08/10] drm: Rename plane->state variables in atomic update and disable

2021-01-15 Thread Maxime Ripard
func(struct drm_plane *plane, struct drm_plane_state *old_pstate) { <... - state + new_pstate ...> } Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_planes.c | 34 +++--- drivers/gpu/drm/armada/armada_overlay.c | 104 +

[Freedreno] [PATCH 01/10] drm/atomic: Pass the full state to planes async atomic check and update

2021-01-15 Thread Maxime Ripard
); <+... - plane_state->state + state ...+> } Signed-off-by: Maxime Ripard --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++- drivers/gpu/drm/drm_atomic_helper.c | 4 +- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 26 + drivers/gpu/drm/msm/di

[Freedreno] [PATCH 09/10] drm/atomic: Pass the full state to planes atomic disable and update

2021-01-15 Thread Maxime Ripard
lt;+... - plane_state->state + state ...+> } Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 +- .../gpu/drm/arm/display/komeda/komeda_plane.c | 2 +- drivers/gpu/drm/arm/hdlcd_crtc.c | 2 +- drivers/gpu/drm/arm/malidp_planes.c

[Freedreno] [PATCH 06/10] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-15 Thread Maxime Ripard
plane->state + old_plane_state ... } @ include depends on adds_old_state || replaces_old_state @ @@ #include @ no_include depends on !include && (adds_old_state || replaces_old_state) @ @@ + #include #include Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c

[Freedreno] [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-15 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arc/arcpgu_crtc.c | 4 +++- drivers/gpu/drm/arm/hdlcd_crtc.c| 3 ++- drivers/gpu/drm/arm/malidp_planes.c | 3 ++- drivers/gpu/drm/armada/armada_overlay.c | 3 ++- drivers/gpu/drm/armada/armada_plane.c

[Freedreno] [PATCH 05/10] drm: Use the state pointer directly in planes atomic_check

2021-01-15 Thread Maxime Ripard
e *plane_state = drm_atomic_get_new_plane_state(state, plane); <... - plane_state->state + state ...> } Signed-off-by: Maxime Ripard --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 +- drivers/gpu/drm/arm/hdlcd_crtc.c

Re: [Freedreno] [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-20 Thread Maxime Ripard
Hi Laurent, On Fri, Jan 15, 2021 at 11:20:21PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Fri, Jan 15, 2021 at 01:57:02PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > >

[Freedreno] [PATCH v2 01/11] drm/atomic: Pass the full state to planes async atomic check and update

2021-01-21 Thread Maxime Ripard
); <+... - plane_state->state + state ...+> } Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- Changes from v1: - Updated the comment according to Thomas suggestions --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++- drivers/gpu/drm/drm_atomic_helper.c

[Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-21 Thread Maxime Ripard
plane->state + old_plane_state ... } @ include depends on adds_old_state || replaces_old_state @ @@ #include @ no_include depends on !include && (adds_old_state || replaces_old_state) @ @@ + #include #include Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c

[Freedreno] [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-21 Thread Maxime Ripard
func(struct drm_plane *plane, struct drm_plane_state *old_pstate) { <... - state + new_pstate ...> } Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_planes.c | 34 +++--- drivers/gpu/drm/armada/armada_overlay.c | 104 +

[Freedreno] [PATCH v2 04/11] drm/atomic: Pass the full state to planes atomic_check

2021-01-21 Thread Maxime Ripard
de @ no_include depends on !include && adds_new_state @ @@ + #include #include Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Rewording and removal of a coccinelle rule suggested by Laurent --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

[Freedreno] [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer

2021-01-21 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arc/arcpgu_crtc.c | 4 +++- drivers/gpu/drm/arm/hdlcd_crtc.c| 3 ++- drivers/gpu/drm/arm/malidp_planes.c | 3 ++- drivers/gpu/drm/armada/armada_overlay.c | 3 ++- drivers/gpu/drm/armada/armada_plane.c

[Freedreno] [PATCH v2 02/11] drm: Rename plane atomic_check state names

2021-01-21 Thread Maxime Ripard
; } Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Updated the variable name in the comment in omapdrm --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++--- .../gpu/drm/arm/display/komeda/komeda_plane.c | 11 ++--- drivers/gpu/drm/arm/hdlcd_crtc.c

[Freedreno] [PATCH v2 05/11] drm: Use the state pointer directly in planes atomic_check

2021-01-21 Thread Maxime Ripard
e *plane_state = drm_atomic_get_new_plane_state(state, plane); <... - plane_state->state + state ...> } Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Fixed the formatting in zynqmp_disp --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu

[Freedreno] [PATCH v2 09/11] drm/atomic: Pass the full state to planes atomic disable and update

2021-01-21 Thread Maxime Ripard
te->state + state ...+> } Signed-off-by: Maxime Ripard --- Changes from v1: - Reintroduce the old_plane_state check in zynqmp_disp_crtc_atomic_disable --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 +- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 +-

Re: [Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-25 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:07:22PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be

Re: [Freedreno] [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-25 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > Some drivers are storing the plane->state pointer in atomic_update and > > atomic_disable in a variable simply called state, while the s

Re: [Freedreno] [PATCH v2] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-18 Thread Maxime Ripard
's probably not what you meant? With that fixed, Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update

2021-02-19 Thread Maxime Ripard
); <+... - plane_state->state + state ...+> } Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- Changes from v1: - Updated the comment according to Thomas suggestions --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++- drivers/gpu/drm/drm_atomic_helper.c

[Freedreno] [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-19 Thread Maxime Ripard
.. - plane->state + old_plane_state ...> } @ include depends on adds_old_state || replaces_old_state @ @@ #include @ no_include depends on !include && (adds_old_state || replaces_old_state) @ @@ + #include #include Reviewed-by: Ville Syrjälä Signed-off-by: Maxime

[Freedreno] [PATCH v3 08/11] drm: Rename plane->state variables in atomic update and disable

2021-02-19 Thread Maxime Ripard
func(struct drm_plane *plane, struct drm_plane_state *old_pstate) { <... - state + new_pstate ...> } Reviewed-by: Ville Syrjälä Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_planes.c | 34 +++--- drivers/gpu/drm/armada/armada_overlay.c

Re: [Freedreno] [PATCH v3 02/11] drm: Rename plane atomic_check state names

2021-02-19 Thread Maxime Ripard
Hi Thomas, Thanks for your review! On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote: > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c > > b/drivers/gpu/drm/imx/ipuv3-plane.c > > index 075508051b5f..1873a155bb26 100644 > > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > > +++ b/drive

[Freedreno] [PATCH v3 02/11] drm: Rename plane atomic_check state names

2021-02-19 Thread Maxime Ripard
; } Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Updated the variable name in the comment in omapdrm --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++--- .../gpu/drm/arm/display/komeda/komeda_plane.c | 11 ++--- drivers/gpu/drm/arm/hdlcd_crtc.c

[Freedreno] [PATCH v3 05/11] drm: Use the state pointer directly in planes atomic_check

2021-02-19 Thread Maxime Ripard
e *plane_state = drm_atomic_get_new_plane_state(state, plane); <... - plane_state->state + state ...> } Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Fixed the formatting in zynqmp_disp --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu

[Freedreno] [PATCH v3 04/11] drm/atomic: Pass the full state to planes atomic_check

2021-02-19 Thread Maxime Ripard
de @ no_include depends on !include && adds_new_state @ @@ + #include #include Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Rewording and removal of a coccinelle rule suggested by Laurent --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

[Freedreno] [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-02-19 Thread Maxime Ripard
Reviewed-by: Ville Syrjälä Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arc/arcpgu_crtc.c | 4 +++- drivers/gpu/drm/arm/hdlcd_crtc.c| 3 ++- drivers/gpu/drm/arm/malidp_planes.c | 3 ++- drivers/gpu/drm/armada/armada_overlay.c | 3 ++- drivers/

[Freedreno] [PATCH v3 09/11] drm/atomic: Pass the full state to planes atomic disable and update

2021-02-19 Thread Maxime Ripard
->state + state ...+> } Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Reintroduce the old_plane_state check in zynqmp_disp_crtc_atomic_disable --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 +- drivers/gpu/drm/arm/disp

Re: [Freedreno] [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-23 Thread Maxime Ripard
Hi Thomas, On Mon, Feb 22, 2021 at 10:12:49AM +0100, Thomas Zimmermann wrote: > Am 19.02.21 um 13:00 schrieb Maxime Ripard: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be the old >

Re: [Freedreno] [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update

2021-02-24 Thread Maxime Ripard
Hi, On Wed, Feb 24, 2021 at 12:33:45PM +0100, Thomas Zimmermann wrote: > Hi Maxime, > > for the whole series: > > Acked-by: Thomas Zimmermann Applied the whole series, thanks to everyone involved in the review, it's been a pretty daunting one :) Maxime signature.asc Description: PGP signatu

Re: [Freedreno] [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-30 Thread Maxime Ripard
Hi Stephen, On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > Trimming Cc list way down, sorry if that's too much. > > Quoting Maxime Ripard (2021-02-19 04:00:30) > > Many drivers reference the plane->state pointer in order to get the > > current plane

Re: [Freedreno] [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-04-08 Thread Maxime Ripard
Hi Stephen, On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-03-30 08:35:27) > > Hi Stephen, > > > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > Trimming Cc list way down, sorry if that's to

Re: [Freedreno] [PATCH] drm/msm/dpu: Delete bonkers code

2021-05-03 Thread Maxime Ripard
Hi, On Fri, Apr 30, 2021 at 10:44:53AM -0700, Stephen Boyd wrote: > Quoting Rob Clark (2021-04-30 10:17:39) > > From: Rob Clark > > > > dpu_crtc_atomic_flush() was directly poking it's attached planes in a > > code path that ended up in dpu_plane_atomic_update(), even if the plane > > was not inv

[Freedreno] [PATCH v4 20/24] drm/bridge: sn65dsi86: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 74 ++- 1

[Freedreno] [PATCH v4 03/24] drm/mipi-dsi: Create devm device registration

2021-09-10 Thread Maxime Ripard
call to mipi_dsi_device_unregister(). Let's create a device-managed variant of the registration function that will automatically unregister the device at unbind. Reviewed-by: Andrzej Hajda Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mipi_dsi.c

[Freedreno] [PATCH v4 04/24] drm/mipi-dsi: Create devm device attachment

2021-09-10 Thread Maxime Ripard
will automatically detach the device at unbind. Reviewed-by: Andrzej Hajda Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mipi_dsi.c | 35 ++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_ds

[Freedreno] [PATCH v4 09/24] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[Freedreno] [PATCH v4 18/24] drm/bridge: sn65dsi83: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 80 +++ 1

[Freedreno] [PATCH v4 19/24] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 +++--- 1 file changed, 7 insertions(+

[Freedreno] [PATCH v4 22/24] drm/bridge: tc358775: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 37 +-- 1

[Freedreno] [PATCH v4 07/24] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/bridge/ana

[Freedreno] [PATCH v4 13/24] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 38 +- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[Freedreno] [PATCH v4 14/24] drm/bridge: lt9611uxc: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 31 +- 1

[Freedreno] [PATCH v4 05/24] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 - drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[Freedreno] [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-10 Thread Maxime Ripard
following the same conventions, resulting in various incompatibilities between DSI hosts and devices. Now that we have a sequence agreed upon and documented, let's convert exynos to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 19 --- 1

[Freedreno] [PATCH v4 06/24] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 13 ++--- 1 file ch

[Freedreno] [PATCH v4 10/24] drm/bridge: lt8912b: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 11 +++ 1 file chang

[Freedreno] [PATCH v4 01/24] drm/bridge: Add documentation sections

2021-09-10 Thread Maxime Ripard
The bridge documentation overview is quite packed already, and we'll add some more documentation that isn't part of an overview at all. Let's add some sections to the documentation to separate each bits. Reviewed-by: Andrzej Hajda Reviewed-by: Sam Ravnborg Signed-off-by

[Freedreno] [PATCH v4 15/24] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device on removal. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --

[Freedreno] [PATCH v4 11/24] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-10 Thread Maxime Ripard
the two patches that were reverting that commit - Add some documentation - Make drm_panel_attach and _detach succeed when no callback is there Maxime Ripard (24): drm/bridge: Add documentation sections drm/bridge: Document the probe issue with MIPI-DSI bridges drm/mipi-dsi: Create

[Freedreno] [PATCH v4 16/24] drm/bridge: ps8640: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 97 +++--- 1

[Freedreno] [PATCH v4 17/24] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge but don't remove its driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 12 +++- 1 file

[Freedreno] [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-10 Thread Maxime Ripard
Interactions between bridges, panels, MIPI-DSI host and the component framework are not trivial and can lead to probing issues when implementing a display driver. Let's document the various cases we need too consider, and the solution to support all the cases. Signed-off-by: Maxime R

[Freedreno] [PATCH v4 23/24] drm/kirin: dsi: Adjust probe order

2021-09-10 Thread Maxime Ripard
following the same conventions, resulting in various incompatibilities between DSI hosts and devices. Now that we have a sequence agreed upon and documented, let's convert kirin to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 27 +++- 1

[Freedreno] [PATCH v4 12/24] drm/bridge: lt9611: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 38 - 1

[Freedreno] [PATCH v4 08/24] drm/bridge: anx7625: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 ++-- 1

[Freedreno] [PATCH v4 21/24] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-)

Re: [Freedreno] [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-14 Thread Maxime Ripard
Hi, On Mon, Sep 13, 2021 at 08:29:37AM +0200, Andrzej Hajda wrote: > > W dniu 10.09.2021 o 12:11, Maxime Ripard pisze: > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when > > imple

Re: [Freedreno] [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-22 Thread Maxime Ripard
Hi Marek, On Fri, Sep 17, 2021 at 02:35:05PM +0200, Marek Szyprowski wrote: > Hi, > > On 13.09.2021 12:30, Andrzej Hajda wrote: > > W dniu 10.09.2021 o 12:12, Maxime Ripard pisze: > >> Without proper care and an agreement between how DSI hosts and devices > >>

Re: [Freedreno] [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-22 Thread Maxime Ripard
Hi, On Tue, Sep 14, 2021 at 09:00:28PM +0200, Andrzej Hajda wrote: > > W dniu 14.09.2021 o 16:35, Maxime Ripard pisze: > > Hi, > > > > On Mon, Sep 13, 2021 at 08:29:37AM +0200, Andrzej Hajda wrote: > >> W dniu 10.09.2021 o 12:11, Maxime Ripard pisze: > >

Re: [Freedreno] [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-23 Thread Maxime Ripard
Hi, On Tue, Sep 21, 2021 at 03:42:05PM -0700, Rob Clark wrote: > On Tue, Sep 21, 2021 at 3:20 PM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > Slightly awkward to fish out the display_info when we aren't creatin

Re: [Freedreno] (subset) [PATCH v4 01/24] drm/bridge: Add documentation sections

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:55 +0200, Maxime Ripard wrote: > The bridge documentation overview is quite packed already, and we'll add > some more documentation that isn't part of an overview at all. > > Let's add some sections to the documentation to separate each bits

Re: [Freedreno] (subset) [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:56 +0200, Maxime Ripard wrote: > Interactions between bridges, panels, MIPI-DSI host and the component > framework are not trivial and can lead to probing issues when > implementing a display driver. Let's document the various cases we need > too

Re: [Freedreno] (subset) [PATCH v4 03/24] drm/mipi-dsi: Create devm device registration

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:57 +0200, Maxime Ripard wrote: > Devices that take their data through the MIPI-DSI bus but are controlled > through a secondary bus like I2C have to register a secondary device on > the MIPI-DSI bus through the mipi_dsi_device_register_full() function. > >

Re: [Freedreno] (subset) [PATCH v4 04/24] drm/mipi-dsi: Create devm device attachment

2021-09-24 Thread Maxime Ripard
On Fri, 10 Sep 2021 12:11:58 +0200, Maxime Ripard wrote: > MIPI-DSI devices need to call mipi_dsi_attach() when their probe is done > to attach against their host. > > However, at removal or when an error occurs, that attachment needs to be > undone through a call to mipi_dsi_detac

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-10-13 Thread Maxime Ripard
Hi John, On Wed, Sep 29, 2021 at 04:29:42PM -0700, John Stultz wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > wrote: > > >

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-10-13 Thread Maxime Ripard
; > > > > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz > > > > wrote: > > > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > > > wrote: > > > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard &

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-10-18 Thread Maxime Ripard
Hi Rob, On Wed, Oct 13, 2021 at 05:16:58PM -0700, Rob Clark wrote: > On Wed, Oct 13, 2021 at 7:16 AM Maxime Ripard wrote: > > > > Hi Caleb, > > > > On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote: > > > Hi, > > > > > > On 3

[Freedreno] [PATCH v5 06/21] drm/bridge: lt8912b: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c

[Freedreno] [PATCH v5 00/21] drm/bridge: Make panel and bridge probe order consistent

2021-10-21 Thread Maxime Ripard
ch and _detach succeed when no callback is there Maxime Ripard (20): drm/bridge: adv7533: Switch to devm MIPI-DSI helpers drm/bridge: adv7511: Register and attach our DSI device at probe drm/bridge: anx7625: Switch to devm MIPI-DSI helpers drm/bridge: anx7625: Register and attach our DSI device

[Freedreno] [PATCH v5 07/21] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 24 1 file changed, 4 insertions(+), 20 dele

[Freedreno] [PATCH v5 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ad

[Freedreno] [PATCH v5 03/21] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/driver

[Freedreno] [PATCH v5 09/21] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 38 +- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/driver

[Freedreno] [PATCH v5 05/21] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gp

[Freedreno] [PATCH v5 04/21] drm/bridge: anx7625: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c

[Freedreno] [PATCH v5 01/21] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511.h

[Freedreno] [PATCH v5 08/21] drm/bridge: lt9611: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lo

[Freedreno] [PATCH v5 19/21] drm/bridge: tc358775: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c

[Freedreno] [PATCH v5 17/21] drm/bridge: sn65dsi86: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c

[Freedreno] [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal

2021-10-21 Thread Maxime Ripard
ld thus be removed as part of its remove callback. Cc: Marek Vasut Fixes: 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach callback") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[Freedreno] [PATCH v5 15/21] drm/bridge: sn65dsi83: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/brid

[Freedreno] [PATCH v5 10/21] drm/bridge: lt9611uxc: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c

[Freedreno] [PATCH v5 21/21] drm/msm/dsi: Adjust probe order

2021-10-21 Thread Maxime Ripard
From: Rob Clark Switch to the documented order dsi-host vs bridge probe. Tested-by: Amit Pundir Tested-by: Caleb Connolly Tested-by: John Stultz Signed-off-by: Rob Clark Signed-off-by: Maxime Ripard --- drivers/gpu/drm/msm/dsi/dsi.c | 50 --- drivers/gpu

[Freedreno] [PATCH v5 16/21] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 +++--- 1 file ch

[Freedreno] [PATCH v5 11/21] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device on removal. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 15 +-- 1 file changed, 5 insertions(+

[Freedreno] [PATCH v5 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c

[Freedreno] [PATCH v5 20/21] drm/kirin: dsi: Adjust probe order

2021-10-21 Thread Maxime Ripard
following the same conventions, resulting in various incompatibilities between DSI hosts and devices. Now that we have a sequence agreed upon and documented, let's convert kirin to it. Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

[Freedreno] [PATCH v5 14/21] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge but don't remove its driver. Acked-by: Sam Ravnborg Tested-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm

[Freedreno] [PATCH v5 18/21] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 13 - 1 file changed, 4 inser

[Freedreno] [PATCH v6 01/21] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers

2021-10-25 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511.h

[Freedreno] [PATCH v6 00/21] drm/bridge: Make panel and bridge probe order consistent

2021-10-25 Thread Maxime Ripard
were reverting that commit - Add some documentation - Make drm_panel_attach and _detach succeed when no callback is there Maxime Ripard (20): drm/bridge: adv7533: Switch to devm MIPI-DSI helpers drm/bridge: adv7511: Register and attach our DSI device at probe drm/bridge: anx7625: Switch

[Freedreno] [PATCH v6 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-10-25 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ad

[Freedreno] [PATCH v6 03/21] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers

2021-10-25 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/driver

[Freedreno] [PATCH v6 04/21] drm/bridge: anx7625: Register and attach our DSI device at probe

2021-10-25 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c

[Freedreno] [PATCH v6 05/21] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers

2021-10-25 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gp

[Freedreno] [PATCH v6 07/21] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers

2021-10-25 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 24 1 file changed, 4 insertions(+), 20 dele

  1   2   3   >