Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-23 Thread Kuogee Hsieh
On 1/22/2024 4:23 PM, Dmitry Baryshkov wrote: On Tue, 23 Jan 2024 at 01:20, Kuogee Hsieh wrote: On 1/22/2024 9:28 AM, Kuogee Hsieh wrote: On 1/19/2024 6:31 PM, Dmitry Baryshkov wrote: On Fri, 19 Jan 2024 at 23:14, Kuogee Hsieh wrote: Dmitry, I am testing this patch serial with msm-next

Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-25 Thread Kuogee Hsieh
On 1/24/2024 11:07 AM, Dmitry Baryshkov wrote: On Tue, 23 Jan 2024 at 19:31, Kuogee Hsieh wrote: On 1/22/2024 4:23 PM, Dmitry Baryshkov wrote: On Tue, 23 Jan 2024 at 01:20, Kuogee Hsieh wrote: On 1/22/2024 9:28 AM, Kuogee Hsieh wrote: On 1/19/2024 6:31 PM, Dmitry Baryshkov wrote: On

Re: [PATCH RESEND v3 01/15] drm/msm/dp: drop unused parser definitions

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Drop several unused and obsolete definitions from the dp_parser module. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_parser.h | 46

Re: [PATCH RESEND v3 02/15] drm/msm/dp: drop unused fields from dp_power_private

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Drop unused and obsolete fields from struct dp_power_private. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_power.c | 3 --- 1 file changed, 3

Re: [PATCH RESEND v3 03/15] drm/msm/dp: parse DT from dp_parser_get

2024-01-26 Thread Kuogee Hsieh
-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 6 -- drivers/gpu/drm/msm/dp/dp_parser.c | 8 +++- drivers/gpu/drm/msm/dp/dp_parser.h | 3 --- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers

Re: [PATCH RESEND v3 04/15] drm/msm/dp: inline dp_power_(de)init

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: In preparation to cleanup of the dp_power module, inline dp_power_init() and dp_power_deinit() functions, which are now just turning the clocks on and off. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh

Re: [PATCH RESEND v3 05/15] drm/msm/dp: fold dp_power into dp_ctrl module

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: The dp_power submodule is limited to handling the clocks only following previous cleanups. Fold it into the dp_ctrl submodule, removing one unnecessary level of indirection. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by

Re: [PATCH RESEND v3 06/15] drm/msm/dp: simplify stream clocks handling

2024-01-26 Thread Kuogee Hsieh
Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 91 -- drivers/gpu/drm/msm/dp/dp_parser.c | 41 - drivers/gpu/drm/msm/dp/dp_parser.h | 2 - 3 files changed, 47 insertions(+), 87 deletions

Re: [PATCH RESEND v3 07/15] drm/msm/dp: stop parsing clock names from DT

2024-01-26 Thread Kuogee Hsieh
can be moved to the device data. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 ++-- drivers/gpu/drm/msm/dp/dp_ctrl.h | 6 ++ drivers/gpu/drm/msm/dp/dp_parser.c | 112

Re: [PATCH RESEND v3 08/15] drm/msm/dp: split dp_ctrl_clk_enable into four functuions

2024-01-26 Thread Kuogee Hsieh
. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 220 +--- drivers/gpu/drm/msm/dp/dp_ctrl.h| 16 +-- drivers/gpu/drm/msm/dp/dp_display.c | 4 +- 3 files changed, 108 insertions

Re: [PATCH RESEND v3 09/15] drm/msm/dp: move phy_configure_opts to dp_ctrl

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: There is little point in sharing phy configuration structure between several modules. Move it to dp_ctrl, which becomes the only submodule re-configuring the PHY. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee

Re: [PATCH RESEND v3 10/15] drm/msm/dp: remove PHY handling from dp_catalog.c

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Inline dp_catalog_aux_update_cfg() and call phy_calibrate() from dp_aux functions directly. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_aux.c | 9 +++-- drivers

Re: [PATCH RESEND v3 11/15] drm/msm/dp: handle PHY directly in dp_ctrl

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: There is little point in going trough dp_parser->io indirection each time the driver needs to access the PHY. Store the pointer directly in dp_ctrl_private. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hs

Re: [PATCH RESEND v3 12/15] drm/msm/dp: move all IO handling to dp_catalog

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Rather than parsing the I/O addresses from dp_parser and then passing them via a struct pointer to dp_catalog, handle I/O region parsing in dp_catalog and drop it from dp_parser. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed

Re: [PATCH RESEND v3 13/15] drm/msm/dp: move link property handling to dp_panel

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Instead of passing link properties through the separate struct, parse them directly in the dp_panel. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 8

Re: [PATCH RESEND v3 14/15] drm/msm/dp: move next_bridge handling to dp_display

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Remove two levels of indirection and fetch next bridge directly in dp_display_probe_tail(). Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 43

Re: [PATCH RESEND v3 15/15] drm/msm/dp: drop dp_parser

2024-01-26 Thread Kuogee Hsieh
On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote: Finally drop separate "parsing" submodule. There is no need in it anymore. All submodules handle DT properties directly rather than passing them via the separate structure pointer. Signed-off-by: Dmitry Baryshkov Tested-by: Ku

Re: [RFC PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-11 Thread Kuogee Hsieh
] : https://lore.kernel.org/all/1664408211-25314-1-git-send-email-quic_khs...@quicinc.com/ Signed-off-by: Abhinav Kumar Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-11 Thread Kuogee Hsieh
://lore.kernel.org/all/1664408211-25314-1-git-send-email-quic_khs...@quicinc.com/ Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Signed-off-by: Abhinav Kumar Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp

[PATCH v1] drm/msm/dp: assign correct DP controller ID to interface table

2024-03-28 Thread Kuogee Hsieh
to DP controller to complete x1e80100 interface table. Signed-off-by: Kuogee Hsieh --- .../drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 34 -- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h b

[PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Kuogee Hsieh
context. Since they are executed under thread context already, there is no reason to hand over those events to hpd_event_thread. Hence dp_hpd_plug_handle() and dp_hpd_unplug_hanlde() are called directly at dp_bridge_hpd_notify(). Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp

[PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Kuogee Hsieh
Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 5 +++--

[PATCH v2] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-29 Thread Kuogee Hsieh
Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") Signe

[PATCH v2] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-03-29 Thread Kuogee Hsieh
to DP controller to complete x1e80100 interface table. Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") Signed-off-by: Kuogee Hsieh Reviewed-by: Abhinav Kumar Reviewed-by: Abel Vesa --- .../drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 34 -- 1 file c

[PATCH v3] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-03-29 Thread Kuogee Hsieh
to DP controller to complete x1e80100 interface table. Changs in V3: -- add v2 changes log Changs in V2: -- add x1e80100 to subject -- add Fixes Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") Signed-off-by: Kuogee Hsieh Reviewed-by: Abhinav Kumar Reviewed-by: Abel Vesa --

[PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-29 Thread Kuogee Hsieh
r() to qmp_v3_configure_dp_phy() -- add dev_err() to qmp_v4_configure_dp_phy() Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") Signed-off-by: Kuogee Hsieh Reviewed-by: Abhinav Kumar --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 13 + 1 file changed, 9

Re: [PATCH] drm/msm/dp: allow voltage swing / pre emphasis of 3

2024-04-01 Thread Kuogee Hsieh
m/msm/dp: add displayPort driver support") Signed-off-by: Dmitry Baryshkov Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_link.c | 22 +++--- drivers/gpu/drm/msm/dp/dp_link.h | 14 +- 3 files c

Re: [PATCH] drm/msm/dp: allow voltage swing / pre emphasis of 3

2024-04-01 Thread Kuogee Hsieh
On 4/1/2024 9:25 AM, Kuogee Hsieh wrote: On 2/3/2024 5:47 AM, Dmitry Baryshkov wrote: Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and pre-emphasis to 2, while the real maximum value for the sum of the voltage swing and pre-emphasis is 3. Fix the DP code to remove this

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Kuogee Hsieh
Dmitry, Any more comments? On 3/29/2024 12:50 PM, Kuogee Hsieh wrote: Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Changes in V3: --

Re: [PATCH v3] drm/msm/dp: assign correct DP controller ID to x1e80100 interface table

2024-04-03 Thread Kuogee Hsieh
Dmitry, any more comments? On 3/29/2024 12:46 PM, Kuogee Hsieh wrote: At current x1e80100 interface table, interface #3 is wrongly connected to DP controller #0 and interface #4 wrongly connected to DP controller #2. Fix this problem by connect Interface #3 to DP controller #0 and interface #4

[Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-11 Thread Kuogee Hsieh
xes: ede3c6bb00c ("drm/msm/disp/dpu1: Add DSC support in hw_ctl") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_h

[Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Kuogee Hsieh
Perform DSC range checking to make sure correct DSC is requested before reserve resource for it. Fixes: c985d7bb64ff ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 10 +- 1 file changed, 9 insertions(+),

[Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-13 Thread Kuogee Hsieh
V2: 1) correct commit text as suggested 2) correct Fixes commit id 3) add FIXME comment Fixes: 77f6da90487c ("drm/msm/disp/dpu1: Add DSC support in hw_ctl") Signed-off-by: Kuogee Hsieh Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 8 1 fi

[Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Kuogee Hsieh
[1], clear DSC active bit will handled at reset_intf_cfg() Signed-off-by: Kuogee Hsieh Fixes: 77f6da90487c ("drm/msm/disp/dpu1: Add DSC support in hw_ctl") Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten [1] https://lore.kernel.org/linux-arm-msm/ec045d6b-4ffd-0f8c-4

[Freedreno] [PATCH v1 0/5] add DSC 1.2 dpu supports

2023-04-20 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. Abhinav Kumar (1): drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (4

[Freedreno] [PATCH v1 2/5] drm/msm/dpu: separate DSC flush update out of interface

2023-04-20 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10 ++ 3 files changed, 38

[Freedreno] [PATCH v1 3/5] drm/msm/dpu: save dpu topology configuration

2023-04-20 Thread Kuogee Hsieh
At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 ++--- 1 file

[Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-20 Thread Kuogee Hsieh
Kumar Signed-off-by: Kuogee Hsieh --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 19 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 11 +++ .../drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h| 21 + .../gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-20 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 38 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 17

[Freedreno] [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-20 Thread Kuogee Hsieh
During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 - 1 file changed, 32 insertions(+), 24 deletions

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-21 Thread Kuogee Hsieh
On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh ---   drivers/gpu/drm/msm/disp/dpu1

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-21 Thread Kuogee Hsieh
On 4/21/2023 2:13 PM, Dmitry Baryshkov wrote: On 22/04/2023 00:07, Kuogee Hsieh wrote: On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Kuogee Hsieh
On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Kuogee Hsieh
On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Kuogee Hsieh
On 4/21/2023 4:11 PM, Dmitry Baryshkov wrote: On 22/04/2023 02:08, Kuogee Hsieh wrote: On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-24 Thread Kuogee Hsieh
On 4/21/2023 4:22 PM, Dmitry Baryshkov wrote: On 22/04/2023 02:16, Kuogee Hsieh wrote: On 4/21/2023 4:11 PM, Dmitry Baryshkov wrote: On 22/04/2023 02:08, Kuogee Hsieh wrote: On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-26 Thread Kuogee Hsieh
On 4/20/2023 4:54 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh ---   drivers/gpu/drm/msm/Makefile   |   1 +   drivers/gpu/drm/msm

[Freedreno] [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Kuogee Hsieh
://patchwork.freedesktop.org/series/116851/ [2]: https://patchwork.freedesktop.org/series/116615/ [3]: https://patchwork.freedesktop.org/series/112332/ Abhinav Kumar (2): drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets drm/msm/dpu: add dsc blocks for remaining chipsets in catalog Kuogee Hsieh (5): drm/msm

[Freedreno] [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-28 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 34 ++- drivers/gpu/drm/msm/disp

[Freedreno] [PATCH v2 3/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-28 Thread Kuogee Hsieh
Kumar Signed-off-by: Kuogee Hsieh --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 14 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 7 ++ .../drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 16 + .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h

[Freedreno] [PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Kuogee Hsieh
From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such a design add the dsc blocks for the chipsets for which DSC is present but was not added in the catalog. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0

[Freedreno] [PATCH v2 2/7] drm/msm/dpu: separate DSC flush update out of interface

2023-04-28 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10

[Freedreno] [PATCH v2 6/7] drm/msm/dpu: save dpu topology configuration

2023-04-28 Thread Kuogee Hsieh
At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 ++--- 1 file

[Freedreno] [PATCH v2 7/7] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-28 Thread Kuogee Hsieh
During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 - 1 file changed, 31 insertions(+), 25 deletions

[Freedreno] [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Kuogee Hsieh
: Kuogee Hsieh --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 12 +- .../gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 8 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 26 ++ .../drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h| 24

Re: [Freedreno] [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-01 Thread Kuogee Hsieh
On 4/28/2023 5:30 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot What exactly was reported? Signed-off-by: Kuogee Hsieh ---   drivers/gpu

Re: [Freedreno] [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-01 Thread Kuogee Hsieh
On 5/1/2023 1:50 PM, Dmitry Baryshkov wrote: On 01/05/2023 23:40, Kuogee Hsieh wrote: On 4/28/2023 5:30 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel

[Freedreno] [PATCH v3 0/7] add DSC 1.2 dpu supports

2023-05-02 Thread Kuogee Hsieh
://patchwork.freedesktop.org/series/116851/ [2]: https://patchwork.freedesktop.org/series/116615/ [3]: https://patchwork.freedesktop.org/series/112332/ Abhinav Kumar (2): drm/msm/dpu: add dsc blocks for remaining chipsets in catalog drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (5): drm

[Freedreno] [PATCH v3 1/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-02 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 7 +++ drivers/gpu/drm/ms

[Freedreno] [PATCH v3 2/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit

2023-05-02 Thread Kuogee Hsieh
Suijten Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 9 ++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp

[Freedreno] [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-02 Thread Kuogee Hsieh
presented. Signed-off-by: Kuogee Hsieh --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 12 +- .../gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 8 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 26 ++ .../drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h

[Freedreno] [PATCH v3 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-02 Thread Kuogee Hsieh
During DSC setup, the crossbar mux need to be programmed to engage DSC to specified PINGPONG. Hence during tear down, the crossbar mux need to be reset to disengage DSC from PINGPONG. This patch add PINGPONG_NONE to serve as disable to reset crossbar mux. Signed-off-by: Kuogee Hsieh --- drivers

[Freedreno] [PATCH v3 5/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-02 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Reported-by: kernel test robot Signed-off-

[Freedreno] [PATCH v3 6/7] drm/msm/dpu: separate DSC flush update out of interface

2023-05-02 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10

[Freedreno] [PATCH v3 7/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-02 Thread Kuogee Hsieh
Kumar Signed-off-by: Kuogee Hsieh --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 14 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 7 ++ .../drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 16 + .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h

Re: [Freedreno] [PATCH v3 5/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-02 Thread Kuogee Hsieh
On 5/2/2023 2:38 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:03, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not  

Re: [Freedreno] [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
On 5/2/2023 3:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:02, Kuogee Hsieh wrote: At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to complete DSC data path setup if this chipset has DSC hardware block presented. This patch add

Re: [Freedreno] [PATCH v3 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-03 Thread Kuogee Hsieh
On 5/3/2023 1:03 AM, Marijn Suijten wrote: On 2023-05-02 14:02:59, Kuogee Hsieh wrote: During DSC setup, the crossbar mux need to be programmed to engage DSC to specified PINGPONG. Hence during tear down, the crossbar mux need to be reset to disengage DSC from PINGPONG. This patch add

Re: [Freedreno] [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
On 5/3/2023 11:55 AM, Dmitry Baryshkov wrote: On 03/05/2023 20:45, Kuogee Hsieh wrote: On 5/2/2023 3:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:02, Kuogee Hsieh wrote: At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to

[Freedreno] [PATCH v4 0/7] add DSC 1.2 dpu supports

2023-05-03 Thread Kuogee Hsieh
: add dsc blocks for remaining chipsets in catalog drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (5): drm/msm/dpu: add DPU_PINGPONG_DSC feature bit drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos drm/msm/dpu: add PINGPONG_NONE to disconnect

[Freedreno] [PATCH v4 1/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-03 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |

[Freedreno] [PATCH v4 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
presented. Signed-off-by: Kuogee Hsieh --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 16 ++--- .../gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 8 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 26 ++ .../drm/msm/disp/dpu1/catalog

[Freedreno] [PATCH v4 2/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit

2023-05-03 Thread Kuogee Hsieh
ble() pingpong ops functions are required to complete DSC datapath setup and start DSC engine. Changes in v4: -- add more details commit text Reported-by: Marijn Suijten Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ drivers/

[Freedreno] [PATCH v4 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-03 Thread Kuogee Hsieh
as disable to reset crossbar mux. Changes in v4: -- more details to commit text Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ds

[Freedreno] [PATCH v4 6/7] drm/msm/dpu: separate DSC flush update out of interface

2023-05-03 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10

[Freedreno] [PATCH v4 7/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-03 Thread Kuogee Hsieh
: -- delete DPU_DSC_HW_REV_1_1 -- re arrange sc8280xp_dsc[] Signed-off-by: Abhinav Kumar Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 14 .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 7 ++ .../drm/msm/disp

[Freedreno] [PATCH v4 5/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-03 Thread Kuogee Hsieh
-- delete off and used real register name directly Reported-by: kernel test robot Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 32 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 14 +- drivers/g

[Freedreno] [PATCH v5 0/7] add DSC 1.2 dpu supports

2023-05-04 Thread Kuogee Hsieh
://patchwork.freedesktop.org/series/116851/ [2]: https://patchwork.freedesktop.org/series/116615/ [3]: https://patchwork.freedesktop.org/series/112332/ Abhinav Kumar (2): drm/msm/dpu: add dsc blocks for remaining chipsets in catalog drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (5

[Freedreno] [PATCH v5 1/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-04 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |

[Freedreno] [PATCH v5 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-04 Thread Kuogee Hsieh
presented. Signed-off-by: Kuogee Hsieh --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 16 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 16 +++ .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 24 +++--- .../drm/msm/disp/dpu1/catalog

[Freedreno] [PATCH v5 2/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit

2023-05-04 Thread Kuogee Hsieh
e details commit text Changes in v5: -- reword commit text suggested by Marijn -- delet comma -- use test_bit() Reported-by: Marijn Suijten Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 +++- drivers/gpu/drm/msm/

[Freedreno] [PATCH v5 4/7] drm/msm/dpu: Introduce PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-04 Thread Kuogee Hsieh
ing case Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 3 ++-

[Freedreno] [PATCH v5 6/7] drm/msm/dpu: separate DSC flush update out of interface

2023-05-04 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10

[Freedreno] [PATCH v5 5/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-04 Thread Kuogee Hsieh
-- delete off and used real register name directly Reported-by: kernel test robot Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 32 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 14 +- drivers/g

[Freedreno] [PATCH v5 7/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-04 Thread Kuogee Hsieh
: -- delete DPU_DSC_HW_REV_1_1 -- re arrange sc8280xp_dsc[] Signed-off-by: Abhinav Kumar Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 14 .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 7 ++ .../drm/msm/disp

[Freedreno] [PATCH v1 0/2] enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-10 Thread Kuogee Hsieh
There is bug report on exteranl DP display does not work. This patch add below two patches to fix the problem. 1) enable HDP plugin/unplugged interrupts to hpd_enable/disable 2) add mutex to protect internal_hpd against race condition between different threads Kuogee Hsieh (2): drm/msm/dp

[Freedreno] [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-10 Thread Kuogee Hsieh
/unplugged interrupts to dp_bridge_hpd_enable()/disable() to set internal_hpd to true along with enabling HPD plugin/unplugged interrupts simultaneously to avoid timing issue during bootup and resume. Fixes: cd198caddea7 ("drm/msm/dp: Rely on hpd_enable/disable callbacks") Signed-off-by: Ku

[Freedreno] [PATCH v1 2/2] drm/msm/dp: add mutex to protect internal_hpd against race condition between different threads

2023-05-10 Thread Kuogee Hsieh
Intrenal_hpd is referenced by event thread but set by drm bridge callback context. Add mutex to protect internal_hpd to avoid conflicts between threads. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

[Freedreno] [PATCH v6 0/8] add DSC 1.2 dpu supports

2023-05-10 Thread Kuogee Hsieh
://patchwork.freedesktop.org/series/116851/ [2]: https://patchwork.freedesktop.org/series/116615/ [3]: https://patchwork.freedesktop.org/series/112332/ Abhinav Kumar (2): drm/msm/dpu: add dsc blocks for remaining chipsets in catalog drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (6

[Freedreno] [PATCH v6 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-10 Thread Kuogee Hsieh
re bit to all chipset with DPU < 7.0.0. changes in v6: -- split patches and rearrange to keep catalog related files at this patch Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 +++- 2 file

[Freedreno] [PATCH v6 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-10 Thread Kuogee Hsieh
the ops of PINGPONG block accordingly if DPU_PINGPONG_DSC bit is set. changes in v6: -- split patches and keep the function file handles DPU_PINGPONG_DSC bit at this patch Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 6 ++ 1 file changed, 6 insertions(+) d

[Freedreno] [PATCH v6 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-10 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |

[Freedreno] [PATCH v6 4/8] drm/msm/dpu: Introduce PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-10 Thread Kuogee Hsieh
ing case Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 1 - drivers/gpu/drm/msm/dis

[Freedreno] [PATCH v6 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-10 Thread Kuogee Hsieh
-- delete off and used real register name directly Reported-by: kernel test robot Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 32 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 14 +- drivers/g

[Freedreno] [PATCH v6 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-10 Thread Kuogee Hsieh
programming of other dpu sub blocks. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 22 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10

[Freedreno] [PATCH v6 8/8] drm/msm/dpu: tear down DSC data path when DSC disabled

2023-05-10 Thread Kuogee Hsieh
Unset DSC_ACTIVE bit at dpu_hw_ctl_reset_intf_cfg_v1(), dpu_encoder_unprep_dsc() and dpu_encoder_dsc_pipe_clr() functions to tear down DSC data path if DSC data path was setup previous. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 44

[Freedreno] [PATCH v6 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-10 Thread Kuogee Hsieh
: -- delete DPU_DSC_HW_REV_1_1 -- re arrange sc8280xp_dsc[] Signed-off-by: Abhinav Kumar Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h | 14 .../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 7 ++ .../drm/msm/disp

Re: [Freedreno] [PATCH v1 2/2] drm/msm/dp: add mutex to protect internal_hpd against race condition between different threads

2023-05-10 Thread Kuogee Hsieh
Kuogee Hsieh (2023-05-10 13:31:05) Intrenal_hpd is referenced by event thread but set by drm bridge callback context. Add mutex to protect internal_hpd to avoid conflicts between threads. Signed-off-by: Kuogee Hsieh --- This patch looks completely unnecessary. How can dp_bridge_hpd_enable() be

Re: [Freedreno] [PATCH v6 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-11 Thread Kuogee Hsieh
On 5/10/2023 9:52 PM, Dmitry Baryshkov wrote: On 11/05/2023 01:07, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not  

[Freedreno] [PATCH v7 0/8] add DSC 1.2 dpu supports

2023-05-11 Thread Kuogee Hsieh
://patchwork.freedesktop.org/series/116851/ [2]: https://patchwork.freedesktop.org/series/116615/ [3]: https://patchwork.freedesktop.org/series/112332/ Abhinav Kumar (2): drm/msm/dpu: add dsc blocks for remaining chipsets in catalog drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (6

<    5   6   7   8   9   10   11   12   >