[Freedreno] [PATCH] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-14 Thread Kuogee Hsieh
when problem happen, EDID has corrupt header panel-simple-dp-aux aux-aea.edp: Couldn't identify panel via EDID panel-simple-dp-aux aux-aea.edp: error -EIO: Couldn't detect panel nor find a fallback Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_aux.c | 7 +++ 1

Re: [Freedreno] [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-14 Thread Kuogee Hsieh
On 12/13/2022 3:06 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-12-13 13:44:05) Add both data-lanes and link-frequencies property into endpoint Why do we care? Please tell us why it's important. Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link ra

Re: [Freedreno] [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-15 Thread Kuogee Hsieh
On 12/14/2022 4:38 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-12-14 14:56:23) On 12/13/2022 3:06 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-12-13 13:44:05) Add both data-lanes and link-frequencies property into endpoint Why do we care? Please tell us why it's impo

Re: [Freedreno] [PATCH] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
PM Kuogee Hsieh wrote: There are 3 possible interrupt sources are handled by DP controller, HPDstatus, Controller state changes and Aux read/write transaction. At every irq, DP controller have to check isr status of every interrupt sources and service the interrupt if its isr status bits shows

[Freedreno] [PATCH v2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
nel nor find a fallback Changes in v2: -- do complete if (ret == IRQ_HANDLED) ay dp-aux_isr() -- add more commit text Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh Tested-by: Douglas Anderson Reviewed-by: Abhinav Kumar --- drivers/gpu

Re: [Freedreno] [PATCH v2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
On 12/15/2022 12:10 PM, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-12-15 10:46:42) On 15/12/2022 20:32, Kuogee Hsieh wrote: if (!aux->cmd_busy) return; if (aux->native) - dp_aux_native_handler(aux, isr); +

[Freedreno] [PATCH v3] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
yPort driver support") Signed-off-by: Kuogee Hsieh Tested-by: Douglas Anderson Reviewed-by: Abhinav Kumar Suggested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 95 ++--- drivers/gpu/drm/msm/dp/dp_aux.h | 2 +- drivers/gpu/drm

Re: [Freedreno] [PATCH v2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
On 12/15/2022 1:15 PM, Dmitry Baryshkov wrote: On 15/12/2022 22:10, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-12-15 10:46:42) On 15/12/2022 20:32, Kuogee Hsieh wrote:    if (!aux->cmd_busy)    return;    if (aux->native) - dp_aux_native_handl

[Freedreno] [PATCH v4 1/2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
s: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh Tested-by: Douglas Anderson Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_aux.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/

[Freedreno] [PATCH v4 2/2] drm/msm/dp: enhance dp controller isr

2022-12-15 Thread Kuogee Hsieh
all isr return IRQ_HANDLED if there are interrupts had been serviced or IRQ_NONE otherwise. Signed-off-by: Kuogee Hsieh Suggested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 96 - drivers/gpu/drm/msm/dp/dp_aux.h | 2 +- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v4 0/2] do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
ignore spuriors isr at dp_aux_isr() to fixed eDP edid read failed Kuogee Hsieh (2): drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer drm/msm/dp: enhance dp controller isr drivers/gpu/drm/msm/dp/dp_aux.c | 98

[Freedreno] [PATCH v5 0/2] do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
ignore spuriors isr at dp_aux_isr() to fixed eDP edid read failed Kuogee Hsieh (2): drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer drm/msm/dp: enhance dp controller isr drivers/gpu/drm/msm/dp/dp_aux.c | 97

[Freedreno] [PATCH v5 1/2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-15 Thread Kuogee Hsieh
Changes in v5: -- delete empty line between tags Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh Tested-by: Douglas Anderson Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 4 1 file chang

[Freedreno] [PATCH v5 2/2] drm/msm/dp: enhance dp controller isr

2022-12-15 Thread Kuogee Hsieh
all isr return IRQ_HANDLED if there are interrupts had been serviced or IRQ_NONE otherwise. Changes in v5: -- move complete into dp_aux_native_handler() -- move complete into dp_aux_i2c_handler() -- restore null ctrl check at isr -- return IRQ_NODE directly Signed-off-by: Kuogee Hsieh Suggested-by

Re: [Freedreno] [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-16 Thread Kuogee Hsieh
On 12/15/2022 6:16 PM, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-12-15 13:12:49) On 15/12/2022 02:38, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-12-14 14:56:23) Once link training start, then there are no any interactions between controller and phy during link training session

[Freedreno] [PATCH v14 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (5): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint dt-bindings: msm/dp: add data-lanes and link-frequencies property drm/msm/dp: parse

[Freedreno] [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
(hz) for link-frequencies at dp_out at sc7180_trogdor.dtsi Changes in v13: -- delete an extra space at data-lanes Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 4 2 files changed, 9 insertions(+

[Freedreno] [PATCH v14 3/5] drm/msm/dp: parse data-lanes as property of dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
oint first Changes in v14: -- replace "parser" with "parse" at commit subject -- add matching brackets at dp_parser_misc() Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 25 + 1 file changed,

[Freedreno] [PATCH v14 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-16 Thread Kuogee Hsieh
: -- add "unevaluatedProperties: false: to endpoint at port@1 -- remove unnecessary quote to $ref -- re store "$ref: /schemas/graph.yaml#/properties/port" to port@0 Signed-off-by: Kuogee Hsieh --- .../bindings/display/msm/dp-controller.yaml| 26 -- 1 f

[Freedreno] [PATCH v14 4/5] drm/msm/dp: parse link-frequencies as property of dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
use do_div() for 64 bits division Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 28 drivers/gpu/drm/msm/dp/dp_parser.h | 2 ++ 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/dr

[Freedreno] [PATCH v14 5/5] drm/msm/dp: add support of max dp link rate

2022-12-16 Thread Kuogee Hsieh
max_dp_link_rate from dp_out endpoint Changes in v4: -- delete unnecessary pr_err Changes in v5: -- split parser function into different patch Changes in v9: -- revised commit test Changes in v13: -- repalced "properity" with "property" Signed-off-by: Kuogee Hsieh Reviewed-

[Freedreno] [PATCH v15 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (5): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint dt-bindings: msm/dp: add data-lanes and link-frequencies property drm/msm/dp: parse

[Freedreno] [PATCH v15 3/5] drm/msm/dp: parse data-lanes as property of dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
oint first Changes in v14: -- replace "parser" with "parse" at commit subject -- add matching brackets at dp_parser_misc() Changes in v15: -- concise dp_parser_misc() Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 22

[Freedreno] [PATCH v15 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-16 Thread Kuogee Hsieh
(hz) for link-frequencies at dp_out at sc7180_trogdor.dtsi Changes in v13: -- delete an extra space at data-lanes Changes in v15: -- replace space with tab at sc7180-trogdor.dtsi Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 arch/arm64/boot/dts/qcom/sc

[Freedreno] [PATCH v15 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-16 Thread Kuogee Hsieh
: -- add "unevaluatedProperties: false: to endpoint at port@1 -- remove unnecessary quote to $ref -- re store "$ref: /schemas/graph.yaml#/properties/port" to port@0 Changes in v15: -- re store desciption of port@0 Signed-off-by: Kuogee Hsieh --- .../bindings/display/msm/dp-

[Freedreno] [PATCH v15 4/5] Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint.

2022-12-16 Thread Kuogee Hsieh
v11: -- return 0 if(!endpoint) Changes in v12: -- replace khz with kbytes at dp_parser.h Changes in v14: -- replace "parser" with "parse" at commit subject -- use do_div() for 64 bits division Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[Freedreno] [PATCH v15 5/5] drm/msm/dp: add support of max dp link rate

2022-12-16 Thread Kuogee Hsieh
max_dp_link_rate from dp_out endpoint Changes in v4: -- delete unnecessary pr_err Changes in v5: -- split parser function into different patch Changes in v9: -- revised commit test Changes in v13: -- repalced "properity" with "property" Signed-off-by: Kuogee Hsieh Reviewed-

Re: [Freedreno] [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Kuogee Hsieh
On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: On 16/12/2022 20:11, Kuogee Hsieh wrote: Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out endpoint as well. The last frequency specified at link-frequencies will be the max link rate

[Freedreno] [PATCH v16 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2022-12-27 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (5): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint dt-bindings: msm/dp: add data-lanes and link-frequencies property drm/msm/dp: parse

[Freedreno] [PATCH v16 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-27 Thread Kuogee Hsieh
(hz) for link-frequencies at dp_out at sc7180_trogdor.dtsi Changes in v13: -- delete an extra space at data-lanes Changes in v15: -- replace space with tab at sc7180-trogdor.dtsi Changes in v16: -- rename dp_out with mdss_dp_Out and keep the order Signed-off-by: Kuogee Hsieh --- arch/arm64/boot

[Freedreno] [PATCH v16 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-27 Thread Kuogee Hsieh
: -- add "unevaluatedProperties: false: to endpoint at port@1 -- remove unnecessary quote to $ref -- re store "$ref: /schemas/graph.yaml#/properties/port" to port@0 Changes in v15: -- re store desciption of port@0 Signed-off-by: Kuogee Hsieh Reviewed-by: Rob Herring --- .../bindi

[Freedreno] [PATCH v16 3/5] drm/msm/dp: parse data-lanes as property of dp_out endpoint

2022-12-27 Thread Kuogee Hsieh
oint first Changes in v14: -- replace "parser" with "parse" at commit subject -- add matching brackets at dp_parser_misc() Changes in v15: -- concise dp_parser_misc() Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 22

[Freedreno] [PATCH v16 5/5] drm/msm/dp: add support of max dp link rate

2022-12-27 Thread Kuogee Hsieh
max_dp_link_rate from dp_out endpoint Changes in v4: -- delete unnecessary pr_err Changes in v5: -- split parser function into different patch Changes in v9: -- revised commit test Changes in v13: -- repalced "properity" with "property" Signed-off-by: Kuogee Hsieh Reviewed-

[Freedreno] [PATCH v16 4/5] Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint.

2022-12-27 Thread Kuogee Hsieh
v11: -- return 0 if(!endpoint) Changes in v12: -- replace khz with kbytes at dp_parser.h Changes in v14: -- replace "parser" with "parse" at commit subject -- use do_div() for 64 bits division Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[Freedreno] [PATCH v6 1/2] drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-27 Thread Kuogee Hsieh
ed line more than 75 char at commit text Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh Tested-by: Douglas Anderson Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 4 1 file changed,

[Freedreno] [PATCH v6 0/2] do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer

2022-12-27 Thread Kuogee Hsieh
ignore spuriors isr at dp_aux_isr() to fixed eDP edid read failed Kuogee Hsieh (2): drm/msm/dp: do not complete dp_aux_cmd_fifo_tx() if irq is not for aux transfer drm/msm/dp: enhance dp controller isr drivers/gpu/drm/msm/dp/dp_aux.c | 97

[Freedreno] [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2022-12-27 Thread Kuogee Hsieh
all isr return IRQ_HANDLED if there are interrupts had been serviced or IRQ_NONE otherwise. Changes in v5: -- move complete into dp_aux_native_handler() -- move complete into dp_aux_i2c_handler() -- restore null ctrl check at isr -- return IRQ_NODE directly Signed-off-by: Kuogee Hsieh Suggested-by

Re: [Freedreno] [PATCH v16 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2023-01-03 Thread Kuogee Hsieh
Hi Krzysztof/Dmitry, Would you please review this patch. Thanks, On 12/27/2022 9:44 AM, Kuogee Hsieh wrote: Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out endpoint as well. The last frequency specified at link-frequencies will be

Re: [Freedreno] [PATCH] drm/msm/dp: Remove INIT_SETUP delay

2023-01-17 Thread Kuogee Hsieh
ossible to boot with an external display on USB Type-C and have the display power up, without disconnecting and reconnecting the cable. Signed-off-by: Bjorn Andersson Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[Freedreno] [PATCH v1 00/14] add display port DSC feature

2023-01-23 Thread Kuogee Hsieh
This patch add DSC related supporting functions into to both dp controller and dpu enccoder Kuogee Hsieh (14): drm/msm/dp: add dpcd read of both dsc and fec capability drm/msm/dp: add dsc factor into calculation of supported bpp drm/msm/dp: add configure mainlink_levels base on lane number

[Freedreno] [PATCH v1 01/14] drm/msm/dp: add dpcd read of both dsc and fec capability

2023-01-23 Thread Kuogee Hsieh
FEC is pre-requirement of DSC. Therefore FEC has to be enabled before DSC enabled. This patch add functions to read sink's DSC and FEC related DPCD and decode them and set enable flags accordingly. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c

[Freedreno] [PATCH v1 02/14] drm/msm/dp: add dsc factor into calculation of supported bpp

2023-01-23 Thread Kuogee Hsieh
When FEC enabled, it introduces 2.5% overhead into link capacity. This factor have to be considered into calculation supported bpp. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c | 45 +-- 1 file changed, 38 insertions(+), 7 deletions

[Freedreno] [PATCH v1 04/14] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2023-01-23 Thread Kuogee Hsieh
MSA MISC0 bit 1 to 7 contains Colorimetry Indicator Field. At current implementation, Colorimetry Indicator Field of MISC0 is not configured correctly. This patch add support of RGB formats Colorimetry. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 5 +++-- drivers/gpu

[Freedreno] [PATCH v1 03/14] drm/msm/dp: add configure mainlink_levels base on lane number

2023-01-23 Thread Kuogee Hsieh
Mainlink_levels determined when two actions to take place by hardware, a new BS sequence due to start of video and a static HW MVID is sent to panel. This patch add function to configure mainlink level properly base on lane number. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v1 05/14] drm/msm/dp: upgrade tu calculation base on newest algorithm

2023-01-23 Thread Kuogee Hsieh
size calculation base on newest algorithm. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 702 +++ 1 file changed, 416 insertions(+), 286 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index

[Freedreno] [PATCH v1 07/14] drm/msm/dp: add dsc helper functions

2023-01-23 Thread Kuogee Hsieh
Add DSC related supporting functions to calculate DSC related parameters. In addition, DSC hardware encoder customized configuration parameters are also included. Algorithms used to perform calculation are derived from system engineer spreadsheet. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm

[Freedreno] [PATCH v1 06/14] drm/msm/dp: add display compression related struct

2023-01-23 Thread Kuogee Hsieh
Add display compression related struct to support variant compression mechanism. However, DSC is the only one supported at this moment. VDC may be added later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.h | 42 ++ drivers/gpu/drm/msm/msm_drv.h | 89

[Freedreno] [PATCH v1 09/14] drm/msm/dsi: export struct msm_compression_info to dpu encoder

2023-01-23 Thread Kuogee Hsieh
. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 -- drivers/gpu/drm/msm/dsi/dsi.c | 3 ++- drivers/gpu/drm/msm/dsi/dsi.h

[Freedreno] [PATCH v1 12/14] drm/msm/disp/dpu1: revise timing engine programming to work for DSC

2023-01-23 Thread Kuogee Hsieh
Current implementation timing engine programming does not consider compression factors. This patch add consideration of DSC factors while programming timing engine. Signed-off-by: Kuogee Hsieh --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 + drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v1 14/14] drm/msm/disp/dpu1: add sc7280 dsc block and sub block

2023-01-23 Thread Kuogee Hsieh
This patch add DSC block and sub block to support new DSC v1.2 hardware encoder. Also sc7280 DSC related hardware information are added to allow sc7280 DSC feature be enabled at sc7280 platform. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 50

[Freedreno] [PATCH v1 08/14] drm/msm/dp: add dsc supporting functions to DP controller

2023-01-23 Thread Kuogee Hsieh
This patch provides DSC required functions at DP controller to complete DSC feature. those functions include enable fec, configure dsc, configure dto, transmit pps and finally flush hardware registers. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_catalog.c | 139 - drivers

[Freedreno] [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-23 Thread Kuogee Hsieh
DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 2 +- drivers/gpu

[Freedreno] [PATCH v1 11/14] drm/msm/disp/dpu1: add supports of new flush mechanism

2023-01-23 Thread Kuogee Hsieh
A new flushing mechanism is introduced to decouple peripheral metadata flushing from timing engine related flush. This patch add peripheral flushing functions. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 24 ++-- drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v1 13/14] drm/msm/disp/dpu1: add dsc supporting functions to dpu encoder

2023-01-23 Thread Kuogee Hsieh
related parameters are calculated and committed to DSC encoder. Also compression information are propagated to phy and committed to timing engine at video mode. This patch completes DSC implementation. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 314

Re: [Freedreno] [PATCH v1 12/14] drm/msm/disp/dpu1: revise timing engine programming to work for DSC

2023-01-24 Thread Kuogee Hsieh
On 1/24/2023 1:11 AM, Dmitry Baryshkov wrote: On 23/01/2023 20:24, Kuogee Hsieh wrote: Current implementation timing engine programming does not consider compression factors. This patch add consideration of DSC factors while programming timing engine. Signed-off-by: Kuogee Hsieh

Re: [Freedreno] [PATCH v1 10/14] drm/msm/disp/dpu: add supports of DSC encoder v1.2 engine

2023-01-24 Thread Kuogee Hsieh
On 1/23/2023 12:11 PM, Marijn Suijten wrote: add support for* drm/msm/dpu* On 2023-01-23 10:24:30, Kuogee Hsieh wrote: DSC V1.2 encoder engine is newly added hardware module. This patch add support functions to configure and enable DSC V1.2 encoder engine. Signed-off-by: Kuogee Hsieh

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: Clean up handling of DP AUX interrupts

2023-01-25 Thread Kuogee Hsieh
On 1/19/2023 2:53 PM, Douglas Anderson wrote: The DP AUX interrupt handling was a bit of a mess. * There were two functions (one for "native" transfers and one for "i2c" transfers) that were quite similar. It was hard to say how many of the differences between the two functions were on pu

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-25 Thread Kuogee Hsieh
On 1/19/2023 2:53 PM, Douglas Anderson wrote: If our interrupt handler gets called and we don't really handle the interrupt then we should return IRQ_NONE. The current interrupt handler didn't do this, so let's fix it. NOTE: for some of the cases it's clear that we should return IRQ_NONE and s

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-25 Thread Kuogee Hsieh
On 1/25/2023 10:21 AM, Doug Anderson wrote: Hi, On Wed, Jan 25, 2023 at 9:22 AM Kuogee Hsieh wrote: -void dp_ctrl_isr(struct dp_ctrl *dp_ctrl) +irqreturn_t dp_ctrl_isr(struct dp_ctrl *dp_ctrl) { struct dp_ctrl_private *ctrl; u32 isr; + irqreturn_t ret = IRQ_NONE

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dp: Clean up handling of DP AUX interrupts

2023-01-30 Thread Kuogee Hsieh
during init, we are seeing DP_INTR_PLL_UNLOCKED. For now I'm going to say that leaving this error reported in the logs is OK-ish and hopefully it will encourage someone to track down what's going on at init time. One last note here is that this change renames one of the interrupt bits. The bit

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-30 Thread Kuogee Hsieh
urselves). This means that if we _do_ end hitting an interrupt where "ack"ing isn't enough the kernel will eventually detect the problem and shut our device down. Signed-off-by: Douglas Anderson Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh --- (no changes since v1) dri

[Freedreno] [PATCH] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-24 Thread Kuogee Hsieh
pm_suspend. Fixes: 989ebe7bc446 ("drm/msm/dp: do not initialize phy until plugin interrupt received") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp

[Freedreno] [PATCH v1 0/2] add V1.1 dsc_helper fucntion

2023-02-24 Thread Kuogee Hsieh
Add V1.1 dsc function and have dsi use it instead of hardcode value Kuogee Hsieh (2): drm/msm/dpu: add dsc helper functions drm/msm/dsi: use new dpu_dsc_populate_dsc_config() drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_dsc_helper.c | 209

[Freedreno] [PATCH v1 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc_config()

2023-02-24 Thread Kuogee Hsieh
use new introduced dpu_dsc_populate_dsc_config() to calculate and populate drm_dsc_info instead of hard code value. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dsi/dsi_host.c | 78 ++ 1 file changed, 12 insertions(+), 66 deletions(-) diff --git a

[Freedreno] [PATCH v1 1/2] drm/msm/dpu: add dsc helper functions

2023-02-24 Thread Kuogee Hsieh
/1). Please noted that only DSC version V1.1 supported. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_dsc_helper.c | 209 + drivers/gpu/drm/msm/disp/dpu1/dpu_dsc_helper.h | 28 drivers/gpu

Re: [Freedreno] [PATCH v1 0/2] add V1.1 dsc_helper fucntion

2023-02-24 Thread Kuogee Hsieh
Please ignore this series I am going to re post it as RFC. kuogee On 2/24/2023 11:01 AM, Kuogee Hsieh wrote: Add V1.1 dsc function and have dsi use it instead of hardcode value Kuogee Hsieh (2): drm/msm/dpu: add dsc helper functions drm/msm/dsi: use new dpu_dsc_populate_dsc_config

[Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-24 Thread Kuogee Hsieh
5 keys, DSC version (V1.1), chroma (444/422/420), colorspace (RGB/YUV), bpc(8/10), bpp (6/7/7.5/8/9/10/12/15) and SCR (0/1). Only DSC version V1.1 added and V1.2 will be added later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp

[Freedreno] [RFC PATCH 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc_config()

2023-02-24 Thread Kuogee Hsieh
use new introduced dpu_dsc_populate_dsc_config() to calculate and populate drm_dsc_info instead of hard code value. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dsi/dsi_host.c | 78 ++ 1 file changed, 12 insertions(+), 66 deletions(-) diff --git a

[Freedreno] [RFC PATCH 0/2] Add DPU DSC helper module

2023-02-24 Thread Kuogee Hsieh
panel is yet to be brough it up. In preparation to post DSC V1.2 over DP, let's handle all common DSI and DP DSC parameters calculation in this new module. Kuogee Hsieh (2): drm/msm/dpu: add dsc helper functions drm/msm/dsi: use new dpu_dsc_populate_dsc_config() drivers/gpu/drm/msm/Mak

Re: [Freedreno] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-24 Thread Kuogee Hsieh
On 2/24/2023 1:13 PM, Dmitry Baryshkov wrote: On 24/02/2023 21:40, Kuogee Hsieh wrote: Add DSC helper functions based on DSC configuration profiles to produce DSC related runtime parameters through both table look up and runtime calculation to support DSC on DPU. There are 6 different DSC

[Freedreno] [PATCH v1] drm/msm/disp/dpu: fix sc7280_pp base address

2023-02-27 Thread Kuogee Hsieh
Correct sc7280 pp block base address. Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[Freedreno] [PATCH v2] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-27 Thread Kuogee Hsieh
rrupt received") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index bde1a7c..1850

[Freedreno] [PATCH v2] drm/msm/disp/dpu: fix sc7280_pp base offset

2023-02-27 Thread Kuogee Hsieh
. Changes in v2: -- add more details info n regrading of pingpong block at commit text Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 inser

[Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-28 Thread Kuogee Hsieh
: 989ebe7bc446 ("drm/msm/dp: do not initialize phy until plugin interrupt received") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp

Re: [Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-01 Thread Kuogee Hsieh
On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd thread context, this test case may

Re: [Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-02 Thread Kuogee Hsieh
On 3/1/2023 1:15 PM, Dmitry Baryshkov wrote: On 01/03/2023 18:57, Kuogee Hsieh wrote: On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since

Re: [Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-03 Thread Kuogee Hsieh
On 3/2/2023 11:04 AM, Dmitry Baryshkov wrote: On Thu, 2 Mar 2023 at 20:41, Kuogee Hsieh wrote: On 3/1/2023 1:15 PM, Dmitry Baryshkov wrote: On 01/03/2023 18:57, Kuogee Hsieh wrote: On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a

Re: [Freedreno] [PATCH v2] drm/msm/dpu: improve DSC allocation

2023-12-11 Thread Kuogee Hsieh
On 12/6/2023 1:35 AM, Dmitry Baryshkov wrote: On 05/12/2023 22:51, Kuogee Hsieh wrote: On 12/5/2023 11:23 AM, Dmitry Baryshkov wrote: On Tue, 5 Dec 2023 at 20:12, Kuogee Hsieh wrote: On 12/4/2023 4:23 PM, Dmitry Baryshkov wrote: On Tue, 5 Dec 2023 at 01:55, Kuogee Hsieh wrote: A DCE

[PATCH v3] drm/msm/dpu: improve DSC allocation

2023-12-11 Thread Kuogee Hsieh
i += 2 at for loop Changes in V2: -- split _dpu_rm_reserve_dsc() into _dpu_rm_reserve_dsc_single() and _dpu_rm_reserve_dsc_pair() Fixes: f2803ee91a41 ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_

Re: [PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-12-11 Thread Kuogee Hsieh
result in -EPROBE_DEFR loops. Signed-off-by: Dmitry Baryshkov --- Dependencies: https://patchwork.freedesktop.org/series/120375/ --- Reviewed-by: Kuogee Hsieh drivers/gpu/drm/msm/dp/dp_display.c | 36 + 1 file changed, 21 insertions(+), 15 deletions(-) diff

Re: [PATCH v3] drm/msm/dpu: improve DSC allocation

2023-12-11 Thread Kuogee Hsieh
On 12/11/2023 1:30 PM, Dmitry Baryshkov wrote: On Mon, 11 Dec 2023 at 20:38, Kuogee Hsieh wrote: A DCE (Display Compression Engine) contains two DSC hard slice encoders. Each DCE start with even DSC encoder index followed by "starts". But it will not be correct. The DCE doesn&#x

Re: [PATCH v3] drm/msm/dpu: improve DSC allocation

2023-12-12 Thread Kuogee Hsieh
On 12/11/2023 4:03 PM, Kuogee Hsieh wrote: On 12/11/2023 1:30 PM, Dmitry Baryshkov wrote: On Mon, 11 Dec 2023 at 20:38, Kuogee Hsieh wrote: A DCE (Display Compression Engine) contains two DSC hard slice encoders. Each DCE start with even DSC encoder index followed by "starts". B

[PATCH v4] drm/msm/dpu: improve DSC allocation

2023-12-12 Thread Kuogee Hsieh
dpu_rm_pingpong_dsc_check() -- for pair allocation use i += 2 at for loop Changes in V2: -- split _dpu_rm_reserve_dsc() into _dpu_rm_reserve_dsc_single() and _dpu_rm_reserve_dsc_pair() Fixes: f2803ee91a41 ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/g

[PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-13 Thread Kuogee Hsieh
lit _dpu_rm_reserve_dsc() into _dpu_rm_reserve_dsc_single() and _dpu_rm_reserve_dsc_pair() Fixes: f2803ee91a41 ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 162 + 1 file changed, 1

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
On 12/13/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
On 12/13/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder

[PATCH v6] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
nto _dpu_rm_reserve_dsc_single() and _dpu_rm_reserve_dsc_pair() Fixes: f2803ee91a41 ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 154 + 1 file changed, 139 insertions(+), 15 deletions(-) diff --

Re: [PATCH v6] drm/msm/dpu: improve DSC allocation

2023-12-19 Thread Kuogee Hsieh
Hi Dmitry, Anymore comments from you? On 12/14/2023 10:56 AM, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder can work

Re: [PATCH v6] drm/msm/dpu: improve DSC allocation

2023-12-20 Thread Kuogee Hsieh
On 12/19/2023 2:32 PM, Dmitry Baryshkov wrote: On Tue, 19 Dec 2023 at 18:18, Kuogee Hsieh wrote: Hi Dmitry, Anymore comments from you? No, for some reason I missed this patch. Please excuse me. On 12/14/2023 10:56 AM, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine

[PATCH v1] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2024-01-10 Thread Kuogee Hsieh
MSA MISC0 bit 1 to 7 contains Colorimetry Indicator Field. At current implementation, Colorimetry Indicator Field of MISC0 is not configured correctly. This patch add support of RGB formats Colorimetry. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Ku

[PATCH v1] drm/msms/dp: fixed link clock divider bits be over written in BPC unknown case

2024-01-10 Thread Kuogee Hsieh
(DP_TEST_BIT_DEPTH_8 >> DP_TEST_BIT_DEPTH_SHIFT). Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 5 - drivers/gpu/drm/msm/dp/dp_link.c | 10 +++--- 2 files changed, 7 insertions(+), 8 deletions(

[PATCH v1] drm/msm/dp: remove mdss_dp_test_bit_depth_to_bpc()

2024-01-11 Thread Kuogee Hsieh
mdss_dp_test_bit_depth_to_bpc() can be replace by mdss_dp_test_bit_depth_to_bpp() / 3. Hence remove it. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_debug.c | 2 +- drivers/gpu/drm/msm/dp/dp_link.h | 23 --- 2 files changed, 1 insertion(+), 24 deletions

Re: [PATCH v1] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2024-01-11 Thread Kuogee Hsieh
On 1/10/2024 3:38 PM, Dmitry Baryshkov wrote: On Wed, 10 Jan 2024 at 22:18, Kuogee Hsieh wrote: MSA MISC0 bit 1 to 7 contains Colorimetry Indicator Field. At current implementation, Colorimetry Indicator Field of MISC0 is not configured correctly. This patch add support of RGB formats

[PATCH v2] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2024-01-17 Thread Kuogee Hsieh
. Changes in V2: -- drop retrieving colorimetry from colorspace -- drop dr = link->dp_link.test_video.test_dyn_range assignment Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_link.c | 11 ++- driver

Re: [PATCH v2] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2024-01-17 Thread Kuogee Hsieh
On 1/17/2024 10:12 AM, Dmitry Baryshkov wrote: On Wed, 17 Jan 2024 at 19:54, Kuogee Hsieh wrote: MSA MISC0 bit 1 to 7 contains Colorimetry Indicator Field. At current implementation, at DP_TEST_DYNAMIC_RANGE_CEA case the In the current implementation, in the ... case Colorimetry Indicator

Re: [PATCH v2] drm/msm/dp: correct configure Colorimetry Indicator Field at MISC0

2024-01-17 Thread Kuogee Hsieh
On 1/17/2024 10:40 AM, Dmitry Baryshkov wrote: On Wed, 17 Jan 2024 at 20:29, Kuogee Hsieh wrote: On 1/17/2024 10:12 AM, Dmitry Baryshkov wrote: On Wed, 17 Jan 2024 at 19:54, Kuogee Hsieh wrote: MSA MISC0 bit 1 to 7 contains Colorimetry Indicator Field. At current implementation, at

[PATCH v3] drm/msm/dp: return correct Colorimetry for DP_TEST_DYNAMIC_RANGE_CEA case

2024-01-17 Thread Kuogee Hsieh
ore precise describe this patch Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_link.c | 12 +++- drivers/gpu/drm/msm/dp/dp_reg.h | 3 +++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-19 Thread Kuogee Hsieh
Dmitry, I am testing this patch serial with msm-next branch. This patch cause system crash during booting up for me. Is this patch work for you? On 12/29/2023 2:56 PM, Dmitry Baryshkov wrote: Remove two levels of indirection and fetch next bridge directly in dp_display_probe_tail(). Signed-o

Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-22 Thread Kuogee Hsieh
On 1/19/2024 6:31 PM, Dmitry Baryshkov wrote: On Fri, 19 Jan 2024 at 23:14, Kuogee Hsieh wrote: Dmitry, I am testing this patch serial with msm-next branch. This patch cause system crash during booting up for me. Is this patch work for you? Yes, tested on top of linux-next. However I

Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-22 Thread Kuogee Hsieh
On 1/22/2024 9:28 AM, Kuogee Hsieh wrote: On 1/19/2024 6:31 PM, Dmitry Baryshkov wrote: On Fri, 19 Jan 2024 at 23:14, Kuogee Hsieh wrote: Dmitry, I am testing this patch serial with msm-next branch. This patch cause system crash during booting up for me. Is this patch work for you? Yes

<    4   5   6   7   8   9   10   11   12   >