I will drop this patch since the problem had been fixed by Dmitry
Baryshkov patch.
https://gitlab.freedesktop.org/drm/msm/-/commit/577e2a9dfc8fba7938aaf75db63fae7e328cc3cb
On 6/3/2022 2:28 PM, Kuogee Hsieh wrote:
At msm initialize phase, msm_drm_init() is called to initialize modules
m/msm/dp: stop event kernel thread when DP unbind")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index da5c03a..2b72639 10
On 6/10/2022 2:04 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-05-27 14:32:13)
During display resolution changes display have to be disabled first
followed by display enabling with new resolution. Display disable
will turn off both pixel clock and main link clock so that main link
have
only (is_edp == false)
Changes in v3:
-- revise commit text
-- add Fixes tag
Changes in v4:
-- revise commit text
Changes in v5:
-- fix spelling at commit text
Fixes: 62671d2ef24b ("drm/msm/dp: fixes wrong connection state caused by
failure of link train")
Signed-off-by: Ku
On 6/14/2022 1:38 AM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-13 14:48:37)
During display resolution changes display have to be disabled first
followed by display enabling with new resolution. Display disable
will turn off both pixel clock and main link clock so that main link
have
On 6/14/2022 1:38 AM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-13 14:48:37)
During display resolution changes display have to be disabled first
followed by display enabling with new resolution. Display disable
will turn off both pixel clock and main link clock so that main link
have
test case
-- revise commit text for modeset
Fixes: 62671d2ef24b ("drm/msm/dp: fixes wrong connection state caused by
failure of link train")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c| 31 +++
drivers/gpu/drm/msm/dp/dp_ctrl
On 6/14/2022 2:59 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-14 14:05:02)
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel
On 6/14/2022 2:59 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-14 14:05:02)
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel
test case
-- revise commit text for modeset
Changes in v7:
-- drop 0 assignment at local variable (ret = 0)
Fixes: 62671d2ef24b ("drm/msm/dp: fixes wrong connection state caused by
failure of link train")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl
1) force link training for display resolution change
2) remove pixel_rate from struct dp_ctrl
Kuogee Hsieh (2):
drm/msm/dp: force link training for display resolution change
drm/msm/dp: clean up pixel_rate from dp_ctrl.c
drivers/gpu/drm/msm/dp/dp_ctrl.c| 147
test case
-- revise commit text for modeset
Changes in v7:
-- drop 0 assignment at local variable (ret = 0)
Changes in v8:
-- add patch to remove pixel_rate from dp_ctrl
Fixes: 62671d2ef24b ("drm/msm/dp: fixes wrong connection state caused by
failure of link train")
Signed-off-by: Ku
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 158 +++
drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 -
2 files changed, 79 insertions(+), 81 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index 01028b5
ction state caused by
failure of link train")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c| 33 +
drivers/gpu/drm/msm/dp/dp_ctrl.h| 2 +-
drivers/gpu/drm/msm/dp/dp_display.c | 13 ++---
3 files changed, 32 insertions(+), 16
On 6/16/2022 1:07 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-16 10:09:21)
dp_ctrl keep an local cache of pixel_rate which increase confusing
in regrading how pixel_rate being used. This patch refer pixel_rate
directly from dp_panel to eliminate unnecessary pixel_rate variable
from
On 6/17/2022 1:47 PM, Stephen Boyd wrote:
This API isn't really more than a couple lines now that we don't store
the pixel_rate to the struct member. Inline it into the caller.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
Reviewed-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp
at sort of task.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 104 +++
1 file changed, 50 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp
On 6/16/2022 5:02 PM, Vinod Koul wrote:
On 25-05-22, 14:02, Kuogee Hsieh wrote:
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp: add regulator_set_load to edp phy
phy
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
tree
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp: add regulator_set_load to edp phy
phy
This patch add regulator_set_load() before enable regulator at
eDP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Douglas Anderson
---
drivers/phy/qualcomm/phy-qcom-edp.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c
b/drivers/phy
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch removes
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 40 -
1 file changed, 31 insertions(+), 9 deletions
On 6/20/2022 1:15 PM, Dmitry Baryshkov wrote:
On 20/06/2022 23:12, Kuogee Hsieh wrote:
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
---
drivers/phy/qualcomm/phy-qcom
On 6/20/2022 1:07 PM, Kuogee Hsieh wrote:
On 6/16/2022 5:02 PM, Vinod Koul wrote:
On 25-05-22, 14:02, Kuogee Hsieh wrote:
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
tree
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp: add regulator_set_load to edp phy
phy
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 43 ---
1 file changed, 33 insertions(+), 10 deletions
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch removes
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
This patch add regulator_set_load() before enable regulator at
eDP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Douglas Anderson
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/qualcomm/phy-qcom-edp.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/phy/qualcomm
On 6/22/2022 12:26 AM, Dmitry Baryshkov wrote:
On 16/06/2022 20:09, Kuogee Hsieh wrote:
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel
ith a function argument instead of
storing to a struct member. Pass the pixel_rate as an argument instead
to simplify the code. Note that dp_ctrl_link_maintenance() was storing
the pixel_rate but never using it so we just remove the assignment
from
there.
Cc: Kuogee Hsieh
Signed-off-by: Stephen
[ 53.840875] drm_dev_dbg+0xfc/0x1b8
[ 53.844480] dp_pm_suspend+0x70/0xf8
[ 53.848164] dpm_run_callback+0x60/0x1a0
[ 53.85] __device_suspend+0x304/0x3f4
[ 53.856363] dpm_suspend+0xf8/0x3a8
[ 53.859959] dpm_suspend_start+0x8c/0xc0
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp
Use quic id instead of codeaurora id in maintainers list
for display devicetree bindings.
Signed-off-by: Kuogee Hsieh
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings
ernel thread when DP unbind")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index 2b7263
On 6/22/2022 1:06 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-22 12:55:31)
During msm initialize phase, dp_display_unbind() will be called to undo
initializations had been done by dp_display_bind() previously if there is
error happen at msm_drm_bind. Under this kind of circumstance
ST_DISCONNECTED state.
Fixes: 391c96ff0555 ("drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts
for eDP")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
On 6/23/2022 5:09 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-23 16:34:16)
eDP implementation does not reuried to support hpd signal. Therefore
s/reuried/require/
it only has either ST_DISPLAY_OFF or ST_CONNECTED state during normal
operation. This patch remove unnecessary
fix primary corruption :
1) move struc of msm_display_info to msm_drv.h
2) decoupling dp->id out of dp controller_id at sc_dp_cfg table
3) place edp at head of drm bridge chain to fix screen corruption
Kuogee Hsieh (3):
drm/msm/dp: move struc of msm_display_info to msm_drv.h
drm/msm
, such as widebus and dcs, in future to serve as communication
channel purpose between interface driver and upper mdss encoder layer so
that existing function calls can be eliminated.
This patch more struct msm_display_info to msm_drv.h to be visible by
whole msm scope.
Signed-off-by: Kuogee Hsieh
off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 16 ++--
drivers/gpu/drm/msm/dp/dp_display.c | 30 +++---
drivers/gpu/drm/msm/msm_drv.h | 2 ++
3 files changed, 35 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/ms
ave primary eDP locate at
head of bridge chain. This correct screen update order and eliminated
the one frame time screen corruption happen d at primary display.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly
coupled with DP controller_id. This means DP use controller id 0 must be placed
at first entry of DP descriptor ta
On 6/24/2022 2:40 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:17:50)
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly
coupled with DP controller_id. This me
On 6/24/2022 2:40 PM, Doug Anderson wrote:
Hi,
On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote:
With current implementation, communication between interface driver and
upper mdss encoder layer are implemented through function calls. This
increase code complexity. Since struct
On 6/24/2022 3:19 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:49:57)
On 6/24/2022 2:40 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:17:50)
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 15:53:45)
MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <== This
is correct
The problem is sc7280_dp_cfg[] have two entries since eDP place at index
of MSM_DP_CONTROLLER_1.
but .num_desc
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 16:30:59)
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 15:53:45)
MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <== This
is correct
The problem is sc7280_dp_
On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh
On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
How can I have eDP call dpu_encoder_init() before DP calls with
_dpu_kms_initialize_displayport()?
Why do you want to do it? They are two different encoders.
eDP is primary display which in
On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
wrote:
On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
How can I have eDP call dpu_encoder_init
On 6/24/2022 6:15 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 18:02:50)
On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
wrote:
On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
On Sat
On 6/27/2022 8:38 AM, Dmitry Baryshkov wrote:
On Mon, 27 Jun 2022 at 18:33, Kuogee Hsieh wrote:
On 6/24/2022 6:15 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 18:02:50)
On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
wrote:
On
manually.
Reported-by: Kuogee Hsieh
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dp/dp_display.c | 46 +
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index
On 6/27/2022 1:05 PM, Dmitry Baryshkov wrote:
On Mon, 27 Jun 2022 at 22:26, Kuogee Hsieh wrote:
On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote:
If for some reason the msm_dp_config::descs array starts from non-zero
index or contains the hole, setting the msm_dp_config::num_descs might
be not
ay at head of
connected connector list. This fixes unexpected corruption happen
at eDP panel if eDP is not placed at head of connected connector
list.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_dr
On 6/27/2022 4:20 PM, Doug Anderson wrote:
Hi,
On Sat, Jun 25, 2022 at 1:48 AM Dmitry Baryshkov
wrote:
On Sat, 25 Jun 2022 at 04:23, Abhinav Kumar wrote:
On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
On 6/24/2022 4:56 PM, Kuogee Hsieh
-...@vger.kernel.org,
dri-de...@lists.freedesktop.org, Bjorn Andersson
, Daniel Vetter , Stephen
Boyd , freedreno@lists.freedesktop.org
Refactoring DP code transformed several functions into empty stubs.
Remove them.
Reviewed-by: Stephen Boyd
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Kuogee Hsieh
, which is later passed to dp_ctrl_on_stream().
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Kuogee Hsieh
---
Changes since v1:
- Added patch
---
drivers/gpu/drm/msm/dp/dp_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
by: Dmitry Baryshkov
Reviewed-by: Kuogee Hsieh
---
Changes since v1:
- Rebased and dropped the dp_display_enable() chunk
---
drivers/gpu/drm/msm/dp/dp_display.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/
On 6/27/2022 2:23 PM, Dmitry Baryshkov wrote:
On 28/06/2022 00:01, Kuogee Hsieh wrote:
On 6/27/2022 1:05 PM, Dmitry Baryshkov wrote:
On Mon, 27 Jun 2022 at 22:26, Kuogee Hsieh
wrote:
On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote:
If for some reason the msm_dp_config::descs array starts
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.
Signed-off-by: Kuogee Hsieh
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
tree
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp: add regulator_set_load to edp phy
phy
This patch add regulator_set_load() before enable regulator at
eDP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Douglas Anderson
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/qualcomm/phy-qcom-edp.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/phy/qualcomm
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 41 ---
1 file changed, 32 insertions(+), 9 deletions
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch removes
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
ay at head of
connected connector list. This fixes unexpected corruption happen
at eDP panel if eDP is not placed at head of connected connector
list.
Changes in v2:
-- move drm_helper_move_panel_connectors_to_head() to
dpu_kms_drm_obj_init()
Signed-off-by: Kuogee Hsieh
Test
ay at head of
connected connector list. This fixes unexpected corruption happen
at eDP panel if eDP is not placed at head of connected connector
list.
Changes in v2:
-- move drm_helper_move_panel_connectors_to_head() to
dpu_kms_drm_obj_init()
Signed-off-by: Kuogee Hsieh
---
driver
On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote:
On 06/07/2022 20:24, Kuogee Hsieh wrote:
Some userspace presumes that the first connected connector is the main
display, where it's supposed to display e.g. the login screen. For
laptops, this should be the main panel.
This patch
On 7/6/2022 10:41 AM, Dmitry Baryshkov wrote:
On 06/07/2022 20:38, Kuogee Hsieh wrote:
On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote:
On 06/07/2022 20:24, Kuogee Hsieh wrote:
Some userspace presumes that the first connected connector is the main
display, where it's supposed to displa
move drm_helper_move_panel_connectors_to_head() to msm_drm_init()
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/msm_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 4a3dda2..4d518c2 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/dr
On 7/8/2022 12:38 PM, Abhinav Kumar wrote:
+ kuogee
On 7/8/2022 12:27 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-07-07 20:46:43)
On 08/07/2022 04:28, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-07-07 14:31:56)
The p1 region was probably added by mistake, none of the DTS
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.
Signed-off-by: Kuogee Hsieh
---
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280
On 7/11/2022 9:02 AM, Doug Anderson wrote:
Hi,
On Mon, Jul 11, 2022 at 8:58 AM Kuogee Hsieh wrote:
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.
Signed-off-by: Kuogee Hsieh
---
arch/arm64/boot/dts/qcom/sc7280
Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
by dp combo phy. Therefore remove them from dp controller.
Signed-off-by: Kuogee Hsieh
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 3 ---
2 files changed, 5
("drm/msm/dp: add support of tps4 (training pattern 4) for
HBR3")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index ab6aa13..013c
On 8/1/2022 12:51 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-01 12:42:50)
Data Symbols scrambled is required for tps4 at link training 2.
Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to
work.
RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter
Fixes tag
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
ind
ut to avoid system crashing due to main link clock
is disabled while access main link registers.
Fixes: 13ea4799a81b ("drm/msm/dp: remove extra wrappers and public functions");
Signed-off-by: Kuogee Hsieh
Reported-by: Leonard Lausen @leezu
---
drivers/gpu/drm/msm/dp/dp_display.c | 10 +++
l
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/17
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index b36f8b6..678289a 100644
--
Fixes patch
-- fix eported-by
-- add Closes tag
Fixes: 375a126090b9 ("drm/msm/dp: tear down main link at unplug handle
immediately")
Reported-by: Leonard Lausen
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/17
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp
On 8/10/2022 3:22 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-10 12:25:51)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index b36f8b6..678289a 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
On 8/10/2022 6:00 PM, Abhinav Kumar wrote:
Hi Stephen
On 8/10/2022 5:09 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-10 16:57:51)
On 8/10/2022 3:22 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-10 12:25:51)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu
Fixes tag
Changes in v3:
-- revise commit text
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
Reviewed-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file
Fixes tag
Changes in v3:
-- revise commit text
Changes in v4:
-- fix commit text newline
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
Reviewed-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
---
drivers/g
Fixes tag
Changes in v3:
-- revise commit text
Changes in v4:
-- fix commit text newline
Changes in v5:
-- fix commit text line over 75 chars
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
Reviewed-by: St
On 8/15/2022 10:08 AM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-11 08:20:01)
On 8/10/2022 6:00 PM, Abhinav Kumar wrote:
Even then, you do have a valid point. DRM framework should not have
caused the disable path to happen without an enable.
I went through the stack mentioned in the
x8000
CPU features: 0x800,00c2a015,19801c82
Memory Limit: none
Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable
and disable")
Reported-by: Leonard Lausen
Suggested-by: Rob Clark
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/17
Signed-o
d PHY"
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c
b/drivers/gpu/drm/msm/dp/dp_catalog.c
index 7257515..676279d 100644
--- a/drivers/gpu/drm/msm/dp/dp_catalog.c
+++
ca06f ("drm/msm/dp: Use qmp phy for DP PLL and PHY")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
eviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c
b/drivers
- fix misspelling of "Reviewed-by"
Fixes: 937f941ca06f ("drm/msm/dp: Use qmp phy for DP PLL and PHY")
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
sm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 5 ++---
drivers/gpu/drm/msm/dp/dp_link.c | 17 +++--
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp
text
2) merge ssc variable into encoding[0]
Fixes: 154b5a7da0fd ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +
drivers/gpu/drm/msm/dp/dp_link.c | 17 +++--
2 files changed, 16 inserti
commit text
2) merge ssc variable into encoding[0]
Changes in v3:
-- correct spelling of DOWNSPREAD_CTRL
-- replace err with len of ssize_t
Fixes: 154b5a7da0fd ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +---
cleared DP_DOWNSPREAD_CTRL register before start link training
Kuogee Hsieh (2):
drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link
training
drm/msm/dp: retry 3 times if set sink to D0 poweer state failed
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +
drivers/gpu
ssize_t
Changes in v4:
-- split into 2 patches
Fixes: 154b5a7da0fd ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/d
Bring sink out of D3 (power down) mode into D0 (normal operation) mode
by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This
patch will retry 3 times if written to DP_SET_POWER register failed.
Changes in v4:
-- split into two patches
Signed-off-by: Kuogee Hsieh
---
drivers/gpu
/gitlab.freedesktop.org/drm/msm/-/issues/17
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_drm.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index 6df25f7..c682588 100644
--- a/drivers/gp
ssize_t
Changes in v4:
-- split into 2 patches
Fixes: 154b5a7da0fd ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/d
drm_dp_dpcd_readb() will return 1 to indicate one byte had been read
successfully. This patch replace variable "err" with "len" have more
correct meaning.
changes in v5:
-- split into 3 patches
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_link.c | 14 +++---
Bring sink out of D3 (power down) mode into D0 (normal operation) mode
by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This
patch will retry 3 times if written to DP_SET_POWER register failed.
Changes in v5:
-- split into two patches
Signed-off-by: Kuogee Hsieh
---
drivers/gpu
cleared DP_DOWNSPREAD_CTRL register before start link training
Kuogee Hsieh (3):
drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link
training
drm/msm/dp: replace variable err with len at dp_aux_link_power_up()
drm/msm/dp: retry 3 times if set sink to D0 poweer state failed
601 - 700 of 1116 matches
Mail list logo
