[Freedreno] [PATCH v4 1/6] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-08-11 Thread Kuogee Hsieh
connected. Changes in V2: -- add fixes statement Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Freedreno] [PATCH v4 6/6] drm/msm/dp: do not end dp link training until video is ready

2021-08-11 Thread Kuogee Hsieh
4.3.2.4. Changes in v3: -- merge retrain link if loss of symbol locked happen into this patch -- replace dp_ctrl_loss_symbol_lock() with dp_ctrl_channel_eq_ok() Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 56

[Freedreno] [PATCH v4 5/6] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-08-11 Thread Kuogee Hsieh
Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[Freedreno] [PATCH v4 2/6] drm/msm/dp: reduce link rate if failed at link training 1

2021-08-11 Thread Kuogee Hsieh
with link_status[DP_LINK_STATUS_SIZE] -- replaced dp_ctrl_any_lane_cr_done() with dp_ctrl_colco_recovery_any_ok() -- replaced dp_ctrl_any_ane_cr_lose() with !drm_dp_clock_recovery_ok() Changes in V3: -- return failed if lane_count <= 1 Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen B

[Freedreno] [PATCH] arm64: dts: qcom: sc7280: Add Display Port node

2021-08-24 Thread Kuogee Hsieh
Add display port supported node for sc7280. Also correct dp-phy node tx/rx/pcs/tx2/rx2 base reg address to fix aux channel read/write failure issue. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 9 +++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 98

[Freedreno] [PATCH] phy: qcom-qmp: add support for voltage and pre emphesis swing

2021-08-24 Thread Kuogee Hsieh
Add voltage and pre emphesis swing tables so that voltage and pre emphsis swing level can be configured base on link rate. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp.c | 95 - 1 file changed, 82 insertions(+), 13 deletions(-) diff

[Freedreno] [PATCH] arm64: dts: qcom: sc7280: fix display port phy base address offset

2021-08-27 Thread Kuogee Hsieh
Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes") Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/s

[Freedreno] [PATCH] arm64: dts: qcom: sc7280: enable IDP display port

2021-08-27 Thread Kuogee Hsieh
Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts index b1cf70e..4aea369 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts

[Freedreno] [PATCH v2] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-08-27 Thread Kuogee Hsieh
emp_post_reg parameters from qcom_qmp_v4_phy_configure_dp_swing() -- delete drv_lvl_reg and emp_post_reg parameters from qcom_qmp_phy_configure_dp_swing() Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add Display Port node

2021-08-30 Thread Kuogee Hsieh
Changes in v2: -- break this patch into 3 patches Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 88 +++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: fix display port phy reg property

2021-09-09 Thread Kuogee Hsieh
V2: -- rewording the commit text Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes") Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dt

[Freedreno] [PATCH v3] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-09-09 Thread Kuogee Hsieh
pport for sm8250-usb3-dp phy") Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp.c | 102 +--- 1 file changed, 70 insertions(+), 32 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 31036a

[Freedreno] [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-09-14 Thread Kuogee Hsieh
__qcom_qmp_phy_configure_dp_swing() Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp.c | 97 + 1 file changed, 66 insertions(+), 31 deletions(-) diff --git a/drivers/phy/qu

[Freedreno] [PATCH] drm/msm/dp: only signal audio when disconnected detected at dp_pm_resume

2021-09-28 Thread Kuogee Hsieh
Only signal audio when disconnected detected at dp_pm_resume since connected status will be signaled to audio at next plugin handler. Fixes: 078867ce04ed ("drm/msm/dp: signal audio plugged change at dp_pm_resume") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_disp

[Freedreno] [PATCH v2] drm/msm/dp: only signal audio when disconnected detected at dp_pm_resume

2021-09-29 Thread Kuogee Hsieh
ned-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 0e543a03..6f13008 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drive

[Freedreno] [PATCH] drm/msm/dp: do not initialize combo phy until plugin interrupt

2021-10-06 Thread Kuogee Hsieh
that it is able to receive HPD interrupts after completion of the initialization phase. DP driver will initialize and power up phy at plugin interrupt handler during normal operation so that both USB3 and DP are work simultaneously. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c

[Freedreno] [PATCH] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-02 Thread Kuogee Hsieh
Current display mode_set, enable and disable functions are implemented as function called directly from drm encoder. This patch have display mode_set, enable and disable be implemented as callback function of drm bridge. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v3] arm64: dts: qcom: sc7280: Add Display Port node

2021-11-02 Thread Kuogee Hsieh
From: Kuogee Hsieh Signed-off-by: Kuogee Hsieh --- Changes in v2: -- move fixes of dp_phy reg property to other patch Changes in v3: -- delete "qcom,sc7180-dp" from msm_dp node arch/arm64/boot/dts/qcom/sc7280.dtsi | 89 +++- 1 file changed, 87

[Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Kuogee Hsieh
From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout when USB tries to power up its phy. This patch has the DP driver not initialize its phy during DP

[Freedreno] [PATCH v2] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-05 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Kuogee Hsieh
On 11/5/2021 10:48 AM, Bjorn Andersson wrote: On Fri 05 Nov 10:28 PDT 2021, Kuogee Hsieh wrote: From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout

[Freedreno] [PATCH v2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-08 Thread Kuogee Hsieh
From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout when USB tries to power up its phy. This patch has the DP driver not initialize its phy during DP

[Freedreno] [PATCH v3] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-08 Thread Kuogee Hsieh
From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout when USB tries to power up its phy. This patch has the DP driver not initialize its phy during DP

Re: [Freedreno] [PATCH v3] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-09 Thread Kuogee Hsieh
On 11/8/2021 4:29 PM, Bjorn Andersson wrote: On Mon 08 Nov 15:42 PST 2021, Kuogee Hsieh wrote: From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout

[Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-09 Thread Kuogee Hsieh
From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divided the driver life cycle of operation into four

Re: [Freedreno] [PATCH v2] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-12 Thread Kuogee Hsieh
On 11/6/2021 9:25 AM, Bjorn Andersson wrote: On Fri 05 Nov 16:22 CDT 2021, Kuogee Hsieh wrote: Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid

Re: [Freedreno] [PATCH v2] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-15 Thread Kuogee Hsieh
On 11/6/2021 9:25 AM, Bjorn Andersson wrote: On Fri 05 Nov 16:22 CDT 2021, Kuogee Hsieh wrote: Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid

[Freedreno] [PATCH v3] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-15 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7280: Add Display Port node

2021-11-16 Thread Kuogee Hsieh
On 11/15/2021 3:39 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-11-02 16:44:33) From: Kuogee Hsieh Signed-off-by: Kuogee Hsieh --- What tree is this based on? I don't see edp_phy upstream for sc7280 this patch is depend on  --> [PATCH v2 4/4] arm64: dts: qcom: sc7280:

[Freedreno] [PATCH v4] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-16 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-16 Thread Kuogee Hsieh
On 11/15/2021 12:23 PM, khs...@codeaurora.org wrote: On 2021-11-09 13:38, Kuogee Hsieh wrote: From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-19 Thread Kuogee Hsieh
On 11/18/2021 5:20 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-11-09 13:38:13) From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and

Re: [Freedreno] [PATCH v3] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-29 Thread Kuogee Hsieh
On 11/24/2021 11:45 AM, Dmitry Baryshkov wrote: On 15/11/2021 21:48, Kuogee Hsieh wrote: Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized

[Freedreno] [PATCH v5] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-29 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

[Freedreno] [PATCH] drm/msm/dp: Add "qcom, sc7280-dp" to support display port.

2021-12-03 Thread Kuogee Hsieh
Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index d44f18b..91582d3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-03 Thread Kuogee Hsieh
On 12/2/2021 6:41 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-11-09 13:38:13) From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and

[Freedreno] [PATCH v2] drm/msm/dp: Add "qcom, sc7280-dp" to support display port.

2021-12-06 Thread Kuogee Hsieh
Changes in v2: -- move "qcom,sc7280-dp" before "qcom,sc7280-edp" Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/dp/dp_disp

[Freedreno] [PATCH v5] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-07 Thread Kuogee Hsieh
dd DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 87 - drivers/gpu/drm/msm/dp/dp_ctrl.h| 9 ++-- drivers/gpu/drm/msm/dp/dp_display.c | 80 ++ 3 files ch

[Freedreno] [PATCH v6] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-12-07 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

[Freedreno] [PATCH v5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-08 Thread Kuogee Hsieh
branch Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 12 +--- drivers/gpu/drm/msm/dp/dp_link.c| 19 ++- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v5] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-08 Thread Kuogee Hsieh
From: Kuogee Hsieh Both voltage and pre-emphasis swing level are set during link training negotiation between host and sink. There are totally four tables added. A voltage swing table for both hbr and hbr1, a voltage table for both hbr2 and hbr3, a pre-emphasis table for both hbr and hbr1 and a

[Freedreno] [PATCH v6] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-08 Thread Kuogee Hsieh
: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 87 - drivers/gpu/drm/msm/dp/dp_ctrl.h| 9 ++-- drivers/gpu/drm/msm/dp/dp_disp

[Freedreno] [PATCH v6] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-08 Thread Kuogee Hsieh
From: Kuogee Hsieh "add support for sm8250-usb3-dp phy" patch added functions to support V4 phy. But it did not update voltage and pre-emphasis tables accordingly. This patch add v4 voltage and pre-emphasis swing tables to complete v4 phy implementation. Both voltage and pre-emphasis s

[Freedreno] [PATCH v7] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-09 Thread Kuogee Hsieh
From: Kuogee Hsieh The previous patch from Fixes (aff188feb5e1) added functions to support V4 phy. But it did not update voltage and pre-emphasis tables accordingly. This patch add v4 voltage and pre-emphasis swing tables to complete v4 phy implementation. Both voltage and pre-emphasis swing

[Freedreno] [PATCH v7 1/2] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-09 Thread Kuogee Hsieh
: -- split this patch as stand alone patch Changes in v5: -- rebase on msm-next branch Changes in v6: -- add more details commit text Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 12 +--- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v7 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-09 Thread Kuogee Hsieh
V7: -- dp_ctrl_irq_enable/disabe() merged into dp_ctrl_reset_irq_ctrl() Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 77 -- drivers/gpu/

[Freedreno] [PATCH v8] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-13 Thread Kuogee Hsieh
From: Kuogee Hsieh The previous patch from Fixes 'aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy")' added functions to support V4 of the PHY, But it did not update voltage and pre-emphasis tables accordingly. This patch add v4 voltage and pre-emphasis swin

[Freedreno] [PATCH v9] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-20 Thread Kuogee Hsieh
h hbr2 and hbr3. In addition, write 0x0a to TX_TX_POL_INV is added to complete the sequence of configure dp phy base on the hardware documentation. Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Rev

Re: [Freedreno] [PATCH v7 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-21 Thread Kuogee Hsieh
On 12/14/2021 5:50 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-12-09 13:35:07) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 0766752..cfbc5e4 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c

[Freedreno] [PATCH v8 1/2] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-21 Thread Kuogee Hsieh
: -- split this patch as stand alone patch Changes in v5: -- rebase on msm-next branch Changes in v6: -- add more details commit text Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 12 +--- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v8 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-21 Thread Kuogee Hsieh
V7: -- dp_ctrl_irq_enable/disabe() merged into dp_ctrl_reset_irq_ctrl() Changes in V8: -- add more detail comment regrading dp phy at dp_display_host_init() Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/

[Freedreno] [PATCH v9 1/2] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-22 Thread Kuogee Hsieh
: -- split this patch as stand alone patch Changes in v5: -- rebase on msm-next branch Changes in v6: -- add more details commit text Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 12 +--- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v9 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-22 Thread Kuogee Hsieh
tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 80 + drivers/gpu/drm/msm/dp/dp_ctrl.h| 8 ++-- drivers/gpu/drm/msm/dp/dp_display.c | 89 - 3 files changed, 94 inserti

Re: [Freedreno] [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

2021-12-28 Thread Kuogee Hsieh
stophe JAILLET Reviewed-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_drm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 188e77c59885..d4d360d19eba 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/

[Freedreno] [PATCH] drm/msm/dp: populate connector of struct dp_panel

2021-12-28 Thread Kuogee Hsieh
;drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 71db10c..6a938a2

[Freedreno] [PATCH] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2021-12-28 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 16 1 file changed, 12 inser

[Freedreno] [PATCH v2] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2021-12-29 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Signed-o

[Freedreno] [PATCH v2] drm/msm/dp: populate connector of struct dp_panel

2021-12-29 Thread Kuogee Hsieh
at dp_panel_read_sink_caps() Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/dr

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-29 Thread Kuogee Hsieh
* functions. Signed-off-by: Dmitry Baryshkov Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh ---   drivers/gpu/drm/msm/Makefile |   1 -   drivers/gpu/drm/msm/dp/dp_clk_util.c | 120 ---   drivers/gpu/drm/msm/dp/dp_clk_util.h |  38 -   drivers/gpu/drm/msm

[Freedreno] [PATCH] drm/msm/dp: stop link training after link training 2 failed

2022-01-04 Thread Kuogee Hsieh
patch fixes link compliance test case 4.3.1.13 (Source Device Link Training EQ Fallback Test). Fixes: 2e0adc765d88 ("drm/msm/dp: do not end dp link training until video is ready") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +++ 1 file changed, 3 insertion

Re: [Freedreno] [PATCH v2] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
On 1/5/2022 1:34 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-12-29 11:17:02) There is kernel crashed due to unable to handle kernel NULL pointer dereference of dp_panel->connector while running DP link layer compliance test case 4.2.2.6 (EDID Corruption Detection). Can you explain

[Freedreno] [PATCH v3] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-06 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v3] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
parameter to dp Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/dr

[Freedreno] [PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
ext Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm

[Freedreno] [PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
ext Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm

[Freedreno] [PATCH v4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-06 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v10 0/5] group dp driver related patches into one series

2022-01-10 Thread Kuogee Hsieh
Group below 5 dp driver related patches into one series. Kuogee Hsieh (5): drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add

[Freedreno] [PATCH v10 3/5] drm/msm/dp: populate connector of struct dp_panel

2022-01-10 Thread Kuogee Hsieh
ommit text Changes in v10: -- group into one series Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 5

[Freedreno] [PATCH v10 2/5] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-10 Thread Kuogee Hsieh
: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 80 + drivers/gpu/drm/msm/dp/dp_ctrl.h| 8 ++-- drivers/gpu/drm/msm/dp/dp_disp

[Freedreno] [PATCH v10 1/5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2022-01-10 Thread Kuogee Hsieh
: -- split this patch as stand alone patch Changes in v5: -- rebase on msm-next branch Changes in v6: -- add more details commit text Changes in v10: -- group into one series Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c

[Freedreno] [PATCH v10 4/5] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-10 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v10 5/5] drm/msm/dp: stop link training after link training 2 failed

2022-01-10 Thread Kuogee Hsieh
patch fixes link compliance test case 4.3.1.13 (Source Device Link Training EQ Fallback Test). Changes in v10: -- group into one series Fixes: 2e0adc765d88 ("drm/msm/dp: do not end dp link training until video is ready") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- d

[Freedreno] [PATCH v11 0/4] group dp driver related patches into one series

2022-01-11 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training

[Freedreno] [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-11 Thread Kuogee Hsieh
: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 80 + drivers/gpu/

[Freedreno] [PATCH v11 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-11 Thread Kuogee Hsieh
ommit text Changes in v10: -- group into one series Changes in v11: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh Reviewed

[Freedreno] [PATCH v11 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-11 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v11 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-11 Thread Kuogee Hsieh
ining until video is ready") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index f98df93..245e1b9 100644 --- a/drivers/gpu/

Re: [Freedreno] [RFC PATCH 2/7] drm/msm/dp: support attaching bridges to the DP encoder

2022-01-11 Thread Kuogee Hsieh
On 1/6/2022 9:26 PM, Dmitry Baryshkov wrote: On 07/01/2022 06:42, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-01-06 18:01:27) Currently DP driver will allocate panel bridge for eDP panels. Simplify this code to just check if there is any next bridge in the chain (be it a panel bridge o

Re: [Freedreno] [RFC PATCH 1/7] drm/msm/dp: fix panel bridge attachment

2022-01-12 Thread Kuogee Hsieh
ge support for eDP panels. Change panel_bridge attachment to come after dp_bridge attachment. Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Cc: Kuogee Hsieh Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 21 ++

Re: [Freedreno] [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-12 Thread Kuogee Hsieh
On 1/12/2022 12:00 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-11 10:43:23) Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code

Re: [Freedreno] [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Kuogee Hsieh
On 1/12/2022 8:13 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-12 14:17:54) On 1/12/2022 12:00 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-11 10:43:23) Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a

Re: [Freedreno] [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Kuogee Hsieh
On 1/13/2022 11:47 AM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-13 09:51:42) On 1/12/2022 8:13 PM, Stephen Boyd wrote: - if (dp->usbpd->orientation == ORIENTATION_CC2) - flip = true; + dp_power_init(dp->power, false); + dp_ctrl_reset_irq_ctrl

[Freedreno] [PATCH v12 0/4] group dp driver related patches into one series

2022-01-13 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training

[Freedreno] [PATCH v12 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Kuogee Hsieh
: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Changes in v12: -- move dp_display_host_phy_exit() after dp_display_host_deinit() Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/g

[Freedreno] [PATCH v12 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-13 Thread Kuogee Hsieh
ommit text Changes in v10: -- group into one series Changes in v11: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh Reviewed

[Freedreno] [PATCH v12 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-13 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v12 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-13 Thread Kuogee Hsieh
ining until video is ready") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index f98df93..245e1b9 100644 --- a/drivers/gpu/

Re: [Freedreno] [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Kuogee Hsieh
On 1/13/2022 1:52 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-13 12:44:16) On 1/13/2022 11:47 AM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-13 09:51:42) On 1/12/2022 8:13 PM, Stephen Boyd wrote: - if (dp->usbpd->orientation == ORIENTATION_CC2) -

[Freedreno] [PATCH v13 0/4] group dp driver related patches into one series

2022-01-13 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training

[Freedreno] [PATCH v13 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Kuogee Hsieh
dd DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 80 +- drivers/gpu/drm/msm/dp/dp_ctrl.h| 8 ++-- drivers/gpu/drm/msm/dp/dp_display.c | 85 +++-- 3 files c

[Freedreno] [PATCH v13 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-13 Thread Kuogee Hsieh
ommit text Changes in v10: -- group into one series Changes in v11: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh Reviewed

[Freedreno] [PATCH v13 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-13 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v13 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-13 Thread Kuogee Hsieh
ining until video is ready") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index f98df93..245e1b9 100644 --- a/drivers/gpu/

Re: [Freedreno] [PATCH v13 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Kuogee Hsieh
On 1/13/2022 6:42 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-13 15:53:36) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 7cc4d21..b3c5404 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c

[Freedreno] [PATCH v14 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-14 Thread Kuogee Hsieh
ommit text Changes in v10: -- group into one series Changes in v11: -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") Signee-off-by: Kuogee Hsieh Reviewed

[Freedreno] [PATCH v14 0/4] group dp driver related patches into one series

2022-01-14 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training

[Freedreno] [PATCH v14 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-14 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes

[Freedreno] [PATCH v14 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-14 Thread Kuogee Hsieh
ining until video is ready") Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index f98df93..245e1b9 100644 --- a/drivers/gpu/

[Freedreno] [PATCH v14 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Kuogee Hsieh
->core_initialized = false form dp_pm_suspend. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 80 drivers/gpu/drm/msm/dp/dp_ctrl.h| 8 ++--

[Freedreno] [PATCH v15 0/4] group dp driver related patches into one series

2022-01-14 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training

<    1   2   3   4   5   6   7   8   9   10   >