Re: [Freedreno] [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Krzysztof Kozlowski
On 13/12/2022 18:31, Abhinav Kumar wrote: > > > On 12/13/2022 5:13 AM, Krzysztof Kozlowski wrote: >> On 13/12/2022 00:41, Abhinav Kumar wrote: >>>>> >>>>> besides, i think i have to sent the whole series patches include this >>>>> one

Re: [Freedreno] [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Krzysztof Kozlowski
On 16/12/2022 20:11, Kuogee Hsieh wrote: > Move data-lanes property from mdss_dp node to dp_out endpoint. Also > add link-frequencies property into dp_out endpoint as well. The last > frequency specified at link-frequencies will be the max link rate > supported by DP. > > Changes in v5: > -- rever

Re: [Freedreno] [PATCH v15 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Krzysztof Kozlowski
On 16/12/2022 22:44, Kuogee Hsieh wrote: > Move data-lanes property from mdss_dp node to dp_out endpoint. Also > add link-frequencies property into dp_out endpoint as well. The last > frequency specified at link-frequencies will be the max link rate > supported by DP. > > Changes in v5: > -- rever

Re: [Freedreno] [PATCH v5 04/21] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of clocks. > > To f

Re: [Freedreno] [PATCH v5 04/21] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-12-22 Thread Krzysztof Kozlowski
On 22/12/2022 12:47, Krzysztof Kozlowski wrote: > On 20/12/2022 13:36, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, t

Re: [Freedreno] [PATCH v5 05/21] dt-bindings: msm: dsi-controller-main: Deprecate qcom, dsi-ctrl-6g-qcm2290 in favour of qcom, qcm2290-dsi-ctrl

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of the desired format > qcom,qcm2290-dsi-ctrl. > > Signed-off-by: Bryan O'Donoghue > --- > .../display/msm/dsi-controller-main.yaml | 36 +++ > 1 file changed, 21 insertions(+), 15 de

Re: [Freedreno] [PATCH v5 06/21] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-12-22 Thread Krzysztof Kozlowski
f > - - const: pixel > - - const: core > - - const: iface > - - const: bus > +minItems: 3 > +maxItems: 9 > >phys: > maxItems: 1 > @@ -157,6 +149,183 @@ required: >- assigned-clock-parents >- ports > > +allOf: > + - $ref: "../dsi-controller.yaml#" Drop the quotes. Add missing Ack. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v5 07/21] dt-bindings: msm: dsi-controller-main: Fix clock declarations

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > When converting from .txt to .yaml dt-binding descriptions we appear to > have missed some of the previous detail on the number and names of > permissible clocks. > > Fix this by listing the clock descriptions against the clock names at a > high level

Re: [Freedreno] [PATCH v5 08/21] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. In the .txt description we mark

Re: [Freedreno] [PATCH v5 09/21] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > Add the list of current compats absent the deprecated qcm2290 to the list > of dsi compats listed here. > > Signed-off-by: Bryan O'Donoghue > --- > .../bindings/display/msm/qcom,mdss.yaml | 16 +++- > 1 file changed, 15 insertio

Re: [Freedreno] [PATCH v5 10/21] dt-bindings: display/msm: Update MDSS dsi compat strings

2022-12-22 Thread Krzysztof Kozlowski
On 20/12/2022 13:36, Bryan O'Donoghue wrote: > Several MDSS yaml files exist which document the dsi sub-node. > For each existing SoC MDSS yaml, provide the right dsi compat string. > > Signed-off-by: Bryan O'Donoghue Same concerns about bisectability. Best regards, Krzysztof

Re: [Freedreno] [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Krzysztof Kozlowski
On 22/12/2022 17:22, Kuogee Hsieh wrote: > > On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: >> On 16/12/2022 20:11, Kuogee Hsieh wrote: >>> Move data-lanes property from mdss_dp node to dp_out endpoint. Also >>> add link-frequencies property into dp_out endpoint a

[Freedreno] [PATCH 2/2] dt-bindings: display: msm: drop unneeded list for single compatible

2022-12-25 Thread Krzysztof Kozlowski
With only one compatible, there is no need to define it as list (items). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/qcom,msm8998-dpu.yaml | 3 +-- .../devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml | 3 +-- .../devicetree/bindings/display/msm

[Freedreno] [PATCH 1/2] dt-bindings: display: msm: drop redundant part of title

2022-12-25 Thread Krzysztof Kozlowski
The Devicetree bindings document does not have to say in the title that contains "DT properties", but instead just describe the hardware. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/dsi-phy-common.yaml| 7 +++ .../devicetree/bindings/displa

Re: [Freedreno] [PATCH v2 1/1] dt-bindings: msm: dsi-phy-28nm: Add missing qcom, dsi-phy-regulator-ldo-mode

2022-12-29 Thread Krzysztof Kozlowski
On 28/12/2022 14:11, Bryan O'Donoghue wrote: > Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY. > When converting from .txt to .yaml we missed this one. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Reviewed-by: Dmitry Baryshkov > Sig

Re: [Freedreno] [PATCH v4 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-12-30 Thread Krzysztof Kozlowski
On 30/12/2022 16:35, Robert Foss wrote: > Use two interconnect cells in order to optionally > support a path tag. > > Signed-off-by: Robert Foss > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- > 1 file changed, 14 insertions(+), 14 de

Re: [Freedreno] [PATCH v4 07/11] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name

2022-12-30 Thread Krzysztof Kozlowski
On 30/12/2022 16:35, Robert Foss wrote: > The mmxc power-domain-name is not required, and is not > used by either earlier or later SoC versions (sm8250 / sm8450). > > Signed-off-by: Robert Foss > Reviewed-by: Konrad Dybcio > --- Please, do not mix fixes, cleanups and new features. This delays a

Re: [Freedreno] [PATCH] dt-bindings: msm: dsi-phy-28nm: Document fam-b compatible

2022-12-31 Thread Krzysztof Kozlowski
On 31/12/2022 18:05, Adam Skladowski wrote: > Document omitted 28nm compatible which will be used on MSM8976 SoC. > Commit msg is not entirely accurate - this compatible is already used in the Linux DSI PHY driver. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v4 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2023-01-03 Thread Krzysztof Kozlowski
On 02/01/2023 18:10, Robert Foss wrote: > On Fri, 30 Dec 2022 at 17:12, Krzysztof Kozlowski > wrote: >> >> On 30/12/2022 16:35, Robert Foss wrote: >>> Use two interconnect cells in order to optionally >>> support a path tag. >>> >>> Sign

Re: [Freedreno] [PATCH v4 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2023-01-03 Thread Krzysztof Kozlowski
On 03/01/2023 10:24, Robert Foss wrote: On which tree/revision did you base this? >>> >>> msm/drm-msm-display-for-6.2 >> >> Then it is not a proper base for DTS changes - you will miss quite some >> commits. The DTS patches should be based on Bjorn's SoC tree or >> linux-next (although the lat

Re: [Freedreno] [PATCH v6 03/11] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs

2023-01-06 Thread Krzysztof Kozlowski
On 07/12/2022 02:22, Dmitry Baryshkov wrote: > SM8350 and SM8450 platforms use the same driver and same bindings as the > existing 7nm DSI PHYs. Add corresponding compatibility strings. > > Acked-by: Krzysztof Kozlowski > Signed-off-by: Dmitry Baryshkov > --- > Doc

Re: [Freedreno] [PATCH 1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-06 Thread Krzysztof Kozlowski
On 04/01/2023 10:08, Neil Armstrong wrote: > Document the SM8550 DSI PHY which is very close from the 7nm > and 5nm DSI PHYs found in earlier platforms. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > 1 file changed, 1 insertion(+

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 10:26, Neil Armstrong wrote: > Document the SM8550 DSI PHY which is very close from the 7nm > and 5nm DSI PHYs found in earlier platforms. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 10:26, Neil Armstrong wrote: > Document the DPU hardware found on the Qualcomm SM8550 platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 > + > 1 file changed, 134 insertions(+) R

Re: [Freedreno] [PATCH v2 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Krzysztof Kozlowski
s(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH] dt-bindings: display/msm: gpu: add rbcpr clock

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 06:44, Dmitry Baryshkov wrote: > Describe the RBCPR clock used on msm8996 (A530), MSM8998 (A540) and > SDM630/660 (A508/A512). > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 2 ++ Acked-by: Krzysztof Kozlows

Re: [Freedreno] [PATCH] dt-bindings: display/msm: qcom, sdm845-mdss: document the DP device

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 05:54, Dmitry Baryshkov wrote: > Document the DP controller added to the sdm845 display subsystem. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 6 ++ > 1 file changed, 6 insertions(+) > R

Re: [Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY

2023-01-16 Thread Krzysztof Kozlowski
On 16/01/2023 12:51, Konrad Dybcio wrote: > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. > > Signed-off-by: Konrad Dybcio > --- Acked-by: K

Re: [Freedreno] [PATCH 1/2] dt-bindings: display/msm: Add SM6375 DSI PHY

2023-01-16 Thread Krzysztof Kozlowski
On 16/01/2023 12:40, Konrad Dybcio wrote: > SM6375 has a single 7nm DSI PHY. Document it. > > Signed-off-by: Konrad Dybcio > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-01-19 Thread Krzysztof Kozlowski
On 18/01/2023 20:30, Mark Yacoub wrote: > From: Sean Paul > > This patch adds the register ranges required for HDCP key injection and Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 This applies to all your patches

Re: [Freedreno] [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-01-19 Thread Krzysztof Kozlowski
On 18/01/2023 20:30, Mark Yacoub wrote: > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. > > Acked-by: Jani Nikula > Acked-by: Jani Nikula > Reviewed-

[Freedreno] [PATCH] dt-bindings: drop type for operating-points-v2

2023-01-19 Thread Krzysztof Kozlowski
The type for operating-points-v2 property is coming from dtschema (/schemas/opp/opp.yaml), so individual bindings can just use simple "true". Signed-off-by: Krzysztof Kozlowski --- This depends on my pull request, at least logically: https://github.com/devicetree-org/dt-schema/pull

Re: [Freedreno] [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-01-21 Thread Krzysztof Kozlowski
On 20/01/2023 16:54, Sean Paul wrote: > On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote: >> On 18/01/2023 20:30, Mark Yacoub wrote: >>> From: Sean Paul >>> >>> This patch adds the register ranges required for HDCP key injection and

Re: [Freedreno] [PATCH v2 1/3] drm/msm/gpu: Add devfreq tuning debugfs

2023-01-23 Thread Krzysztof Kozlowski
On 11/01/2023 00:14, Rob Clark wrote: > From: Rob Clark > > Make the handful of tuning knobs available visible via debugfs. > > v2: select DEVFREQ_GOV_SIMPLE_ONDEMAND because for some reason > struct devfreq_simple_ondemand_data depends on this > > Signed-off-by: Rob Clark > --- For some

Re: [Freedreno] [PATCH 1/6] dt-bindings: phy: qcom, hdmi-phy-other: use pxo clock

2023-01-26 Thread Krzysztof Kozlowski
) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Krzysztof Kozlowski
On 06/02/2023 11:17, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 > 1 file changed, 4 insertion

Re: [Freedreno] [PATCH v2 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-10 Thread Krzysztof Kozlowski
On 10/02/2023 11:34, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v3 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-11 Thread Krzysztof Kozlowski
On 10/02/2023 16:27, Neil Armstrong wrote: > On 10/02/2023 16:16, Dmitry Baryshkov wrote: >> On 10/02/2023 16:44, Neil Armstrong wrote: >>> The SM8450 & SM350 shares the same DT TX IP version, use the >>> SM8350 compatible as fallback for SM8450. >>&

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-02-17 Thread Krzysztof Kozlowski
On 16/02/2023 14:14, Konrad Dybcio wrote: > Since the DSI autodetection is bound to work correctly on 6115 now, > switch to using the correct per-SoC + generic fallback compatible > combo. > > Signed-off-by: Konrad Dybcio > --- > Depends on (and should have been a part of): > > https://lore.kern

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:13, Konrad Dybcio wrote: > SM6115 previously erroneously added just "qcom,dsi-ctrl-6g-qcm2290", > without the generic fallback. Fix the deprecated binding to reflect > that. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible > strings for every curren

Re: [Freedreno] [PATCH v2 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-02-17 Thread Krzysztof Kozlowski
part of): > > https://lore.kernel.org/linux-arm-msm/20230213121012.1768296-1-konrad.dyb...@linaro.org/ > > v1 -> v2: > - Deprecate the old compatible instead of removing it (Krzysztof) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:32, Konrad Dybcio wrote: > > > On 17.02.2023 12:30, Krzysztof Kozlowski wrote: >> On 17/02/2023 12:13, Konrad Dybcio wrote: >>> SM6115 previously erroneously added just "qcom,dsi-ctrl-6g-qcm2290", >>> without the generic fallback. Fix

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:36, Konrad Dybcio wrote: >>> >>> compatible = "qcom,dsi-ctrl-6g-qcm2290"; >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm6115.dtsi?h=next-20230217#n1221 >> >> I meant, that original commit wanted to deprecate: >> compatible="

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-18 Thread Krzysztof Kozlowski
On 17/02/2023 22:13, Bryan O'Donoghue wrote: > On 17/02/2023 12:24, Krzysztof Kozlowski wrote: >> First, it would be nice to know what was the intention of Bryan's commit? > > Sorry I've been grazing this thread but, not responding. > > - qcom,dsi-ctrl-6g-qcm

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-18 Thread Krzysztof Kozlowski
On 18/02/2023 12:23, Konrad Dybcio wrote: > > > On 18.02.2023 11:14, Krzysztof Kozlowski wrote: >> On 17/02/2023 22:13, Bryan O'Donoghue wrote: >>> On 17/02/2023 12:24, Krzysztof Kozlowski wrote: >>>> First, it would be nice to know what was the intent

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-20 Thread Krzysztof Kozlowski
On 20/02/2023 11:24, Konrad Dybcio wrote: > > > On 18.02.2023 15:49, Krzysztof Kozlowski wrote: >> On 18/02/2023 12:23, Konrad Dybcio wrote: >>> >>> >>> On 18.02.2023 11:14, Krzysztof Kozlowski wrote: >>>> On 17/02/2023 22:13, Bryan

Re: [Freedreno] [PATCH v3 01/15] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-02-24 Thread Krzysztof Kozlowski
On 23/02/2023 13:06, Konrad Dybcio wrote: > GMU wrapper-equipped A6xx GPUs require clocks and clock-names to be > specified under the GPU node, just like their older cousins. > Account for that. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/gpu.yaml | 63 > +

Re: [Freedreno] [PATCH v3 02/15] dt-bindings: display/msm/gmu: Add GMU wrapper

2023-02-24 Thread Krzysztof Kozlowski
On 23/02/2023 13:06, Konrad Dybcio wrote: > GMU wrapper is essentially a register space within the GPU, which > Linux sees as a dumbed-down regular GMU: there's no clocks, > interrupts, multiple regs, iommus and OPP. Document it. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/d

Re: [Freedreno] [PATCH v3 01/15] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-02-24 Thread Krzysztof Kozlowski
On 24/02/2023 12:51, Konrad Dybcio wrote: >>> +else: >>> + if: >>> +properties: >>> + compatible: >>> +contains: >>> + pattern: '^qcom,adreno-6[0-9][0-9]\.[0-9]$' >>> + >>> + then: # Starting with A6xx, the clocks are usually defined in the >

Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-06 Thread Krzysztof Kozlowski
On 04/03/2023 16:55, Konrad Dybcio wrote: > The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" > alone. This however didn't quite work out and the property became s/property/compatible/ > undocumented instead of deprecated. Fix that. Reviewed-by: Krz

Re: [Freedreno] [PATCH v3 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-03-06 Thread Krzysztof Kozlowski
On 04/03/2023 16:55, Konrad Dybcio wrote: > Since the DSI autodetection is bound to work correctly on 6115 now, > switch to using the correct per-SoC + generic fallback compatible > combo. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml

Re: [Freedreno] [PATCH v3 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-03-07 Thread Krzysztof Kozlowski
On 06/03/2023 11:06, Konrad Dybcio wrote: > > > On 6.03.2023 09:57, Krzysztof Kozlowski wrote: >> On 04/03/2023 16:55, Konrad Dybcio wrote: >>> Since the DSI autodetection is bound to work correctly on 6115 now, >>> switch to using the correct per-SoC + gene

Re: [Freedreno] [PATCH v2 8/9] dt-bindings: display/msm: dsi-controller-main: Add SM6115

2023-03-07 Thread Krzysztof Kozlowski
On 13/02/2023 13:10, Konrad Dybcio wrote: > Add a compatible for the DSI on SM6115. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml| 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/ms

Re: [Freedreno] [PATCH v2 8/9] dt-bindings: display/msm: dsi-controller-main: Add SM6115

2023-03-07 Thread Krzysztof Kozlowski
On 07/03/2023 12:14, Konrad Dybcio wrote: > > > On 7.03.2023 10:17, Krzysztof Kozlowski wrote: >> On 13/02/2023 13:10, Konrad Dybcio wrote: >>> Add a compatible for the DSI on SM6115. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>>

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8650 compatible

2023-12-07 Thread Krzysztof Kozlowski
On 07/12/2023 17:37, Neil Armstrong wrote: > Document the DisplayPort controller found in the Qualcomm SM8650 SoC, > the Controller base addresses and layout differ and thus cannot use > the SM8350 compatible as fallback. > > Signed-off-by: Neil Armstrong > --- Reviewed-by: K

Re: [PATCH 1/9] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-11 Thread Krzysztof Kozlowski
On 10/12/2023 00:21, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/9] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-11 Thread Krzysztof Kozlowski
On 10/12/2023 00:21, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/8] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-12 Thread Krzysztof Kozlowski
On 11/12/2023 16:44, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- DT list... Best regards, Krzysztof

Re: [PATCH 2/8] dt-bindings: dsi-controller-main: Document missing msm8976 compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > When all dsi-ctrl compats were added msm8976 was missed, include it too. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/8] dt-bindings: msm: qcom,mdss: Include ommited fam-b compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > During conversion 28nm-hpm-fam-b compat got lost, add it. Please add Fixes tag and put this commit as first in your patchset or even as separate one. Best regards, Krzysztof

Re: [PATCH 5/8] dt-bindings: drm/msm/gpu: Document AON clock for A506/A510

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > Adreno 506(MSM8953) and Adreno 510(MSM8976) require > Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for X1E80100

2024-01-30 Thread Krzysztof Kozlowski
On 29/01/2024 14:18, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH 1/5] dt-bindings: display/msm: document MDSS on X1E80100

2024-01-30 Thread Krzysztof Kozlowski
es some note. > .../bindings/display/msm/qcom,x1e80100-mdss.yaml | 249 > + > 1 file changed, 249 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"

2024-02-05 Thread Krzysztof Kozlowski
| 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/8] dt-bindings: msm: qcom,mdss: Include ommited fam-b compatible

2024-02-05 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > During conversion 28nm-hpm-fam-b compat got lost, add it. > > Signed-off-by: Adam Skladowski > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] dt-bindings: display/msm: Document the DPU for X1E80100

2024-02-20 Thread Krzysztof Kozlowski
On 16/02/2024 18:01, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Krzysztof Kozlowski
On 20/02/2024 22:23, Konrad Dybcio wrote: > On 20.02.2024 18:31, Dmitry Baryshkov wrote: >> The patch adding Type-C support for sm6115 was misapplied. All the >> orientation switch configuration ended up at the UFS PHY node instead of >> the USB PHY node. Move the data bits to the correct place. >>

Re: [PATCH v3 2/7] dt-bindings: arm-smmu: fix SM8[45]50 GPU SMMU if condition

2024-02-22 Thread Krzysztof Kozlowski
U SMMU") > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/7] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-22 Thread Krzysztof Kozlowski
On 16/02/2024 12:03, Neil Armstrong wrote: > Document the GPU SMMU found on the SM8650 platform. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Krzyszto

Re: [PATCH v2 1/7] dt-bindings: clock: Add Qcom QCM2290 GPUCC

2024-02-24 Thread Krzysztof Kozlowski
On 23/02/2024 22:21, Konrad Dybcio wrote: > Add device tree bindings for graphics clock controller for Qualcomm > Technology Inc's QCM2290 SoCs. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-25 Thread Krzysztof Kozlowski
On 24/02/2024 23:34, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 17:55, Abel Vesa wrote: >> >> Add the X1E80100 to the list of compatibles and document the is-edp >> flag. The controllers are expected to operate in DP mode by default, >> and this flag can be used to select eDP mode. >> >> Sig

Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-27 Thread Krzysztof Kozlowski
On 22/02/2024 16:55, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and document the is-edp > flag. The controllers are expected to operate in DP mode by default, > and this flag can be used to select eDP mode. > > Signed-off-by: Abel Vesa > --- > Documentation/devicetree/binding

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > diff --git > a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > index c0d6a4fdff97..40b077fb20aa 100644 > --- a/Documentation/devicetree/bindings/display/msm

Re: [RFC PATCH 1/1] dt-bindings: display/msm: gpu: Split Adreno schemas into separate files

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:05, Adam Skladowski wrote: > Split shared schema into per-gen and group adrenos by clocks used. > > Signed-off-by: Adam Skladowski > --- > .../devicetree/bindings/display/msm/gpu.yaml | 317 ++ > .../bindings/display/msm/qcom,adreno-306.yaml | 115 +++ > ...

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 27/03/2024 09:52, Dmitry Baryshkov wrote: > On Wed, 27 Mar 2024 at 10:45, Krzysztof Kozlowski > wrote: >> >> On 26/03/2024 21:02, Dmitry Baryshkov wrote: >>> diff --git >>> a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml >>>

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > As Qualcomm SM8150 got support for the DisplayPort, add displayport@ > node as a valid child to the MDSS node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-29 Thread Krzysztof Kozlowski
On 28/03/2024 12:11, Jun Nie wrote: > Add DSI mode property and compression mode property > > Signed-off-by: Jun Nie > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 8 > 1 file changed, 8 insertions(+) > Please use scripts/get_maintainers.pl to get a list of necess

Re: [PATCH v2 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-30 Thread Krzysztof Kozlowski
On 29/03/2024 08:45, Luca Weiss wrote: > Document the displayport controller subnode of the SM6350 MDSS. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-30 Thread Krzysztof Kozlowski
On 27/03/2024 11:11, Krzysztof Kozlowski wrote: > On 26/03/2024 21:02, Dmitry Baryshkov wrote: >> As Qualcomm SM8150 got support for the DisplayPort, add displayport@ >> node as a valid child to the MDSS node. >> >> Signed-off-by: Dmitry Baryshkov >> --- > >

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:14, Dmitry Baryshkov wrote: >> >> I didnt follow why this is a link property. Sorry , I didnt follow the >> split part. > > There is a link between the DSI host and the panel. I don't want to > end up in a situation when the properties of the link are split

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:32, Dmitry Baryshkov wrote: > On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:14, Dmitry Baryshkov wrote: >>>>>>>> >>>>>>>> I didnt follow why this is a link property. Sorry , I didnt

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
the default. In such case the property can > be skipped. > > Signed-off-by: Dmitry Baryshkov Maybe we need third DT maintainer review/ack... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 19:52, Abhinav Kumar wrote: > > > On 6/4/2024 8:36 AM, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:32, Dmitry Baryshkov wrote: >>> On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >>>> On 04/06/2024 17:14, Dmitry Baryshkov

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
mm SM7150 Display DPU What is DPU? Such acronyms should be explained in description or expanded here, if there is space. Reviewed-by: Krzysztof Kozlowski > + > +maintainers: > + - Danila Tikhonov > + > +$ref: /schemas/display/msm/dpu-common.yaml# > + > +properties: > + compatible: > +const: qcom,sm7150-dpu > + Best regards, Krzysztof

Re: [PATCH v2 1/4] dt-bindings: display/msm: Add SM7150 MDSS

2024-06-13 Thread Krzysztof Kozlowski
On 12/06/2024 20:43, Danila Tikhonov wrote: > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
On 13/06/2024 12:13, Dmitry Baryshkov wrote: > On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: >> On 12/06/2024 20:43, Danila Tikhonov wrote: >>> Document the DPU hardware found on the Qualcomm SM7150 platform. >> >> In general, this should be b

Re: [PATCH 1/4] dt-bindings: display/msm: qcom, mdp5: Add msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > Add the compatible for the MDP5 found on MSM8937. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you know

Re: [PATCH 3/4] dt-bindings: msm: dsi-phy-28nm: Document msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > The MSM8937 SoC uses a slightly different 28nm dsi phy. Add a new > compatible for it. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > naming scheme for Adreno GPU, 'X' stands for compute series, '1' denotes > 1st generation and '8' & '5' denotes

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 ++++ Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Add the necessary dt nodes for gpu support in X1E80100. > > Signed-off-by: Akhil P Oommen > --- > + gmu: gmu@3d6a000 { > + compatible = "qcom,adreno-gmu-x185.1", > "qcom,adreno-gmu"; > + reg = <0x0 0

[PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Signed-off-by: Krzysztof Kozlowski --- Documentation

[PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 - 1 file chang

[PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
MMIO address space is known per each variant of Adreno GPU, so we can constrain the reg/reg-names entries for each variant. There is no DTS for A619, so that part is not accurate but could be corrected later. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/gpu.yaml

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindin

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 14:28, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oomm

[PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
work-around do the binding can be used against DTS validation. Signed-off-by: Krzysztof Kozlowski --- Cc: Akhil P Oommen --- .../devicetree/bindings/display/msm/gmu.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 16:13, Conor Dooley wrote: > On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: >> MMIO address space is known per each variant of Adreno GPU, so we can >> constrain the reg/reg-names entries for each variant. There is no DTS >> for A619

[PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-23 Thread Krzysztof Kozlowski
rrect way. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index c3703a51287b..a8afe0b6429b 100644 --- a/d

[PATCH 2/2] arm64: dts: qcom: sm8150-mtp: drop incorrect amd,imageon

2024-06-23 Thread Krzysztof Kozlowski
was added in commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") to the SM8150 and later moved to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: qcom: sm8150: Don't start Adreno in headless mode") with an intention to allow headless mode. This shou

<    1   2   3   4   5   6   7   >