Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-11 Thread Krzysztof Kozlowski
On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> If your child schema fails, the referencing schema fails as well... > > > Although now with DSI-PHY I cannot reproduce it and I am pretty sure I > reproduced it with DPU controllers after modifying the DTS to lack a > pr

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-15 Thread Krzysztof Kozlowski
On 15/09/2022 12:50, Dmitry Baryshkov wrote: > On 11/09/2022 22:19, Krzysztof Kozlowski wrote: >> On 11/09/2022 20:36, Krzysztof Kozlowski wrote: >> >>>> If your child schema fails, the referencing schema fails as well... >>> >>> >>> Although

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-17 Thread Krzysztof Kozlowski
icinc SoB (unless you also take ownership). Acked-by: Krzysztof Kozlowski \ Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-20 Thread Krzysztof Kozlowski
On 19/09/2022 23:18, Bjorn Andersson wrote: > On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof Kozlowski wrote: >> On 16/09/2022 21:00, Bjorn Andersson wrote: >>> From: Bjorn Andersson >>> >>> Add compatibles for the DisplayPort and Embedded DisplayPo

Re: [Freedreno] [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema.

Re: [Freedreno] [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The d

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [Freedreno] [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > +--

Re: [Freedreno] [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/qcom,msm8998-mdss.yaml| 12 + > .../display/msm/qcom,qcm2290-mdss.ya

Re: [Freedreno] [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-common.yaml | 4 +- > .../bindings/display/msm/qcom,sm8250-dpu.yaml | 92 +++

Re: [Freedreno] [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:50, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all DPU DT nodes to the dpu-common.yaml. >>> >>> Note, this remo

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 09:53, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all MDSS DT nodes to the mdss-common.yaml. >>> >>> T

Re: [Freedreno] [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 12:30, Dmitry Baryshkov wrote: >>> +display-subsystem@ae0 { >>> +#address-cells = <1>; >>> +#size-cells = <1>; >>> +compatible = "qcom,sc7180-mdss"; >>> +reg = <0xae0 0x1000>; >>> +reg-names = "mdss"; >>> +power-domains = <&d

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:47, Dmitry Baryshkov wrote: missing allOf >>> >>> Rob asked to remove this while reviewing v6 ([1]). And indeed the >>> allOf's around a single $ref do not seem to be necessary >> >> He commented on one of properties, not top-level, maybe it is different >> case for dtsc

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>> - ranges: true >>> +maxItems: 2 >>> >>> interconnects: >>> -items: >>> - - description: Interconnect path from mdp0 port to the data bus >>> - - description: Interconnect path from mdp1 port to the data bus >>> +maxItems

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-22 Thread Krzysztof Kozlowski
On 22/09/2022 02:14, Bjorn Andersson wrote: > On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: >> On 19/09/2022 23:18, Bjorn Andersson wrote: >>> On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof Kozlowski wrote: >>>> On 16/09/2022 21:00, Bjo

Re: [Freedreno] [PATCH 0/9] arm: dts: qcom: rename DSI PHY nodes

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:00, Dmitry Baryshkov wrote: > Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace > them with generic phy@ names. > > Dmitry Baryshkov (9): > ARM: dts: qcom-apq8064: change DSI PHY node name to generic one dsi-phy is similar to other generic names (usb-phy,

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 10:51, Dmitry Baryshkov wrote: > From: Loic Poulain > > QCM2290 platform uses the 14nm DSI PHY driver. > > Signed-off-by: Loic Poulain > [DB: changed compat to follow the agreed scheme] Bjorn asked to keep consistency in other case: https://lore.kernel.org/all/20220829210408.gxbv

Re: [Freedreno] [PATCH 0/9] arm: dts: qcom: rename DSI PHY nodes

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:20, Dmitry Baryshkov wrote: > On 24/09/2022 12:11, Krzysztof Kozlowski wrote: >> On 24/09/2022 11:00, Dmitry Baryshkov wrote: >>> Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace >>> them with generic phy@ names. >>> >&

Re: [Freedreno] [PATCH 1/9] ARM: dts: qcom-apq8064: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 2/9] ARM: dts: qcom-msm8974: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 3/9] arm64: dts: qcom: msm8916: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 4/9] arm64: dts: qcom: msm8996: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 5/9] arm64: dts: qcom: sc7180: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 6/9] arm64: dts: qcom: sdm630: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 7/9] arm64: dts: qcom: sdm660: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 8/9] arm64: dts: qcom: sdm845: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 9/9] arm64: dts: qcom: sm8250: change DSI PHY node name to generic one

2022-09-24 Thread Krzysztof Kozlowski
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v8 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-24 Thread Krzysztof Kozlowski
ted in the > schema. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/dpu-sdm845.yaml| 10 ++ > 1 file changed, 10 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives

Re: [Freedreno] [PATCH v8 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-24 Thread Krzysztof Kozlowski
On Sat, 24 Sep 2022 15:36:00 +0300, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-25 Thread Krzysztof Kozlowski
On 24/09/2022 11:15, Dmitry Baryshkov wrote: > On 24/09/2022 12:12, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:51, Dmitry Baryshkov wrote: >>> From: Loic Poulain >>> >>> QCM2290 platform uses the 14nm DSI PHY driver. >>> >>> Signed-off-b

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-26 Thread Krzysztof Kozlowski
On 26/09/2022 17:13, Rob Herring wrote: > On Thu, Sep 22, 2022 at 05:37:39PM +0200, Krzysztof Kozlowski wrote: >> On 22/09/2022 02:14, Bjorn Andersson wrote: >>> On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: >>>> On 19/09/2022 23:18, Bjorn Ande

Re: [Freedreno] [PATCH 1/2] ARM: dts: qcom-apq8064: change HDMI PHY node name to generic one

2022-09-29 Thread Krzysztof Kozlowski
On 24/09/2022 11:43, Dmitry Baryshkov wrote: > Change HDMI PHY node names from custom 'hdmi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 2/2] arm64: dts: qcom: msm8996: change HDMI PHY node name to generic one

2022-09-29 Thread Krzysztof Kozlowski
On 24/09/2022 11:43, Dmitry Baryshkov wrote: > Change HDMI PHY node name from custom 'hdmi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-10-03 Thread Krzysztof Kozlowski
On 23/09/2022 22:32, Dmitry Baryshkov wrote: > On 22/09/2022 15:28, Krzysztof Kozlowski wrote: >> On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>>>> - ranges: true >>>>> +maxItems: 2 >>>>> >>>>> interconnects: >

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-21 Thread Krzysztof Kozlowski
On 21/10/2022 12:55, Dmitry Baryshkov wrote: > Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 > platforms and for the Qualcomm v2 SMMU used on SDM630 platform. > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++ >

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-22 Thread Krzysztof Kozlowski
On 22/10/2022 05:17, Dmitry Baryshkov wrote: > On 22/10/2022 03:59, Krzysztof Kozlowski wrote: >> On 21/10/2022 12:55, Dmitry Baryshkov wrote: >>> Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 >>> platforms and for the Qualcomm v2 SMMU used on SDM6

Re: [Freedreno] [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles

2022-10-22 Thread Krzysztof Kozlowski
On 21/10/2022 12:55, Dmitry Baryshkov wrote: > Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 > platforms and for the Qualcomm v2 SMMU used on SDM630 platform. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH 3/9] dt-bindings: arm-smmu: Add generic qcom, smmu-500 bindings

2022-10-22 Thread Krzysztof Kozlowski
; Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > nodes the display subsystem is configured to support > one DSI output. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 196 ++- > 1 file changed,

Re: [Freedreno] [PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Enable the display subsystem and the dsi0 output for > the sm8350-hdk board. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/

Re: [Freedreno] [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > In order to toggle the board to enable the HDMI output, > switch #7 & #8 on the rightmost multi-switch package have > to be toggled to On. > > Signed-off-by: Robert Foss > --- > arch/arm

Re: [Freedreno] [RFC PATCH v2 01/11] arm64: dts: qcom: msm8996: change order of SMMU clocks on this platform

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Change order of SMMU clocks to match the schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 03/11] dt-bindings: arm-smmu: fix clocks/clock-names schema

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Rework clocks/clock-names properties schema to property describe > possible usage cases. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 03/11] dt-bindings: arm-smmu: fix clocks/clock-names schema

2022-11-02 Thread Krzysztof Kozlowski
On 02/11/2022 14:44, Dmitry Baryshkov wrote: > Rework clocks/clock-names properties schema to property describe s/property/properly/ with that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RFC PATCH v2 04/11] dt-bindings: arm-smmu: add special case for Google Cheza platform

2022-11-02 Thread Krzysztof Kozlowski
o arm,smmu.yaml schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [RESEND PATCH v1] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 18:08, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) > schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: >- interconnects, interconnect-names >- iommu

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: display/msm/dsi-controller-main: allow defining opp-table

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Allow defining DSI OPP table inside the DSI controller node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 2/8] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > SM8350 and SM8450 platforms use the same driver and same bindings as the > existing 7nm DSI PHYs. Add corresponding compatibility strings. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-03 Thread Krzysztof Kozlowski
On 02/11/2022 19:13, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml | 34

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 08:34, Dmitry Baryshkov wrote: > On 03/11/2022 17:03, Krzysztof Kozlowski wrote: >> On 02/11/2022 19:13, Dmitry Baryshkov wrote: >>> Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm >>> SM8450 platform. >>>

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 08:45, Dmitry Baryshkov wrote: > On 03/11/2022 17:03, Krzysztof Kozlowski wrote: >> On 02/11/2022 19:13, Dmitry Baryshkov wrote: >>> Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm >>> SM8450 platform. >>>

Re: [Freedreno] [PATCH] dt-bindings: qcom: add another exception to the device naming rule

2022-11-04 Thread Krzysztof Kozlowski
1 + > 1 file changed, 1 insertion(+) Thanks Dmitry! Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v1 2/5] arm64: dts: qcom: sm8450: add display hardware devices

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > Add devices tree nodes describing display hardware on SM8450: > - Display Clock Controller > - MDSS > - MDP > - two DSI controllers and DSI PHYs > > This does not provide support for DP controllers present on SM8450. > > Signed-off-by: Dmitry Baryshk

Re: [Freedreno] [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 + > 1 file changed, 61 insertions(+)

Re: [Freedreno] [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

2022-11-04 Thread Krzysztof Kozlowski
remote-endpoint = <<9611_a>; > + data-lanes = <0 1 2 3>; > + }; > + }; > + }; > + Drop blank line. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-07 Thread Krzysztof Kozlowski
On 07/11/2022 11:46, Konrad Dybcio wrote: > > > On 06/11/2022 05:30, Bjorn Andersson wrote: >> On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: >>> Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel >>> configuration (yet). >>> >>> Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH v3 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-08 Thread Krzysztof Kozlowski
On 04/11/2022 14:03, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ > .../display/msm/qcom,sm8450-mdss.yaml | 34

Re: [Freedreno] [PATCH v9 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The d

Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-08 Thread Krzysztof Kozlowski
On 24/10/2022 18:42, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. (...) > +minItems: 1 > +items:

Re: [Freedreno] [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint

2022-11-08 Thread Krzysztof Kozlowski
be the case for the apq8064 so we shouldn't > be marking power-domain as required in yaml checks. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Reviewed-by: Dmitry Baryshkov > Cc: Rob Clark > Cc: Abhinav Kumar > C

Re: [Freedreno] [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-08 Thread Krzysztof Kozlowski
;dt-bindings: msm: dsi: add yaml schemas for DSI > bindings") > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: linux-arm-...@vger.kerne

Re: [Freedreno] [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > There's a typo in describing the core clock as an 'escape' clock. The > accurate description is 'core'. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI > bindings")

Re: [Freedreno] [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > Sort the order of the compatible strings alphanumerically. > > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: K

Re: [Freedreno] [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-08 Thread Krzysztof Kozlowski
On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significan

Re: [Freedreno] [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-11-08 Thread Krzysztof Kozlowski
d Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: linux-arm-...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicet...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Signed-off-by: B

Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-10 Thread Krzysztof Kozlowski
On 10/11/2022 22:45, Dmitry Baryshkov wrote: >> >>> + - reg >>> + - reg-names >>> + - power-domains >>> + - clocks >>> + - interrupts >>> + - interrupt-controller >>> + - iommus >>> + - ranges >> >> Keep the same order as in list of top-level properties. > > But the order is the same. Yes

Re: [Freedreno] [PATCH v2 00/12] Enable Display for SM8350

2022-11-15 Thread Krzysztof Kozlowski
On 15/11/2022 14:30, Robert Foss wrote: > Dependencies: > https://lore.kernel.org/all/20221102231309.583587-1-dmitry.barysh...@linaro.org/ > https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ > https://lore.kernel.org/all/20221104130324.1024242-5-dmitry.barysh...@lina

Re: [Freedreno] [PATCH v1 00/10] iommu/arm-smmu-qcom: Rework Qualcomm SMMU bindings and implementation

2022-11-18 Thread Krzysztof Kozlowski
On 14/11/2022 18:06, Dmitry Baryshkov wrote: > The main goal of this patchset is to define a generic qcom,smmu-500 > binding to be used by newer Qualcomm platforms instead of defining each > and every SoC line with no actual differences between the compats. > > While preparing this change it was r

Re: [Freedreno] [PATCH v1 03/10] dt-bindings: arm-smmu: add special case for Google Cheza platform

2022-11-18 Thread Krzysztof Kozlowski
o arm,smmu.yaml schema. > > Signed-off-by: Dmitry Baryshkov You already got my tag. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-11-23 Thread Krzysztof Kozlowski
On 23/11/2022 00:36, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov > --- > + > &sdhc_2 { > cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>; > pinct

Re: [Freedreno] [PATCH v4 01/11] dt-bindings: display/msm: *dpu.yaml: split required properties clauses

2022-11-23 Thread Krzysztof Kozlowski
lared in given schema, which makes the code a bit more readable and easy to follow. Reviewed-by: Krzysztof Kozlowski Suggested-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v4 02/11] dt-bindings: display/msm: *mdss.yaml: split required properties clauses

2022-11-23 Thread Krzysztof Kozlowski
have a tag for such request: Suggested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v4 03/11] dt-bindings: display/msm: mdss-common: make clock-names required

2022-11-23 Thread Krzysztof Kozlowski
On 23/11/2022 00:12, Dmitry Baryshkov wrote: > Mark clock-names property as required to be used on all MDSS devices. This we see from the diff. Please tell why you are doing it. In some other recent bindings we dropped clock-names from required, so this is confusing. > > Signed-off-by: Dmitry Ba

Re: [Freedreno] [PATCH v4 00/11] drm/msm: add support for SM8450

2022-11-23 Thread Krzysztof Kozlowski
On 23/11/2022 00:12, Dmitry Baryshkov wrote: > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8450 platform. > > Dependencies for the DT bindings: [1]. > > [1] > https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ > I don't get... this was merged, so how

Re: [Freedreno] [PATCH v4 04/11] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs

2022-11-23 Thread Krzysztof Kozlowski
On 23/11/2022 00:12, Dmitry Baryshkov wrote: > SM8350 and SM8450 platforms use the same driver and same bindings as the > existing 7nm DSI PHYs. Add corresponding compatibility strings. > > Signed-off-by: Dmitry Baryshkov Didn't you have here tag? What changed? Best regards, Krzysztof

Re: [Freedreno] [PATCH v4 05/11] dt-bindings: display/msm: add support for the display on SM8450

2022-11-23 Thread Krzysztof Kozlowski
On 23/11/2022 00:12, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 139 +++ > .../display/msm/qcom,sm8450-mdss.yaml | 35

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: display/msm: add support for SM6115

2022-11-25 Thread Krzysztof Kozlowski
qcm2290, sm6115 and sm6125 > this phy is supplied via power domain, not regulator. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v3 03/18] dt-bindings: msm: dsi-controller-main: Rename qcom, dsi-ctrl-6g-qcm2290 to qcom, qcm2290-dsi-ctrl

2022-11-26 Thread Krzysztof Kozlowski
On 24/11/2022 01:47, Bryan O'Donoghue wrote: > We will add in a number of compat strings to dsi-controller-main.yaml in > the format "qcom,socname-dsi-ctrl" convert the currently unused > qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl. It is used: drivers/gpu/drm/msm/dsi/dsi.c > > Signed-off-

Re: [Freedreno] [PATCH v3 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-26 Thread Krzysztof Kozlowski
On 24/11/2022 01:47, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of clocks. > > To f

Re: [Freedreno] [PATCH v3 07/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations

2022-11-26 Thread Krzysztof Kozlowski
On 24/11/2022 01:47, Bryan O'Donoghue wrote: > When converting from .txt to .yaml dt-binding descriptions we appear to > have missed some of the previous detail on the number and names of > permissible clocks. > > Fix this by listing the clock descriptions against the clock names at a > high level

Re: [Freedreno] [PATCH v3 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-11-26 Thread Krzysztof Kozlowski
On 24/11/2022 01:47, Bryan O'Donoghue wrote: > Each compatible has a different set of clocks which are associated with it. > Add in the list of clocks for each compatible. > > Signed-off-by: Bryan O'Donoghue > --- > .../display/msm/dsi-controller-main.yaml | 154 -- > 1 file

Re: [Freedreno] [PATCH v3 08/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-11-26 Thread Krzysztof Kozlowski
On 24/11/2022 01:47, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. In the .txt description we mark

Re: [Freedreno] [PATCH v5 04/10] dt-bindings: display/msm: add support for the display on SM8450

2022-11-28 Thread Krzysztof Kozlowski
qcom,sm8450-mdss.yaml | 343 ++ > 2 files changed, 482 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml > Reviewed

Re: [Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vcca-supply on 14nm PHY

2022-11-30 Thread Krzysztof Kozlowski
On 30/11/2022 14:58, Konrad Dybcio wrote: > On some SoCs (hello SM6115) vcca-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX line, which is > voted for in the DSI ctrl node. > > Signed-off-by: Konrad Dybcio Acked-by: Krzysztof Kozlowski

Re: [Freedreno] [PATCH 01/12] dt-bindings: display: msm: Replace mdss with display-subsystem

2022-11-30 Thread Krzysztof Kozlowski
On 29/11/2022 21:46, Adam Skladowski wrote: > Follow other YAMLs and replace mdss name. That's really not explaining what you are doing here. Your commit msg and subject suggest you rename mdss. But you don't. You touch only examples. > > Signed-off-by: Adam Skladowski > --- > .../devicetree/b

Re: [Freedreno] [PATCH 02/12] dt-bindings: thermal: tsens: Add SM6115 compatible

2022-11-30 Thread Krzysztof Kozlowski
On 29/11/2022 21:46, Adam Skladowski wrote: > Document compatible for tsens on Qualcomm SM6115 platform > according to downstream dts it ship v2.4 of IP > > Signed-off-by: Adam Skladowski Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 10/12] arm64: dts: qcom: sm6115: Add i2c/spi nodes

2022-11-30 Thread Krzysztof Kozlowski
On 29/11/2022 21:46, Adam Skladowski wrote: > Add I2C/SPI nodes for SM6115. > > Signed-off-by: Adam Skladowski > --- > arch/arm64/boot/dts/qcom/sm6115.dtsi | 287 +++ > 1 file changed, 287 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi > b/arch/arm6

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Rename mdss node name in example

2022-12-01 Thread Krzysztof Kozlowski
On 30/11/2022 21:09, Adam Skladowski wrote: > Follow other YAMLs and replace mdss name into display-subystem. > > Signed-off-by: Adam Skladowski Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 11/12] arm64: dts: qcom: sm6115: Add WCN node.

2022-12-01 Thread Krzysztof Kozlowski
On 30/11/2022 21:09, Adam Skladowski wrote: > Add WCN node to allow using wifi module. > A nit: Drop full stop from commit subject. Best regards, Krzysztof

Re: [Freedreno] [PATCH v3 2/5] arm64: dts: qcom: sm8450: add display hardware devices

2022-12-05 Thread Krzysztof Kozlowski
On 23/11/2022 22:07, Dmitry Baryshkov wrote: > Add devices tree nodes describing display hardware on SM8450: > - Display Clock Controller > - MDSS > - MDP > - two DSI controllers and DSI PHYs > > This does not provide support for DP controllers present on SM8450. > > Reviewed-by: Konrad Dybcio >

Re: [Freedreno] [PATCH v3 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-12-05 Thread Krzysztof Kozlowski
On 23/11/2022 22:07, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 59 + > 1

Re: [Freedreno] [PATCH v3 09/11] arm64: dts: qcom: sm8350: Add display system nodes

2022-12-05 Thread Krzysztof Kozlowski
On 05/12/2022 17:37, Robert Foss wrote: > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > nodes the display subsystem is configured to support > one DSI output. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 199 ++- > 1 file changed,

Re: [Freedreno] [PATCH v3 11/11] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-12-05 Thread Krzysztof Kozlowski
On 05/12/2022 17:37, Robert Foss wrote: > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > In order to toggle the board to enable the HDMI output, > switch #7 & #8 on the rightmost multi-switch package have > to be toggled to On. > > Signed-off-by: Robert Foss Thank you for yo

Re: [Freedreno] [PATCH v2 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-12-09 Thread Krzysztof Kozlowski
nects, interconnect-names >- iommus >- power-domains >- operating-points-v2, opp-table > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 2/4] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml

2022-12-09 Thread Krzysztof Kozlowski
On 08/12/2022 01:54, Dmitry Baryshkov wrote: > Add platform-specific compatible entries to the qcom,mdp5.yaml to allow > distinguishing between various platforms. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,mdp5.yaml | 19 ++- > 1 file changed,

Re: [Freedreno] [PATCH v11 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-09 Thread Krzysztof Kozlowski
On 08/12/2022 23:36, Kuogee Hsieh wrote: > Move data-lanes property from mdss_dp node to dp_out endpoint. Also > add link-frequencies property into dp_out endpoint as well. The last > frequency specified at link-frequencies will be the max link rate > supported by DP. > > Changes in v5: > -- rever

Re: [Freedreno] [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-09 Thread Krzysztof Kozlowski
On 09/12/2022 00:38, Kuogee Hsieh wrote: > > On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote: >> On 09/12/2022 00:36, Kuogee Hsieh wrote: >>> Add both data-lanes and link-frequencies property into endpoint >>> >>> Changes in v7: >>> -- split yaml out of dtsi patch >>> -- link-frequencies from link ra

Re: [Freedreno] [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Krzysztof Kozlowski
On 13/12/2022 00:41, Abhinav Kumar wrote: >>> >>> besides, i think i have to sent the whole series patches include this >>> one to address your new comments on other patch. >>> >>> is this correct? >> >> No. Please fix your system first, validate your patches and send them >> afterwards. You can no

<    1   2   3   4   5   6   7   >