[Freedreno] Reboot crash at msm_atomic_commit_tail

2021-01-12 Thread Fabio Estevam
nit! exitcode=0x [ 25.678331] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x ]--- It happens on 5.4 as well as 5.11-rc2. Any ideas? Thanks, Fabio Estevam ___ Freedreno mailing list Freedreno@lists.freedesktop.

Re: [Freedreno] Reboot crash at msm_atomic_commit_tail

2021-01-18 Thread Fabio Estevam
Adding some more folks in case anyone has any suggestions to fix this reboot hang. Thanks On Tue, Jan 12, 2021 at 5:07 PM Fabio Estevam wrote: > > Hi, > > I have noticed that on an imx53-qsb, it is no longer possible to > reboot the system as it fails like this: > > Req

Re: [Freedreno] Reboot crash at msm_atomic_commit_tail

2021-01-18 Thread Fabio Estevam
On Mon, Jan 18, 2021 at 6:44 PM Fabio Estevam wrote: > > Adding some more folks in case anyone has any suggestions to fix this > reboot hang. Not sure if this is a valid fix, but the change below makes reboot works correctly. kmscube still works. --- a/drivers/gpu/drm/msm/msm_atomi

Re: [Freedreno] Reboot crash at msm_atomic_commit_tail

2021-01-19 Thread Fabio Estevam
Hi Rob, On Tue, Jan 19, 2021 at 1:40 PM Rob Clark wrote: > > I suppose we should do the drm_atomic_helper_shutdown() conditionally? This suggestion works, thanks. I will submit a patch shortly. Thanks ___ Freedreno mailing list Freedreno@lists.freede

Re: [Freedreno] [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
Hi Dmitry, On Mon, Mar 1, 2021 at 6:41 PM Dmitry Baryshkov wrote: > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > b/drivers/gpu/drm/msm/msm_atomic.c > index 6a326761dc4a..2fd0cf6421ad 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -207,7 +207,12

Re: [Freedreno] [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
Hi Rob, On Fri, Mar 19, 2021 at 11:44 AM Rob Clark wrote: > I think that might not help if something fails to probe due to (for > example) a missing dependency, so !priv->kms is probably a better > check to cover both cases. But the 2nd patch makes a good point, that > the suspend/resume path p

Re: [Freedreno] [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-19 Thread Fabio Estevam
On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote: > Thanks for the feedback. > I will follow the same approach for fixing the suspend/resume path then. > > Let me test it and then I will re-submit Dmitry's patch and the one > for suspend/resume as part of a patch series.

[Freedreno] [PATCH v2 1/2] drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-20 Thread Fabio Estevam
eb02007f 5401 (f9400285) [ 66.874525] ---[ end trace 20dedb2a3229fec8 ]--- Fixes: 9d5cbf5fe46e ("drm/msm: add shutdown support for display platform_driver") Signed-off-by: Dmitry Baryshkov Signed-off-by: Fabio Estevam --- Changes since v1: - None, only added freedreno@lists.freedesktop

[Freedreno] [PATCH v2 2/2] drm/msm: Fix suspend/resume on i.MX5

2021-03-20 Thread Fabio Estevam
317743] LR is at commit_tail+0xa4/0x1b0 Fix the problem by calling drm_mode_config_helper_suspend/resume() only when priv->kms is available. Fixes: ca8199f13498 ("drm/msm/dpu: ensure device suspend happens during PM sleep") Signed-off-by: Fabio Estevam --- Changes since v1: - None, o

[Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices

2021-09-14 Thread Fabio Estevam
t use the DPU controller. Cc: sta...@vger.kernel.org Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot") Signed-off-by: Fabio Estevam --- drivers/gpu/drm/msm/msm_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.

Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices

2021-09-16 Thread Fabio Estevam
Hi Abhinav, On Wed, Sep 15, 2021 at 11:22 PM wrote: > Are you not using DPU or are you not using mdp4/mdp5 as well? Even if > you are using any of mdps, kms should > not be NULL. Hence wanted to check the test case. I am running i.MX53, which is an NXP SoC, not Qualcomm's. It does not use DPU,

Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices

2021-09-16 Thread Fabio Estevam
Hi Abhinav, On Thu, Sep 16, 2021 at 1:15 PM wrote: > > Hi Fabio > > Thanks for confirming. > > Although I have no issues with your change, I am curious why even msm is > probing and/or binding. > Your device tree should not be having any mdp/dpu nodes then. The i.MX53 does have the following GPU

Re: [Freedreno] [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support (v2)

2022-03-08 Thread Fabio Estevam
On Tue, Mar 8, 2022 at 3:48 PM Rob Clark wrote: > > From: Rob Clark > > Avoid going down devfreq paths on devices where devfreq is not > initialized. > > v2: Change has_devfreq() logic [Dmitry] > > Reported-by: Linux Kernel Functional Testing > Reported-by: Anders Roxell > Signed-off-by: Rob Cl

Re: [Freedreno] [PATCH v3 4/4] ARM: dts: imx5: add gpu nodes

2018-12-03 Thread Fabio Estevam
Hi Jonathan, Thanks for working on this. Really nice to see GPU support for mx51/mx53! On Mon, Dec 3, 2018 at 7:21 PM Jonathan Marek wrote: Please add a commit log. > Signed-off-by: Jonathan Marek > --- > arch/arm/boot/dts/imx51.dtsi | 17 + > arch/arm/boot/dts/imx53.dtsi |

Re: [Freedreno] [PATCH v3 4/4] ARM: dts: imx5: add gpu nodes

2018-12-03 Thread Fabio Estevam
On Mon, Dec 3, 2018 at 8:24 PM Jonathan marek wrote: > > I can't find the dt-bindings for these compatible entries. Have you > > documented them? > > > > It is the same as qcom,adreno which is documented here: > > Documentation/devicetree/bindings/display/msm/gpu.txt > > I guess I should add amd,

Re: [Freedreno] [PATCH v4 4/5] ARM: dts: imx5: add gpu nodes

2018-12-07 Thread Fabio Estevam
r 128KiB GMEM size. > > Signed-off-by: Jonathan Marek Reviewed-by: Fabio Estevam ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH] qcom: Add firmware files for Adreno A200

2019-09-04 Thread Fabio Estevam
Add firmware files for Adreno A200. These firmware files are needed for running the adreno kernel driver on i.MX51 and i.MX53 SoCs. Signed-off-by: Fabio Estevam --- WHENCE | 2 ++ qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes 3 files c

Re: [Freedreno] [PATCH] drm/msm: Use the correct dma_sync calls harder

2019-10-08 Thread Fabio Estevam
> Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none > Control: 10c5387d Table: 70004019 DAC: 0051 > Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) > > Signed-off-by: Rob Clark > Fixes: 3de433c5b38a ("drm/msm: Use the correct dma_sync

Re: [Freedreno] [PATCH] drm/msm: Use the correct dma_sync calls harder

2019-10-08 Thread Fabio Estevam
Hi Rob, On Tue, Oct 8, 2019 at 8:08 PM Rob Clark wrote: > afaict this should be at least in v5.4-rc2.. am I missing something? You are right, it is in 5.4-rc indeed, sorry. It is 5.3.x stable that has this commit missing, but I guess it will be backported at some point. Thanks! __

[Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-10-15 Thread Fabio Estevam
d. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 0783e4b5486a..5d7bdb4c83cc 100644 --- a/drivers/gpu/drm/

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-10-31 Thread Fabio Estevam
Hi Rob, On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo wrote: > > On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam wrote: > > > > Booting the adreno driver on a imx53 board leads to the following > > error message: > > > > adreno 3000.gpu: [drm:adreno_gpu_

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-11-12 Thread Fabio Estevam
Hi Jordan, On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse wrote: > I'm good with this. This really should only be around for > compatibility with downstream device tree files which should mean nothing for > I.MX5. May I resend it with your Reviewed-by tag? Thanks ___

[Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-12-10 Thread Fabio Estevam
d. Signed-off-by: Fabio Estevam Reviewed-by: Jeffrey Hugo Reviewed-by: Jordan Crouse --- Trying once again :-) drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/ad

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-12-18 Thread Fabio Estevam
Hi Rob, On Tue, Dec 10, 2019 at 8:12 PM Fabio Estevam wrote: > > Booting the adreno driver on a imx53 board leads to the following > error message: > > adreno 3000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU > powerlevels > > As the "qcom,gpu-pw

[Freedreno] gpu: msm: possible circular locking dependency detected on 5.5

2020-04-01 Thread Fabio Estevam
5.4.x I don't see this problem. I haven't started bisecting this yet, but just checking if anyone has any ideas first. Thanks, Fabio Estevam ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH v2 1/4] drm/msm/a2xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions: [ cut here ] WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/

[Freedreno] [PATCH v2 2/4] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[Freedreno] [PATCH v2 4/4] drm/msm/a5xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[Freedreno] [PATCH v2 3/4] drm/msm/a4xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fab

[Freedreno] [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam The adreno_is_a20x() and adreno_is_a225() functions rely on the GPU revision, but such information is retrieved inside adreno_gpu_init(), which is called afterwards. Fix this problem by caling adreno_gpu_init() earlier, so that the GPU information revision is available when

Re: [Freedreno] [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-07-24 Thread Fabio Estevam
Hi Rob, A gentle ping. On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov wrote: > > On 21/06/2023 02:23, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The adreno_is_a20x() and adreno_is_a225() functions rely on the > > GPU revision, but such i

Re: [Freedreno] [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Fabio Estevam
Hi Rob, Any comments, please? On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > Hi Rob, > > A gentle ping. > > On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov > wrote: > > > > On 21/06/2023 02:23, Fabio Estevam wrote: > > > From: Fabio Est

Re: [Freedreno] [PATCH] drm/msm/a2xx: support loading legacy (iMX) firmware

2023-01-01 Thread Fabio Estevam
Hi Dmitry, On Sun, Jan 1, 2023 at 12:58 PM Dmitry Baryshkov wrote: > > Support loading A200 firmware generated from the iMX firmware header > files. The firmware lacks protection support, however it allows GPU to > function properly while using the firmware files with clear license > which allows

Re: [Freedreno] [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

2023-03-07 Thread Fabio Estevam
linux-arm-...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org This fixes the warning after running 'make imx_v6_v7_defconfig', thanks: Tested-by: Fabio Estevam