Hi,
On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla
wrote:
>
>
>
> On 27/02/2021 00:26, Douglas Anderson wrote:
> > When running the latest kernel on an sc7180 with KASAN I got this
> > splat:
> >BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644
> >Read of size 4 at addr
Hi,
On Wed, Mar 17, 2021 at 9:40 AM Rob Clark wrote:
>
> From: Rob Clark
>
> We have seen a couple cases where low memory situations cause something
> bad to happen, followed by a flood of these messages obscuring the root
> cause. Lets ratelimit the dmesg spam so that next time it happens we
>
Hi,
On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota wrote:
>
> During crtc disable, display perf structures are reset to 0
> which includes state varibles which are immutable. On crtc
> enable, we use the same structures and they don't refelect
> the actual values
>
> 1) Fix is to avoid updating the
Hi,
On Mon, Mar 29, 2021 at 6:34 PM John Stultz wrote:
>
> Commit 7bf168c8fe8c ("drm/msm: Fix speed-bin support not to
> access outside valid memory"), reworked the nvmem reading of
> "speed_bin", but in doing so dropped handling of the -ENOENT
> case which was previously documented as "fine".
>
Hi,
On Wed, Mar 31, 2021 at 4:27 AM Kalyan Thota wrote:
>
> @@ -294,6 +294,9 @@ static int dpu_kms_parse_data_bus_icc_path(struct dpu_kms
> *dpu_kms)
> struct icc_path *path1;
> struct drm_device *dev = dpu_kms->dev;
>
> + if (!dpu_supports_bw_scaling(dev))
> +
Hi,
On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
>
> @@ -818,11 +820,19 @@ static void update_inactive(struct msm_gem_object
> *msm_obj)
> mutex_lock(&priv->mm_lock);
> WARN_ON(msm_obj->active_count != 0);
>
> + if (msm_obj->dontneed)
> + mark_unpurgable(m
Hi,
On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
>
> @@ -111,23 +111,15 @@ static const struct file_operations msm_gpu_fops = {
> static int msm_gem_show(struct drm_device *dev, struct seq_file *m)
> {
> struct msm_drm_private *priv = dev->dev_private;
> - struct msm_gpu *gpu
Hi,
On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
>
> From: Rob Clark
>
> The last patch lost the breakdown of active vs inactive GEM objects in
> $debugfs/gem. But we can add some better stats to summarize not just
> active vs inactive, but also purgable/purged to make up for that.
>
> Sign
Hi,
On Wed, Mar 31, 2021 at 4:23 PM Rob Clark wrote:
>
> On Wed, Mar 31, 2021 at 3:44 PM Doug Anderson wrote:
> >
> > Hi,
> >
> > On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
> > >
> > > @@ -818,11 +820,19 @@ static void updat
Hi,
On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
>
> From: Rob Clark
>
> I've been spending some time looking into how things behave under high
> memory pressure. The first patch is a random cleanup I noticed along
> the way. The second improves the situation significantly when we are
> ge
Hi,
On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Unused since c951a9b284b907604759628d273901064c60d09f
Not terribly important, but checkpatch always yells at me when I don't
reference commits by saying:
commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work")
> S
Hi,
On Wed, Mar 31, 2021 at 6:23 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Unused since commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work")
>
> Signed-off-by: Rob Clark
> Tested-by: Douglas Anderson
> ---
> drivers/gpu/drm/msm/msm_gem.h | 2 --
> 1 file changed, 2 deletions(-)
Review
Hi,
On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote:
>
> @@ -45,6 +30,9 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct
> shrink_control *sc)
> list_for_each_entry(msm_obj, &priv->inactive_dontneed, mm_list) {
> if (freed >= sc->nr_to_scan)
>
Hi,
On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote:
>
> From: Rob Clark
>
> In normal cases the gem obj lock is acquired first before mm_lock. The
> exception is iterating the various object lists. In the shrinker path,
> deadlock is avoided by using msm_gem_trylock() and skipping over object
Hi,
On Fri, Apr 2, 2021 at 2:08 PM Rob Clark wrote:
>
> From: Rob Clark
>
> lock_stat + mmm_donut[1] say that this reduces contention on mm_lock
> significantly (~350x lower waittime-max, and ~100x lower waittime-avg)
>
> [1]
> https://chromium.googlesource.com/chromiumos/platform/microbenchmar
Hi,
On Wed, Apr 14, 2021 at 9:41 AM Rajeev Nandan wrote:
>
> The backlight level of an eDP panel can be controlled through the AUX
> channel using DPCD registers of the panel.
>
> The capability for the Source device to adjust backlight characteristics
> within the panel, using the Sink device DP
Hi,
On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote:
>
> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote:
> > Add bindings for DisplayPort aux backlight driver.
> >
> > Changes in v2:
> > - New
> >
> > Signed-off-by: Rajeev Nandan
> > ---
> > .../bindings/leds/backlight/dp-aux-
Hi,
On Fri, Apr 30, 2021 at 8:10 AM wrote:
>
> On 30-04-2021 02:33, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote:
> >>
> >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote:
> >>
Hi,
On Tue, May 11, 2021 at 11:12 AM wrote:
>
> On 01-05-2021 03:08, Doug Anderson wrote:
> > Hi,
> >
> > On Fri, Apr 30, 2021 at 8:10 AM wrote:
> >>
> >> On 30-04-2021 02:33, Doug Anderson wrote:
> >> > Hi,
> >> >
> >>
Hi,
On Tue, May 11, 2021 at 4:17 PM Doug Anderson wrote:
>
> Hi,
>
> On Tue, May 11, 2021 at 11:12 AM wrote:
> >
> > On 01-05-2021 03:08, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Fri, Apr 30, 2021 at 8:10 AM wrote:
> > >&g
Hi,
On Fri, May 21, 2021 at 3:02 PM Stephen Boyd wrote:
>
> Quoting Douglas Anderson (2021-05-21 13:45:50)
> > Let's use the newly-added nvmem_cell_read_variable_le_u32() to future
> > proof ourselves a little bit.
> >
> > Signed-off-by: Douglas Anderson
> > ---
> > The patch that this depends o
Hi,
On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote:
>
> Some panels datasheets may specify a delay between the enable GPIO and
> the regulator. Support this in panel-simple.
>
> Signed-off-by: Rajeev Nandan
> ---
>
> Changes in v4:
> - New
>
> drivers/gpu/drm/panel/panel-simple.c | 23 +++
Hi,
On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote:
>
> Add Samsung 13.3" FHD eDP AMOLED panel.
>
> Signed-off-by: Rajeev Nandan
> ---
>
> Changes in v4:
> - New
>
> drivers/gpu/drm/panel/panel-simple.c | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff -
Hi,
On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote:
>
> Add Samsung 13.3" FHD eDP AMOLED panel.
>
> Signed-off-by: Rajeev Nandan
> ---
>
> Changes in v4:
> - New
>
> Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
Hi,
On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote:
>
> @@ -171,6 +172,19 @@ struct panel_desc {
>
> /** @connector_type: LVDS, eDP, DSI, DPI, etc. */
> int connector_type;
> +
> + /**
> +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight control.
> +
Hi,
On Thu, May 27, 2021 at 5:21 AM wrote:
>
> >> @@ -171,6 +172,19 @@ struct panel_desc {
> >>
> >> /** @connector_type: LVDS, eDP, DSI, DPI, etc. */
> >> int connector_type;
> >> +
> >> + /**
> >> +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight
> >> cont
Hi,
On Wed, May 26, 2021 at 10:08 PM Krishna Manikandan
wrote:
>
> Crtc perf update from frame event work can result in
> wrong bandwidth and clock update from dpu if the work
> is scheduled after the swap state has happened.
>
> Avoid such issues by moving perf update to complete
> commit once t
Hi,
On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote:
>
> +static int dp_aux_backlight_update_status(struct backlight_device *bd)
> +{
> + struct dp_aux_backlight *bl = bl_get_data(bd);
> + u16 brightness = backlight_get_brightness(bd);
> + int ret = 0;
> +
> + if (brig
Hi,
On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote:
>
> Some panels datasheets may specify a delay between the enable GPIO and
> the regulator. Support this in panel-simple.
>
> Signed-off-by: Rajeev Nandan
> ---
>
> Changes in v4:
> - New
>
> Changes in v5:
> - Update description (Douglas)
Hi,
On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan wrote:
>
> If there is no backlight specified in the device tree and the panel
> has access to the DP AUX channel then create a DP AUX backlight if
> supported by the panel.
>
> Signed-off-by: Rajeev Nandan
> ---
>
> This patch depends on [1] (dr
Lyude,
On Tue, Jun 1, 2021 at 3:20 PM Lyude Paul wrote:
>
> oh-looks like my patches just got reviewed, so hopefully I should get a chance
> to get a look at this in the next day or two :)
I'm going to assume that means that you don't need extra eyes on your
backlight patches. If you do, please
Hi,
On Sat, Jun 12, 2021 at 5:09 AM Rajeev Nandan wrote:
>
> +static const struct panel_desc samsung_atna33xc20 = {
> + .modes = &samsung_atna33xc20_mode,
> + .num_modes = 1,
> + .bpc = 10,
> + .size = {
> + .width = 294,
> + .height = 165,
> +
Hi,
On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote:
>
> Hi Rajeev
> On Sat, Jun 19, 2021 at 04:10:30PM +0530, Rajeev Nandan wrote:
> > Add Samsung 13.3" FHD eDP AMOLED panel.
> >
> > Signed-off-by: Rajeev Nandan
> > Reviewed-by: Douglas Anderson
> > ---
> >
> > Changes in v4:
> > - New
> >
Hi,
On Mon, Jun 21, 2021 at 11:42 AM Sam Ravnborg wrote:
>
> Hi Doug,
>
> On Mon, Jun 21, 2021 at 08:34:51AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote:
> > >
> > > Hi Rajeev
> > > On S
Hi,
On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg wrote:
>
> > > I cannot see why you need the extra check on ->enabled?
> > > Would it be sufficient to check backlight_is_blank() only?
> >
> > This extra check on bl->enabled flag is added to avoid enabling/disabling
> > backlight again if it is
Hi,
On Mon, Jun 28, 2021 at 6:33 AM Laurent Pinchart
wrote:
>
> Hi Rajeev,
>
> On Mon, Jun 28, 2021 at 05:46:24PM +0530, rajee...@codeaurora.org wrote:
> > On 27-06-2021 23:48, Laurent Pinchart wrote:
> > > On Sat, Jun 26, 2021 at 10:21:06PM +0530, Rajeev Nandan wrote:
> > >> Do not give a warnin
Hi,
On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote:
>
> This series adds the support for the eDP panel that needs the backlight
> controlling over the DP AUX channel using DPCD registers of the panel
> as per the VESA's standard.
>
> This series also adds support for the Samsung eDP AMOLED p
Hi,
On Fri, Jul 9, 2021 at 1:41 PM Ville Syrjälä
wrote:
>
> On Fri, Jul 09, 2021 at 06:54:05AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan
> > wrote:
> > >
> > > This series adds the su
Hi,
On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote:
>
> > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd,
> > +EDP_DISPLAY_CTL_CAP_SIZE);
>
> This creates a cyclic dependency between drm_kms_helper-ko and drm.ko.
> drm_panel.c is in the latter, wh
Hi,
On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote:
> >
> > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd,
> > > +EDP_DISPLAY_CTL_CAP_
Hi,
On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote:
>
> From: Rob Clark
>
> If we created our own connector because the driver does not support the
> NO_CONNECTOR flag, we don't want the downstream bridge to *also* create
> a connector. And if this driver did pass the NO_CONNECTOR flag (and we
Hi,
On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote:
>
> From: Rob Clark
>
> For the brave new world of bridges not creating their own connectors, we
> need to implement the max clock limitation via bridge->mode_valid()
> instead of connector->mode_valid().
>
> Signed-off-by: Rob Clark
> ---
>
Hi,
On Wed, Aug 11, 2021 at 4:51 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Slightly awkward to fish out the display_info when we aren't creating
> own connector. But I don't see an obvious better way.
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 34 ++
Laurent,
On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart
wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote:
> > From: Rob Clark
> >
> > Slightly awkward to fish out the display_info when we aren't creating
> > own connector. But I do
Hi,
On Wed, Aug 11, 2021 at 5:08 PM Sankeerth Billakanti
wrote:
>
> The Qualcomm SC7280 platform supports an eDP controller, add
> compatible string for it to msm/binding.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++
>
Hi,
On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson
wrote:
>
> +static int dp_parser_find_panel(struct dp_parser *parser)
> +{
> + struct device_node *np = parser->pdev->dev.of_node;
> + int rc;
> +
> + rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL);
> +
Hi,
On Wed, Aug 25, 2021 at 6:31 PM Stephen Boyd wrote:
>
> Quoting Bjorn Andersson (2021-07-26 16:13:51)
> > eDP panels might need some power sequencing and backlight management,
> > so make it possible to associate a drm_panel with a DP instance and
> > prepare and enable the panel accordingly.
Hi,
On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson
wrote:
>
> +static int dp_parser_find_panel(struct dp_parser *parser)
> +{
> + struct device_node *np = parser->pdev->dev.of_node;
> + int rc;
> +
> + rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL);
Why p
Hi,
On Sat, Aug 28, 2021 at 7:40 AM Bjorn Andersson
wrote:
>
> On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote:
>
> > Hi,
> >
> > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson
> > wrote:
> > >
> > > +static int dp_parser_find_panel(stru
Hi,
On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Slightly awkward to fish out the display_info when we aren't creating
> own connector. But I don't see an obvious better way.
>
> v2: Remove error return with NO_CONNECTOR flag
>
> Signed-off-by: Rob Clark
> ---
> dr
Hi,
On Thu, Aug 26, 2021 at 10:20 PM Stephen Boyd wrote:
>
> Quoting Bjorn Andersson (2021-08-25 16:42:31)
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> > b/drivers/gpu/drm/msm/dp/dp_display.c
> > index 2c7de43f655a..4a6132c18e57 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> >
Hi,
On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart
wrote:
>
> > > > err_conn_init:
> > > > drm_dp_aux_unregister(&pdata->aux);
> > > > return ret;
> > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct
> > > > ti_sn65dsi86 *pdata)
> > > > regmap_write(pdat
Hi,
On Wed, Sep 22, 2021 at 5:31 PM Laurent Pinchart
wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Mon, Sep 20, 2021 at 03:57:59PM -0700, Rob Clark wrote:
> > From: Rob Clark
> >
> > For the brave new world of bridges not creating their own connectors, we
> > need to implement the max c
Hi,
On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson
wrote:
>
> On Fri 27 Aug 13:52 PDT 2021, Doug Anderson wrote:
>
> > Hi,
> >
> > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson
> > wrote:
> > >
> > > +static int dp_parser_find_panel(stru
Hi,
On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson
wrote:
>
> On Mon 04 Oct 17:36 PDT 2021, Doug Anderson wrote:
>
> > Hi,
> >
> > On Fri, Oct 1, 2021 at 2:00 PM Bjorn Andersson
> > wrote:
> > >
> > > On Fri 27 Aug 13:52 PDT 2021, Doug Ander
Hi,
On Tue, Oct 5, 2021 at 10:33 AM Bjorn Andersson
wrote:
>
> On Tue 05 Oct 08:39 PDT 2021, Doug Anderson wrote:
>
> > Hi,
> >
> > On Mon, Oct 4, 2021 at 6:09 PM Bjorn Andersson
> > wrote:
> > >
> > > On Mon 04 Oct 17:36 PDT 2021, Doug Ander
Hi,
On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson
wrote:
>
> > > For reference, this is how I thought one is supposed to tie the Type-C
> > > controller to the display driver:
> > > https://lore.kernel.org/all/20211005022451.2037405-1-bjorn.anders...@linaro.org/
> >
> > OK, so I looked at that a
Hi,
On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti
wrote:
>
> From: Sankeerth Billakanti
>
> The Qualcomm SC7280 platform supports an eDP controller, add
> compatible string for it to dp-controller.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> Documentation/devicetree/bindings/display
Hi,
On Sat, Oct 30, 2021 at 10:08 AM Philip Chen wrote:
>
> If "data_lanes" property of the dsi output endpoint is missing in
> the DT, num_data_lanes would be 0 by default, which could cause
> dsi_host_attach() to fail if dsi->lanes is set to a non-zero value
> by the bridge driver.
>
> Accordin
Hi,
On Thu, Nov 4, 2021 at 3:23 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Reported-by: Douglas Anderson
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Rev
Hi,
On Thu, Nov 4, 2021 at 9:32 PM Steev Klimaszewski wrote:
>
>
> On 11/4/21 5:28 PM, Rob Clark wrote:
> > From: Rob Clark
> >
> > Reported-by: Douglas Anderson
> > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> > Signed-off-by: Rob Clark
> > ---
> > drivers/gpu/drm/msm/msm_gpu_devfreq.c
Hi,
On Fri, Nov 5, 2021 at 1:15 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Reported-by: Douglas Anderson
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Dougl
Hi,
On Wed, Nov 3, 2021 at 1:59 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 31 +--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> b/dr
Hi,
On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote:
>
> From: Rob Clark
>
> This was supposed to be a relative timer, not absolute.
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Douglas Anderson
Hi,
On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote:
>
> +void msm_devfreq_boost(struct msm_gpu *gpu, unsigned factor)
> +{
> + struct msm_gpu_devfreq *df = &gpu->devfreq;
> + unsigned long freq;
> +
> + freq = get_freq(gpu);
> + freq *= factor;
> + freq /= HZ_PER_KH
Hi,
On Mon, Jan 24, 2022 at 10:15 AM Sankeerth Billakanti
wrote:
>
> Enable the eDP display panel support with backlight on sc7280 platform.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127
>
> 1 file changed, 127 i
Hi,
On Mon, Jan 24, 2022 at 10:16 AM Sankeerth Billakanti
wrote:
>
> Add eDP panel support for sc7280 CRD platform.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> drivers/gpu/drm/panel/panel-edp.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel
Hi,
On Mon, Jan 24, 2022 at 11:04 AM Doug Anderson wrote:
>
> > +&mdss_edp {
> > + status = "okay";
> > +
> > + vdda-1p2-supply = <&vreg_l6b_1p2>;
> > + vdda-0p9-supply = <&vreg_l10c_0p8>;
> > +
> &g
Hi,
On Wed, Feb 2, 2022 at 1:54 PM Stephen Boyd wrote:
>
> Quoting Sankeerth Billakanti (2021-11-15 23:07:35)
> > This series adds support for the eDP PHY on Qualcomm SC7280 platform.
> > The changes are dependent on v4 of the new eDP PHY driver introduced by
> > Bjorn:
> > https://patchwork.ker
Hi,
On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
wrote:
>
> Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel
> with 1920x1080 display resolution.
>
> Signed-off-by: Sankeerth Billakanti
> Acked-by: Rob Herring
> Reviewed-by: Stephen Boyd
> ---
>
> Changes in v4:
>
Hi,
On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
wrote:
>
> Add support for the 14" sharp,lq140m1jw46 eDP panel.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> 00 ff ff ff ff ff ff 00 4d 10 23 15 00 00 00 00
> 35 1e 01 04 a5 1f 11 78 07 de 50 a3 54 4c 99 26
> 0f 50 54 00 00 00 01 01 01
Hi,
On Wed, Feb 16, 2022 at 11:26 AM Doug Anderson wrote:
>
> Hi,
>
> On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
> wrote:
> >
> > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel
> > with 1920x1080 display resolution.
>
Hi,
On Wed, Feb 16, 2022 at 11:29 AM Doug Anderson wrote:
>
> Hi,
>
> On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
> wrote:
> >
> > Add support for the 14" sharp,lq140m1jw46 eDP panel.
> >
> > Signed-off-by: Sankeerth Billakanti
> > --
Hi,
On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
wrote:
>
> +&pm8350c_gpios {
> + edp_bl_power: edp-bl-power {
> + pins = "gpio7";
> + function = "normal";
> + qcom,drive-strength = ;
As far as I can tell you're lacking:
#include
...whic
Hi,
On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
wrote:
>
> + backlight_3v3_regulator: backlight-3v3-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "backlight_3v3_regulator";
> +
> + regulator-min-microvolt = <330>;
Hi,
On Thu, Feb 10, 2022 at 4:04 PM Bjorn Andersson
wrote:
>
> > +&mdss_edp {
> > + status = "okay";
> > +
> > + vdda-1p2-supply = <&vreg_l6b_1p2>;
> > + vdda-0p9-supply = <&vreg_l10c_0p8>;
> > + /delete-property/ pinctrl-names;
> > + /delete-property/ pinctrl-0;
>
> If the fi
Hi,
On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti
wrote:
>
> Add support in the DP driver to utilize the custom eDP panels
> from drm/panels.
>
> An eDP panel is always connected to the platform. So, the eDP
> connector can be reported as always connected. The display mode
> will be source
Hi,
On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov
wrote:
>
> > +static int dp_link_psr_status(struct dp_link_private *link)
> > +{
> > + u8 status[2];
> > +
> > + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2);
> > +
> > + if (status[0] & DP_PSR_LINK_CRC_ERROR)
>
Hi,
On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote:
>
> Quoting Vinod Polimera (2022-02-21 05:12:06)
> > Panels with higher refresh rate will need mdp clk above 300Mhz.
> > Select max frequency for mdp clock during bootup, dpu driver will
> > scale down the clock as per usecase when first up
Hi,
On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov
wrote:
>
> On 22/02/2022 22:25, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov
> > wrote:
> >>
> >>> +static int dp_link_psr_status(struct dp_lin
Hi,
On Tue, Feb 22, 2022 at 1:46 PM Stephen Boyd wrote:
>
> Quoting Doug Anderson (2022-02-22 13:25:05)
> > Hi,
> >
> > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote:
> > >
> > > Quoting Vinod Polimera (2022-02-21 05:12:06)
> > > > P
Hi,
On Thu, Mar 3, 2022 at 1:40 AM Vinod Polimera wrote:
>
> Kernel clock driver assumes that initial rate is the
> max rate for that clock and was not allowing it to scale
> beyond the assigned clock value.
>
> Drop the assigned clock rate property and vote on the mdp clock as per
> calculated v
Hi,
On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov
wrote:
>
> On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote:
> >
> > Quoting Dmitry Baryshkov (2022-03-03 15:50:50)
> > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera
> > > wrote:
> > > >
> > > > Kernel clock driver assumes that initial rate is
Hi,
On Tue, Mar 8, 2022 at 8:55 AM Vinod Polimera wrote:
>
> use max clock during probe/bind sequence from the opp table.
> The clock will be scaled down when framework sends an update.
>
> Signed-off-by: Vinod Polimera
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++
> 1 file changed,
Hi,
On Fri, Mar 11, 2022 at 1:22 AM Dmitry Baryshkov
wrote:
>
> On Fri, 11 Mar 2022 at 11:06, Vinod Polimera
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Stephen Boyd
> > > Sent: Wednesday, March 9, 2022 1:36 AM
> > > To: quic_vpolimer ;
> > > devicet...@vger.kernel.org; d
Hi,
On Wed, Mar 16, 2022 at 10:37 AM Sankeerth Billakanti
wrote:
>
> Add panel identification entry for the sharp LQ140M1JW46 eDP panel
> with power sequencing delay information.
>
> Signed-off-by: Sankeerth Billakanti
> ---
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 inserti
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
wrote:
>
> use max clock during probe/bind sequence from the opp table.
> The clock will be scaled down when framework sends an update.
>
> Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support")
The "Fixes:" format is a little wrong. Should have mo
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
wrote:
>
> Drop the assigned clock rate property and vote on the mdp clock as per
> calculated value during the usecase.
>
> This patch is dependent on below patch
> https://patchwork.kernel.org/patch/12774067/
Some nits on how you're referring
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
wrote:
>
> Drop the assigned clock rate property and vote on the mdp clock as per
> calculated value during the usecase.
>
> This patch is dependent on below patch
> https://patchwork.kernel.org/patch/12774067/
>
> Signed-off-by: Vinod Polimera
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
wrote:
>
> Drop the assigned clock rate property and vote on the mdp clock as per
> calculated value during the usecase.
>
> This patch is dependent on below patch
> https://patchwork.kernel.org/patch/12774067/
>
> Signed-off-by: Vinod Polimera
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
wrote:
>
> Drop the assigned clock rate property and vote on the mdp clock as per
> calculated value during the usecase.
>
> This patch is dependent on below patch
> https://patchwork.kernel.org/patch/12774067/
>
> Signed-off-by: Vinod Polimera
Hi,
On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti
wrote:
>
> Rename the edp_out label in the sc7280 platform to mdss_edp_out
> so that the nodes related to mdss are all grouped together in
> the board specific files.
>
> Signed-off-by: Sankeerth Billakanti
> ---
>
> Changes in v5:
> -
Hi,
On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote:
>
> Quoting Sankeerth Billakanti (2022-03-16 10:35:51)
> > The source device should ensure the sink is ready before
> > proceeding to read the sink capability or performing any aux transactions.
> > The sink will indicate its readine
Hi,
On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti
wrote:
>
> Enable support for eDP interface via aux_bus on CRD platform.
>
> Signed-off-by: Sankeerth Billakanti
> ---
>
> Changes in v5:
> - Change the order of patches
> - Remove the backlight nodes
> - Remove the bias setting
>
Hi,
On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote:
>
> > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog);
> > >
> > > Why are we making aux transactions when hpd isn't asserted? Can we only
> > > register the aux device once we know that state is "connected"? I'm
>
Hi,
On Fri, Mar 18, 2022 at 4:27 PM Stephen Boyd wrote:
>
> > > Pushing hpd state checking into aux
> > > transactions looks like the wrong direction. Also, as I said up above I
> > > am concerned that even checking the GPIO won't work and we need some way
> > > to ask the bridge if HPD is assert
Hi,
On Fri, Mar 25, 2022 at 6:41 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > -Original Message-
> > From: Doug Anderson
> > Sent: Friday, March 18, 2022 10:51 PM
> > To: Sankeerth Billakanti (QUIC)
> > Cc: dri-devel ; linux-arm-msm > m...@vger.kern
Hi,
On Fri, Mar 25, 2022 at 8:54 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > -Original Message-
> > From: Doug Anderson
> > Sent: Saturday, March 19, 2022 5:26 AM
> > To: Stephen Boyd
> > Cc: Sankeerth Billakanti (QUIC) ; open list:OPEN
> > FIRM
Hi,
On Fri, Mar 25, 2022 at 7:11 AM Sankeerth Billakanti (QUIC)
wrote:
>
> > > @@ -114,10 +114,12 @@ struct drm_bridge *dp_bridge_init(struct
> > msm_dp *dp_display, struct drm_device *
> > > bridge->funcs = &dp_bridge_ops;
> > > bridge->type = dp_display->connector_type;
> > >
>
Hi,
On Wed, Mar 30, 2022 at 4:19 PM Dmitry Baryshkov
wrote:
> > + bridge->ops =
> > + DRM_BRIDGE_OP_DETECT |
> > + DRM_BRIDGE_OP_HPD |
> > + DRM_BRIDGE_OP_MODES;
>
> I think OP_MODES should be used for eDP, shouldn't it?
No.
1 - 100 of 396 matches
Mail list logo
