[Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-28 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180

[Freedreno] [PATCH v3 1/3] drm/msm: Add support for GPU cooling

2020-10-28 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen --- Changes in v3: 1. Minor fix in binding documentation (RobH) Changes in v2: 1. Update the dt bindings documentation drivers/gpu/drm/msm

[Freedreno] [PATCH v3 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-28 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings

[Freedreno] [PATCH v2 1/2] drm/msm: Implement shutdown callback for adreno

2020-10-28 Thread Akhil P Oommen
Implement the shutdown callback for adreno gpu platform device to safely shutdown it before a system reboot. This helps to avoid futher transactions from gpu after the smmu is moved to bypass mode. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ 1 file

[Freedreno] [PATCH v2 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-28 Thread Akhil P Oommen
summary from the debugfs. Signed-off-by: Akhil P Oommen --- Changes in v2: 1. Minor updates (Jordan) drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 21 +++-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 20 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 32

Re: [Freedreno] [v3, 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-29 Thread Akhil P Oommen
On 10/29/2020 6:09 AM, m...@chromium.org wrote: Hi Akhil, On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote: Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30

[Freedreno] [PATCH v4 1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- Changes in v4: 1. Fix gpu cooling map. 2. Add mka's Reviewed-by tag. Changes in v3: 1. Minor f

[Freedreno] [PATCH v4 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-29 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a

[Freedreno] [PATCH v4 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-29 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings

Re: [Freedreno] [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread Akhil P Oommen
On 10/30/2020 2:18 AM, m...@chromium.org wrote: On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke Wait, I did not

[Freedreno] [PATCH v5 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-30 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a

[Freedreno] [PATCH v5 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-30 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen Reviewed-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a

[Freedreno] [PATCH v5 1/3] drm/msm: Add support for GPU cooling

2020-10-30 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen Tested-by: Matthias Kaehlcke --- Changes in v5: 1. Update Reviewed-by/Tested-by tags Changes in v4: 1. Fix gpu cooling map. 2. Add mka&#

Re: [Freedreno] [PATCH v5 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-11-05 Thread Akhil P Oommen
On 11/5/2020 2:28 AM, Rob Clark wrote: On Wed, Nov 4, 2020 at 12:03 PM Rob Herring wrote: On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen

[Freedreno] [PATCH] drm/msm: adreno: Make speed-bin support generic

2020-11-12 Thread Akhil P Oommen
So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed-bin. This patch makes this support generic across gpu families. This is in preparation to extend speed-bin support to a6x family. Signed-off-by: Akhil P Oommen --- This patch is rebased on top of

Re: [Freedreno] [PATCH] drm/msm: adreno: Make speed-bin support generic

2020-11-16 Thread Akhil P Oommen
On 11/12/2020 10:05 PM, Jordan Crouse wrote: On Thu, Nov 12, 2020 at 09:19:04PM +0530, Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed-bin. This patch makes this support generic across gpu families. This is in preparation

Re: [Freedreno] [PATCH] drm/msm: adreno: Make speed-bin support generic

2020-11-16 Thread Akhil P Oommen
On 11/12/2020 10:07 PM, Rob Clark wrote: On Thu, Nov 12, 2020 at 7:49 AM Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed-bin. This patch makes this support generic across gpu families. This is in preparation to extend

Re: [Freedreno] [PATCH] drm/msm: adreno: Make speed-bin support generic

2020-11-26 Thread Akhil P Oommen
On 11/16/2020 9:52 PM, Rob Clark wrote: On Mon, Nov 16, 2020 at 6:34 AM Akhil P Oommen wrote: On 11/12/2020 10:07 PM, Rob Clark wrote: On Thu, Nov 12, 2020 at 7:49 AM Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed

[Freedreno] [PATCH v2 2/3] drm/msm: Add speed-bin support for a618 gpu

2020-11-27 Thread Akhil P Oommen
Extend speed-bin support to a618 gpu. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index e0ff16c..21db7ae 100644 --- a

[Freedreno] [PATCH v2 1/3] drm/msm: adreno: Make speed-bin support generic

2020-11-27 Thread Akhil P Oommen
So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed-bin. This patch makes this support generic across gpu families. This is in preparation to extend speed-bin support to a6x family. Signed-off-by: Akhil P Oommen --- Changes from v1: 1. Added

[Freedreno] [PATCH v2 3/3] arm: dts: sc7180: Add support for gpu fuse

2020-11-27 Thread Akhil P Oommen
Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index

Re: [Freedreno] [PATCH] drm/msm: adreno: Make speed-bin support generic

2020-11-27 Thread Akhil P Oommen
On 11/16/2020 10:44 PM, Jordan Crouse wrote: On Mon, Nov 16, 2020 at 07:40:03PM +0530, Akhil P Oommen wrote: On 11/12/2020 10:05 PM, Jordan Crouse wrote: On Thu, Nov 12, 2020 at 09:19:04PM +0530, Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a

Re: [Freedreno] [PATCH v2 1/3] drm/msm: adreno: Make speed-bin support generic

2020-12-02 Thread Akhil P Oommen
<< Resending since Jordan wasn't in the CC list >> On 11/30/2020 10:32 PM, Jordan Crouse wrote: On Fri, Nov 27, 2020 at 06:19:44PM +0530, Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a fuse value called speed-bin. This patch m

Re: [Freedreno] [PATCH v2 1/3] drm/msm: adreno: Make speed-bin support generic

2020-12-03 Thread Akhil P Oommen
On 12/2/2020 10:00 PM, Jordan Crouse wrote: On Wed, Dec 02, 2020 at 08:53:51PM +0530, Akhil P Oommen wrote: On 11/30/2020 10:32 PM, Jordan Crouse wrote: On Fri, Nov 27, 2020 at 06:19:44PM +0530, Akhil P Oommen wrote: So far a530v2 gpu has support for detecting its supported opps based on a

[Freedreno] [PATCH v3 1/2] drm/msm: Add speed-bin support to a618 gpu

2020-12-07 Thread Akhil P Oommen
Some GPUs support different max frequencies depending on the platform. To identify the correct variant, we should check the gpu speedbin fuse value. Add support for this speedbin detection to a6xx family along with the required fuse details for a618 gpu. Signed-off-by: Akhil P Oommen --- Changes

[Freedreno] [PATCH v3 2/2] arm: dts: sc7180: Add support for gpu fuse

2020-12-07 Thread Akhil P Oommen
Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index

Re: [Freedreno] [PATCH v3 1/2] drm/msm: Add speed-bin support to a618 gpu

2020-12-11 Thread Akhil P Oommen
On 12/7/2020 4:12 PM, Akhil P Oommen wrote: Some GPUs support different max frequencies depending on the platform. To identify the correct variant, we should check the gpu speedbin fuse value. Add support for this speedbin detection to a6xx family along with the required fuse details for a618

Re: [Freedreno] [PATCH v3 2/2] arm: dts: sc7180: Add support for gpu fuse

2020-12-11 Thread Akhil P Oommen
On 12/7/2020 4:12 PM, Akhil P Oommen wrote: Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

[Freedreno] [PATCH v4 1/2] drm/msm: Add speed-bin support to a618 gpu

2021-01-08 Thread Akhil P Oommen
Some GPUs support different max frequencies depending on the platform. To identify the correct variant, we should check the gpu speedbin fuse value. Add support for this speedbin detection to a6xx family along with the required fuse details for a618 gpu. Signed-off-by: Akhil P Oommen --- Changes

[Freedreno] [PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-01-08 Thread Akhil P Oommen
Add support for gpu fuse to help identify the supported opps. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index

Re: [Freedreno] [PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-02-03 Thread Akhil P Oommen
On 2/3/2021 4:22 AM, Bjorn Andersson wrote: On Fri 08 Jan 12:15 CST 2021, Akhil P Oommen wrote: Please align the $subject prefix with other changes in the same file. I fixed it up while picking up the patch this time. Will take of this in future. Thanks, Bjorn. -Akhil. Regards, Bjorn Add

Re: [Freedreno] [PATCH] drm/msm: Fix legacy relocs path

2021-02-04 Thread Akhil P Oommen
gem_submit_reloc)); /* check for overflow: */ Reviewed-by: Akhil P Oommen -Akhil. ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v2] drm/msm: a6xx: Make sure the SQE microcode is safe

2021-02-11 Thread Akhil P Oommen
On 2/10/2021 6:22 AM, Jordan Crouse wrote: Most a6xx targets have security issues that were fixed with new versions of the microcode(s). Make sure that we are booting with a safe version of the microcode for the target and print a message and error if not. v2: Add more informative error messages

Re: [Freedreno] [PATCH v2] drm/msm: a6xx: Make sure the SQE microcode is safe

2021-02-11 Thread Akhil P Oommen
On 2/11/2021 9:32 PM, Jordan Crouse wrote: On Thu, Feb 11, 2021 at 06:50:28PM +0530, Akhil P Oommen wrote: On 2/10/2021 6:22 AM, Jordan Crouse wrote: Most a6xx targets have security issues that were fixed with new versions of the microcode(s). Make sure that we are booting with a safe version

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-17 Thread Akhil P Oommen
On 2/17/2021 8:36 AM, Rob Clark wrote: On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, to fix the case where the kernel was compiled without CONFIG_NVMEM. Fixes: fe7952c629da ("drm/msm: Add speed-bin support to

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-18 Thread Akhil P Oommen
On 2/18/2021 2:05 AM, Jonathan Marek wrote: On 2/17/21 3:18 PM, Rob Clark wrote: On Wed, Feb 17, 2021 at 11:08 AM Jordan Crouse wrote: On Wed, Feb 17, 2021 at 07:14:16PM +0530, Akhil P Oommen wrote: On 2/17/2021 8:36 AM, Rob Clark wrote: On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-19 Thread Akhil P Oommen
On 2/18/2021 9:41 PM, Rob Clark wrote: On Thu, Feb 18, 2021 at 4:28 AM Akhil P Oommen wrote: On 2/18/2021 2:05 AM, Jonathan Marek wrote: On 2/17/21 3:18 PM, Rob Clark wrote: On Wed, Feb 17, 2021 at 11:08 AM Jordan Crouse wrote: On Wed, Feb 17, 2021 at 07:14:16PM +0530, Akhil P Oommen

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-22 Thread Akhil P Oommen
On 2/19/2021 9:30 PM, Rob Clark wrote: On Fri, Feb 19, 2021 at 2:44 AM Akhil P Oommen wrote: On 2/18/2021 9:41 PM, Rob Clark wrote: On Thu, Feb 18, 2021 at 4:28 AM Akhil P Oommen wrote: On 2/18/2021 2:05 AM, Jonathan Marek wrote: On 2/17/21 3:18 PM, Rob Clark wrote: On Wed, Feb 17, 2021

Re: [Freedreno] [PATCH] drm/msm: Fix removal of valid error case when checking speed_bin

2021-03-29 Thread Akhil P Oommen
DRM_DEV_ERROR(dev, "failed to read speed-bin (%d). Some OPPs may not be supported by hardware", ret); Reviewed-by: Akhil P Oommen This looks "fine" to me. ;) -Akhil. ___

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-04-02 Thread Akhil P Oommen
On 4/2/2021 3:19 AM, Rob Clark wrote: On Thu, Apr 1, 2021 at 2:03 PM Dmitry Baryshkov wrote: On Thu, 1 Apr 2021 at 23:09, Rob Clark wrote: On Mon, Feb 22, 2021 at 8:06 AM Rob Clark wrote: On Mon, Feb 22, 2021 at 7:45 AM Akhil P Oommen wrote: On 2/19/2021 9:30 PM, Rob Clark wrote: On

[Freedreno] [PATCH 1/2] drm/msm/a6xx: Fix perfcounter oob timeout

2021-04-05 Thread Akhil P Oommen
We were not programing the correct bit while clearing the perfcounter oob. So, clear it correctly using the new 'clear' bit. This fixes the below error: [drm:a6xx_gmu_set_oob] *ERROR* Timeout waiting for GMU OOB set PERFCOUNTER: 0x8000 Signed-off-by: Akhil P Oommen --- drivers/g

[Freedreno] [PATCH 2/2] drm/msm: Select CONFIG_NVMEM

2021-04-05 Thread Akhil P Oommen
The speedbin support requires nvmem driver api. So lets explicitly enable CONFIG_NVMEM to have this support. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index dabb4a1

[Freedreno] [PATCH] freedreno/a6xx: Add a few registers

2021-04-20 Thread Akhil P Oommen
Add a few new registers for a6xx gpu. Signed-off-by: Akhil P Oommen --- registers/adreno/a6xx.xml | 2 ++ registers/adreno/a6xx_gmu.xml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/registers/adreno/a6xx.xml b/registers/adreno/a6xx.xml index 15314fb..3b04565 100644 --- a/registers

[Freedreno] [PATCH] freedreno/a6xx: Add a few registers

2021-04-20 Thread Akhil P Oommen
Add a few new registers for a6xx gpu. Signed-off-by: Akhil P Oommen --- registers/adreno/a6xx.xml | 2 ++ registers/adreno/a6xx_gmu.xml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/registers/adreno/a6xx.xml b/registers/adreno/a6xx.xml index 15314fb..3b04565 100644 --- a/registers

Re: [Freedreno] [PATCH v2 2/8] drm/msm/a6xx: use AOP-initialized PDC for a650

2021-05-31 Thread Akhil P Oommen
On 5/13/2021 10:43 PM, Jonathan Marek wrote: SM8250 AOP firmware already sets up PDC registers for us, and it only needs to be enabled. This path will be used for other newer GPUs. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 21 - 1 file chan

Re: [Freedreno] [PATCH v2 1/8] drm/msm: remove unused icc_path/ocmem_icc_path

2021-05-31 Thread Akhil P Oommen
/* -* Second interconnect path for some A3xx and all A4xx GPUs to the -* On Chip MEMory (OCMEM). -*/ - struct icc_path *ocmem_icc_path; - /* Hang and Inactivity Detection: */ #define DRM_MSM_INACTIVE_PERIOD 66 /* in ms (roughly four frames) */ Rev

Re: [Freedreno] [PATCH v2 3/8] drm/msm/a6xx: fix incorrectly set uavflagprd_inv field for A650

2021-05-31 Thread Akhil P Oommen
uavflagprd_inv >> 4 | lower_bit << 1); + uavflagprd_inv << 4 | lower_bit << 1); gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL, lower_bit << 21); } Reviewed-by: Akhil P Oommen -Akhil.

Re: [Freedreno] [PATCH v2 4/8] drm/msm/a6xx: update/fix CP_PROTECT initialization

2021-05-31 Thread Akhil P Oommen
registers starting at _reg. */ -#define A6XX_PROTECT_RW(_reg, _len) \ +#define A6XX_PROTECT_NORDWR(_reg, _len) \ ((1 << 31) | \ (((_len) & 0x3FFF) << 18) | ((_reg) & 0x3)) Reviewed-by: Akhil P Oommen -Akhil __

Re: [Freedreno] [PATCH v2 5/8] drm/msm/a6xx: avoid shadow NULL reference in failure path

2021-05-31 Thread Akhil P Oommen
x_gpu->shadow_bo) for (i = 0; i < gpu->nr_rings; i++) a6xx_gpu->shadow[i] = 0; Reviewed-by: Akhil P Oommen -Akhil ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v2 6/8] drm/msm/a6xx: add support for Adreno 660 GPU

2021-05-31 Thread Akhil P Oommen
On 5/13/2021 10:44 PM, Jonathan Marek wrote: Add adreno_is_{a660,a650_family} helpers and convert update existing adreno_is_a650 usage based on downstream driver's logic (changing into adreno_is_a650_family or adding adreno_is_a660). And add the remaining changes required for A660, again based o

Re: [Freedreno] [PATCH v2 7/8] drm/msm/a6xx: update a6xx_ucode_check_version for a660

2021-05-31 Thread Akhil P Oommen
On 5/13/2021 10:44 PM, Jonathan Marek wrote: Accept all SQE firmware versions for A660. Re-organize the function a bit and print an error message for unexpected GPU IDs instead of failing silently. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 36 +

Re: [Freedreno] [PATCH v2 8/8] drm/msm/a6xx: add a660 hwcg table

2021-05-31 Thread Akhil P Oommen
On 5/13/2021 10:44 PM, Jonathan Marek wrote: Add a660 hwcg table, ported over from downstream. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 53 ++ drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.h

Re: [Freedreno] [PATCH 3/3] drm/msm: Devfreq tuning

2021-07-22 Thread Akhil P Oommen
On 7/23/2021 3:51 AM, Rob Clark wrote: From: Rob Clark This adds a few things to try and make frequency scaling better match the workload: 1) Longer polling interval to avoid whip-lashing between too-high and too-low frequencies in certain workloads, like mobile games which throttle th

[Freedreno] [PATCH 1/2] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-23 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno

[Freedreno] [PATCH 2/2] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-23 Thread Akhil P Oommen
0x06030500 as the gpu id of this gpu to communicate to the userspace driver. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 20 ++- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 2 ++ drivers/gpu/drm/msm

[Freedreno] [PATCH] arm64: dts: qcom: sc7280: Add gpu support

2021-07-23 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t...@codeaurora.org/ arch/arm64/boot/dts/qcom/sc7280

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-24 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t...@codeaurora.org/ Changes in v2: - formatting update

Re: [Freedreno] [PATCH 2/2] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-25 Thread Akhil P Oommen
On 7/24/2021 11:42 PM, Rob Clark wrote: () On Fri, Jul 23, 2021 at 3:38 AM Akhil P Oommen wrote: This patch adds support for the gpu found in the Snapdragon 7c Gen 3 compute platform. This gpu is similar to the exisiting a660 gpu with minor delta in the programing sequence. As the Adreno

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-28 Thread Akhil P Oommen
On 7/27/2021 5:46 AM, Stephen Boyd wrote: Quoting Akhil P Oommen (2021-07-24 10:29:00) Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch

[Freedreno] [PATCH v3 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-07-28 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 29

[Freedreno] [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-28 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This has dependency on the below GPUCC bindings patch which is already accepted in clk-next: https://patchwork.kernel.org/project/linux-clk/list/?series=514831&state=%2A&archive=both Changes in

[Freedreno] [PATCH v2 1/3] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-29 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[Freedreno] [PATCH v2 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
0x06030500 as the gpu id of this gpu to communicate to the userspace driver. Signed-off-by: Akhil P Oommen --- Changes in v2: - Introduce adreno_is_a660_family() (Rob) - Remove revn for 7c3 (Rob) - Remove CPR register programing since they are not required for 7c3 drivers/gpu/drm/msm/adreno/a6xx_gmu.c

[Freedreno] [PATCH v2 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

[Freedreno] [PATCH v3 0/3] Support Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
0x06030500 as the gpu id of this gpu to communicate to the userspace driver. Changes in v3: - Add a cover letter. Changes in v2: - Use rev to identify SKU - Introduce adreno_is_a660_family() (Rob) - Remove revn for 7c3 (Rob) - Remove CPR register programing since they are not required for 7c3 Akhil P

[Freedreno] [PATCH v3 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

[Freedreno] [PATCH v3 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
0x06030500 as the gpu id of this gpu to communicate to the userspace driver. Signed-off-by: Akhil P Oommen --- (no changes since v2) Changes in v2: - Introduce adreno_is_a660_family() (Rob) - Remove revn for 7c3 (Rob) - Remove CPR register programing since they are not required for 7c3 drivers/gpu/drm

[Freedreno] [PATCH v3 1/3] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-29 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[Freedreno] [RFC PATCH] drm/msm: Introduce Adreno Features

2021-07-29 Thread Akhil P Oommen
Introduce a feature flag in gpulist to easily identify the capabilities of each gpu revision. This will help to avoid a lot of adreno_is_axxx() check when we add new features. In the current patch, HW APRIV feature is converted to a feature flag. Signed-off-by: Akhil P Oommen --- This patch is

Re: [Freedreno] [PATCH v2 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
On 7/29/2021 8:57 PM, Rob Clark wrote: On Thu, Jul 29, 2021 at 7:33 AM Akhil P Oommen wrote: Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- (no changes since v1) driver

Re: [Freedreno] [PATCH v3 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
On 7/29/2021 9:08 PM, Rob Clark wrote: On Thu, Jul 29, 2021 at 8:21 AM Akhil P Oommen wrote: This patch adds support for the gpu found in the Snapdragon 7c Gen 3 compute platform. This gpu is similar to the exisiting a660 gpu with minor delta in the programing sequence. As the Adreno GPUs are

Re: [Freedreno] [RFC PATCH] drm/msm: Introduce Adreno Features

2021-07-29 Thread Akhil P Oommen
On 7/29/2021 9:26 PM, Rob Clark wrote: On Thu, Jul 29, 2021 at 8:31 AM Akhil P Oommen wrote: Introduce a feature flag in gpulist to easily identify the capabilities of each gpu revision. This will help to avoid a lot of adreno_is_axxx() check when we add new features. In the current patch, HW

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-29 Thread Akhil P Oommen
On 7/29/2021 10:46 PM, Stephen Boyd wrote: Quoting Akhil P Oommen (2021-07-28 00:17:45) On 7/27/2021 5:46 AM, Stephen Boyd wrote: Quoting Akhil P Oommen (2021-07-24 10:29:00) Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on

[Freedreno] [PATCH v4 0/3] Support Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
) - Remove revn for 7c3 (Rob) - Remove CPR register programing since they are not required for 7c3 Akhil P Oommen (3): drm/msm/a6xx: Fix llcc configuration for a660 gpu drm/msm/a6xx: Use rev to identify SKU drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu drivers/gpu/drm/msm/adreno

[Freedreno] [PATCH v4 1/3] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-29 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[Freedreno] [PATCH v4 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- Changes in v4: - Move adreno_cmp_rev() here to fix compilation drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- driver

[Freedreno] [PATCH v4 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
0x06030500 as the chip id of this gpu to communicate to the userspace driver. Signed-off-by: Akhil P Oommen --- Changes in v4: - Move out adreno_cmp_rev() to patch-2/3 to fix compilation Changes in v2: - Introduce adreno_is_a660_family() (Rob) - Remove revn for 7c3 (Rob) - Remove CPR register programing

Re: [Freedreno] [PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-29 Thread Akhil P Oommen
On 7/30/2021 5:38 AM, Rob Clark wrote: On Sat, Jul 24, 2021 at 8:21 PM Bjorn Andersson wrote: This patch adds a Adreno 680 entry to the gpulist. Looks reasonable, but I wonder if we should just go ahead and add adreno_is_a640_family() in a similar vein to adreno_is_a650_familiy()/adreno_is_a

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly w

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021

[Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-08-11 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 29

[Freedreno] [PATCH v4 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-08-11 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- Changes in v4: - Removed the dependency on gpucc bindings (Stephen) - Reordered GPU's opp table Changes in v3: - Re-ordered the nodes based on address (Stephen) - Added the patch for gpu cooling t

[Freedreno] [PATCH v5 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-08-11 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- Changes in v5: - Added Stephen's reviewed-by tag to patch-2 Changes in v4: - Removed the dependency on gpucc bindings (Stephen) - Reordered GPU's opp table Changes in v3: - Re-ordered the node

[Freedreno] [PATCH v5 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-08-11 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen Reviewed-by: Stephen Boyd --- (no changes since v1) arch/arm64

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-09 Thread Akhil P Oommen
On 9/9/2021 9:42 PM, Amit Pundir wrote: On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-12 Thread Akhil P Oommen
On 9/10/2021 11:04 PM, Caleb Connolly wrote: On 10/09/2021 18:18, Rob Clark wrote: On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9

Re: [Freedreno] [PATCH] drm/msm: Switch ordering of runpm put vs devfreq_idle

2021-09-28 Thread Akhil P Oommen
On 9/27/2021 8:59 PM, Rob Clark wrote: From: Rob Clark I've seen a few crashes like: Internal error: synchronous external abort: 9610 [#1] PREEMPT SMP Modules linked in: snd_seq_dummy snd_seq snd_seq_device bridge stp llc tun nf_nat_tftp nf_conntrack_tftp nf_nat_ftp nf_conntrack

Re: [Freedreno] [PATCH] drm/msm/a6xx: Serialize GMU communication

2021-10-04 Thread Akhil P Oommen
.gpu_set_freq = a6xx_gmu_set_freq, + .gpu_set_freq = a6xx_gpu_set_freq, #if defined(CONFIG_DRM_MSM_GPU_STATE) .gpu_state_get = a6xx_gpu_state_get, .gpu_state_put = a6xx_gpu_state_put, I think I overlooked this because every hw access is serialized in the downstream driver. Reviewed-by: Akhil P Oommen -Akhil

Re: [Freedreno] [bug report] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-10-13 Thread Akhil P Oommen
On 10/12/2021 3:30 PM, Dan Carpenter wrote: Hello Akhil P Oommen, The patch a6f24383f6c0: "drm/msm/a6xx: Fix llcc configuration for a660 gpu" from Jul 30, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/msm/adreno/a6xx_gpu.c:1480 a6xx_ll

Re: [Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Akhil P Oommen
static int msm_devfreq_target(struct device *dev, unsigned long *freq, */ if (gpu->devfreq.idle_freq) { gpu->devfreq.idle_freq = *freq; + dev_pm_opp_put(opp); return 0; } Reviewed-by: Akhil P Oommen -Akhil

Re: [Freedreno] [PATCH v4 07/13] drm/msm: Track "seqno" fences by idr

2021-11-10 Thread Akhil P Oommen
On 7/28/2021 6:36 AM, Rob Clark wrote: From: Rob Clark Previously the (non-fd) fence returned from submit ioctl was a raw seqno, which is scoped to the ring. But from UABI standpoint, the ioctls related to seqno fences all specify a submitqueue. We can take advantage of that to replace the se

Re: [Freedreno] [PATCH v4 07/13] drm/msm: Track "seqno" fences by idr

2021-11-11 Thread Akhil P Oommen
On 11/10/2021 10:25 PM, Rob Clark wrote: On Wed, Nov 10, 2021 at 7:28 AM Akhil P Oommen wrote: On 7/28/2021 6:36 AM, Rob Clark wrote: From: Rob Clark Previously the (non-fd) fence returned from submit ioctl was a raw seqno, which is scoped to the ring. But from UABI standpoint, the ioctls

Re: [Freedreno] [PATCH 2/5] drm/msm: Drop priv->lastctx

2021-11-11 Thread Akhil P Oommen
eqno value of the last context to submit rendering, +* and the one with current pgtables installed (for generations +* that support per-context pgtables). Tracked by seqno rather + * than pointer value to avoid dangling pointers, and cases where +* a ctx can be freed and a new one created with the same address. +*/ + int cur_ctx_seqno; + /* * List of GEM active objects on this gpu. Protected by * msm_drm_private::mm_lock Reviewed-by: Akhil P Oommen -Akhil.

Re: [Freedreno] [PATCH 4/5] drm/msm: Handle fence rollover

2021-11-11 Thread Akhil P Oommen
d b have close values. And that is a good assumption for KMD generated seqno. Reviewed-by: Akhil P Oommen -Akhil. +} + +static inline bool +fence_after(uint32_t a, uint32_t b) +{ + return (int32_t)(a - b) > 0; +} + #endif diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm

Re: [Freedreno] [PATCH 5/5] drm/msm: Add debugfs to disable hw err handling

2021-11-11 Thread Akhil P Oommen
detection, in ms */ unsigned int hangcheck_period; + + /** +* disable_err_irq: +* +* Disable handling of GPU hw error interrupts, to force fallback to +* sw hangcheck timer. Written (via debugfs) by igt tests to test +* the sw hangcheck mechanism. + */ + bool disable_err_irq; }; struct msm_format { Reviewed-by: Akhil P Oommen -Akhil.

Re: [Freedreno] [PATCH 2/2] drm/msm: Restore error return on invalid fence

2021-11-15 Thread Akhil P Oommen
On 11/12/2021 12:54 AM, Rob Clark wrote: From: Rob Clark When converting to use an idr to map userspace fence seqno values back to a dma_fence, we lost the error return when userspace passes seqno that is larger than the last submitted fence. Restore this check. Reported-by: Akhil P Oommen

Re: [Freedreno] [PATCH 2/2] drm/msm: Restore error return on invalid fence

2021-11-15 Thread Akhil P Oommen
On 11/15/2021 10:26 PM, Rob Clark wrote: On Mon, Nov 15, 2021 at 6:43 AM Akhil P Oommen wrote: On 11/12/2021 12:54 AM, Rob Clark wrote: From: Rob Clark When converting to use an idr to map userspace fence seqno values back to a dma_fence, we lost the error return when userspace passes

[Freedreno] [PATCH 1/4] drm/msm: Increase gpu boost interval

2021-11-18 Thread Akhil P Oommen
interval) to fix this. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c index d32b729..c4d8920 100644 --- a/drivers/gpu/drm/msm

[Freedreno] [PATCH 2/4] drm/msm: Fix null ptr access msm_ioctl_gem_submit()

2021-11-18 Thread Akhil P Oommen
/0x1c0 26545.307445: Code: d503201f d503201f 52800028 4b0803e8 (b8680008) 26545.318799: Kernel panic - not syncing: Oops: Fatal exception Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_gem_submit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm

[Freedreno] [PATCH 3/4] drm/msm/a6xx: Fix uinitialized use of gpu_scid

2021-11-18 Thread Akhil P Oommen
Avoid a possible uninitialized use of gpu_scid variable to fix the below smatch warning: drivers/gpu/drm/msm/adreno/a6xx_gpu.c:1480 a6xx_llc_activate() error: uninitialized symbol 'gpu_scid'. Reported-by: Dan Carpenter Signed-off-by: Akhil P Oommen --- drivers/g

  1   2   3   4   5   6   7   8   >