[Freedreno] [PATCH 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-15 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen --- drivers/clk/qcom/gdsc.c | 11 ++---

[Freedreno] [PATCH 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-15 Thread Akhil P Oommen
-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.h | 4 3 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_g

[Freedreno] [PATCH 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-15 Thread Akhil P Oommen
0:3d6a000.gmuactive 0 Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 31 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c

[Freedreno] [PATCH 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-15 Thread Akhil P Oommen
ensure that cx gdsc has collapsed before we turn it back ON. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 6 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +++ 3 files changed, 32 insertions

[Freedreno] [PATCH v2 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-16 Thread Akhil P Oommen
which requires that the 'gpucc cx gdsc' power domain should move to OFF state in hardware at least once before turning in ON again to clear the internal state. Signed-off-by: Ulf Hansson Signed-off-by: Akhil P Oommen --- Changes in v2: - Minor formatting fix drivers/base/powe

[Freedreno] [PATCH v2 0/5] Improve GPU reset sequence for Adreno GPU

2022-12-16 Thread Akhil P Oommen
s rebased on top of linux-next (20221215) since the changes span multiple drivers. [1] https://patchwork.freedesktop.org/series/107507/ Changes in v2: - Minor formatting fix - Select PM_GENERIC_DOMAINS from Kconfig Akhil P Oommen (4): clk: qcom: gdsc: Support 'synced_poweroff' genpd fl

[Freedreno] [PATCH v2 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-16 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/clk/qcom/g

[Freedreno] [PATCH v2 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-16 Thread Akhil P Oommen
-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.h | 4 3 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/

[Freedreno] [PATCH v2 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-16 Thread Akhil P Oommen
ensure that cx gdsc has collapsed before we turn it back ON. Signed-off-by: Akhil P Oommen --- Changes in v2: - Select PM_GENERIC_DOMAINS from Kconfig drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h

[Freedreno] [PATCH v2 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-16 Thread Akhil P Oommen
0:3d6a000.gmuactive 0 Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 31 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/d

[Freedreno] [PATCH] drm/msm/a6xx: Avoid gx gbit halt during rpm suspend

2022-12-16 Thread Akhil P Oommen
As per the downstream driver, gx gbif halt is required only during recovery sequence. So lets avoid it during regular rpm suspend. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 7 +++ drivers/gpu/drm

[Freedreno] [PATCH v3 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-19 Thread Akhil P Oommen
which requires that the 'gpucc cx gdsc' power domain should move to OFF state in hardware at least once before turning in ON again to clear the internal state. Signed-off-by: Ulf Hansson Signed-off-by: Akhil P Oommen --- (no changes since v2) Changes in v2: - Minor formatting fix dri

[Freedreno] [PATCH v3 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-19 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen --- Changes in v3: - Rename the var 'force

[Freedreno] [PATCH v3 0/5] Improve GPU reset sequence for Adreno GPU

2022-12-19 Thread Akhil P Oommen
s rebased on top of linux-next (20221215) since the changes span multiple drivers. [1] https://patchwork.freedesktop.org/series/107507/ Changes in v3: - Rename the var 'force_sync' to 'wait (Stephen) Changes in v2: - Minor formatting fix - Select PM_GENERIC_DOMAINS from Kconfig A

[Freedreno] [PATCH v3 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-19 Thread Akhil P Oommen
0:3d6a000.gmuactive 0 Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 31 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/d

[Freedreno] [PATCH v3 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-19 Thread Akhil P Oommen
ffectively reverts commit 1f6cca404918 ("drm/msm/a6xx: Ensure CX collapse during gpu recovery"). Signed-off-by: Akhil P Oommen --- Changes in v3: - Updated commit msg (Philipp) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.c | 4 drivers/g

[Freedreno] [PATCH v3 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-19 Thread Akhil P Oommen
ensure that cx gdsc has collapsed before we turn it back ON. Signed-off-by: Akhil P Oommen --- (no changes since v2) Changes in v2: - Select PM_GENERIC_DOMAINS from Kconfig drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm

[Freedreno] [PATCH v2 1/4] drm/msm/adreno: Fix null ptr access in adreno_gpu_cleanup()

2022-12-21 Thread Akhil P Oommen
anced pm_runtime_enable in adreno_gpu_{init, cleanup}") Signed-off-by: Akhil P Oommen --- Changes in v2: - Added 'Fixes' tag (Dan Carpenter) drivers/gpu/drm/msm/adreno/adreno_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.

[Freedreno] [PATCH v2 3/4] drm/msm/a6xx: Update a6xx gpu coredump

2022-12-21 Thread Akhil P Oommen
Update gpu coredump for a660/a650 family of gpus with the extra information available. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx.xml.h | 18 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 50 - drivers

[Freedreno] [PATCH v2 2/4] drm/msm: Fix failure paths in msm_drm_init()

2022-12-21 Thread Akhil P Oommen
Ensure that we do drm_dev_put() when there is an early return in msm_drm_init(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 3 +++ drivers/gpu/drm/msm/msm_drv.c| 11 +++ 2 files changed, 10 insertions(+), 4

[Freedreno] [PATCH v2 4/4] drm/msm/a6xx: Update ROQ size in coredump

2022-12-21 Thread Akhil P Oommen
Since RoQ size differs between generations, calculate dynamically the RoQ size while capturing coredump. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 11 ++- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++--- 2

[Freedreno] [PATCH v4 0/5] Improve GPU reset sequence for Adreno GPU

2022-12-21 Thread Akhil P Oommen
rmatting fix - Select PM_GENERIC_DOMAINS from Kconfig Akhil P Oommen (4): clk: qcom: gdsc: Support 'synced_poweroff' genpd flag drm/msm/a6xx: Vote for cx gdsc from gpu driver drm/msm/a6xx: Remove cx gdsc polling using 'reset' drm/msm/a6xx: Use genpd notifier to ensur

[Freedreno] [PATCH v4 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Akhil P Oommen
which requires that the 'gpucc cx gdsc' power domain should move to OFF state in hardware at least once before turning in ON again to clear the internal state. Signed-off-by: Ulf Hansson Signed-off-by: Akhil P Oommen --- Changes in v4: - Update genpd function documentation (Ulf) Changes

[Freedreno] [PATCH v4 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-21 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: -

[Freedreno] [PATCH v4 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-21 Thread Akhil P Oommen
0:3d6a000.gmuactive 0 Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 31 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/d

[Freedreno] [PATCH v4 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-21 Thread Akhil P Oommen
ffectively reverts commit 1f6cca404918 ("drm/msm/a6xx: Ensure CX collapse during gpu recovery"). Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: - Updated commit msg (Philipp) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 drivers/gpu/drm/msm/msm_gpu.c |

[Freedreno] [PATCH v4 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-21 Thread Akhil P Oommen
ensure that cx gdsc has collapsed before we turn it back ON. Signed-off-by: Akhil P Oommen --- (no changes since v2) Changes in v2: - Select PM_GENERIC_DOMAINS from Kconfig drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm

Re: [Freedreno] [PATCH v3 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Akhil P Oommen
On 12/21/2022 8:13 PM, Ulf Hansson wrote: > On Tue, 20 Dec 2022 at 08:44, Akhil P Oommen wrote: >> From: Ulf Hansson >> >> Some genpd providers doesn't ensure that it has turned off at hardware. >> This is fine until the consumer really requires during some spe

Re: [Freedreno] [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-28 Thread Akhil P Oommen
lf Hansson wrote: >>>>> On Wed, 7 Dec 2022 at 17:55, Bjorn Andersson wrote: >>>>>> On Wed, Dec 07, 2022 at 05:00:51PM +0100, Ulf Hansson wrote: >>>>>>> On Thu, 1 Dec 2022 at 23:57, Bjorn Andersson >>>>>>> wrote: >>>

Re: [Freedreno] [PATCH v4 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2023-01-02 Thread Akhil P Oommen
On 12/29/2022 12:13 AM, Bjorn Andersson wrote: > On Wed, Dec 21, 2022 at 10:43:59PM +0530, Akhil P Oommen wrote: >> From: Ulf Hansson >> >> Some genpd providers doesn't ensure that it has turned off at hardware. >> This is fine until the consumer really requires

[Freedreno] [PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-02 Thread Akhil P Oommen
'wait (Stephen) Changes in v2: - Minor formatting fix - Select PM_GENERIC_DOMAINS from Kconfig Akhil P Oommen (4): clk: qcom: gdsc: Support 'synced_poweroff' genpd flag drm/msm/a6xx: Vote for cx gdsc from gpu driver drm/msm/a6xx: Remove cx gdsc polling using 'reset&#x

[Freedreno] [PATCH v5 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2023-01-02 Thread Akhil P Oommen
which requires that the 'gpucc cx gdsc' power domain should move to OFF state in hardware at least once before turning in ON again to clear the internal state. Signed-off-by: Ulf Hansson Signed-off-by: Akhil P Oommen Reviewed-by: Bjorn Andersson --- (no changes since v4) Changes in v4:

[Freedreno] [PATCH v5 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2023-01-02 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson --- (no change

[Freedreno] [PATCH v5 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2023-01-02 Thread Akhil P Oommen
0:3d6a000.gmuactive 0 Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 31 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + 2 files changed, 28 insertions(+), 4 deletions(-)

[Freedreno] [PATCH v5 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2023-01-02 Thread Akhil P Oommen
ffectively reverts commit 1f6cca404918 ("drm/msm/a6xx: Ensure CX collapse during gpu recovery"). Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson --- (no changes since v3) Changes in v3: - Updated commit msg (Philipp) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 drivers/g

[Freedreno] [PATCH v5 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2023-01-02 Thread Akhil P Oommen
ensure that cx gdsc has collapsed before we turn it back ON. Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson --- (no changes since v2) Changes in v2: - Select PM_GENERIC_DOMAINS from Kconfig drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15

Re: [Freedreno] [PATCH v2] drm/msm/adreno: Make adreno quirks not overwrite each other

2023-01-02 Thread Akhil P Oommen
ne ADRENO_QUIRK_LMLOADKILL_DISABLE BIT(2) > > struct adreno_rev { > uint8_t core; > @@ -65,7 +63,7 @@ struct adreno_info { > const char *name; > const char *fw[ADRENO_FW_MAX]; > uint32_t gmem; > - enum adreno_quirks quirks; > +

Re: [Freedreno] [PATCH 02/14] drm/msm/a6xx: Extend UBWC config

2023-02-01 Thread Akhil P Oommen
On 1/26/2023 8:46 PM, Konrad Dybcio wrote: > Port setting min_access_length, ubwc_mode and upper_bit from downstream. > Values were validated using downstream device trees for SM8[123]50 and > left default (as per downstream) elsewhere. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 2/23/2023 5:36 PM, Konrad Dybcio wrote: > Rename lower_bit to hbb_lo and explain what it signifies. > Add explanations (wherever possible to other tunables). > > Sort the variable definition and assignment alphabetically. Sorting based on decreasing order of line length is more readable, isn't i

Re: [Freedreno] [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 3/1/2023 2:10 AM, Konrad Dybcio wrote: > > On 28.02.2023 21:23, Akhil P Oommen wrote: >> On 2/23/2023 5:36 PM, Konrad Dybcio wrote: >>> Rename lower_bit to hbb_lo and explain what it signifies. >>> Add explanations (wherever possible to other tunables). >>&g

Re: [Freedreno] [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 3/1/2023 2:14 AM, Akhil P Oommen wrote: > On 3/1/2023 2:10 AM, Konrad Dybcio wrote: >> On 28.02.2023 21:23, Akhil P Oommen wrote: >>> On 2/23/2023 5:36 PM, Konrad Dybcio wrote: >>>> Rename lower_bit to hbb_lo and explain what it signifies. >>>> Ad

Re: [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-12-07 Thread Akhil P Oommen
On Thu, Nov 23, 2023 at 12:03:56AM +0300, Danila Tikhonov wrote: > > sc7180/sm7125 (atoll) expects speedbins from atoll.dtsi: > And has a parameter: /delete-property/ qcom,gpu-speed-bin; > 107 for 504Mhz max freq, pwrlevel 4 > 130 for 610Mhz max freq, pwrlevel 3 > 159 for 750Mhz max freq, pwrlevel

Re: [PATCH] drm/msm/a6xx: Fix recovery vs runpm race

2023-12-22 Thread Akhil P Oommen
On Mon, Dec 18, 2023 at 07:59:24AM -0800, Rob Clark wrote: > > From: Rob Clark > > a6xx_recover() is relying on the gpu lock to serialize against incoming > submits doing a runpm get, as it tries to temporarily balance out the > runpm gets with puts in order to power off the GPU. Unfortunately

Re: [PATCH v4 04/16] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-24 Thread Akhil P Oommen
On Sat, Mar 23, 2024 at 12:56:56AM +0200, Dmitry Baryshkov wrote: > The msm_gpummu.c implementation is used only on A2xx and it is tied to > the A2xx registers. Rename the source file accordingly. > There are very few functions in this file and a2xx_gpu.c is a relatively small source file too. Sh

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-24 Thread Akhil P Oommen
On Sat, Mar 23, 2024 at 12:57:02AM +0200, Dmitry Baryshkov wrote: > Generate DRM/MSM headers on the fly during kernel build. This removes a > need to push register changes to Mesa with the following manual > synchronization step. Existing headers will be removed in the following > commits (split aw

Re: [PATCH v4 10/16] drm/msm: generate headers on the fly

2024-03-25 Thread Akhil P Oommen
On Sun, Mar 24, 2024 at 12:57:43PM +0200, Dmitry Baryshkov wrote: > On Sun, 24 Mar 2024 at 12:30, Akhil P Oommen wrote: > > > > On Sat, Mar 23, 2024 at 12:57:02AM +0200, Dmitry Baryshkov wrote: > > > Generate DRM/MSM headers on the fly during kernel build. This remo

Re: [PATCH v4 04/16] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-25 Thread Akhil P Oommen
On Sun, Mar 24, 2024 at 01:13:55PM +0200, Dmitry Baryshkov wrote: > On Sun, 24 Mar 2024 at 11:55, Akhil P Oommen wrote: > > > > On Sat, Mar 23, 2024 at 12:56:56AM +0200, Dmitry Baryshkov wrote: > > > The msm_gpummu.c implementation is used only on A2xx and it is tied to

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-05-14 Thread Akhil P Oommen
On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > Memory barriers help ensure instruction ordering, NOT time and order > of actual write arrival at other observers (e.g. memory-mapped IP). > On architectures employing weak memory ordering, the latter can be a > giant pain point, and

Re: [PATCH] drm/msm: Add obj flags to gpu devcoredump

2024-05-14 Thread Akhil P Oommen
On Mon, May 13, 2024 at 08:51:47AM -0700, Rob Clark wrote: > From: Rob Clark > > When debugging faults, it is useful to know how the BO is mapped (cached > vs WC, gpu readonly, etc). > > Signed-off-by: Rob Clark Reviewed-by: Akhil P Oommen -Akhil > --- > dr

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-05-16 Thread Akhil P Oommen
On Thu, May 16, 2024 at 08:15:34AM -0500, Andrew Halaney wrote: > On Wed, May 15, 2024 at 12:08:49AM GMT, Akhil P Oommen wrote: > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > > > Memory barriers help ensure instruction ordering, NOT time and order >

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Akhil P Oommen
On Tue, Jun 04, 2024 at 03:40:56PM +0100, Will Deacon wrote: > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: > > On Thu, May 16, 2024 at 08:20:05PM GMT, Akhil P Oommen wrote: > > > On Thu, May 16, 2024 at 08:15:34AM -0500, Andrew Halaney wrote: > > >

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Akhil P Oommen
On Tue, Jun 04, 2024 at 07:35:04PM +0200, Konrad Dybcio wrote: > > > On 5/14/24 20:38, Akhil P Oommen wrote: > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > > > Memory barriers help ensure instruction ordering, NOT time and order > > >

[PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Akhil P Oommen
This series is rebased on top of v6.10-rc4. P3 cherry-picks cleanly on qcom/for-next. P1 & P2 for Rob, P3 for Bjorn to pick up. Akhil P Oommen (3): dt-bindings: display/msm/gmu: Add Adreno X185 GMU drm/msm/adreno: Add support for X185 GPU arm64: dts: qcom: x1e80100: Add gpu support .../dev

[PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Akhil P Oommen
Document Adreno X185 GMU in the dt-binding specification. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings

[PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-23 Thread Akhil P Oommen
Add support in drm/msm driver for the Adreno X185 gpu found in Snapdragon X1 Elite chipset. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 19 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++ drivers/gpu/drm/msm/adreno/adreno_device.c

[PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in X1E80100. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 + 1 file changed, 195 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > + gmu: gmu@3d6a000 { &

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 14:28, Akhil P Oommen wrote: > > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > >> On 23/06/2024 13:06, Akhil P Oommen wrote: > >>> Add the necessary dt nod

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 03:40:06PM -0500, Bjorn Andersson wrote: > On Sun, Jun 23, 2024 at 08:46:30PM GMT, Akhil P Oommen wrote: > > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > > > On 23/06/2024 14:28, Akhil P Oommen wrote: > > > > On S

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 01:11:48PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > > naming

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Akhil P Oommen
On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian > wrote: > > > > The driver's memory regions are currently just ioremap()ed, but not > > reserved through a request. That's not a bug, but having the request is > > a little more robust. > >

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-25 Thread Akhil P Oommen
On Thu, Jun 20, 2024 at 02:04:01PM +0100, Will Deacon wrote: > On Tue, Jun 18, 2024 at 09:41:58PM +0530, Akhil P Oommen wrote: > > On Tue, Jun 04, 2024 at 03:40:56PM +0100, Will Deacon wrote: > > > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: > > > &

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-25 Thread Akhil P Oommen
On Tue, Jun 18, 2024 at 10:08:23PM +0530, Akhil P Oommen wrote: > On Tue, Jun 04, 2024 at 07:35:04PM +0200, Konrad Dybcio wrote: > > > > > > On 5/14/24 20:38, Akhil P Oommen wrote: > > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: >

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Akhil P Oommen
On Tue, Jun 25, 2024 at 11:03:42AM -0700, Rob Clark wrote: > On Tue, Jun 25, 2024 at 10:59 AM Akhil P Oommen wrote: > > > > On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > > > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian > > > wrote: > > >

Re: [PATCH v2 0/2] Clean up barriers

2024-06-25 Thread Akhil P Oommen
eno/a6xx_gpu.c | 14 ++ > 2 files changed, 7 insertions(+), 11 deletions(-) > --- > base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed > change-id: 20240625-adreno_barriers-29f356742418 for the whole series: Reviewed-by: Akhil P Oommen -Akhil > > Best regards, > -- > Konrad Dybcio >

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-26 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 02:40:14PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > Document Adreno X185 GMU in the dt-binding specification. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > Documentation/devic

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 12:21:30AM +0300, Dmitry Baryshkov wrote: > On Sun, Jun 23, 2024 at 04:36:29PM GMT, Akhil P Oommen wrote: > > Add support in drm/msm driver for the Adreno X185 gpu found in > > Snapdragon X1 Elite chipset. > > > > Signed-off-by: Akhil P Oommen

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > Add support in drm/msm driver for the Adreno X185 gpu found in > > Snapdragon X1 Elite chipset. > > > > Signed-off-by: Akhil P Oommen > > --

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 07:28:06AM -0700, Rob Clark wrote: > On Mon, Jun 24, 2024 at 7:25 AM Rob Clark wrote: > > > > On Sun, Jun 23, 2024 at 4:08 AM Akhil P Oommen > > wrote: > > > > > > Add support in drm/msm driver for the Adreno X185 gpu fou

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Wed, Jun 26, 2024 at 11:43:08AM -0700, Rob Clark wrote: > On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen > wrote: > > > > On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 6/23/24 13:06, Akhil P Oommen wrote:

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 12:23:42AM +0300, Dmitry Baryshkov wrote: > On Sun, Jun 23, 2024 at 04:36:30PM GMT, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > arch/

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 03:57:35PM +0200, Konrad Dybcio wrote: > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > [...] > > >

Re: [PATCH v2 1/2] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-26 Thread Akhil P Oommen
On Wed, Jun 26, 2024 at 09:59:39AM +0200, Daniel Vetter wrote: > On Tue, Jun 25, 2024 at 08:54:41PM +0200, Konrad Dybcio wrote: > > Memory barriers help ensure instruction ordering, NOT time and order > > of actual write arrival at other observers (e.g. memory-mapped IP). > > On architectures emplo

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-26 Thread Akhil P Oommen
<< snip >> > > > > > > @@ -1503,7 +1497,7 @@ static void __iomem *a6xx_gmu_get_mmio(struct > > > > > > platform_device *pdev, > > > > > > return ERR_PTR(-EINVAL); > > > > > > } > > > > > > > > > > > > - ret = ioremap(res->start, resource_size(res)); > > > > > > +

[PATCH v2 1/5] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-28 Thread Akhil P Oommen
Document Adreno X185 GMU in the dt-binding specification. Signed-off-by: Akhil P Oommen Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Minor update to compatible pattern, '[x]' -> 'x' Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 1 fil

[PATCH v2 0/5] Support for Adreno X1-85 GPU

2024-06-28 Thread Akhil P Oommen
ed gmu_chipid in a6xx_info (Rob) - Improved fallback logic for gmxc (Dmitry) - Rebased on top of msm-next - Picked a new patch for arm-mmu bindings update - Reordered gpu & gmu reg enties to match schema Akhil P Oommen (5): dt-bindings: display/msm/gmu: Add Adreno X185 GMU drm/msm/ad

[PATCH v2 3/5] drm/msm/adreno: Introduce gmu_chipid for a740 & a750

2024-06-28 Thread Akhil P Oommen
To simplify, introduce the new gmu_chipid for a740 & a750 GPUs. Signed-off-by: Akhil P Oommen --- Changes in v2: - New patch in v2 drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 23 +-- 2 files changed, 3 insertions(+)

[PATCH v2 2/5] drm/msm/adreno: Add support for X185 GPU

2024-06-28 Thread Akhil P Oommen
Add support in drm/msm driver for the Adreno X185 gpu found in Snapdragon X1 Elite chipset. Signed-off-by: Akhil P Oommen --- Changes in v2: - Increased address space size (Rob) - Introduced gmu_chipid in a6xx_info (Rob) - Improved fallback logic for gmxc (Dmitry) drivers/gpu/drm/msm/adreno

[PATCH v2 4/5] dt-bindings: arm-smmu: Add X1E80100 GPU SMMU

2024-06-28 Thread Akhil P Oommen
Update the devicetree bindings to support the gpu present in X1E80100 platform. Signed-off-by: Akhil P Oommen --- Changes in v2: - New patch in v2 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH v2 5/5] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-28 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in X1E80100. Signed-off-by: Akhil P Oommen --- Changes in v2: - Reordered gpu & gmu reg enties to match schema arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 + 1 file changed, 195 insertions(+) diff --git a/arch/arm64/boot

Re: [PATCH v4 1/5] drm/msm/adreno: Split up giant device table

2024-06-28 Thread Akhil P Oommen
On Tue, Jun 18, 2024 at 09:42:47AM -0700, Rob Clark wrote: > From: Rob Clark > > Split into a separate table per generation, in preparation to move each > gen's device table to it's own file. > > Signed-off-by: Rob Clark > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Konrad Dybcio > --- > dr

Re: [PATCH v2 0/5] Support for Adreno X1-85 GPU

2024-06-28 Thread Akhil P Oommen
On Sat, Jun 29, 2024 at 07:19:33AM +0530, Akhil P Oommen wrote: > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > naming scheme for Adreno GPU, 'X' stands for compute series, 

Re: [PATCH v4 1/5] drm/msm/adreno: Split up giant device table

2024-06-30 Thread Akhil P Oommen
On Sat, Jun 29, 2024 at 06:32:05AM -0700, Rob Clark wrote: > On Fri, Jun 28, 2024 at 6:58 PM Akhil P Oommen > wrote: > > > > On Tue, Jun 18, 2024 at 09:42:47AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Split into a separate tabl

Re: [PATCH v4 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-06-30 Thread Akhil P Oommen
On Tue, Jun 25, 2024 at 08:28:06PM +0200, Konrad Dybcio wrote: > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > abstracted through SMEM, instead of being directly available in a fuse. > > Add support for SMEM-based speed binning, which includes getting > "feature code" and "

Re: [PATCH v4 4/5] drm/msm/adreno: Redo the speedbin assignment

2024-06-30 Thread Akhil P Oommen
On Tue, Jun 25, 2024 at 08:28:09PM +0200, Konrad Dybcio wrote: > There is no need to reinvent the wheel for simple read-match-set logic. > > Make speedbin discovery and assignment generation independent. > > This implicitly removes the bogus 0x80 / BIT(7) speed bin on A5xx, > which has no represe

Re: [PATCH v2 3/5] drm/msm/adreno: Introduce gmu_chipid for a740 & a750

2024-06-30 Thread Akhil P Oommen
On Sat, Jun 29, 2024 at 03:06:22PM +0200, Konrad Dybcio wrote: > On 29.06.2024 3:49 AM, Akhil P Oommen wrote: > > To simplify, introduce the new gmu_chipid for a740 & a750 GPUs. > > > > Signed-off-by: Akhil P Oommen > > --- > > This gets rid of getting p

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-15 Thread Akhil P Oommen
On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > abstracted through SMEM, instead of being directly available in a fuse. > > Add support for SMEM-based speed binning, which includes getting > "feature code" and "

Re: [PATCH] drm/msm/adreno: Fix error return if missing firmware-name

2024-07-16 Thread Akhil P Oommen
. But not when > there is, but without a firmware-name property. This case we want to > treat as-if the needed fw is not found. > > Signed-off-by: Rob Clark > --- Reviewed-by: Akhil P Oommen -Akhil > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 i

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Akhil P Oommen
On Mon, Jul 29, 2024 at 02:40:30PM +0200, Konrad Dybcio wrote: > > > On 29.07.2024 2:13 PM, Konrad Dybcio wrote: > > On 16.07.2024 1:56 PM, Konrad Dybcio wrote: > >> On 15.07.2024 10:04 PM, Akhil P Oommen wrote: > >>> On Tue, Jul 09, 2024 at 12:45:29PM +

Re: [PATCH 1/4] drm/msm/a5xx: disable preemption in submits by default

2024-08-01 Thread Akhil P Oommen
On Mon, Jul 15, 2024 at 02:00:10PM -0700, Rob Clark wrote: > On Thu, Jul 11, 2024 at 3:02 AM Vladimir Lypak > wrote: > > > > Fine grain preemption (switching from/to points within submits) > > requires extra handling in command stream of those submits, especially > > when rendering with tiling (u

Re: [PATCH 2/4] drm/msm/a5xx: properly clear preemption records on resume

2024-08-01 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:19AM +, Vladimir Lypak wrote: > Two fields of preempt_record which are used by CP aren't reset on > resume: "data" and "info". This is the reason behind faults which happen > when we try to switch to the ring that was active last before suspend. > In addition those

Re: [PATCH 2/4] drm/msm/a5xx: properly clear preemption records on resume

2024-08-05 Thread Akhil P Oommen
On Fri, Aug 02, 2024 at 01:41:32PM +, Vladimir Lypak wrote: > On Thu, Aug 01, 2024 at 06:46:10PM +0530, Akhil P Oommen wrote: > > On Thu, Jul 11, 2024 at 10:00:19AM +, Vladimir Lypak wrote: > > > Two fields of preempt_record which are used by CP aren't reset on &

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:20AM +, Vladimir Lypak wrote: > On A5XX GPUs when preemption is used it's invietable to enter a soft > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > This appears as full UI lockup and not detected as GPU hang (because > it's not). This h

Re: [PATCH 4/4] drm/msm/a5xx: workaround early ring-buffer emptiness check

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:21AM +, Vladimir Lypak wrote: > There is another cause for soft lock-up of GPU in empty ring-buffer: > race between GPU executing last commands and CPU checking ring for > emptiness. On GPU side IRQ for retire is triggered by CACHE_FLUSH_TS > event and RPTR shadow

Re: [PATCH v2 1/3] drm/msm: Use a7xx family directly in gpu_state

2024-08-11 Thread Akhil P Oommen
On Wed, Aug 07, 2024 at 01:34:27PM +0100, Connor Abbott wrote: > With a7xx, we need to import a new header for each new generation and > switch to a different list of registers, instead of making > backwards-compatible changes. Using the helpers inadvertently made a750 > use the a740 list of regist

Re: [PATCH v2 3/3] drm/msm: Fix CP_BV_DRAW_STATE_ADDR name

2024-08-11 Thread Akhil P Oommen
On Wed, Aug 07, 2024 at 01:34:29PM +0100, Connor Abbott wrote: > This was missed because we weren't using the a750-specific indexed regs. > > Fixes: f3f8207d8aed ("drm/msm: Add devcoredump support for a750") > Signed-off-by: Connor Abbott Reviewed-by: Akhil P Oommen

Re: [PATCH v2 1/3] drm/msm: Use a7xx family directly in gpu_state

2024-08-12 Thread Akhil P Oommen
On Mon, Aug 12, 2024 at 07:25:14PM +0100, Connor Abbott wrote: > On Mon, Aug 12, 2024 at 7:09 AM Akhil P Oommen > wrote: > > > > On Wed, Aug 07, 2024 at 01:34:27PM +0100, Connor Abbott wrote: > > > With a7xx, we need to import a new header for each new generation and

Re: [PATCH 1/7] drm/msm: Fix bv_fence being used as bv_rptr

2024-08-19 Thread Akhil P Oommen
alco Reviewed-by: Akhil P Oommen -Akhil. > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > b/drivers/gpu/drm/msm

Re: [PATCH 2/7] drm/msm: Add submitqueue setup and close

2024-08-19 Thread Akhil P Oommen
On Thu, Aug 15, 2024 at 08:26:12PM +0200, Antonino Maniscalco wrote: > This patch adds a bit of infrastructure to give the different Adreno > targets the flexibility to setup the submitqueues per their needs. > > Signed-off-by: Sharat Masetty Reviewed-by: Akhil P Oom

Re: [PATCH 3/7] drm/msm: Add a `preempt_record_size` field

2024-08-19 Thread Akhil P Oommen
.address_space_size = SZ_16G, > + .preempt_record_size = 4192 * SZ_1K, > }, { > .chip_ids = ADRENO_CHIP_IDS(0x43050c01), /* "C512v2" */ We can use 4192KB for X185. With that, Reviewed-by: Akhil P Oommen -Akhil

<    1   2   3   4   5   6   7   8   9   >