On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
dsi_clk_init(), which gets the clocks, is called only through platform
driver probe and its failure is a failure of the probe. Therefore
NULL-ifying specific clocks is pointless and redundant - the PTR_ERR
value stored there won't be used/deref
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
dsi_clk_init() and msm_dsi_host_init() are called only from platform
dsi_get_config() as well? OR you didnt want to explicitly mention that
since its called from msm_dsi_host_init().
driver probe function, so using dev_err_probe is both ap
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
Cleanup few obvious kernel coding style violations: missing or
unnecessary braces in 'if-else', unnecessary break lines, incorrect
breaking of long function declarations, unnecessary 'else' after a
'return'. No functional impact expected.
Sign
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
Kernel core already prints detailed report about memory allocation
failures, so drivers should not have their own error messages.
Signed-off-by: Krzysztof Kozlowski
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +---
1 file changed, 1 insertio
On 12/23/2024 8:25 PM, Dmitry Baryshkov wrote:
Enable CDM block on all the platforms where it is supposed to be
present. Notably, from the platforms being supported by the DPU driver
it is not enabled for SM6115 (DPU 6.3), QCM2290 (DPU 6.5) and SM6375
(DPU 6.9)
Thanks for enabling it, but c
f_count = ARRAY_SIZE(sdm845_vbif),
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-add-writeback-support-for-sm6150-ba7657196ea8
Best regards,
On Sun, Jan 05, 2025 at 04:55:42PM -0800, Rob Clark wrote:
> fwiw, I did see some perf boost (was mainly looking at gfxbench aztec
> ruins vk high/normal, and also a separate mesa MR that fixes some LRZ
> issues with turnip, so I don't remember how much boost was related to
> which offhand).. I've
On Mon, Jan 6, 2025 at 12:11 PM Akhil P Oommen wrote:
>
> On 1/3/2025 1:00 AM, Akhil P Oommen wrote:
> > On 1/3/2025 12:02 AM, Rob Clark wrote:
> >> From: Rob Clark
> >>
> >> On mmu-500, stall-on-fault seems to stall all context banks, causing the
> >> GMU to misbehave. So limit this feature to
On Mon, Jan 6, 2025 at 12:11 PM Akhil P Oommen wrote:
>
> On 1/3/2025 1:00 AM, Akhil P Oommen wrote:
> > On 1/3/2025 12:02 AM, Rob Clark wrote:
> >> From: Rob Clark
> >>
> >> On mmu-500, stall-on-fault seems to stall all context banks, causing the
> >> GMU to misbehave. So limit this feature to
dsi_clk_init(), which gets the clocks, is called only through platform
driver probe and its failure is a failure of the probe. Therefore
NULL-ifying specific clocks is pointless and redundant - the PTR_ERR
value stored there won't be used/dereferenced afterwards. What's more,
variant-specific clo
Cleanup few obvious kernel coding style violations: missing or
unnecessary braces in 'if-else', unnecessary break lines, incorrect
breaking of long function declarations, unnecessary 'else' after a
'return'. No functional impact expected.
Signed-off-by: Krzysztof Kozlowski
---
drivers/gpu/drm/m
dsi_clk_init() and msm_dsi_host_init() are called only from platform
driver probe function, so using dev_err_probe is both appropriate and
beneficial:
- Properly marks device deferred probe status,
- Avoids dmesg flood on probe deferrals,
- Already incorporates printing ERR value,
- Shows devic
Kernel core already prints detailed report about memory allocation
failures, so drivers should not have their own error messages.
Signed-off-by: Krzysztof Kozlowski
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/d
/dsi: Drop unnecessary -ENOMEM message
drivers/gpu/drm/msm/dsi/dsi_host.c | 158 -
1 file changed, 68 insertions(+), 90 deletions(-)
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-drm-msm-cleanups-ddacf1fc3ba5
Best regards
On 1/3/2025 1:00 AM, Akhil P Oommen wrote:
> On 1/3/2025 12:02 AM, Rob Clark wrote:
>> From: Rob Clark
>>
>> On mmu-500, stall-on-fault seems to stall all context banks, causing the
>> GMU to misbehave. So limit this feature to smmu-v2 for now.
>>
>> This fixes an issue with an older mesa bug tak
On Thu, Dec 05, 2024 at 08:32:15PM -0800, Abhinav Kumar wrote:
> From: Yongxing Mou
>
I'd expect "sa8775p" in the subject prefix.
> Populate the pixel clock for stream 1 for DP0 for sa8775p DP controller.
Please write your commit messages in the style expressed in
https://docs.kernel.org/proce
On Thu, Dec 05, 2024 at 08:31:34PM -0800, Abhinav Kumar wrote:
> Interface type of MST interfaces is currently INTF_NONE.
> Fix this to INTF_DP.
>
Wouldn't it make sense to introduce this later in the series, once the
implementation would actually handle this case? Or could/should we have
left th
On Thu, Dec 05, 2024 at 08:31:31PM -0800, Abhinav Kumar wrote:
Please discuss with and reply to Dmitry's questions/feedback on the
list, so that it's possible for others to join the discussion.
Regards,
Bjorn
> Add support for Multi-stream transport for MSM chipsets that allow
> a single instanc
Hi Bjorn / Dmitry
Happy New Year !
On 1/6/2025 5:06 PM, Bjorn Andersson wrote:
On Thu, Dec 05, 2024 at 08:31:31PM -0800, Abhinav Kumar wrote:
Please discuss with and reply to Dmitry's questions/feedback on the
list, so that it's possible for others to join the discussion.
Regards,
Bjorn
Sor
On 12/17/2024 4:35 AM, Dmitry Baryshkov wrote:
The SM6150 platform doesn't have 3DMux (MERGE_3D) block, so it can not
split the screen between two LMs. Drop lm_pair fields as they don't make
sense for this platform.
Suggested-by: Abhinav Kumar
Fixes: cb2f9144693b ("drm/msm/dpu: Add SM6150 su
On 12/31/2024 4:02 PM, Konrad Dybcio wrote:
> On 30.12.2024 10:11 PM, Akhil P Oommen wrote:
>> Add a module param to disable ACD which will help to quickly rule it
>> out for any GPU issues.
>>
>> Signed-off-by: Akhil P Oommen
>> ---
>
> Is that something useful during internal development, or do
f_count = ARRAY_SIZE(sm6150_intf),
.intf = sm6150_intf,
.vbif_count = ARRAY_SIZE(sdm845_vbif),
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-add-writeback-support-for-sm6150-ba7657196ea8
Best regards,
On 25-01-03 20:09:42, Dmitry Baryshkov wrote:
> On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote:
> > LTTPRs operating modes are defined by the DisplayPort standard and the
> > generic framework now provides a helper to switch between them, which
> > is handling the explicit disabling of n
On 2025-01-06 04:45, Dmitry Baryshkov wrote:
> On Mon, 6 Jan 2025 at 10:55, Maxime Ripard wrote:
>>
>> On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote:
>>> On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote:
While working on the generic mode_valid() implement
On 07/01/2025 03:56, Abhinav Kumar wrote:
>
>
> On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
>> dsi_clk_init() and msm_dsi_host_init() are called only from platform
>
> dsi_get_config() as well? OR you didnt want to explicitly mention that
> since its called from msm_dsi_host_init().
>
As
On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote:
> On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote:
> > While working on the generic mode_valid() implementation for the HDMI
> > Connector framework I noticed that unlike other DRM objects
> > drm_connector accepts n
Hi
Am 05.01.25 um 23:47 schrieb Dmitry Baryshkov:
On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote:
While working on the generic mode_valid() implementation for the HDMI
Connector framework I noticed that unlike other DRM objects
drm_connector accepts non-const pointer to struc
On Mon, 6 Jan 2025 at 10:55, Maxime Ripard wrote:
>
> On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote:
> > On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote:
> > > While working on the generic mode_valid() implementation for the HDMI
> > > Connector framework I noti
Dmitry Baryshkov 于2025年1月4日周六 01:51写道：
>
> On Fri, Jan 03, 2025 at 11:49:07PM +0800, Jun Nie wrote:
> > Dmitry Baryshkov 于2024年12月20日周五 07:46写道：
> > >
> > > On Thu, Dec 19, 2024 at 03:49:33PM +0800, Jun Nie wrote:
> > > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are
> >
29 matches
Mail list logo
