Re: [PATCH v4 5/9] drm/msm/dpu: Add SM6150 support

2024-12-17 Thread fange zhang
On 2024/12/17 18:54, Dmitry Baryshkov wrote: On Tue, Dec 10, 2024 at 02:53:56PM +0800, Fange Zhang wrote: From: Li Liu Add definitions for the display hardware used on the Qualcomm SM6150 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Li Liu Signed-off-by: Fange Zhang --- .../

Re: [PATCH 7/8] drm/msm/dpu: link DSPP_2/_3 blocks on X1E80100

2024-12-17 Thread Johan Hovold
On Mon, Dec 16, 2024 at 10:27:28AM +0200, Dmitry Baryshkov wrote: > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. Please say something about why you're doing this and what the expected outcome of doing so is. There is currently no way for a third party (e.g. stable or distro mainta

[bug report] drm/msm/dpu: add support for virtual planes

2024-12-17 Thread Dan Carpenter
Hello Dmitry Baryshkov, Commit 774bcfb73176 ("drm/msm/dpu: add support for virtual planes") from Dec 15, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1062 dpu_plane_virtual_atomic_check() error: 'plane_state' dereferencing pos

[PATCH v6 0/7] drm/msm: adreno: add support for DDR bandwidth scaling via GMU

2024-12-17 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also vote for DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. While scaling the interconnect path was sufficient, newer GPUs like the A750 requires specific vote parameters and

[PATCH v6 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-12-17 Thread Neil Armstrong
Even if the code uses ARRAY_SIZE() to fill those tables, it's still a best practice to not use magic values for tables in structs. Suggested-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.h |

[PATCH v6 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-12-17 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, until now we left the OPP core scale the OPP bandwidth via the interconnect path. In order to enable bandwidth voting via the GPU Management Unit (GMU), when an opp is set by devfreq w

[PATCH v6 7/7] arm64: qcom: dts: sm8650: add interconnect and opp-peak-kBps for GPU

2024-12-17 Thread Neil Armstrong
Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dts

[PATCH v6 5/7] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-12-17 Thread Neil Armstrong
Now all the DDR bandwidth voting via the GPU Management Unit (GMU) is in place, declare the Bus Control Modules (BCMs) and the corresponding parameters in the GPU info struct. Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno

[PATCH v6 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-12-17 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. While scaling via the interconnect path was sufficient, newer GPUs like the A750 requires specific vote paremeters and

[PATCH v6 6/7] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-12-17 Thread Neil Armstrong
Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Reviewed-by: Akhil P Oommen Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm

[PATCH v6 3/7] drm/msm: adreno: dynamically generate GMU bw table

2024-12-17 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale the ddr bandwidth along the frequency and power domain level, but for now we statically fill the bw_table with values from the downstream driver. Only the first entry is used, which is a disable vote, so we currently rely on scaling via the linux

Re: [PATCH 7/8] drm/msm/dpu: link DSPP_2/_3 blocks on X1E80100

2024-12-17 Thread Dmitry Baryshkov
On Tue, Dec 17, 2024 at 09:41:44AM +0100, Johan Hovold wrote: > On Mon, Dec 16, 2024 at 10:27:28AM +0200, Dmitry Baryshkov wrote: > > Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. > > Please say something about why you're doing this and what the expected > outcome of doing so is. >

Re: [PATCH v4 5/9] drm/msm/dpu: Add SM6150 support

2024-12-17 Thread Dmitry Baryshkov
On Tue, 17 Dec 2024 at 13:02, fange zhang wrote: > > > > On 2024/12/17 18:54, Dmitry Baryshkov wrote: > > On Tue, Dec 10, 2024 at 02:53:56PM +0800, Fange Zhang wrote: > >> From: Li Liu > >> > >> Add definitions for the display hardware used on the Qualcomm SM6150 > >> platform. > >> > >> Reviewed

Re: [PATCH v4 04/25] drm/tests: Add test for drm_atomic_helper_check_modeset()

2024-12-17 Thread Maxime Ripard
On Mon, 16 Dec 2024 16:43:15 -0800, Jessica Zhang wrote: > Add a test for drm_atomic_check_modeset() specifically to validate > drm_atomic_check_valid_clones() helper > > Signed-off-by: Jessica Zhang Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v2 02/22] drm: Add valid clones check

2024-12-17 Thread Simona Vetter
On Sun, Dec 15, 2024 at 06:19:08PM -0800, Abhinav Kumar wrote: > Hi Maxime > > Gentle reminder on this one. > > We are looking for some advice on how to go about KUnit for this static > function. > > Please help with our question below. > > Thanks > > Abhinav > > On 12/6/2024 4:48 PM, Jessica

Re: [PATCH v4 5/9] drm/msm/dpu: Add SM6150 support

2024-12-17 Thread Dmitry Baryshkov
On Tue, Dec 10, 2024 at 02:53:56PM +0800, Fange Zhang wrote: > From: Li Liu > > Add definitions for the display hardware used on the Qualcomm SM6150 > platform. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Li Liu > Signed-off-by: Fange Zhang > --- > .../gpu/drm/msm/disp/dpu1/catalog/dp

[PATCH v2] drm/msm/dpu: correct LM pairing for SM6150

2024-12-17 Thread Dmitry Baryshkov
The SM6150 platform doesn't have 3DMux (MERGE_3D) block, so it can not split the screen between two LMs. Drop lm_pair fields as they don't make sense for this platform. Suggested-by: Abhinav Kumar Fixes: cb2f9144693b ("drm/msm/dpu: Add SM6150 support") Signed-off-by: Dmitry Baryshkov --- Changes

[PATCH v2 1/5] drm/msm: register a fault handler for display mmu faults

2024-12-17 Thread Jessica Zhang
From: Abhinav Kumar In preparation to register a iommu fault handler for display related modules, register a fault handler for the backing mmu object of msm_kms. Currently, the fault handler only captures the display snapshot but we can expand this later if more information needs to be added to

[PATCH v2 5/5] drm/msm/dpu: rate limit snapshot capture for mmu faults

2024-12-17 Thread Jessica Zhang
From: Abhinav Kumar There is no recovery mechanism in place yet to recover from mmu faults for DPU. We can only prevent the faults by making sure there is no misconfiguration. Rate-limit the snapshot capture for mmu faults to once per msm_atomic_commit_tail() as that should be sufficient to capt

Re: [PATCH v4 9/9] arm64: dts: qcom: Add display support for QCS615 RIDE board

2024-12-17 Thread fange zhang
On 2024/12/13 18:19, Dmitry Baryshkov wrote: On Fri, 13 Dec 2024 at 11:21, fange zhang wrote: On 2024/12/10 19:02, Dmitry Baryshkov wrote: On Tue, Dec 10, 2024 at 02:54:00PM +0800, Fange Zhang wrote: From: Li Liu Add display MDSS and DSI configuration for QCS615 RIDE board. QCS615 has

[PATCH v2 0/5] drm/msm: add a display mmu fault handler

2024-12-17 Thread Jessica Zhang
| 3 +++ drivers/gpu/drm/msm/msm_mmu.h| 1 + 5 files changed, 52 insertions(+), 4 deletions(-) --- base-commit: 86313a9cd152330c634b25d826a281c6a002eb77 change-id: 20241217-abhinavk-smmu-fault-handler-ade75fef9809 Best regards, -- Jessica Zhang

[PATCH v2 4/5] drm/msm: switch msm_kms to use msm_iommu_disp_new()

2024-12-17 Thread Jessica Zhang
From: Abhinav Kumar Switch msm_kms to use msm_iommu_disp_new() so that the newly registered fault handler will kick-in during any mmu faults. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_kms.c | 2 +- 1 file changed, 1 in

[PATCH v2 3/5] drm/msm/iommu: introduce msm_iommu_disp_new() for msm_kms

2024-12-17 Thread Jessica Zhang
From: Abhinav Kumar Introduce a new API msm_iommu_disp_new() for display use-cases. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_iommu.c | 26 ++ drivers/gpu/drm/msm/msm_mmu.h | 1 + 2 files cha

[PATCH v2 2/5] drm/msm/iommu: rename msm_fault_handler to msm_gpu_fault_handler

2024-12-17 Thread Jessica Zhang
From: Abhinav Kumar In preparation of registering a separate fault handler for display, lets rename the existing msm_fault_handler to msm_gpu_fault_handler. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_iommu.c | 6 +++---

Re: [PATCH v6 3/7] drm/msm: adreno: dynamically generate GMU bw table

2024-12-17 Thread Akhil P Oommen
On 12/17/2024 8:21 PM, Neil Armstrong wrote: > The Adreno GPU Management Unit (GMU) can also scale the ddr > bandwidth along the frequency and power domain level, but for > now we statically fill the bw_table with values from the > downstream driver. > > Only the first entry is used, which is a di

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-17 Thread Akhil P Oommen
On 12/17/2024 2:21 AM, Rob Clark wrote: > On Mon, Dec 16, 2024 at 12:25 PM Akhil P Oommen > wrote: >> >> On 12/16/2024 10:28 PM, Connor Abbott wrote: >>> On Mon, Dec 16, 2024 at 11:55 AM Akhil P Oommen >>> wrote: On 12/13/2024 10:40 PM, Antonino Maniscalco wrote: > On 12/13/24 5:50

Re: [PATCH v4 03/25] drm: Add valid clones check

2024-12-17 Thread Maxime Ripard
On Mon, 16 Dec 2024 16:43:14 -0800, Jessica Zhang wrote: > Check that all encoders attached to a given CRTC are valid > possible_clones of each other. > > Signed-off-by: Jessica Zhang Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 02/25] drm/tests: Add test for drm_crtc_in_clone_mode()

2024-12-17 Thread Maxime Ripard
On Mon, 16 Dec 2024 16:43:13 -0800, Jessica Zhang wrote: > Add kunit test to validate drm_crtc_in_clone_mode() helper > > Signed-off-by: Jessica Zhang Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 01/25] drm: add clone mode check for CRTC

2024-12-17 Thread Maxime Ripard
On Mon, 16 Dec 2024 16:43:12 -0800, Jessica Zhang wrote: > Add a common helper to check if the given CRTC state is in clone mode. > This can be used by drivers to help detect if a CRTC is being shared by > multiple encoders > > Signed-off-by: Jessica Zhang > > [ ... ] Reviewed-by: Maxime Ripard