Re: [PATCH v5 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

2024-10-21 Thread Krzysztof Kozlowski
On Sat, Oct 19, 2024 at 09:14:54PM +0530, Mahadevan wrote: > Document the DPU for Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski Best re

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-21 Thread Maxime Ripard
On Sat, 19 Oct 2024 00:49:11 +0300, Dmitry Baryshkov wrote: > One of the features that drm_bridge_connector can't handle currently is > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > the drm_bridge struct and propagate it to the drm_connector as AND of > all flags in the

Re: [PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-21 Thread Abhinav Kumar
On 10/18/2024 2:49 PM, Dmitry Baryshkov wrote: Instead of forcing the ycbcr_420_allowed flag to be set on the created drm_connector, set it on the drm_bridge instance and allow drm_bridge_connecgtor to propagate it to the drm_connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/m

Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-10-21 Thread Akhil P Oommen
On Tue, Sep 24, 2024 at 08:14:17AM +0200, Dmitry Baryshkov wrote: > On Mon, 23 Sept 2024 at 22:05, Akhil P Oommen > wrote: > > > > On Wed, Sep 18, 2024 at 12:27:03AM +0300, Dmitry Baryshkov wrote: > > > On Wed, Sep 18, 2024 at 02:08:43AM GMT, Akhil P Oommen wrote: > > > > From: Puranam V G Tejasw

[PATCH v2 2/4] dt-bindings: display/msm/gmu: Add Adreno 663 GMU

2024-10-21 Thread Akhil P Oommen
From: Puranam V G Tejaswi Document Adreno 663 GMU in the dt-binding specification. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Docum

[PATCH v2 1/4] drm/msm/a6xx: Add support for A663

2024-10-21 Thread Akhil P Oommen
From: Puranam V G Tejaswi Add support for Adreno 663 found on sa8775p based platforms. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 19 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 ++- drivers/gp

[PATCH v2 3/4] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-10-21 Thread Akhil P Oommen
From: Puranam V G Tejaswi Add gpu and gmu nodes for sa8775p chipset. As of now all SKUs have the same GPU fmax, so there is no requirement of speed bin support. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 94

[PATCH v2 4/4] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

2024-10-21 Thread Akhil P Oommen
From: Puranam V G Tejaswi Enable GPU for sa8775p-ride platform and provide path for zap shader. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/

[PATCH v2 0/4] DRM/MSM: Support for Adreno 663 GPU

2024-10-21 Thread Akhil P Oommen
This series adds support for Adreno 663 gpu found in SA8775P chipsets. The closest gpu which is currently supported in drm-msm is A660. Following are the major differences with that: 1. gmu/zap firmwares 2. Recommended to disable Level2 swizzling Verified kmscube/weston/glmark2-es2

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-10-21 Thread Akhil P Oommen
On Mon, Oct 21, 2024 at 11:38:41AM +0200, Konrad Dybcio wrote: > On 11.10.2024 10:29 PM, Akhil P Oommen wrote: > > ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce > > the power consumption. In some chipsets, it is also a requirement to > > support higher GPU frequencies. Th

Re: [PATCH] drm: a6xx: avoid excessive stack usage

2024-10-21 Thread Akhil P Oommen
On Sat, Oct 19, 2024 at 04:14:13PM +0300, Dmitry Baryshkov wrote: > On Sat, Oct 19, 2024 at 03:01:46PM +0530, Akhil P Oommen wrote: > > On Fri, Oct 18, 2024 at 03:11:38PM +, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Clang-19 and above sometimes end up with multiple copies of

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other bridges in the chain still might limit YCbCr 420 support on the corresponding connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/display-connector.c | 4 1 f

Re: [PATCH 6/6] drm/bridge: dw-hdmi: set bridge's ycbcr_420_allowed flag

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Set the drm_bridge's ycbcr_420_allowed flag if the YCbCr 420 output is supported by the hardware. Cc: Alexander Stein Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --g

Re: [PATCH] drm: a6xx: avoid excessive stack usage

2024-10-21 Thread Konrad Dybcio
On 21.10.2024 11:25 AM, Akhil P Oommen wrote: > On Sat, Oct 19, 2024 at 04:14:13PM +0300, Dmitry Baryshkov wrote: >> On Sat, Oct 19, 2024 at 03:01:46PM +0530, Akhil P Oommen wrote: >>> On Fri, Oct 18, 2024 at 03:11:38PM +, Arnd Bergmann wrote: From: Arnd Bergmann Clang-19 and ab

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread Dmitry Baryshkov
On Mon, 21 Oct 2024 at 10:29, Neil Armstrong wrote: > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other > > bridges in the chain still might limit YCbCr 420 support on the > > corresponding connector. > > > > Signed-off-by: Dmitry

[PATCH v2 1/3] drm/msm/adreno: Add support for ACD

2024-10-21 Thread Akhil P Oommen
ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce the power consumption. In some chipsets, it is also a requirement to support higher GPU frequencies. This patch adds support for GPU ACD by sending necessary data to GMU and AOSS. The feature support for the chipset is detecte

[PATCH v2 0/3] Support for GPU ACD feature on Adreno X1-85

2024-10-21 Thread Akhil P Oommen
This series adds support for ACD feature for Adreno GPU which helps to lower the power consumption on GX rail and also sometimes is a requirement to enable higher GPU frequencies. At high level, following are the sequences required for ACD feature: 1. Identify the ACD level data for each re

[PATCH v2 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-10-21 Thread Akhil P Oommen
Add a new schema which extends opp-v2 to support a new vendor specific property required for Adreno GPUs found in Qualcomm's SoCs. The new property called "qcom,opp-acd-level" carries a u32 value recommended for each opp needs to be shared to GMU during runtime. Cc: Rob Clark Signed-off-by: Akhil

[PATCH v2 3/3] arm64: dts: qcom: x1e80100: Add ACD levels for GPU

2024-10-21 Thread Akhil P Oommen
Update GPU node to include acd level values. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index a36076e3c56

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread neil . armstrong
On 21/10/2024 11:06, Dmitry Baryshkov wrote: On Mon, 21 Oct 2024 at 10:29, Neil Armstrong wrote: On 18/10/2024 23:49, Dmitry Baryshkov wrote: Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other bridges in the chain still might limit YCbCr 420 support on the corresponding connect

Re: [PATCH 1/6] drm/display: bridge_connector: handle ycbcr_420_allowed

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Follow the interlace_allowed example and calculate drm_connector's ycbcr_420_allowed flag as AND of all drm_bridge's ycbcr_420_allowed flags in a chain. This is one of the gaps between several bridge-specific connector implementations and drm_bridge_co

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-10-21 Thread Konrad Dybcio
On 11.10.2024 10:29 PM, Akhil P Oommen wrote: > ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce > the power consumption. In some chipsets, it is also a requirement to > support higher GPU frequencies. This patch adds support for GPU ACD by > sending necessary data to GMU an

Re: [PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Although the interlace_allowed and ycbcr_420_allowed flags are a part of the struct drm_connector rather than struct drm_connector_state, still include them into state dump in order to ease debugging of the setup issues. Signed-off-by: Dmitry Baryshko

Re: [PATCH 4/6] drm/bridge: aux: allow interlaced and YCbCr 420 output

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: As both aux bridges are merely passthrough bridges, mark them as supporting interlaced and YCbCr 420 data. Other bridges in the chain still might limit interlaced and YCbCr 420 data support on the corresponding connector. Signed-off-by: Dmitry Baryshk

Re: [PATCH] drm: a6xx: avoid excessive stack usage

2024-10-21 Thread Arnd Bergmann
On Mon, Oct 21, 2024, at 09:25, Akhil P Oommen wrote: > On Sat, Oct 19, 2024 at 04:14:13PM +0300, Dmitry Baryshkov wrote: >> On Sat, Oct 19, 2024 at 03:01:46PM +0530, Akhil P Oommen wrote: >> > On Fri, Oct 18, 2024 at 03:11:38PM +, Arnd Bergmann wrote: >> > > From: Arnd Bergmann >> > > >> > >

Re: [PATCH v6 00/15] drm/msm/dpu: be more friendly to X.org

2024-10-21 Thread Dmitry Baryshkov
On Tue, 03 Sep 2024 06:22:43 +0300, Dmitry Baryshkov wrote: > Unlike other compositors X.org allocates a single framebuffer covering > the whole screen space. This is not an issue with the single screens, > but with the multi-monitor setup 5120x4096 becomes a limiting factor. > Check the hardware

Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon

2024-10-21 Thread Dmitry Baryshkov
On Wed, 18 Sep 2024 10:33:57 +0800, Yang Li wrote: > ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon > > This patch removes an unneeded semicolon after a switch statement in the > pll_get_post_div function. Adding a semicolon after a switch statement is > unnecessary and c

Re: [PATCH 0/3] drm/msm/dpu: catalog fixes for SDM845 / MSM8998

2024-10-21 Thread Dmitry Baryshkov
On Thu, 05 Sep 2024 06:26:12 +0300, Dmitry Baryshkov wrote: > Drop two extra blocks that sneaked into SDM845 and MSM8998 catalog > declarations. > > Applied, thanks! [1/3] drm/msm/dpu: on SDM845 move DSPP_3 to LM_5 block https://gitlab.freedesktop.org/lumag/msm/-/commit/768a272d5357 [2/

Re: [PATCH][next] drm/msm8998: make const arrays ratio_list and band_list static

2024-10-21 Thread Dmitry Baryshkov
On Thu, 12 Sep 2024 16:10:37 +0100, Colin Ian King wrote: > Don't populate the const read-only arrays ratio_list and band_list on the > stack at run time, instead make them static. > > Applied, thanks! [1/1] drm/msm8998: make const arrays ratio_list and band_list static https://gitlab.f

Re: [PATCH v5 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-21 Thread Dmitry Baryshkov
On Sat, 19 Oct 2024 21:14:52 +0530, Mahadevan wrote: > This series introduces support to enable the Mobile Display Subsystem (MDSS) > and Display Processing Unit (DPU) for the Qualcomm SA8775P target. It > includes the addition of the hardware catalog, compatible string, > relevant device tree ch

Re: [PATCH 0/5] dt-bindings: display/msm: dpu: merge bindings

2024-10-21 Thread Dmitry Baryshkov
On Thu, 03 Oct 2024 10:14:17 +0200, Krzysztof Kozlowski wrote: > In 2022 the bindings were split each device per file, but this makes > not much sense. Devices are the same in many cases, same clocks, same IO > register space. > > Best regards, > Krzysztof > > [...] Applied, thanks! [1/5] dt

Re: [PATCH v2 0/4] Add MSM8996/MSM8953/MSM8937/MSM8917 dpu catalog

2024-10-21 Thread Dmitry Baryshkov
On Mon, 30 Sep 2024 20:35:55 +0200, Barnabás Czémán wrote: > This patch series add dpu support for MSM8996/MSM8953/MSM8937/MSM8917 SoCs. > > This parch series was tested on many devices: > > - Xiaomi Redmi 5A (msm8917, video panel) > - Xiaomi Redmi Note 5A (msm8917, video panel) > - Xiaomi Redm

Re: [PATCH v5 0/5] Add support for DisplayPort on SA8775P platform

2024-10-21 Thread Dmitry Baryshkov
On Fri, 18 Oct 2024 12:37:01 +0530, Soutrik Mukhopadhyay wrote: > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > Applied, thanks! [4/5] dt-bindings: display: msm: dp-controller: document SA8775P compatible https://gitlab

Re: [PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Instead of forcing the ycbcr_420_allowed flag to be set on the created drm_connector, set it on the drm_bridge instance and allow drm_bridge_connecgtor to propagate it to the drm_connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp

Re: [PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-21 Thread Neil Armstrong
On 18/10/2024 23:49, Dmitry Baryshkov wrote: Instead of forcing the ycbcr_420_allowed flag to be set on the created drm_connector, set it on the drm_bridge instance and allow drm_bridge_connecgtor to propagate it to the drm_connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-21 Thread Neil Armstrong
Hi, On 18/10/2024 23:49, Dmitry Baryshkov wrote: One of the features that drm_bridge_connector can't handle currently is setting of the ycbcr_420_allowed flag on the connector. Add the flag to the drm_bridge struct and propagate it to the drm_connector as AND of all flags in the bridge chain. A

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-21 Thread Dmitry Baryshkov
On Mon, 21 Oct 2024 at 15:32, Neil Armstrong wrote: > > Hi, > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > One of the features that drm_bridge_connector can't handle currently is > > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > > the drm_bridge struct and propaga

Re: [PATCH v2 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-10-21 Thread Krzysztof Kozlowski
On Mon, Oct 21, 2024 at 05:23:43PM +0530, Akhil P Oommen wrote: > Add a new schema which extends opp-v2 to support a new vendor specific > property required for Adreno GPUs found in Qualcomm's SoCs. The new > property called "qcom,opp-acd-level" carries a u32 value recommended > for each opp needs