Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-09 Thread Dmitry Baryshkov
On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > Only 2 DSC engines are allowed, or no DSC is involved currently. Can't parse this phrase. > We need 4 DSC in quad-pipe topology in future. So let's only configure > DSC engines in use, instread of maximum number of DSC engines. Nit: instead > > S

Re: [PATCH v4 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-09 Thread Dmitry Baryshkov
On Wed, 9 Oct 2024 at 17:34, Mahadevan wrote: > > This series introduces support to enable the Mobile Display Subsystem (MDSS) > and Display Processing Unit (DPU) for the Qualcomm SA8775P target. It > includes the addition of the hardware catalog, compatible string, > relevant device tree changes,

[PATCH v4 4/5] drm/msm/dpu: Add SA8775P support

2024-10-09 Thread Mahadevan
Add definitions for the display hardware used on the Qualcomm SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- .../drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h| 485 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/

[PATCH v4 5/5] arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU

2024-10-09 Thread Mahadevan
Add devicetree changes to enable MDSS0 display-subsystem its display-controller(DPU) for Qualcomm SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 89 +++ 1 file changed, 89 insertions(+) diff -

[PATCH v4 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-09 Thread Mahadevan
This series introduces support to enable the Mobile Display Subsystem (MDSS) and Display Processing Unit (DPU) for the Qualcomm SA8775P target. It includes the addition of the hardware catalog, compatible string, relevant device tree changes, and their YAML bindings. --- In this series - PATCH 1:

[PATCH v4 3/5] drm/msm: mdss: Add SA8775P support

2024-10-09 Thread Mahadevan
Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v4 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-10-09 Thread Mahadevan
Document the MDSS hardware found on the Qualcomm SA8775P platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Mahadevan --- .../bindings/display/msm/qcom,sa8775p-mdss.yaml| 241 + 1 file changed, 241 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

[PATCH v4 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

2024-10-09 Thread Mahadevan
Document the DPU for Qualcomm SA8775P platform. Signed-off-by: Mahadevan --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindi

Re: [PATCH v4 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

2024-10-09 Thread Rob Herring (Arm)
x27; was unexpected) from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8650-dpu.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009-patchv3_1-v4-2-cd683a9ca...@quicinc.com The base for the series

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-09 Thread Adrián Larumbe
Hi Tvrtko, On 04.10.2024 14:41, Tvrtko Ursulin wrote: > > Hi Adrian, > > On 03/10/2024 00:45, Adrián Larumbe wrote: > > Some drivers must allocate a considerable amount of memory for bookkeeping > > structures and GPU's MCU-kernel shared communication regions. These are > > often created as a re

[PATCH v2 01/14] drm/msm/dpu: polish log for resource allocation

2024-10-09 Thread Jun Nie
Add resource allocation type info. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 15b42a6683639..

[PATCH v2 02/14] drm/msm/dpu: decide right side per last bit

2024-10-09 Thread Jun Nie
decide right side of a pair per last bit, in case of multiple mixer pairs. Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drive

[PATCH v2 00/14] drm/msm/dpu: Support quad pipe with dual-DSI

2024-10-09 Thread Jun Nie
: eac5b436019c2eeb005f7bdf3ca29d5e8f443d67 change-id: 20241009-sm8650-v6-11-hmd-pocf-mdss-quad-upstream-21-1142507692ba Best regards, -- Jun Nie

[PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-09 Thread Jun Nie
Store pipes in array with removing dedicated r_pipe. There are 2 pipes in a drm plane at most currently. While 4 pipes are needed for new usage case. This change generalize the handling to pipe pair and ease handling to another pipe pair later. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp

[PATCH v2 04/14] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-10-09 Thread Jun Nie
Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id so that mixer number can be known in dpu_plane_virtual_assign_resources() via CRTC id for sspp alloation. Because the mixer allocation is done in drm_atomic_helper_check_modeset() as part of CRTC o

[PATCH v2 06/14] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2024-10-09 Thread Jun Nie
Split PIPES_PER_STAGE definition per plane and mixer pair. Because there are more than 2 pipes in quad pipe case, while 2 pipes at most per mixer pair. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 2 +- drivers/gpu

[PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-09 Thread Jun Nie
Blend pipes by set of mixer pair config. The first 2 pipes are for left half screen with the first set of mixer pair config. And the later 2 pipes are for right in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 38 ++--- drivers/g

[PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-09 Thread Jun Nie
Update mixer number info earlier so that the plane nopipe check can have the info to clip the plane. Otherwise, the first nonpipe check will have mixer number as 0 and plane is not checked. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 ++- 1 file changed, 1

[PATCH v2 07/14] drm/msm/dpu: bind correct pingpong for quad pipe

2024-10-09 Thread Jun Nie
There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_enco

[PATCH v2 10/14] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-10-09 Thread Jun Nie
Move requreiment check to routine of every pipe check. Because there is multiple SSPPs for quad-pipe case in future. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 86 ++--- 2 files changed, 44

[PATCH v2 03/14] drm/msm/dpu: fix mixer number counter on allocation

2024-10-09 Thread Jun Nie
Add the case to reserve multiple pairs mixers for high resolution. Current code only supports one pair of mixer usage case. To support quad-pipe usage case, two pairs of mixers are needed. Current code resets number of mixer on failure of pair's peer test and retry on another pair. If two pairs ar

[PATCH v2 12/14] drm/msm/dpu: support plane splitting in quad-pipe case

2024-10-09 Thread Jun Nie
Clip plane into pipes per left and right half screen ROI if topology is quad pipe. Then split the clipped rectangle by half if the rectangle width still exceeds width limit. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h |

[PATCH v2 14/14] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2024-10-09 Thread Jun Nie
Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are enabled. We prefer to use 4 pipes for dual DSI case for it is power optimal for DSC. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 +

[PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-09 Thread Jun Nie
Share SSPP info for multi-rect case if virtual plane is not enabled. Otherwise, the 2nd half of DMA content is not displayed due to sspp pointer of r_pipe is null. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a/driver

[PATCH v2 13/14] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-10-09 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method. The first 2 pipes can share a set of mixer config and enable multi-rect mode if condition is met. It is also the case for the later 2 pipes. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 85 +++--

Re: [PATCH v2 16/22] drm/msm/dpu: Configure CWB in writeback encoder

2024-10-09 Thread neil . armstrong
On 08/10/2024 14:25, Jessica Zhang wrote: On 10/8/2024 1:00 AM, Neil Armstrong wrote: Hi, On 01/10/2024 09:37, neil.armstr...@linaro.org wrote: Hi, On 30/09/2024 21:19, Jessica Zhang wrote: On 9/30/2024 7:17 AM, neil.armstr...@linaro.org wrote: On 25/09/2024 00:59, Jessica Zhang wrote:

Re: [v8,09/12] drm/msm/a6xx: Add traces for preemption

2024-10-09 Thread Kees Bakker
Op 03-10-2024 om 18:12 schreef Antonino Maniscalco: Add trace points corresponding to preemption being triggered and being completed for latency measurement purposes. Reviewed-by: Akhil P Oommen Tested-by: Rob Clark Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-09 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 06:10写道: > > On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > > > Only 2 DSC engines are allowed, or no DSC is involved currently. > > Can't parse this phrase. How about this: If DSC is enabled, the only case is with 2 DSC engines so far. > > > We need 4 DSC in q

[PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-09 Thread Jessica Zhang
_pp->merge_3d) + if (mode_3d && hw_ctl->ops.update_pending_flush_merge_3d && + hw_pp && hw_pp->merge_3d) hw_ctl->ops.update_pending_flush_merge_3d(hw_ctl, hw_pp->merge_3d->idx); --- base-commit: a20a91fb1bfac5d05ec5bcf9afe0c9363f6c8c93 change-id: 20241009-mode3d-fix-4c3c114ffeb9 Best regards, -- Jessica Zhang

[PATCH] drm/msm/dpu: don't always program merge_3d block

2024-10-09 Thread Jessica Zhang
Only program the merge_3d block for the video phys encoder when the 3d blend mode is not NONE Fixes: 3e79527a33a8 ("drm/msm/dpu: enable merge_3d support on sm8150/sm8250") Suggested-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- 1