Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-17 Thread Soutrik Mukhopadhyay
On 9/14/2024 2:54 AM, Bjorn Andersson wrote: On Thu, Sep 12, 2024 at 03:34:05PM +0530, Soutrik Mukhopadhyay wrote: On 9/12/2024 1:32 AM, Bjorn Andersson wrote: On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: The Qualcomm SA8775P platform comes with a DisplayPort control

Re: [PATCH v2 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-17 Thread Soutrik Mukhopadhyay
On 9/13/2024 5:12 PM, Dmitry Baryshkov wrote: On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay wrote: In order to support different HW versions, introduce aux_cfg array to move v4 specific aux configuration settings. Signed-off-by: Soutrik Mukhopadhyay --- v2: Fixed review comments from

Re: [PATCH v2 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-17 Thread Dmitry Baryshkov
On Tue, 17 Sept 2024 at 10:40, Soutrik Mukhopadhyay wrote: > > > On 9/13/2024 5:12 PM, Dmitry Baryshkov wrote: > > On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay > > wrote: > >> In order to support different HW versions, introduce aux_cfg array > >> to move v4 specific aux configuration sett

[PATCH v4 00/11] Preemption support for A7XX

2024-09-17 Thread Antonino Maniscalco
This series implements preemption for A7XX targets, which allows the GPU to switch to an higher priority ring when work is pushed to it, reducing latency for high priority submissions. This series enables L1 preemption with skip_save_restore which requires the following userspace patches to functi

[PATCH v4 01/11] drm/msm: Fix bv_fence being used as bv_rptr

2024-09-17 Thread Antonino Maniscalco
The bv_fence field of rbmemptrs was being used incorrectly as the BV rptr shadow pointer in some places. Add a bv_rptr field and change the code to use that instead. Signed-off-by: Antonino Maniscalco Reviewed-by: Akhil P Oommen Tested-by: Neil Armstrong # on SM8650-QRD --- drivers/gpu/drm/ms

[PATCH v4 02/11] drm/msm/A6XX: Track current_ctx_seqno per ring

2024-09-17 Thread Antonino Maniscalco
With preemption it is not enough to track the current_ctx_seqno globally as execution might switch between rings. This is especially problematic when current_ctx_seqno is used to determine whether a page table switch is necessary as it might lead to security bugs. Track current context per ring.

[PATCH v4 03/11] drm/msm: Add a `preempt_record_size` field

2024-09-17 Thread Antonino Maniscalco
Adds a field to `adreno_info` to store the GPU specific preempt record size. Signed-off-by: Antonino Maniscalco Reviewed-by: Akhil P Oommen Tested-by: Neil Armstrong # on SM8650-QRD --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 4 drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + 2 files

[PATCH v4 04/11] drm/msm: Add CONTEXT_SWITCH_CNTL bitfields

2024-09-17 Thread Antonino Maniscalco
Add missing bitfields to CONTEXT_SWITCH_CNTL in a6xx.xml. Signed-off-by: Antonino Maniscalco --- drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/adreno/a6xx.xml b/drivers/gpu/drm/msm/registers/

[PATCH v4 05/11] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-17 Thread Antonino Maniscalco
This patch implements preemption feature for A6xx targets, this allows the GPU to switch to a higher priority ringbuffer if one is ready. A6XX hardware as such supports multiple levels of preemption granularities, ranging from coarse grained(ringbuffer level) to a more fine grained such as draw-cal

[PATCH v4 07/11] drm/msm/A6xx: Use posamble to reset counters on preemption

2024-09-17 Thread Antonino Maniscalco
Use the postamble to reset perf counters when switching between rings, except when sysprof is enabled, analogously to how they are reset between submissions when switching pagetables. Signed-off-by: Antonino Maniscalco --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++ drivers/gpu/drm/m

[PATCH v4 08/11] drm/msm/A6xx: Add traces for preemption

2024-09-17 Thread Antonino Maniscalco
Add trace points corresponding to preemption being triggered and being completed for latency measurement purposes. Signed-off-by: Antonino Maniscalco Tested-by: Neil Armstrong # on SM8650-QRD --- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 6 ++ drivers/gpu/drm/msm/msm_gpu_trace.h |

[PATCH v4 09/11] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-09-17 Thread Antonino Maniscalco
Some userspace changes are necessary so add a flag for userspace to advertise support for preemption when creating the submitqueue. When this flag is not set preemption will not be allowed in the middle of the submitted IBs therefore mantaining compatibility with older userspace. The flag is reje

[PATCH v4 11/11] Documentation: document adreno preemption

2024-09-17 Thread Antonino Maniscalco
Add documentation about the preemption feature supported by the msm driver. Signed-off-by: Antonino Maniscalco --- Documentation/gpu/msm-preemption.rst | 98 1 file changed, 98 insertions(+) diff --git a/Documentation/gpu/msm-preemption.rst b/Documentation/

[PATCH v4 10/11] drm/msm/A6xx: Enable preemption for A750

2024-09-17 Thread Antonino Maniscalco
Initialize with 4 rings to enable preemption. For now only on A750 as other targets require testing. Add the "preemption_enabled" module parameter to override this for other A7xx targets. Signed-off-by: Antonino Maniscalco Tested-by: Neil Armstrong # on SM8650-QRD --- drivers/gpu/drm/msm/adre

[PATCH v4 06/11] drm/msm/A6xx: Sync relevant adreno_pm4.xml changes

2024-09-17 Thread Antonino Maniscalco
In mesa CP_SET_CTXSWITCH_IB is renamed to CP_SET_AMBLE and some other names are changed to match KGSL. Import those changes. The changes have not been merged yet in mesa but are necessary for this series. Signed-off-by: Antonino Maniscalco --- .../gpu/drm/msm/registers/adreno/adreno_pm4.xml

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-17 Thread Konrad Dybcio
On 17.09.2024 10:12 AM, Soutrik Mukhopadhyay wrote: > > On 9/14/2024 2:54 AM, Bjorn Andersson wrote: >> On Thu, Sep 12, 2024 at 03:34:05PM +0530, Soutrik Mukhopadhyay wrote: >>> On 9/12/2024 1:32 AM, Bjorn Andersson wrote: On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote:

Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-17 Thread Konrad Dybcio
On 13.09.2024 9:51 PM, Rob Clark wrote: > From: Rob Clark > > The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some > devices (x1-85, possibly others), it seems to pass that barrier while > there are still things in the event completion FIFO waiting to be > written back to memory. C

Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-17 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 03:47:09PM +0200, Konrad Dybcio wrote: > On 13.09.2024 9:51 PM, Rob Clark wrote: > > From: Rob Clark > > > > The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some > > devices (x1-85, possibly others), it seems to pass that barrier while > > there are still thi

Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-17 Thread Rob Clark
On Tue, Sep 17, 2024 at 6:47 AM Konrad Dybcio wrote: > > On 13.09.2024 9:51 PM, Rob Clark wrote: > > From: Rob Clark > > > > The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some > > devices (x1-85, possibly others), it seems to pass that barrier while > > there are still things in t

[PATCH 0/3] DRM/MSM: Support for Adreno 663 GPU

2024-09-17 Thread Akhil P Oommen
/drm/msm/adreno/a6xx_hfi.c | 33 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h| 5 ++ 7 files changed, 148 insertions(+), 1 deletion(-) --- base-commit: 15302579373ed2c8ada629e9e7bcf9569393a48d change-id: 20240917-a663-gpu-support-b1475c828606 Best regards, -- Akh

[PATCH 1/3] drm/msm/a6xx: Add support for A663

2024-09-17 Thread Akhil P Oommen
From: Puranam V G Tejaswi Add support for Adreno 663 found on sa8775p based platforms. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 19 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++- drivers/gpu/d

[PATCH 2/3] dt-bindings: display/msm/gmu: Add Adreno 663 GMU

2024-09-17 Thread Akhil P Oommen
From: Puranam V G Tejaswi Document Adreno 663 GMU in the dt-binding specification. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/

[PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-09-17 Thread Akhil P Oommen
From: Puranam V G Tejaswi Add gpu and gmu nodes for sa8775p based platforms. Signed-off-by: Puranam V G Tejaswi Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 8 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 75 ++ 2 files chang

Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-09-17 Thread Dmitry Baryshkov
On Wed, Sep 18, 2024 at 02:08:43AM GMT, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Add gpu and gmu nodes for sa8775p based platforms. Which platforms? The commit adds nodes to the SoC and the single RIDE platform. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oomm

Re: [PATCH 1/3] drm/msm/a6xx: Add support for A663

2024-09-17 Thread Dmitry Baryshkov
On Wed, Sep 18, 2024 at 02:08:41AM GMT, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Add support for Adreno 663 found on sa8775p based platforms. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 19

Re: [PATCH 0/3] DRM/MSM: Support for Adreno 663 GPU

2024-09-17 Thread Dmitry Baryshkov
m/msm/adreno/a6xx_gpu.c | 8 ++- > drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 33 ++ > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++ > 7 files changed, 148 insertions(+), 1 deletion(-) > --- > base-commit: 15302579373ed2c8ada629e9e7bcf9569393a48d > change-id: 20240917-a663-gpu-support-b1475c828606 > > Best regards, > -- > Akhil P Oommen > -- With best wishes Dmitry

Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-17 Thread Konrad Dybcio
On 17.09.2024 5:30 PM, Rob Clark wrote: > On Tue, Sep 17, 2024 at 6:47 AM Konrad Dybcio wrote: >> >> On 13.09.2024 9:51 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some >>> devices (x1-85, possibly others), it seems to pass that b

Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update

2024-09-17 Thread Rob Clark
On Tue, Sep 17, 2024 at 4:37 PM Konrad Dybcio wrote: > > On 17.09.2024 5:30 PM, Rob Clark wrote: > > On Tue, Sep 17, 2024 at 6:47 AM Konrad Dybcio > > wrote: > >> > >> On 13.09.2024 9:51 PM, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle

[PATCH -next v2] drm/msm: Remove unneeded semicolon

2024-09-17 Thread Yang Li
./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon This patch removes an unneeded semicolon after a switch statement in the pll_get_post_div function. Adding a semicolon after a switch statement is unnecessary and can lead to confusion in the code structure. Reported-by: Aba