Re: [PATCH v2] drm/msm/dp: fix the max supported bpp logic

2024-08-05 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-30 10:55:40) > Fix the dp_panel_get_supported_bpp() API to return the minimum > supported bpp correctly for relevant cases and use this API > to correct the behavior of DP driver which hard-codes the max supported > bpp to 30. > > This is incorrect because the number

Re: [PATCH 2/4] drm/msm/a5xx: properly clear preemption records on resume

2024-08-05 Thread Akhil P Oommen
On Fri, Aug 02, 2024 at 01:41:32PM +, Vladimir Lypak wrote: > On Thu, Aug 01, 2024 at 06:46:10PM +0530, Akhil P Oommen wrote: > > On Thu, Jul 11, 2024 at 10:00:19AM +, Vladimir Lypak wrote: > > > Two fields of preempt_record which are used by CP aren't reset on > > > resume: "data" and "inf

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-05 Thread Abhinav Kumar
On 8/2/2024 12:47 PM, Dmitry Baryshkov wrote: During suspend/resume process all connectors are explicitly disabled and then reenabled. However resume fails because of the connector_status check: [ 1185.831970] [dpu error]connector not connected 3 It doesn't make sense to check for the Writeb

Re: [PATCH v2 2/2] drm/msm/dpu: don't play tricks with debug macros

2024-08-05 Thread Abhinav Kumar
On 8/2/2024 12:47 PM, Dmitry Baryshkov wrote: DPU debugging macros need to be converted to a proper drm_debug_* macros, however this is a going an intrusive patch, not suitable for a fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER to make sure that DPU debugging message

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:20AM +, Vladimir Lypak wrote: > On A5XX GPUs when preemption is used it's invietable to enter a soft > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > This appears as full UI lockup and not detected as GPU hang (because > it's not). This h

Re: [PATCH v5 02/12] drm/msm/dpu: relax YUV requirements

2024-08-05 Thread Abhinav Kumar
On 7/31/2024 5:34 PM, Dmitry Baryshkov wrote: On Wed, 31 Jul 2024 at 22:36, Abhinav Kumar wrote: On 6/26/2024 2:45 PM, Dmitry Baryshkov wrote: YUV formats require only CSC to be enabled. Even decimated formats should not require scaler. Relax the requirement and don't check for the scale

Re: [PATCH 4/4] drm/msm/a5xx: workaround early ring-buffer emptiness check

2024-08-05 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:21AM +, Vladimir Lypak wrote: > There is another cause for soft lock-up of GPU in empty ring-buffer: > race between GPU executing last commands and CPU checking ring for > emptiness. On GPU side IRQ for retire is triggered by CACHE_FLUSH_TS > event and RPTR shadow

[PATCH v3] drm/msm/dp: fix the max supported bpp logic

2024-08-05 Thread Abhinav Kumar
Fix the dp_panel_get_supported_bpp() API to return the minimum supported bpp correctly for relevant cases and use this API to correct the behavior of DP driver which hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need