Re: [Freedreno] [PATCH RFC v7 07/10] drm/atomic: Loosen FB atomic checks

2023-12-05 Thread Maxime Ripard
Hi, On Fri, Oct 27, 2023 at 03:32:57PM -0700, Jessica Zhang wrote: > Loosen the requirements for atomic and legacy commit so that, in cases > where pixel_source != FB, the commit can still go through. > > This includes adding framebuffer NULL checks in other areas to account for > FB being NULL w

Re: [Freedreno] [PATCH v2 1/2] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [Freedreno] [RFT PATCH v2 1/4] drm/msm/dpu: enable writeback on SM8150

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > On 04/12/2023 10:38, Maxime Ripard wrote: > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > The drm_atomic_helper_check_wb_encoder_state() function doesn't use > > > encoder for anything other than getting

Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Dmitry Baryshkov
On Tue, 5 Dec 2023 at 13:48, Maxime Ripard wrote: > > On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > > On 04/12/2023 10:38, Maxime Ripard wrote: > > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > > The drm_atomic_helper_check_wb_encoder_state() funct

Re: [Freedreno] [RFT PATCH v2 1/4] drm/msm/dpu: enable writeback on SM8150

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [Freedreno] [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-05 Thread Mark Brown
120651840e79b535594ee09f5768] Merge branch 'for-linux-next-fixes' of git://anongit.freedesktop.org/drm/drm-misc git bisect good cc1b39317a57120651840e79b535594ee09f5768 # bad: [0f5f12ac05f36f117e793656c3f560625e927f1b] Add linux-next specific files for 20231205 git bisect bad 0f

Re: [Freedreno] [PATCH] drm/ci: remove rebase-merge directory

2023-12-05 Thread Helen Koike
On 02/12/2023 19:13, Dmitry Baryshkov wrote: Gitlab runner can cache git repository, including the unfinished rebase merge status. New CI job will come as a fresh checkout, however this will not destroy the unfinished rebase, failing our build script. Destroy the unfinished rebase state. Sugg

Re: [Freedreno] [PATCH v2] drm/msm/dpu: improve DSC allocation

2023-12-05 Thread Kuogee Hsieh
On 12/4/2023 4:23 PM, Dmitry Baryshkov wrote: On Tue, 5 Dec 2023 at 01:55, Kuogee Hsieh wrote: A DCE (Display Compression Engine) contains two DSC hard slice encoders. Each DCE start with even DSC encoder index followed by an odd DSC encoder index. Each encoder can work independently. But Onl

Re: [Freedreno] [RFT PATCH v2 2/4] drm/msm/dpu: enable writeback on SC8108X

2023-12-05 Thread kernel test robot
Hi Dmitry, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Freedreno] [PATCH] drm/scheduler: Unwrap job dependencies

2023-12-05 Thread Rob Clark
From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap array or chain fences. Signed-off-by: Rob Clark --- drivers/gpu/drm/scheduler/sched_main.c | 47 ++ 1 file changed, 32

[Freedreno] [PATCH] drm/msm: Expose syncobj timeline support

2023-12-05 Thread Rob Clark
From: Rob Clark This does unfortunately require a mesa fix to avoid turnip hanging, but we don't have a good way to know the userspace version. Fortunately that fix is now in mesa-23.3.0-rc3 and later[1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/2bd7e293bfed5d2956a5dcb3e17555d0f68

Re: [Freedreno] [PATCH v2] drm/msm/dpu: improve DSC allocation

2023-12-05 Thread Dmitry Baryshkov
On Tue, 5 Dec 2023 at 20:12, Kuogee Hsieh wrote: > > > On 12/4/2023 4:23 PM, Dmitry Baryshkov wrote: > > On Tue, 5 Dec 2023 at 01:55, Kuogee Hsieh wrote: > >> A DCE (Display Compression Engine) contains two DSC hard slice > >> encoders. Each DCE start with even DSC encoder index followed by > >>

Re: [Freedreno] [PATCH v2] drm/msm/dpu: correct clk bit for WB2 block

2023-12-05 Thread Abhinav Kumar
On 12/2/2023 4:24 PM, Dmitry Baryshkov wrote: On sc7280 there are two clk bits for WB2: vbif_cli and clk_ctrl. While programming the VBIF params of WB, the driver should be toggling the former bit, while the sc7180_mdp, sc7280_mdp and sm8250_mdp structs list the latter one. Correct that to en

Re: [Freedreno] [PATCH v2] drm/msm/dpu: improve DSC allocation

2023-12-05 Thread Kuogee Hsieh
On 12/5/2023 11:23 AM, Dmitry Baryshkov wrote: On Tue, 5 Dec 2023 at 20:12, Kuogee Hsieh wrote: On 12/4/2023 4:23 PM, Dmitry Baryshkov wrote: On Tue, 5 Dec 2023 at 01:55, Kuogee Hsieh wrote: A DCE (Display Compression Engine) contains two DSC hard slice encoders. Each DCE start with even

Re: [Freedreno] [PATCH v2] drm/msm/dpu: correct clk bit for WB2 block

2023-12-05 Thread Paloma Arellano
On 12/5/2023 12:30 PM, Abhinav Kumar wrote: On 12/2/2023 4:24 PM, Dmitry Baryshkov wrote: On sc7280 there are two clk bits for WB2: vbif_cli and clk_ctrl. While programming the VBIF params of WB, the driver should be toggling the former bit, while the sc7180_mdp, sc7280_mdp and sm8250_mdp st

[Freedreno] [PATCH 0/5] drm/msm/adreno: Introduce/rework device hw catalog

2023-12-05 Thread Rob Clark
From: Rob Clark Split the single flat gpulist table into per-gen tables that exist in their own per-gen files, and start moving more info into the device table. This at least gets all the big tables of register settings out of the heart of the a6xx_gpu code. Probably more could be moved, to rem

[Freedreno] [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-05 Thread Rob Clark
From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 59 +++--- 1 file changed, 51 insertions(+), 8 deletions(-) diff --git a/drive

[Freedreno] [PATCH 2/5] drm/msm/adreno: Split catalog into separate files

2023-12-05 Thread Rob Clark
From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 53 ++ drivers/gpu/drm/msm/adreno/a3xx_catalog.c | 75 +++ dr

[Freedreno] [PATCH 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2023-12-05 Thread Rob Clark
From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 560 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 558 - drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 - 3 files chang

[Freedreno] [PATCH 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2023-12-05 Thread Rob Clark
From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 55 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +- drivers/gpu/drm/m

[Freedreno] [PATCH 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2023-12-05 Thread Rob Clark
From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 246 - drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 255 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 + drive

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-05 Thread Bjorn Andersson
On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: > > > On 12/3/2023 7:31 PM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, D