Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: attach the DP subconnector property

2023-11-15 Thread Johan Hovold
On Wed, Oct 25, 2023 at 12:23:10PM +0300, Dmitry Baryshkov wrote: > While developing and testing the commit bfcc3d8f94f4 ("drm/msm/dp: > support setting the DP subconnector type") I had the patch [1] in my > tree. I haven't noticed that it was a dependency for the commit in > question. Mea culpa.

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case

2023-11-15 Thread Johan Hovold
On Wed, Oct 25, 2023 at 12:23:09PM +0300, Dmitry Baryshkov wrote: > From: Abel Vesa > > In case of the eDP connection there is no subconnetor and as such no > subconnector property. Put drm_dp_set_subconnector_property() calls > under the !is_edp condition. > > Fixes: bfcc3d8f94f4 ("drm/msm/dp:

Re: [Freedreno] [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 09:55, Manivannan Sadhasivam wrote: > > + Dmitry > > On Wed, Nov 15, 2023 at 12:02:01PM +0530, Viresh Kumar wrote: > > On 11-10-23, 11:18, Viresh Kumar wrote: > > > On 16-02-23, 12:17, Manivannan Sadhasivam wrote: > > > > Sorry for the delay. I've submitted the dts changes [

Re: [Freedreno] [PATCH v2 1/6] drm/msm/dpu: fix video mode DSC for DSI

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > Add necessary DPU changes for DSC to work with DSI video mode. > > Note this changes the logic to enable HCTL to match downstream, it will > now be enabled for the no-DSC no-widebus case. > > Signed-off-by: Jonathan Marek > --- > drivers/gp

[Freedreno] [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dipam Turkar
Make msm use drm_gem_create_map_offset() instead of its custom implementation for associating GEM object with a fake offset. Since, we already have this generic implementation, we don't need the custom implementation and it is better to standardize the code for GEM based drivers. This also removes

Re: [Freedreno] [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 16:30, Dipam Turkar wrote: > > Make msm use drm_gem_create_map_offset() instead of its custom > implementation for associating GEM object with a fake offset. Since, > we already have this generic implementation, we don't need the custom > implementation and it is better to s

Re: [Freedreno] [PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-15 Thread Marijn Suijten
On 2023-11-14 14:00:19, Jonathan Marek wrote: > On 11/14/23 1:28 PM, Marijn Suijten wrote: > > On what hardware have you been testing this? Dmitry and I have a stack of > > patches to resolve support for Active CTL programming on newer hardware (DPU > > 5.0+ IIRC), where a single CTL is responsibl

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: attach the DP subconnector property

2023-11-15 Thread Abhinav Kumar
On 11/15/2023 12:06 AM, Johan Hovold wrote: On Wed, Oct 25, 2023 at 12:23:10PM +0300, Dmitry Baryshkov wrote: While developing and testing the commit bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type") I had the patch [1] in my tree. I haven't noticed that it was a dependenc

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-11-15 Thread Abhinav Kumar
On 10/30/2023 4:23 PM, Bjorn Andersson wrote: During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to typically take 1-2ms to complete. As expected this results in poor performance, something that has been mitigated by proposing running the iommu in non-strict mode (boot with iom

Re: [Freedreno] [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dipam Turkar
They are not outdated, my bad. I went through the locks' code and saw that they have been updated. But they are probably not necessary here as most of the drivers do not use any form of locking in their implementations. The generic implementations drm_gem_dumb_map_offset() and drm_gem_ttm_dumb_map_

Re: [Freedreno] [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dipam Turkar
They are not outdated, my bad. I went through the locks' code and saw that they have been updated. But they are probably not necessary here as most of the drivers do not use any form of locking in their implementations. The generic implementations drm_gem_dumb_map_offset() and drm_gem_ttm_dumb_map_

Re: [Freedreno] [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > They are not outdated, my bad. I went through the locks' code and saw that > they have been updated. But they are probably not necessary here as most of > the drivers do not use any form of locking in their implementations. The > generic imp

[Freedreno] [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device

2023-11-15 Thread Rob Clark
From: Rob Clark The dpu devcore's are already associated with the dpu device. So we should associate the gpu devcore's with the gpu device, for easier classification. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Freedreno] [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device

2023-11-15 Thread Abhinav Kumar
On 11/15/2023 2:44 PM, Rob Clark wrote: From: Rob Clark The dpu devcore's are already associated with the dpu device. So we should associate the gpu devcore's with the gpu device, for easier classification. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar