Re: [Freedreno] [PATCH 08/15] drm/msm/dpu: Add SM6125 support

2023-06-26 Thread Konrad Dybcio
On 25.06.2023 22:19, Marijn Suijten wrote: > On 2023-06-24 03:47:27, Konrad Dybcio wrote: >> On 24.06.2023 02:41, Marijn Suijten wrote: >>> Add definitions for the display hardware used on the Qualcomm SM6125 >>> platform. >>> >>> Signed-off-by: Marijn Suijten >>> --- >> [...] >> >>> +static const

Re: [Freedreno] [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-06-26 Thread Konrad Dybcio
On 25.06.2023 21:18, Marijn Suijten wrote: > On 2023-06-24 03:42:46, Konrad Dybcio wrote: >> On 24.06.2023 02:40, Marijn Suijten wrote: >>> Bring up the SM6125 DPU now that all preliminary series (such as INTF >>> TE) have been merged (for me to test the hardware properly) >> We should not repeat t

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Konrad Dybcio
On 25.06.2023 21:48, Marijn Suijten wrote: > On 2023-06-24 03:45:02, Konrad Dybcio wrote: >> On 24.06.2023 02:41, Marijn Suijten wrote: >>> The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will >>> be passed from DT, and should be required by the bindings. >>> >>> Fixes: 8397c9c0c2

Re: [Freedreno] [PATCH 11/15] drm/msm/dsi: Add 14nm phy configuration for SM6125

2023-06-26 Thread Konrad Dybcio
On 25.06.2023 22:23, Marijn Suijten wrote: > On 2023-06-24 03:49:25, Konrad Dybcio wrote: >> On 24.06.2023 02:41, Marijn Suijten wrote: >>> SM6125 features only a single PHY (despite a secondary PHY PLL source >>> being available to the disp_cc_mdss_pclk0_clk_src clock), and downstream >>> sources

Re: [Freedreno] [PATCH v2 02/15] phy: qualcomm: add QMP HDMI PHY driver

2023-06-26 Thread Konrad Dybcio
On 25.06.2023 13:42, Dmitry Baryshkov wrote: > Port Qualcomm QMP HDMI PHY to the generic PHY framework. Split the > generic part and the msm8996 part. When adding support for msm8992/4 and > msm8998 (which also employ QMP for HDMI PHY), one will have to provide > the PLL programming part only. > >

Re: [Freedreno] [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

2023-06-26 Thread Marijn Suijten
On 2023-06-20 00:25:04, Dmitry Baryshkov wrote: > There is always a single MDP TOP block. Drop the mdp_count field and > stop declaring dpu_mdp_cfg instances as arrays. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h > b

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Dmitry Baryshkov
On 24/06/2023 03:41, Marijn Suijten wrote: SM6125 is identical to SM6375 except that while downstream also defines a throttle clock, its presence results in timeouts whereas SM6375 requires it to not observe any timeouts. I see that the vendor DTS still references this clock. Abhinav, Tanya, d

Re: [Freedreno] [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-06-26 Thread Marijn Suijten
On 2023-06-26 11:41:39, Konrad Dybcio wrote: > On 25.06.2023 21:18, Marijn Suijten wrote: > > On 2023-06-24 03:42:46, Konrad Dybcio wrote: > >> On 24.06.2023 02:40, Marijn Suijten wrote: > >>> Bring up the SM6125 DPU now that all preliminary series (such as INTF > >>> TE) have been merged (for me t

Re: [Freedreno] [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-06-26 Thread Konrad Dybcio
On 26.06.2023 16:17, Marijn Suijten wrote: > On 2023-06-26 11:41:39, Konrad Dybcio wrote: >> On 25.06.2023 21:18, Marijn Suijten wrote: >>> On 2023-06-24 03:42:46, Konrad Dybcio wrote: On 24.06.2023 02:40, Marijn Suijten wrote: > Bring up the SM6125 DPU now that all preliminary series (suc

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-26 11:43:39, Konrad Dybcio wrote: > On 25.06.2023 21:48, Marijn Suijten wrote: > > On 2023-06-24 03:45:02, Konrad Dybcio wrote: > >> On 24.06.2023 02:41, Marijn Suijten wrote: > >>> The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will > >>> be passed from DT, and should

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 25/06/2023 21:48, Marijn Suijten wrote: > On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: >> On 24/06/2023 03:45, Konrad Dybcio wrote: >>> On 24.06.2023 02:41, Marijn Suijten wrote: The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will be passed from DT, and should

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 26/06/2023 16:26, Marijn Suijten wrote: > On 2023-06-26 11:43:39, Konrad Dybcio wrote: >> On 25.06.2023 21:48, Marijn Suijten wrote: >>> On 2023-06-24 03:45:02, Konrad Dybcio wrote: On 24.06.2023 02:41, Marijn Suijten wrote: > The "gcc_disp_gpll0_div_clk_src" clock is consumed by the dr

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Krzysztof Kozlowski
On 25/06/2023 21:52, Marijn Suijten wrote: > On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: >> On 24/06/2023 02:41, Marijn Suijten wrote: >>> SM6125 is identical to SM6375 except that while downstream also defines >>> a throttle clock, its presence results in timeouts whereas SM6375 >>> require

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-26 18:15:13, Krzysztof Kozlowski wrote: > On 26/06/2023 16:26, Marijn Suijten wrote: > > On 2023-06-26 11:43:39, Konrad Dybcio wrote: > >> On 25.06.2023 21:48, Marijn Suijten wrote: > >>> On 2023-06-24 03:45:02, Konrad Dybcio wrote: > On 24.06.2023 02:41, Marijn Suijten wrote: > >>>

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-26 18:10:44, Krzysztof Kozlowski wrote: > On 25/06/2023 21:48, Marijn Suijten wrote: > > On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: > >> On 24/06/2023 03:45, Konrad Dybcio wrote: > >>> On 24.06.2023 02:41, Marijn Suijten wrote: > The "gcc_disp_gpll0_div_clk_src" clock is con

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Marijn Suijten
On 2023-06-26 18:16:58, Krzysztof Kozlowski wrote: > On 25/06/2023 21:52, Marijn Suijten wrote: > > On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: > >> On 24/06/2023 02:41, Marijn Suijten wrote: > >>> SM6125 is identical to SM6375 except that while downstream also defines > >>> a throttle clock

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 26/06/2023 19:49, Marijn Suijten wrote: > On 2023-06-26 18:10:44, Krzysztof Kozlowski wrote: >> On 25/06/2023 21:48, Marijn Suijten wrote: >>> On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: On 24/06/2023 03:45, Konrad Dybcio wrote: > On 24.06.2023 02:41, Marijn Suijten wrote: >>

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-26 20:29:37, Krzysztof Kozlowski wrote: > On 26/06/2023 19:49, Marijn Suijten wrote: > > On 2023-06-26 18:10:44, Krzysztof Kozlowski wrote: > >> On 25/06/2023 21:48, Marijn Suijten wrote: > >>> On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: > On 24/06/2023 03:45, Konrad Dybcio w

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-26 20:51:38, Marijn Suijten wrote: > > Not really, binding also defines the list of clocks - their order and > > specific entries. This changes. > > And so it does in "dt-bindings: clock: qcom,dispcc-sm6125: Remove unused > GCC_DISP_AHB_CLK"? Never mind: it is the last item so the ord

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Konrad Dybcio
On 26.06.2023 19:54, Marijn Suijten wrote: > On 2023-06-26 18:16:58, Krzysztof Kozlowski wrote: >> On 25/06/2023 21:52, Marijn Suijten wrote: >>> On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: On 24/06/2023 02:41, Marijn Suijten wrote: > SM6125 is identical to SM6375 except that while

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Marijn Suijten
On 2023-06-26 20:57:51, Konrad Dybcio wrote: > On 26.06.2023 19:54, Marijn Suijten wrote: > > On 2023-06-26 18:16:58, Krzysztof Kozlowski wrote: > >> On 25/06/2023 21:52, Marijn Suijten wrote: > >>> On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: > On 24/06/2023 02:41, Marijn Suijten wrote:

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Konrad Dybcio
On 26.06.2023 22:28, Marijn Suijten wrote: > On 2023-06-26 20:57:51, Konrad Dybcio wrote: >> On 26.06.2023 19:54, Marijn Suijten wrote: >>> On 2023-06-26 18:16:58, Krzysztof Kozlowski wrote: On 25/06/2023 21:52, Marijn Suijten wrote: > On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: >>>

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Jessica Zhang
On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL, memory fetch will be disabled. Thinking

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Dmitry Baryshkov
On 27/06/2023 02:02, Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL,

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Jessica Zhang
On 6/26/2023 5:06 PM, Dmitry Baryshkov wrote: On 27/06/2023 02:02, Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Dmitry Baryshkov
On Tue, 27 Jun 2023 at 03:45, Jessica Zhang wrote: > > > > On 6/26/2023 5:06 PM, Dmitry Baryshkov wrote: > > On 27/06/2023 02:02, Jessica Zhang wrote: > >> > >> > >> On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > >>> On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > Introduce an

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 26/06/2023 20:53, Marijn Suijten wrote: > On 2023-06-26 20:51:38, Marijn Suijten wrote: > >>> Not really, binding also defines the list of clocks - their order and >>> specific entries. This changes. >> >> And so it does in "dt-bindings: clock: qcom,dispcc-sm6125: Remove unused >> GCC_DISP_AHB_

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Marijn Suijten
On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: > On 26/06/2023 20:53, Marijn Suijten wrote: > > On 2023-06-26 20:51:38, Marijn Suijten wrote: > > > >>> Not really, binding also defines the list of clocks - their order and > >>> specific entries. This changes. > >> > >> And so it does in "dt-bi