Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Dmitry Baryshkov
On Fri, 26 May 2023 at 01:42, Abhinav Kumar wrote: > On 5/25/2023 3:30 PM, Dmitry Baryshkov wrote: > > On Fri, 26 May 2023 at 00:40, Jeykumar Sankaran > > wrote: > >> On 5/22/2023 2:45 PM, Dmitry Baryshkov wrote: > >>> There is no point in having a single enum (and a single array) for both > >>>

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Neil Armstrong
On 22/05/2023 23:45, Dmitry Baryshkov wrote: There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_7_0_sm8

[Freedreno] [PATCH] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-05-26 Thread Dmitry Baryshkov
Currently the driver passes the PINGPONG index to dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean flag to tell whether INTF should be bound or unbound. Simplify this by passing PINGPONG_NONE in case of unbinding and drop the flag completely. Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH 2/4] drm/msm: add hdmi cec support

2023-05-26 Thread Hans Verkuil
Hi Arnaud, My apologies for the long delay in replying, it's been very, very busy lately. I hope I'll be able to be more responsive going forward. On 21/04/2023 18:58, Arnaud Vrac wrote: > Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit > : >> >> Hi Arnaud, >> >> Some review comments below..

[Freedreno] [PATCH v2] drm/msm/dpu: clean up dpu_kms_get_clk_rate() returns

2023-05-26 Thread Dan Carpenter
Static analysis tools complain about the -EINVAL error code being stored in an unsigned variable. Let's change this to match the clk_get_rate() function which is type unsigned long and returns zero on error. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dan Carpenter ---

Re: [Freedreno] [v4, 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:57 schrieb Sui Jingfeng: Hi, we love your patch: On 2023/5/24 17:21, Thomas Zimmermann wrote: For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback function

Re: [Freedreno] [v4, 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:23 schrieb Sui Jingfeng: Tested-by: Sui Jingfeng This version works fine, I have tested it On LoongArch with drm/loongson(v14) as it is most handy for me. Also because it using fbdev-generic. fbdev of IGT report no error. Then I run fbtest from geert[1], Before app

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Abhinav Kumar
On 5/26/2023 1:43 AM, Dmitry Baryshkov wrote: On Fri, 26 May 2023 at 01:42, Abhinav Kumar wrote: On 5/25/2023 3:30 PM, Dmitry Baryshkov wrote: On Fri, 26 May 2023 at 00:40, Jeykumar Sankaran wrote: On 5/22/2023 2:45 PM, Dmitry Baryshkov wrote: There is no point in having a single enum (a

Re: [Freedreno] (subset) [PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

2023-05-26 Thread Bjorn Andersson
On Sun, 7 May 2023 22:07:31 +0300, Dmitry Baryshkov wrote: > Enable GPU, DSI panel and remoteprocs on the APQ8074 dragonboard device. > > Dmitry Baryshkov (4): > ARM: dts: qcom: msm8974: add ocmem clock to GPU > ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled > ARM: dts: