Re: [Freedreno] [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-05-14 Thread Dmitry Baryshkov
On Sat, 13 May 2023 at 01:12, Abhinav Kumar wrote: > > > > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: > > Take into account the plane rotation and flipping when calculating src > > positions for the wide plane parts. > > > > Signed-off-by: Dmitry Baryshkov > > Do we need to have a fixes tag fo

Re: [Freedreno] [RFC PATCH v2 03/13] drm/msm/dpu: encoder: simplify debugfs handling

2023-05-14 Thread Dmitry Baryshkov
On Sat, 13 May 2023 at 01:18, Abhinav Kumar wrote: > > > > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: > > As the debugfs is fully cleared on drm device removal, drop the > > encoder-specific cleanup function, remove debugfs_root from dpu_encoder > > struct and also remove phys_encoder late_regi

Re: [Freedreno] [RFC PATCH v2 05/13] drm/msm/dpu: get rid of struct dpu_rm_requirements

2023-05-14 Thread Dmitry Baryshkov
On Sat, 13 May 2023 at 01:39, Abhinav Kumar wrote: > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: > > The struct dpu_rm_requirements was used to wrap display topology and > > hw resources, which meant INTF indices. As of commit ef58e0ad3436 > > ("drm/msm/dpu: get INTF blocks directly rather than

Re: [Freedreno] [PATCH v10 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-14 Thread Marijn Suijten
On 2023-05-12 14:32:12, Jessica Zhang wrote: > > From: Dmitry Baryshkov > > Add a helper setting config values which are typically constant across > operating modes (table E-4 of the standard) and mux_word_size (which is > a const according to 3.5.2). > > Signed-off-by: Dmitry Baryshkov > Revi

Re: [Freedreno] [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-14 Thread Marijn Suijten
On 2023-05-12 14:32:14, Jessica Zhang wrote: > > Introduce MSM-specific DSC helper methods, as some calculations are > common between DP and DSC. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/msm_dsc_helper.h | 65 > > 1 file changed, 65 inse

Re: [Freedreno] [PATCH v10 7/8] drm/msm/dsi: Use MSM and DRM DSC helper methods

2023-05-14 Thread Marijn Suijten
On 2023-05-12 14:32:17, Jessica Zhang wrote: > > Use MSM and DRM DSC helper methods to configure DSC for DSI. > > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Marijn Suijten > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 7 --- > 1 file changed, 4 insertions(+

Re: [Freedreno] [PATCH v10 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-14 Thread Marijn Suijten
On 2023-05-12 14:32:18, Jessica Zhang wrote: > > hdisplay for compressed images should be calculated as bytes_per_slice * > slice_count. Thus, use MSM DSC helper to calculate hdisplay for > dsi_timing_setup instead of directly using mode->hdisplay. As mentioned in review on an earlier revision, i

Re: [Freedreno] [PATCH v8 0/8] add DSC 1.2 dpu supports

2023-05-14 Thread Marijn Suijten
Asked this before: change the title to "DPU support" (capital "DPU", singular "support") if this series keeps being resent. On 2023-05-12 11:00:15, Kuogee Hsieh wrote: > > This series adds the DPU side changes to support DSC 1.2 encoder. This > was validated with both DSI DSC 1.2 panel and DP DSC

Re: [Freedreno] [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-14 Thread Marijn Suijten
DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while the series is clearly aimed at 1.1...). This was done for the DSC 1.2 HW block patch after all. in catalog -> to catalog But it's just two platforms, you can fit MSM8998 and SC8180X in the title. On 2023-05-12 11:00:16, Ku

Re: [Freedreno] [PATCH v8 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-14 Thread Marijn Suijten
Fix the title: "Require DPU_PINGPONG_DSC bit for DSC ops on PINGPONG block" Or: "Only enable PINGPONG DSC ops with DPU_PINGPONG_DSC bit" Or (my preference): "Guard PINGPONG DSC ops behind DPU_PINGPONG_DSC bit" On 2023-05-12 11:00:18, Kuogee Hsieh wrote: > > DPU < 7.0.0 has DPU_PINGPONG_DSC featur

Re: [Freedreno] [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-14 Thread Marijn Suijten
On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: > +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc > > *hw_dsc, > > + const enum dpu_pingpong pp) > > +{ > > + struct dpu_hw_blk_reg_map *hw; > > + const struct dpu_dsc_sub_blks

Re: [Freedreno] [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-14 Thread Marijn Suijten
On 2023-05-12 11:00:20, Kuogee Hsieh wrote: > > Add support for DSC 1.2 by providing the necessary hooks to program > the DPU DSC 1.2 encoder. > > Changes in v3: > -- fixed kernel test rebot report that "__iomem *off" is declared but not >used at dpu_hw_dsc_config_1_2() > -- unrolling thresh

[Freedreno] [PATCH 2/3] drm/msm/dp: Clean up logs dp_power module

2023-05-14 Thread Bjorn Andersson
The clk_bulk API already provides error messages indicating which specific clock in the request for which the operation failed, further more these errors are associated with the specific DisplayPort controller (rather than the shared drm_device). The additional error messages int he dp_power module

[Freedreno] [PATCH 3/3] drm/msm/dp: Clean up pdev/dev duplication in dp_power

2023-05-14 Thread Bjorn Andersson
The dp_power module keeps track of both the DP controller's struct platform_device and struct device - with the prior pulled out of the dp_parser module. Clean up the duplication by dropping the platform_device reference and just track the passed struct device. Signed-off-by: Bjorn Andersson ---

[Freedreno] [PATCH 1/3] drm/msm/dp: Drop now unused dp_hpd module

2023-05-14 Thread Bjorn Andersson
The dp_hpd module is a remnant from the downstream design and is now completely unused. Drop it and all references to it. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_debug.c | 8 ++- drivers/gpu/drm/msm/dp/dp_debug.h | 12 ++--- drivers/gpu/drm/msm/dp/dp_display.c | 35 +---