Re: [Freedreno] [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-09 Thread Marijn Suijten
On 2023-05-09 02:08:52, Dmitry Baryshkov wrote: > On 09/05/2023 00:46, Jessica Zhang wrote: > > > > > > On 5/7/2023 9:00 AM, Marijn Suijten wrote: > >> On 2023-05-05 14:23:50, Jessica Zhang wrote: > >>> Add DATA_COMPRESS feature flag to DPU INTF block. > >>> > >>> In DPU 7.x and later, DSC/DCE en

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 01:27, Dmitry Baryshkov wrote: > On 08/05/2023 23:09, Abhinav Kumar wrote: >> >> >> On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: >>> On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice

Re: [Freedreno] [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 01:38, Dmitry Baryshkov wrote: > On Mon, 8 May 2023 at 21:01, Dmitry Baryshkov > wrote: >> >> On 08/05/2023 13:49, Dmitry Baryshkov wrote: >>> On 08/05/2023 13:38, Konrad Dybcio wrote: On 8.05.2023 12:33, Dmitry Baryshkov wrote: > On 08/05/2023 11:33, Konrad Dybc

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Neil Armstrong
On 09/05/2023 01:27, Dmitry Baryshkov wrote: On 08/05/2023 23:09, Abhinav Kumar wrote: On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice per packet, which is

Re: [Freedreno] [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-09 Thread Konrad Dybcio
On 8.05.2023 23:15, Akhil P Oommen wrote: > On Mon, May 08, 2023 at 10:59:24AM +0200, Konrad Dybcio wrote: >> >> >> On 6.05.2023 16:46, Akhil P Oommen wrote: >>> On Fri, May 05, 2023 at 12:35:18PM +0200, Konrad Dybcio wrote: On 5.05.2023 10:46, Akhil P Oommen wrote: > On Thu,

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Konrad Dybcio
On 9.05.2023 10:23, Neil Armstrong wrote: > On 09/05/2023 01:27, Dmitry Baryshkov wrote: >> On 08/05/2023 23:09, Abhinav Kumar wrote: >>> >>> >>> On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: > Currently, word count is calculated using slice_coun

Re: [Freedreno] [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-09 Thread Dmitry Baryshkov
On Tue, 9 May 2023 at 10:00, Marijn Suijten wrote: > > On 2023-05-09 02:08:52, Dmitry Baryshkov wrote: > > On 09/05/2023 00:46, Jessica Zhang wrote: > > > > > > > > > On 5/7/2023 9:00 AM, Marijn Suijten wrote: > > >> On 2023-05-05 14:23:50, Jessica Zhang wrote: > > >>> Add DATA_COMPRESS feature fl

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Dmitry Baryshkov
On 09/05/2023 11:54, Konrad Dybcio wrote: On 9.05.2023 10:23, Neil Armstrong wrote: On 09/05/2023 01:27, Dmitry Baryshkov wrote: On 08/05/2023 23:09, Abhinav Kumar wrote: On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calcu

[Freedreno] [PATCH 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-09 Thread Rob Clark
From: Rob Clark When the special handling of qcom,adreno-smmu was moved into qcom_smmu_create(), it was overlooked that we didn't have all the required entries in qcom_smmu_impl_of_match. So we stopped getting adreno_smmu_priv on sc7180, breaking per-process pgtables. Fixes: 30b912a03d91 ("iomm

[Freedreno] [PATCH 2/2] drm/msm: Be more shouty if per-process pgtables aren't working

2023-05-09 Thread Rob Clark
From: Rob Clark Otherwise it is not always obvious if a dt or iommu change is causing us to fall back to global pgtable. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_iommu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/driv

[Freedreno] [PATCH v3] drm/msm: Fix submit error-path leaks

2023-05-09 Thread Rob Clark
From: Rob Clark For errors after msm_submitqueue_get(), we need to drop the submitqueue reference. Additionally after get_unused_fd() we need to drop the fd. The ordering for dropping the queue lock and put_unused_fd() is not important, so just move this all into out_post_unlock. v2: Only drop

Re: [Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-09 Thread Krzysztof Kozlowski
On 08/05/2023 04:56, Laurent Pinchart wrote: > Hi Rob, > > On Sun, May 07, 2023 at 04:25:44PM -0500, Rob Herring wrote: >> On Sun, 07 May 2023 23:12:16 +0300, Dmitry Baryshkov wrote: >>> Follow the dp-connector example and add hdmi-pwr supply to drive the 5V >>> pin of the HDMI connector (together

Re: [Freedreno] [PATCH 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-09 Thread Krzysztof Kozlowski
On 07/05/2023 22:12, Dmitry Baryshkov wrote: > Follow the dp-connector example and add hdmi-pwr supply to drive the 5V > pin of the HDMI connector (together with some simple glue logic possibly > attached to the connector). > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Abhinav Kumar
On 5/9/2023 4:42 AM, Dmitry Baryshkov wrote: On 09/05/2023 11:54, Konrad Dybcio wrote: On 9.05.2023 10:23, Neil Armstrong wrote: On 09/05/2023 01:27, Dmitry Baryshkov wrote: On 08/05/2023 23:09, Abhinav Kumar wrote: On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jes

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-09 Thread Abhinav Kumar
On 5/8/2023 4:30 AM, Dmitry Baryshkov wrote: On 08/05/2023 14:02, Leonard Lausen wrote: Abhinav Kumar writes: On 5/7/2023 7:15 PM, Bjorn Andersson wrote: When booting with the cable connected on my X13s, 100 is long enough for my display to time out and require me to disconnect and reconn

Re: [Freedreno] [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-09 Thread Jessica Zhang
On 5/9/2023 11:02 AM, Abhinav Kumar wrote: On 5/9/2023 4:42 AM, Dmitry Baryshkov wrote: On 09/05/2023 11:54, Konrad Dybcio wrote: On 9.05.2023 10:23, Neil Armstrong wrote: On 09/05/2023 01:27, Dmitry Baryshkov wrote: On 08/05/2023 23:09, Abhinav Kumar wrote: On 5/3/2023 1:26 AM, Dmi

[Freedreno] [PATCH v4] drm/msm: Fix submit error-path leaks

2023-05-09 Thread Rob Clark
From: Rob Clark For errors after msm_submitqueue_get(), we need to drop the submitqueue reference. Additionally after get_unused_fd() we need to drop the fd. The ordering for dropping the queue lock and put_unused_fd() is not important, so just move this all into out_post_unlock. v2: Only drop

[Freedreno] [PATCH v7 1/8] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-09 Thread Jessica Zhang
Add helpers to calculate det_thresh_flatness and initial_scale_value as these calculations are defined within the DSC spec. Signed-off-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- include/drm/display/drm_dsc_helper.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/incl

[Freedreno] [PATCH v7 0/8] Introduce MSM-specific DSC helpers

2023-05-09 Thread Jessica Zhang
There are some overlap in calculations for MSM-specific DSC variables between DP and DSI. In addition, the calculations for initial_scale_value and det_thresh_flatness that are defined within the DSC 1.2 specifications, but aren't yet included in drm_dsc_helper.c. This series moves these calculati

[Freedreno] [PATCH v7 3/8] drm/msm/dsi: use DRM DSC helpers for DSC setup

2023-05-09 Thread Jessica Zhang
From: Dmitry Baryshkov Use new DRM DSC helpers to setup DSI DSC configuration. The initial_scale_value needs to be adjusted according to the standard, but this is a separate change. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/ms

[Freedreno] [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-09 Thread Jessica Zhang
Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/msm_dsc_helper.c | 26 ++ drivers/gpu/drm/msm/msm_dsc_helper

[Freedreno] [PATCH v7 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-09 Thread Jessica Zhang
hdisplay for compressed images should be calculated as bytes_per_slice * slice_count. Thus, use MSM DSC helper to calculate hdisplay for dsi_timing_setup instead of directly using mode->hdisplay. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c |

[Freedreno] [PATCH v7 6/8] drm/msm/dpu: Fix slice_last_group_size calculation

2023-05-09 Thread Jessica Zhang
Correct the math for slice_last_group_size so that it matches the calculations downstream. Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 5 ++

[Freedreno] [PATCH v7 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-09 Thread Jessica Zhang
From: Dmitry Baryshkov Add a helper setting config values which are typically constant across operating modes (table E-4 of the standard) and mux_word_size (which is a const according to 3.5.2). Signed-off-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/display/drm_dsc_h

[Freedreno] [PATCH v7 7/8] drm/msm/dsi: Use MSM and DRM DSC helper methods

2023-05-09 Thread Jessica Zhang
Use MSM and DRM DSC helper methods to configure DSC for DSI. Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi

[Freedreno] [PATCH v7 5/8] drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness

2023-05-09 Thread Jessica Zhang
The current dpu_hw_dsc calculation for det_thresh_flatness does not match the downstream calculation or the DSC spec. Use the DRM DSC helper for det_thresh_flatness to match downstream implementation and the DSC spec. Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by: Dmi

Re: [Freedreno] [PATCH v7 1/8] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-09 Thread Marijn Suijten
On 2023-05-09 15:06:47, Jessica Zhang wrote: > Add helpers to calculate det_thresh_flatness and initial_scale_value as > these calculations are defined within the DSC spec. > > Signed-off-by: Dmitry Baryshkov > Signed-off-by: Jessica Zhang This ordering is odd: Jessica originally sent the patch

Re: [Freedreno] [PATCH v7 7/8] drm/msm/dsi: Use MSM and DRM DSC helper methods

2023-05-09 Thread Marijn Suijten
On 2023-05-09 15:06:53, Jessica Zhang wrote: > Use MSM and DRM DSC helper methods to configure DSC for DSI. > > Signed-off-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git

Re: [Freedreno] [PATCH v7 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-09 Thread Marijn Suijten
On 2023-05-09 15:06:54, Jessica Zhang wrote: > hdisplay for compressed images should be calculated as bytes_per_slice * > slice_count. Thus, use MSM DSC helper to calculate hdisplay for For most intents and purposes, these values are the same when bits_per_pixel=8. We should find a place where we

Re: [Freedreno] [PATCH v7 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-09 Thread Marijn Suijten
On 2023-05-09 15:06:48, Jessica Zhang wrote: > From: Dmitry Baryshkov > > Add a helper setting config values which are typically constant across > operating modes (table E-4 of the standard) and mux_word_size (which is > a const according to 3.5.2). > > Signed-off-by: Dmitry Baryshkov > Signed-

Re: [Freedreno] [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-09 Thread Marijn Suijten
On 2023-05-09 15:06:50, Jessica Zhang wrote: > Introduce MSM-specific DSC helper methods, as some calculations are > common between DP and DSC. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/msm_dsc_hel

Re: [Freedreno] [PATCH v7 5/8] drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness

2023-05-09 Thread Marijn Suijten
Title suggestion: Use **fixed** MSM DSC helper... To make it clear that this is a bugfix without having to read the commit description first. - Marijn On 2023-05-09 15:06:51, Jessica Zhang wrote: > The current dpu_hw_dsc calculation for det_thresh_flatness does not > match the downstream calcula