Re: [Freedreno] [PATCH 07/11] drm/msm/dpu: add sspp cursor blocks to msm8998 hw catalog

2023-04-20 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 01:10, Dmitry Baryshkov a écrit : > > On 19/04/2023 17:41, Arnaud Vrac wrote: > > Now that cursor sspp blocks can be used for cursor planes, enable them > > on msm8998. The dma sspp blocks that were assigned to cursor planes can > > now be used for overlay planes instead. >

Re: [Freedreno] [PATCH 11/11] drm/msm/dpu: do not use mixer that supports dspp when not required

2023-04-20 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 01:18, Dmitry Baryshkov a écrit : > > On 19/04/2023 17:41, Arnaud Vrac wrote: > > This avoids using lm blocks that support DSPP when not needed, to > > keep those resources available. > > This will break some of the platforms. Consider qcm2290 which has a > single LM with DS

Re: [Freedreno] [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-20 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 02:20, Dmitry Baryshkov a écrit : > > On 18/04/2023 21:10, Arnaud Vrac wrote: > > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > > and MSM8998. The hardware block can handle a single CEC logical address > > and broadcast messages. > > > > Port the

Re: [Freedreno] [PATCH 04/11] drm/msm/dpu: allow using lm mixer base stage

2023-04-20 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 00:43, Dmitry Baryshkov a écrit : > > On 19/04/2023 17:41, Arnaud Vrac wrote: > > The dpu backend already handles applying alpha to the base stage, so we > > can use it to render the bottom plane in all cases. This allows mixing > > one additional plane with the hardware mix

Re: [Freedreno] [PATCH v10 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-04-20 Thread kernel test robot
16 (https://download.01.org/0day-ci/archive/20230420/202304201512.cllnzi0u-...@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/

Re: [Freedreno] [PATCH 07/11] drm/msm/dpu: add sspp cursor blocks to msm8998 hw catalog

2023-04-20 Thread Dmitry Baryshkov
On Thu, 20 Apr 2023 at 10:06, Arnaud Vrac wrote: > > Le jeu. 20 avr. 2023 à 01:10, Dmitry Baryshkov > a écrit : > > > > On 19/04/2023 17:41, Arnaud Vrac wrote: > > > Now that cursor sspp blocks can be used for cursor planes, enable them > > > on msm8998. The dma sspp blocks that were assigned to

Re: [Freedreno] [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-20 Thread Dmitry Baryshkov
On Thu, 20 Apr 2023 at 10:24, Arnaud Vrac wrote: > > Le jeu. 20 avr. 2023 à 02:20, Dmitry Baryshkov > a écrit : > > > > On 18/04/2023 21:10, Arnaud Vrac wrote: > > > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > > > and MSM8998. The hardware block can handle a single

Re: [Freedreno] [PATCH 04/11] drm/msm/dpu: allow using lm mixer base stage

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 10:26, Arnaud Vrac wrote: Le jeu. 20 avr. 2023 à 00:43, Dmitry Baryshkov a écrit : On 19/04/2023 17:41, Arnaud Vrac wrote: The dpu backend already handles applying alpha to the base stage, so we can use it to render the bottom plane in all cases. This allows mixing one additiona

Re: [Freedreno] [PATCH v10 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-04-20 Thread kernel test robot
16 (https://download.01.org/0day-ci/archive/20230420/202304201909.d57x63j5-...@intel.com/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu1: Rename sm8150_dspp_blk to sdm845_dspp_blk

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 04:14, Konrad Dybcio wrote: SDM845 was the first SoC to include both PCC v4 and GC v1.8. We don't currently support any other blocks but the common config for these two can be reused for a large amount of SoCs. Rename it to indicate the origin of that combo. Signed-off-by: Konrad

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu1: Rename sm8150_dspp_blk to sdm845_dspp_blk

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 04:14, Konrad Dybcio wrote: SDM845 was the first SoC to include both PCC v4 and GC v1.8. We don't currently support any other blocks but the common config for these two can be reused for a large amount of SoCs. Rename it to indicate the origin of that combo. Signed-off-by: Konrad

Re: [Freedreno] [PATCH] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-20 Thread Dmitry Baryshkov
On 11/04/2023 17:31, Jianhua Lu wrote: This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Signed-off-by: Jianhua Lu --- .../bindings/display/msm/dsi-controller-main.yaml| 12 ++

Re: [Freedreno] [PATCH v4 2/6] drm/msm: Switch to fdinfo helper

2023-04-20 Thread Dmitry Baryshkov
On 13/04/2023 01:42, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 11 +-- drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Dmitry Baryshkov
On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send the wrong patch as the improvements from v2 are missing? However,

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-20 Thread Dmitry Baryshkov
On 18/04/2023 02:14, Marijn Suijten wrote: The WB debug log mask ended up never being assigned, leading to writes to this block to never be logged even if the mask is enabled in dpu_hw_util_log_mask via sysfs. Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") S

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Dmitry Baryshkov
On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all. Drop them to save some space, and above all confusion when looking at these members. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: Pass catalog pointers directly from RM instead of IDs

2023-04-20 Thread Dmitry Baryshkov
On 18/04/2023 02:14, Marijn Suijten wrote: The Resource Manager already iterates over all available blocks from the catalog, only to pass their ID to a dpu_hw_xxx_init() function which uses an _xxx_offset() helper to search for and find the exact same catalog pointer again to initialize the block

Re: [Freedreno] [PATCH] drm/msm/atomic: Don't try async if crtc not active

2023-04-20 Thread Dmitry Baryshkov
On 18/04/2023 19:41, Rob Clark wrote: From: Rob Clark For a similar reason as commit f2c7ca890182 ("drm/atomic-helper: Don't set deadline for modesets"), we need the crtc to be already active in order to compute a target vblank time for an async commit. Otherwise we get this splat reminding us

Re: [Freedreno] [PATCH] drm/msm/atomic: Don't try async if crtc not active

2023-04-20 Thread Abhinav Kumar
On 4/18/2023 9:41 AM, Rob Clark wrote: From: Rob Clark For a similar reason as commit f2c7ca890182 ("drm/atomic-helper: Don't set deadline for modesets"), we need the crtc to be already active in order to compute a target vblank time for an async commit. Otherwise we get this splat remindin

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Abhinav Kumar
On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all.  Drop them to save some space, and above all confusion when looking at these members. Fixes:

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Abhinav Kumar
Hi Dmitry / Marijn On 4/20/2023 7:03 AM, Dmitry Baryshkov wrote: On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 19:40, Abhinav Kumar wrote: Hi Dmitry / Marijn On 4/20/2023 7:03 AM, Dmitry Baryshkov wrote: On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentenc

Re: [Freedreno] [PATCH 02/11] drm/msm/dpu: use the actual lm maximum width instead of a hardcoded value

2023-04-20 Thread Jeykumar Sankaran
On 4/19/2023 3:23 PM, Dmitry Baryshkov wrote: On 19/04/2023 17:41, Arnaud Vrac wrote: This avoids using two LMs instead of one when the display width is lower than the maximum supported value. For example on MSM8996/MSM8998, the actual maxwidth is 2560, so we would use two LMs for 1280x720 or

Re: [Freedreno] [PATCH 03/11] drm/msm/dpu: use hsync/vsync polarity set by the encoder

2023-04-20 Thread Jeykumar Sankaran
On 4/19/2023 7:41 AM, Arnaud Vrac wrote: Do not override the hsync/vsync polarity passed by the encoder when setting up intf timings. The same logic was used in both the encoder and intf code to set the DP and DSI polarities, so those interfaces are not impacted. However for HDMI, the polariti

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM, Konrad Dybcio wrote: On 20.04.2023 03:25, Dmitry Baryshkov wrote: On 20/04/2023 04:14, Konrad Dybcio wrote: Almost all SoCs from SDM845 to SM8550 inclusive feature a GC1.8 dspp sub-

Re: [Freedreno] [PATCH 03/11] drm/msm/dpu: use hsync/vsync polarity set by the encoder

2023-04-20 Thread Dmitry Baryshkov
On Thu, 20 Apr 2023 at 21:01, Jeykumar Sankaran wrote: > > > > On 4/19/2023 7:41 AM, Arnaud Vrac wrote: > > Do not override the hsync/vsync polarity passed by the encoder when > > setting up intf timings. The same logic was used in both the encoder and > > intf code to set the DP and DSI polaritie

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Abhinav Kumar
On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM, Konrad Dybcio wrote: On 20.04.2023 03:25, Dmitry Baryshkov wrote: On 20/04/2023 04:14, Konrad Dybcio wrote: Almost all SoCs from S

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Marijn Suijten
On 2023-04-20 21:01:04, Dmitry Baryshkov wrote: > On 20/04/2023 04:36, Konrad Dybcio wrote: > > > > > > On 20.04.2023 03:28, Abhinav Kumar wrote: > >> > >> > >> On 4/19/2023 6:26 PM, Konrad Dybcio wrote: > >>> > >>> > >>> On 20.04.2023 03:25, Dmitry Baryshkov wrote: > On 20/04/2023 04:14, Ko

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM, Konrad Dybcio wrote: On 20.04.2023 03:25, Dmitry Baryshkov wrote: On 20/04/2023 04:14, Ko

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Abhinav Kumar
On 4/20/2023 12:51 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM, Konrad Dybcio wrote: On 20.04.2023 03:2

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Marijn Suijten
On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: > On 20/04/2023 22:47, Abhinav Kumar wrote: > > > > > > On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: > >> On 20/04/2023 04:36, Konrad Dybcio wrote: > >>> > >>> > >>> On 20.04.2023 03:28, Abhinav Kumar wrote: > > > On 4/19/2023 6:26

[Freedreno] [PATCH] drm/msm/dpu: drop the regdma configuration

2023-04-20 Thread Dmitry Baryshkov
The regdma is currently not used by the current driver. We have no way to practically verify that the regdma is described correctly. Drop it now. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 2 - .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 2 - .../ms

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 22:53, Abhinav Kumar wrote: On 4/20/2023 12:51 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM,

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Marijn Suijten
On 2023-04-20 08:46:46, Abhinav Kumar wrote: > > > On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: > > On 18/04/2023 02:14, Marijn Suijten wrote: > >> Some of these members were initialized while never read, while others > >> were not even assigned any value at all.  Drop them to save some space, >

Re: [Freedreno] [PATCH v2 07/17] drm/msm/dpu: Sort INTF registers numerically

2023-04-20 Thread Marijn Suijten
On 2023-04-20 03:47:57, Dmitry Baryshkov wrote: > On 17/04/2023 23:21, Marijn Suijten wrote: > > A bunch of registers were appended at the end in e.g. 91143873a05d > > ("drm/msm/dpu: Add MISR register support for interface") rather than > > being inserted in a place that maintains numerical sorting

Re: [Freedreno] [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-20 Thread Marijn Suijten
On 2023-04-20 04:03:31, Dmitry Baryshkov wrote: [..] > >>>   -static void dpu_hw_setup_vsync_source(struct dpu_hw_mdp *mdp, > >>> +static void dpu_hw_setup_vsync_source_v1(struct dpu_hw_mdp *mdp, > >>>   struct dpu_vsync_source_cfg *cfg) > >> > >> In my opinion _v1 is not really descripti

Re: [Freedreno] [PATCH v2 14/17] drm/msm/dpu: Document and enable TEAR interrupts on DSI interfaces

2023-04-20 Thread Marijn Suijten
On 2023-04-20 04:11:29, Dmitry Baryshkov wrote: > On 17/04/2023 23:21, Marijn Suijten wrote: > > All SoCs since DPU 5.0.0 have the tear interrupt registers moved out of > > the PINGPONG block and into the INTF block. Wire up these interrupts > > and IRQ masks on all supported hardware. > > > > Si

Re: [Freedreno] [PATCH] drm/msm/dpu: drop the regdma configuration

2023-04-20 Thread Marijn Suijten
Whoops, looks like I wrongly lost all the cc's when importing b4-am's mbx file which is just a patch with a few but not all email headers. Cc'ing everyone on this occasion with my review. On 2023-04-20 23:33:07, Marijn Suijten wrote: > On 2023-04-20 23:07:42, Dmitry Baryshkov wrote: > > The regdma

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 00:39, Marijn Suijten wrote: On 2023-04-20 08:46:46, Abhinav Kumar wrote: On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all.  Dro

[Freedreno] [PATCH v2 1/2] drm/msm/dpu: drop the regdma configuration

2023-04-20 Thread Dmitry Baryshkov
The regdma is currently not used by the current driver. We have no way to practically verify that the regdma is described correctly. Drop it now. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 1 - .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 2 - .../ms

[Freedreno] [PATCH v2 2/2] drm/msm/dpu: stop mapping the regdma region

2023-04-20 Thread Dmitry Baryshkov
Stop mapping the regdma region. The driver does not support regdma. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/

Re: [Freedreno] [PATCH] drm/msm/dpu: drop the regdma configuration

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:01, Marijn Suijten wrote: Whoops, looks like I wrongly lost all the cc's when importing b4-am's mbx file which is just a patch with a few but not all email headers. Cc'ing everyone on this occasion with my review. On 2023-04-20 23:33:07, Marijn Suijten wrote: On 2023-04-20 23:0

Re: [Freedreno] [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 00:51, Marijn Suijten wrote: On 2023-04-20 04:03:31, Dmitry Baryshkov wrote: [..]   -static void dpu_hw_setup_vsync_source(struct dpu_hw_mdp *mdp, +static void dpu_hw_setup_vsync_source_v1(struct dpu_hw_mdp *mdp,   struct dpu_vsync_source_cfg *cfg) In my opinion _v1 i

[Freedreno] [PATCH v2 01/13] dt-bindings: display/msm: dsi-controller-main: Add SM6350

2023-04-20 Thread Konrad Dybcio
Add the DSI host found on SM6350. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Docume

[Freedreno] [PATCH v2 00/13] SM63(50|75) DPU support

2023-04-20 Thread Konrad Dybcio
v1 -> v2: - Rebase on the DPU catalog rework and INTF_TE - Fix QSEED(3L/4) discrepancies - Fixed DMA/cursor discrepancies for 6350 - No deduplication, that's gonna be handled in catalogrework 2: "the return of the catalogrework" - Split MDSS & DPU binding additions - Drop "Allow variable SSPP/INT

[Freedreno] [PATCH v2 04/13] dt-bindings: display/msm: Add SM6350 MDSS

2023-04-20 Thread Konrad Dybcio
Document the SM6350 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 + 1 file changed, 214 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/dis

[Freedreno] [PATCH v2 02/13] dt-bindings: display/msm: dsi-controller-main: Add SM6375

2023-04-20 Thread Konrad Dybcio
Add the DSI host found on SM6375. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Docume

[Freedreno] [PATCH v2 03/13] dt-bindings: display/msm: Add SM6350 DPU

2023-04-20 Thread Konrad Dybcio
Document the SM6350 DPU. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-dpu.yaml | 94 ++ 1 file changed, 94 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-dpu.yaml b/Documentation/devicetree/bindings/display

[Freedreno] [PATCH v2 06/13] dt-bindings: display/msm: Add SM6375 MDSS

2023-04-20 Thread Konrad Dybcio
Document the SM6375 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 + 1 file changed, 216 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/dis

[Freedreno] [PATCH v2 08/13] drm/msm: mdss: Add SM6350 support

2023-04-20 Thread Konrad Dybcio
Add support for MDSS on SM6350. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e8c93731aaa1..4e3a5f0c303c 100644 --- a/drivers/gpu/drm/msm/msm_mdss.

[Freedreno] [PATCH v2 09/13] drm/msm/dpu: Add SM6375 support

2023-04-20 Thread Konrad Dybcio
Add basic SM6375 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 5 - .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c |

[Freedreno] [PATCH v2 05/13] dt-bindings: display/msm: Add SM6375 DPU

2023-04-20 Thread Konrad Dybcio
Document SM6375 DPU. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6375-dpu.yaml | 106 + 1 file changed, 106 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-dpu.yaml b/Documentation/devicetree/bindings/display/ms

[Freedreno] [PATCH v2 12/13] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-04-20 Thread Konrad Dybcio
From: Konrad Dybcio Add the SM6350 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-sm

[Freedreno] [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Konrad Dybcio
Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 191 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v2 13/13] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-04-20 Thread Konrad Dybcio
It got broken at some point, fix it up. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c index 2daaa600ac75.

[Freedreno] [PATCH v2 11/13] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-04-20 Thread Konrad Dybcio
Add the SM6375 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm

[Freedreno] [PATCH v2 10/13] drm/msm: mdss: Add SM6375 support

2023-04-20 Thread Konrad Dybcio
Add support for MDSS on SM6375. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 4e3a5f0c303c..f2470ce699f7 100644 --- a/drivers/gpu/drm/msm/msm_md

Re: [Freedreno] [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 191 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalo

Re: [Freedreno] [PATCH v2 08/13] drm/msm: mdss: Add SM6350 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add support for MDSS on SM6350. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 9 + 1 file changed, 9 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [Freedreno] [PATCH v2 09/13] drm/msm/dpu: Add SM6375 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add basic SM6375 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 5 - .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 + driver

Re: [Freedreno] [PATCH v2 10/13] drm/msm: mdss: Add SM6375 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add support for MDSS on SM6375. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [Freedreno] [PATCH v2 10/13] drm/msm: mdss: Add SM6375 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add support for MDSS on SM6375. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 4e3a5f0c303c..f2470c

Re: [Freedreno] [PATCH v2 12/13] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: From: Konrad Dybcio Add the SM6350 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 inser

Re: [Freedreno] [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023 03:28, Abhinav Kumar wrote: On 4/19/2023 6:26 PM,

Re: [Freedreno] [PATCH v2 11/13] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add the SM6375 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) Acked-by: Dmitry Baryshkov -- With best

Re: [Freedreno] [PATCH v2 13/13] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: It got broken at some point, fix it up. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) This should probably come before patches 11 and 12. diff --git a/driver

Re: [Freedreno] [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Konrad Dybcio
On 21.04.2023 00:41, Dmitry Baryshkov wrote: > On 21/04/2023 01:31, Konrad Dybcio wrote: >> Add SM6350 support to the DPU1 driver to enable display output. >> >> Signed-off-by: Konrad Dybcio >> Signed-off-by: Konrad Dybcio >> --- [...] >> + >> +static const struct dpu_sspp_cfg sm6350_sspp[] =

Re: [Freedreno] [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:05, Konrad Dybcio wrote: On 21.04.2023 00:41, Dmitry Baryshkov wrote: On 21/04/2023 01:31, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- [...] + +static const struct dpu

Re: [Freedreno] [PATCH v2 10/13] drm/msm: mdss: Add SM6375 support

2023-04-20 Thread Konrad Dybcio
On 21.04.2023 00:50, Dmitry Baryshkov wrote: > On 21/04/2023 01:31, Konrad Dybcio wrote: >> Add support for MDSS on SM6375. >> >> Signed-off-by: Konrad Dybcio >> --- >>   drivers/gpu/drm/msm/msm_mdss.c | 10 ++ >>   1 file changed, 10 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/

[Freedreno] [PATCH v1 0/5] add DSC 1.2 dpu supports

2023-04-20 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. Abhinav Kumar (1): drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh (4):

[Freedreno] [PATCH v1 2/5] drm/msm/dpu: separate DSC flush update out of interface

2023-04-20 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separate DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush p

[Freedreno] [PATCH v1 3/5] drm/msm/dpu: save dpu topology configuration

2023-04-20 Thread Kuogee Hsieh
At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 ++--- 1 file c

[Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-20 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. Signed-off-by: Abhinav K

[Freedreno] [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-20 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 38 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 17 +-

[Freedreno] [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-20 Thread Kuogee Hsieh
During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 - 1 file changed, 32 insertions(+), 24 deletions(-) dif

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 38 ++- drivers/gpu

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dpu: separate DSC flush update out of interface

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separate DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make

Re: [Freedreno] [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different s

Re: [Freedreno] [PATCH v1 3/5] drm/msm/dpu: save dpu topology configuration

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Please take a look at https://patchwork.freedesktop.org/patch/527960/?series=

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 - 1 file ch

Re: [Freedreno] [PATCH v1 3/5] drm/msm/dpu: save dpu topology configuration

2023-04-20 Thread Abhinav Kumar
On 4/20/2023 5:12 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Please take a look at https

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-20 Thread kernel test robot
Hi Kuogee, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc7 next-20230420